activerecord-jdbc-alt-adapter 52.6.0-java → 60.0.0-java

data/lib/arjdbc/jdbc/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   # Represents exceptions that have propagated up through the JDBC API.
   class JDBCError < WrappedDatabaseException

data/lib/arjdbc/jdbc/extension.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ArJdbc
 
   # Defines an AR-JDBC extension. An extension consists of a declaration using

data/lib/arjdbc/jdbc/java.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'java'
 require 'arjdbc/jdbc/adapter_java'
 
@@ -10,4 +12,4 @@ module ActiveRecord
       Types = ::Java::JavaSql::Types
     end
   end
-end
+end

data/lib/arjdbc/jdbc/railtie.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require 'arjdbc/railtie'
-ArJdbc.deprecate "require 'arjdbc/railtie' instead of 'arjdbc/jdbc/railtie'"
+ArJdbc.deprecate "require 'arjdbc/railtie' instead of 'arjdbc/jdbc/railtie'"

data/lib/arjdbc/jdbc/rake_tasks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 load 'arjdbc/tasks.rb'
 
-ArJdbc.deprecate "load 'arjdbc/tasks.rb' instead of 'arjdbc/jdbc/rake_tasks.rb'"
+ArJdbc.deprecate "load 'arjdbc/tasks.rb' instead of 'arjdbc/jdbc/rake_tasks.rb'"

data/lib/arjdbc/jdbc/serialized_attributes_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'arjdbc/util/serialized_attributes'
 
-ArJdbc.deprecate "require 'arjdbc/util/serialized_attributes' instead of 'arjdbc/jdbc/serialized_attributes_helper'"
+ArJdbc.deprecate "require 'arjdbc/util/serialized_attributes' instead of 'arjdbc/jdbc/serialized_attributes_helper'"

data/lib/arjdbc/jdbc/type_cast.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_record/connection_adapters/column'
 
 module ActiveRecord::ConnectionAdapters

data/lib/arjdbc/jdbc/type_converter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     # I want to use JDBC's DatabaseMetaData#getTypeInfo to choose the best native types to

data/lib/arjdbc/mssql.rb

@@ -1,7 +1,9 @@
 require 'arjdbc'
 require 'arjdbc/mssql/adapter'
 require 'arjdbc/mssql/connection_methods'
+
 module ArJdbc
   MsSQL = MSSQL # compatibility with 1.2
 end
-ArJdbc.warn_unsupported_adapter 'mssql', [5, 2] # warns on AR >= 4.2
+
+ArJdbc.warn_unsupported_adapter 'mssql', [6, 0] # warns on AR >= 4.2

data/lib/arjdbc/mssql/adapter.rb

@@ -1,4 +1,4 @@
-# frozen_string_literal: false
+# frozen_string_literal: true
 
 ArJdbc.load_java_part :MSSQL
 
@@ -68,8 +68,19 @@ module ActiveRecord
         # configure_connection happens in super
         super(connection, logger, config)
 
-        unless mssql_major_version >= 11
-          raise "Your MSSQL #{mssql_version_year} is too old. This adapter supports MSSQL >= 2012."
+        if database_version < '11'
+          raise "Your #{mssql_product_name} #{mssql_version_year} is too old. This adapter supports #{mssql_product_name} >= 2012."
+        end
+      end
+
+      def self.database_exists?(config)
+        !!ActiveRecord::Base.sqlserver_connection(config)
+      rescue ActiveRecord::JDBCError => e
+        case e.message
+        when /Cannot open database .* requested by the login/
+          false
+        else
+          raise
         end
       end
 
@@ -101,6 +112,14 @@ module ActiveRecord
         true
       end
 
+      def supports_savepoints?
+        true
+      end
+
+      def supports_lazy_transactions?
+        true
+      end
+
       # The MSSQL datetime type doe have precision.
       def supports_datetime_with_precision?
         true
@@ -121,12 +140,23 @@ module ActiveRecord
         true
       end
 
+      def supports_insert_on_conflict?
+        false
+      end
+      alias supports_insert_on_duplicate_skip? supports_insert_on_conflict?
+      alias supports_insert_on_duplicate_update? supports_insert_on_conflict?
+      alias supports_insert_conflict_target? supports_insert_on_conflict?
+
+      def build_insert_sql(insert) # :nodoc:
+        # TODO: hope we can implement an upsert like feature
+        "INSERT #{insert.into} #{insert.values_list}"
+      end
+
       # Overrides abstract method which always returns false
       def valid_type?(type)
         !native_database_types[type].nil?
       end
 
-      # FIXME: to be reviewed.
       def clear_cache!
         reload_type_map
         super
@@ -170,22 +200,6 @@ module ActiveRecord
         result
       end
 
-      def arel_visitor # :nodoc:
-        ::Arel::Visitors::SQLServer.new(self)
-      end
-
-      def schema_creation # :nodoc:
-        MSSQL::SchemaCreation.new(self)
-      end
-
-      def create_table_definition(*args) # :nodoc:
-        MSSQL::TableDefinition.new(*args)
-      end
-
-      def update_table_definition(table_name, base) #:nodoc:
-        MSSQL::Table.new(table_name, base)
-      end
-
       # Returns the name of the current security context
       def current_user
         @current_user ||= select_value('SELECT CURRENT_USER')
@@ -208,15 +222,25 @@ module ActiveRecord
 
       alias_method :current_schema=, :default_schema=
 
-      # Overrides method in abstract adapter
-      # FIXME: This needs to be fixed the we find a way how to
-      # get the collation per column basis. At the moment we only use
-      # the global database collation
-      def case_sensitive_comparison(table, attribute, column, value)
-        if [:string, :text].include?(column.type) && collation && !collation.match(/_CS/)
-          table[attribute].eq(Arel::Nodes::Bin.new(value))
-        # elsif value.acts_like?(:string)
-        #   table[attribute].eq(Arel::Nodes::Bin.new(Arel::Nodes::BindParam.new))
+      # FIXME: This needs to be fixed when we implement the collation per
+      # column basis. At the moment we only use the global database collation
+      def default_uniqueness_comparison(attribute, value, klass) # :nodoc:
+        column = column_for_attribute(attribute)
+
+        if [:string, :text].include?(column.type) && collation && !collation.match(/_CS/) && !value.nil?
+          # NOTE: there is a deprecation warning here in the mysql adapter
+          # no sure if it's required.
+          attribute.eq(Arel::Nodes::Bin.new(value))
+        else
+          super
+        end
+      end
+
+      def case_sensitive_comparison(attribute, value)
+        column = column_for_attribute(attribute)
+
+        if [:string, :text].include?(column.type) && collation && !collation.match(/_CS/) && !value.nil?
+          attribute.eq(Arel::Nodes::Bin.new(value))
         else
           super
         end
@@ -248,6 +272,27 @@ module ActiveRecord
         MSSQL_VERSION_YEAR[mssql_major_version.to_i]
       end
 
+      def mssql_product_version
+        return @mssql_product_version if defined? @mssql_product_version
+
+        @mssql_product_version = @connection.database_product_version
+      end
+
+      def mssql_product_name
+        return @mssql_product_name if defined? @mssql_product_name
+
+        @mssql_product_name = @connection.database_product_name
+      end
+
+      def get_database_version # :nodoc:
+        MSSQLAdapter::Version.new(mssql_product_version)
+      end
+
+      def check_version # :nodoc:
+        # NOTE: hitting the database from here causes trouble when adapter
+        # uses JNDI or Data Source setup.
+      end
+
       def tables_with_referential_integrity
         schema_and_tables_sql = %(
           SELECT s.name, o.name
@@ -266,20 +311,22 @@ module ActiveRecord
 
       private
 
-      def translate_exception(exception, message)
+      def translate_exception(exception, message:, sql:, binds:)
         case message
         when /(cannot insert duplicate key .* with unique index) | (violation of unique key constraint)/i
-          RecordNotUnique.new(message)
+          RecordNotUnique.new(message, sql: sql, binds: binds)
         when /Lock request time out period exceeded/i
-          LockTimeout.new(message)
+          LockTimeout.new(message, sql: sql, binds: binds)
         when /The .* statement conflicted with the FOREIGN KEY constraint/
-          ActiveRecord::InvalidForeignKey.new(message)
+          InvalidForeignKey.new(message, sql: sql, binds: binds)
+        when /The .* statement conflicted with the REFERENCE constraint/
+          InvalidForeignKey.new(message, sql: sql, binds: binds)
         when /(String or binary data would be truncated)/i
-          ActiveRecord::ValueTooLong.new(message)
+          ValueTooLong.new(message, sql: sql, binds: binds)
         when /Cannot insert the value NULL into column .* does not allow nulls/
-          ActiveRecord::NotNullViolation.new(message)
+          NotNullViolation.new(message, sql: sql, binds: binds)
         when /Arithmetic overflow error converting expression/
-          ActiveRecord::RangeError.new(message)
+          RangeError.new(message, sql: sql, binds: binds)
         else
           super
         end
@@ -387,6 +434,28 @@ module ActiveRecord
         map.register_type 'ntext', MSSQL::Type::Ntext.new
         map.register_type 'image', MSSQL::Type::Image.new
       end
+
+      # Returns an array of Column objects for the table specified by +table_name+.
+      # See the concrete implementation for details on the expected parameter values.
+      # NOTE: This is ready, all implemented in the java part of adapter,
+      # it uses MSSQLColumn, SqlTypeMetadata, etc.
+      def column_definitions(table_name)
+       log('JDBC: GETCOLUMNS', 'SCHEMA') { @connection.columns(table_name) }
+      rescue => e
+        # raise translate_exception_class(e, nil)
+        # FIXME: this breaks one arjdbc test but fixes activerecord tests
+        # (table name alias). Also it behaves similarly to the CRuby adapter
+        # which returns an empty array too. (postgres throws a exception)
+        []
+      end
+
+      def arel_visitor # :nodoc:
+        ::Arel::Visitors::SQLServer.new(self)
+      end
+
+      def build_statement_pool
+        # NOTE: @statements is set in StatementCache module
+      end
     end
   end
 end

data/lib/arjdbc/mssql/column.rb

@@ -1,11 +1,15 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     # MSSQL specific extensions to column definitions in a table.
     class MSSQLColumn < Column
+      attr_reader :table_name
       def initialize(name, raw_default, sql_type_metadata = nil, null = true, table_name = nil, default_function = nil, collation = nil, comment: nil)
+        @table_name = table_name
         default = extract_default(raw_default)
 
-        super(name, default, sql_type_metadata, null, table_name, default_function, collation, comment: comment)
+        super(name, default, sql_type_metadata, null, default_function, collation: collation, comment: comment)
       end
 
       def extract_default(value)

data/lib/arjdbc/mssql/connection_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ArJdbc::ConnectionMethods.module_eval do
 
   # Default connection method for MS-SQL adapter (`adapter: mssql`),
@@ -11,6 +13,8 @@ ArJdbc::ConnectionMethods.module_eval do
       return sqlserver_connection(config)
     end
 
+    config = config.deep_dup
+
     config[:adapter_spec] ||= ::ArJdbc::MSSQL
     config[:adapter_class] = ActiveRecord::ConnectionAdapters::MSSQLAdapter unless config.key?(:adapter_class)
 
@@ -31,7 +35,8 @@ ArJdbc::ConnectionMethods.module_eval do
     config[:connection_alive_sql] ||= 'SELECT 1'
 
     config[:url] ||= begin
-      url = "jdbc:jtds:sqlserver://#{config[:host]}:#{config[:port]}/#{config[:database]}"
+      url = ''.dup
+      url << "jdbc:jtds:sqlserver://#{config[:host]}:#{config[:port]}/#{config[:database]}"
       # Instance is often a preferrable alternative to port when dynamic ports are used.
       # If instance is specified then port is essentially ignored.
       url << ";instance=#{config[:instance]}" if config[:instance]
@@ -65,7 +70,8 @@ ArJdbc::ConnectionMethods.module_eval do
     config[:lock_timeout] ||= 5000
 
     config[:url] ||= begin
-      url = "jdbc:sqlserver://#{config[:host]}"
+      url = ''.dup
+      url << "jdbc:sqlserver://#{config[:host]}"
       url << ( config[:port] ? ":#{config[:port]};" : ';' )
       url << "databaseName=#{config[:database]};" if config[:database]
       url << "instanceName=#{config[:instance]};" if config[:instance]

data/lib/arjdbc/mssql/database_limits.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
  module ConnectionAdapters
    module MSSQL

data/lib/arjdbc/mssql/database_statements.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   module ConnectionAdapters
     module MSSQL
@@ -23,6 +25,15 @@ module ActiveRecord
         end
         alias_method :execute_procedure, :exec_proc # AR-SQLServer-Adapter naming
 
+        READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp(
+          :begin, :commit, :explain, :select, :set, :show, :release, :savepoint, :rollback, :with
+        ) # :nodoc:
+        private_constant :READ_QUERY
+
+        def write_query?(sql) # :nodoc:
+          !READ_QUERY.match?(sql)
+        end
+
         def execute(sql, name = nil)
           # with identity insert on block
           if insert_sql?(sql)
@@ -52,11 +63,6 @@ module ActiveRecord
           end
         end
 
-        # Implements the truncate method.
-        def truncate(table_name, name = nil)
-          execute "TRUNCATE TABLE #{quote_table_name(table_name)}", name
-        end
-
         # Not a rails method, own method to test different isolation
         # levels supported by the mssql adapter.
         def supports_transaction_isolation_level?(level)
@@ -95,8 +101,40 @@ module ActiveRecord
           end
         end
 
+        # Implements the truncate method.
+        def truncate(table_name, name = nil)
+          execute "TRUNCATE TABLE #{quote_table_name(table_name)}", name
+        end
+
+        def truncate_tables(*table_names) # :nodoc:
+          return if table_names.empty?
+
+          disable_referential_integrity do
+            table_names.each do |table_name|
+              mssql_truncate(table_name)
+            end
+          end
+        end
+
         private
 
+        # It seems the truncate_tables is mostly used for testing
+        # this a workaround to the fact that SQL Server truncate tables
+        # referenced by a foreign key, it may not be required to reset
+        # the identity column too, more at:
+        #    https://docs.microsoft.com/en-us/sql/t-sql/statements/truncate-table-transact-sql?view=sql-server-ver15
+        # TODO: improve is with pure T-SQL, use statements
+        # such as TRY CATCH and reset identity with DBCC CHECKIDENT
+        def mssql_truncate(table_name)
+          execute "TRUNCATE TABLE #{quote_table_name(table_name)}", 'Truncate Tables'
+        rescue => e
+          if e.message =~ /Cannot truncate table .* because it is being referenced by a FOREIGN KEY constraint/
+          execute "DELETE FROM #{quote_table_name(table_name)}", 'Truncate Tables with Delete'
+          else
+            raise
+          end
+        end
+
         # Overrides method in abstract class, combining the sqls with semicolon
         # affects disable_referential_integrity in mssql specially when multiple
         # tables are involved.

data/lib/arjdbc/mssql/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveRecord
   # Error raised when adapter determines the database could not acquire
   # a necessary lock before timing out

data/lib/arjdbc/mssql/explain_support.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/string'
 
 module ActiveRecord
@@ -108,7 +110,7 @@ module ActiveRecord
           end
 
           def build_separator
-            '+' << @widths.map {|w| '-' * (w + (cell_padding * 2))}.join('+') << '+'
+            '+'.dup << @widths.map {|w| '-' * (w + (cell_padding * 2))}.join('+') << '+'
           end
 
           def build_cells(items)

data/lib/arjdbc/mssql/extensions/attribute_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file contains extensions, overrides, and monkey patches to core parts
 # of active record to allow SQL Server work properly.
 #
@@ -15,7 +17,9 @@ module ActiveRecord
         # this behaviour, even the current comments for that method says that
         # it rejects primary key but it doesn't (maybe a rails bug?)
         def attributes_for_update(attribute_names)
-          attribute_names.reject do |name|
+          attribute_names &= self.class.column_names
+
+          attribute_names.delete_if do |name|
             # It seems is only required to check if column in identity or not.
             # This allows to update rails custom primary keys
             next true if readonly_attribute?(name)