activerecord-jdbc-adapter 70.0.pre-java → 70.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0552eaeb2b86ff8a8a2e24e86c56315c059dff050596c329cb5a082ad9d0c460
-  data.tar.gz: 12c7b5068269990ed27e15e7ef0d97ba0928a7bbcfbc6ca2cc6aa3e854d780ba
+  metadata.gz: '095c3d28051b253315cdd1bec95a83683f3240b0f3315cfb8f9c3c4c0d124f41'
+  data.tar.gz: 13b5d48e4c1b0b16811da5a361cfd9bb687727b5bbad2f5b750540b0232408ee
 SHA512:
-  metadata.gz: 90f35907b970e53e8c3910cf7d6e572a33d78270ab7002ad7c10170bdff4872d8784bf4d361b6ef5d1dda397387e5e2804fabee549b195e594178ba7bcfa7b97
-  data.tar.gz: 10be265dd0aab6905de89bb779b1aa653e004e0ed0d5a536c4a54ca876b2dc806c17da8d36b2a15c1852c97e87305b29edc99c5e05e2d946f43e44202a989288
+  metadata.gz: bc4801f970c8651e0ce8076b6544bf56d0e4decd77a9463439a8d5692f767aab896786680197c25b52d510465837290604970689b1b6cba26708385038f1fa39
+  data.tar.gz: 47e1df847914baefffadb80537b1ffd9dfcb218b2f5bfd26addefad934be7b31a0ade446c5838bea88b81897c34b13a7cef8e6b840540e89f4627f950949549c

data/Rakefile

@@ -26,7 +26,7 @@
 
 require 'rake/clean'
 
-CLEAN.include 'derby*', 'test.db.*', '*test.sqlite3', 'test/reports'
+CLEAN.include 'test.db.*', '*test.sqlite3', 'test/reports'
 CLEAN.include 'lib/**/*.jar', 'MANIFEST.MF', '*.log', 'target/*'
 
 task :default => :jar # RubyGems extention will do a bare `rake' e.g. :

data/activerecord-jdbc-adapter.gemspec

@@ -1,7 +1,5 @@
 # -*- encoding: utf-8 -*-
 
-path = File.expand_path('lib/arjdbc/version.rb', File.dirname(__FILE__))
-puts "VERSION: #{File.read(path).match( /.*VERSION\s*=\s*['"](.*)['"]/m )[1]}"
 Gem::Specification.new do |gem|
   gem.name = 'activerecord-jdbc-adapter'
   path = File.expand_path('lib/arjdbc/version.rb', File.dirname(__FILE__))
@@ -49,6 +47,6 @@ Gem::Specification.new do |gem|
   #gem.add_development_dependency 'test-unit-context', '>= 0.3.0'
   #gem.add_development_dependency 'mocha', '~> 0.13.1'
 
-  gem.rdoc_options = ["--main", "README.md", "-SHN", "-f", "darkfish"]
+  gem.rdoc_options = ["--main", "README.md"]
 end
 

data/lib/arel/visitors/compat.rb

@@ -4,44 +4,16 @@ module Arel
 
       protected
 
-      if ToSql.instance_method('visit').arity == 1
-        def do_visit(x, a); visit(x); end # a = nil
-      else # > AREL 4.0
-        def do_visit(x, a); visit(x, a); end
-      end
+      def do_visit(x, a); visit(x, a); end
 
-      if ToSql.instance_method('visit_Arel_Nodes_SelectCore').arity == 1
-        def do_visit_select_core(x, a) # a = nil
-          visit_Arel_Nodes_SelectCore(x)
-        end
-      else # > AREL 4.0
-        def do_visit_select_core(x, a)
-          visit_Arel_Nodes_SelectCore(x, a)
-        end
+      def do_visit_select_core(x, a)
+        visit_Arel_Nodes_SelectCore(x, a)
       end
 
       private
 
-      if ArJdbc::AR42
-        if Arel::VERSION < '6.0.2'
-          def limit_for(limit_or_node)
-            if limit_or_node.respond_to?(:expr)
-              expr = limit_or_node.expr
-              # NOTE(uwe): Different behavior for Arel 6.0.0 and 6.0.2
-              expr.respond_to?(:value) ? expr.value.to_i : expr.to_i
-            else
-              limit_or_node
-            end
-          end
-        else
-          def limit_for(limit_or_node)
-            limit_or_node.respond_to?(:expr) ? limit_or_node.expr.to_i : limit_or_node
-          end
-        end
-      else
-        def limit_for(limit_or_node)
-          limit_or_node.respond_to?(:expr) ? limit_or_node.expr.to_i : limit_or_node
-        end
+      def limit_for(limit_or_node)
+        limit_or_node.respond_to?(:expr) ? limit_or_node.expr.to_i : limit_or_node
       end
       module_function :limit_for
 

data/lib/arel/visitors/h2.rb

@@ -7,19 +7,7 @@ module Arel
       def visit_Arel_Nodes_SelectStatement(o, *)
         o.limit ||= Arel::Nodes::Limit.new(-1) if o.offset
         super
-      end if ArJdbc::AR42
-
-      def limit_offset sql, o
-        offset = o.offset || 0
-        offset = offset.expr unless (offset.nil? || offset == 0)
-        if limit = o.limit
-          "SELECT LIMIT #{offset} #{limit_for(limit)} #{sql[7..-1]}"
-        elsif offset > 0
-          "SELECT LIMIT #{offset} -1 #{sql[7..-1]}" # removes "SELECT "
-        else
-          sql
-        end
-      end unless ArJdbc::AR42
+      end
     end
   end
 end

data/lib/arel/visitors/hsqldb.rb

@@ -6,27 +6,7 @@ module Arel
       def visit_Arel_Nodes_SelectStatement(o, *)
         o.limit ||= Arel::Nodes::Limit.new(0) if o.offset
         super
-      end if ArJdbc::AR42
-
-      def visit_Arel_Nodes_SelectStatement o, a = nil
-        sql = limit_offset(o.cores.map { |x| do_visit_select_core x, a }.join, o)
-        sql << " ORDER BY #{o.orders.map { |x| do_visit x, a }.join(', ')}" unless o.orders.empty?
-        sql
-      end unless ArJdbc::AR42
-
-      private
-
-      def limit_offset sql, o
-        offset = o.offset || 0
-        offset = offset.expr unless (offset.nil? || offset == 0)
-        if limit = o.limit
-          "SELECT LIMIT #{offset} #{limit_for(limit)} #{sql[7..-1]}"
-        elsif offset > 0
-          "SELECT LIMIT #{offset} 0 #{sql[7..-1]}" # removes "SELECT "
-        else
-          sql
-        end
-      end unless ArJdbc::AR42
+      end
     end
   end
 end

data/lib/arel/visitors/sql_server.rb

@@ -11,44 +11,6 @@ module Arel
 
       private
 
-      def visit_Arel_Nodes_SelectStatement(*args) # [o] AR <= 4.0 [o, a] on 4.1
-        o, a = args.first, args.last
-
-        return _visit_Arel_Nodes_SelectStatement(*args) if ! o.limit && ! o.offset
-
-        unless o.orders.empty?
-          select_order_by = do_visit_columns o.orders, a, 'ORDER BY '
-        end
-
-        select_count = false; sql = ''
-        o.cores.each do |x|
-          x = x.dup
-          core_order_by = select_order_by || determine_order_by(x, a)
-          if select_count? x
-            x.projections = [
-              Arel::Nodes::SqlLiteral.new(core_order_by ? over_row_num(core_order_by) : '*')
-            ]
-            select_count = true
-          else
-            # NOTE: this should really be added here and we should built the
-            # wrapping SQL but than #replace_limit_offset! assumes it does that
-            # ... MS-SQL adapter code seems to be 'hacked' by a lot of people
-            #x.projections << Arel::Nodes::SqlLiteral.new over_row_num(order_by)
-          end
-          sql << do_visit_select_core(x, a)
-        end
-
-        #sql = "SELECT _t.* FROM (#{sql}) as _t WHERE #{get_offset_limit_clause(o)}"
-        select_order_by ||= "ORDER BY #{@connection.determine_order_clause(sql)}"
-        replace_limit_offset!(sql, limit_for(o.limit), o.offset && o.offset.value.to_i, select_order_by)
-
-        sql = "SELECT COUNT(*) AS count_id FROM (#{sql}) AS subquery" if select_count
-
-        add_lock!(sql, :lock => o.lock && true)
-
-        sql
-      end unless ArJdbc::AR42
-
       # @private
       MAX_LIMIT_VALUE = 9_223_372_036_854_775_807
 
@@ -60,14 +22,6 @@ module Arel
         super
       end
 
-      def visit_Arel_Nodes_Lock o, a = nil
-        # MS-SQL doesn't support "SELECT...FOR UPDATE".  Instead, it needs
-        # WITH(ROWLOCK,UPDLOCK) specified after each table in the FROM clause.
-        #
-        # we return nothing here and add the appropriate stuff with #add_lock!
-        #do_visit o.expr, a
-      end unless ArJdbc::AR42
-
       def visit_Arel_Nodes_Top o, a = nil
         # `top` wouldn't really work here:
         #   User.select("distinct first_name").limit(10)
@@ -76,29 +30,6 @@ module Arel
         a || ''
       end
 
-      def visit_Arel_Nodes_Limit o, a = nil
-        "TOP (#{do_visit o.expr, a})"
-      end unless ArJdbc::AR42
-
-      def visit_Arel_Nodes_Ordering o, a = nil
-        expr = do_visit o.expr, a
-        if o.respond_to?(:direction)
-          "#{expr} #{o.ascending? ? 'ASC' : 'DESC'}"
-        else
-          expr
-        end
-      end unless ArJdbc::AR42
-
-      def visit_Arel_Nodes_Bin o, a = nil
-        expr = o.expr; sql = do_visit expr, a
-        if expr.respond_to?(:val) && expr.val.is_a?(Numeric)
-          sql
-        else
-          sql << " #{::ArJdbc::MSSQL.cs_equality_operator} "
-          sql
-        end
-      end unless ArJdbc::AR42
-
       private
 
       def self.possibly_private_method_defined?(name)
@@ -140,25 +71,7 @@ module Arel
           visit(x, sql); sql << ', ' unless i == last
         end
         sql.value
-      end if ArJdbc::AR42
-
-      def do_visit_columns(colls, a, sql)
-        non_simple_order = /\sASC|\sDESC|\sCASE|\sCOLLATE|[\.,\[\(]/i # MIN(width)
-
-        last = colls.size - 1
-        colls.each_with_index do |x, i|
-          coll = do_visit(x, a)
-
-          if coll !~ non_simple_order && coll.to_i == 0
-            sql << @connection.quote_column_name(coll)
-          else
-            sql << coll
-          end
-
-          sql << ', ' unless i == last
-        end
-        sql
-      end if Arel::VERSION < '4.0.0'
+      end
 
       def over_row_num order_by
         "ROW_NUMBER() OVER (#{order_by}) as _row_num"
@@ -174,20 +87,6 @@ module Arel
         end
       end
 
-      def table_from_select_core core
-        table_finder = lambda do |x|
-          case x
-          when Arel::Table
-            x
-          when Arel::Nodes::SqlLiteral
-            Arel::Table.new(x, @engine)
-          when Arel::Nodes::Join
-            table_finder.call(x.left)
-          end
-        end
-        table_finder.call(core.froms)
-      end if ActiveRecord::VERSION::STRING < '3.2'
-
       def primary_key_from_table t
         return unless t
         return t.primary_key if t.primary_key
@@ -219,7 +118,7 @@ module Arel
       include ArJdbc::MSSQL::LimitHelpers::SqlServer2000ReplaceLimitOffset
     end
 
-    load 'arel/visitors/sql_server/ng42.rb' if ArJdbc::AR42
+    load 'arel/visitors/sql_server/ng42.rb'
 
   end
 end

data/lib/arjdbc/abstract/core.rb

@@ -34,7 +34,7 @@ module ArJdbc
         raw_connection.jdbc_connection(unwrap)
       end
 
-      protected
+      private
 
       def translate_exception_class(e, sql, binds)
         message = "#{e.class.name}: #{e.message}"
@@ -42,16 +42,19 @@ module ArJdbc
         exception = translate_exception(
           e, message: message, sql: sql, binds: binds
         )
-        exception.set_backtrace e.backtrace
+        exception.set_backtrace e.backtrace unless exception.equal?(e)
         exception
       end
 
+      Throwable = java.lang.Throwable
+      private_constant :Throwable
+
       def translate_exception(exception, message:, sql:, binds:)
         # override in derived class
 
         # we shall not translate native "Java" exceptions as they might
         # swallow an ArJdbc / driver bug into an AR::StatementInvalid !
-        return exception if exception.is_a?(Java::JavaLang::Throwable)
+        return exception if exception.is_a?(Throwable)
 
         case exception
           when SystemExit, SignalException, NoMemoryError then exception
@@ -61,14 +64,10 @@ module ArJdbc
         end
       end
 
-      def extract_raw_bind_values(binds)
-        binds.map(&:value_for_database)
-      end
-
       # this version of log() automatically fills type_casted_binds from binds if necessary
-      def log(sql, name = "SQL", binds = [], type_casted_binds = [], statement_name = nil)
+      def log(sql, name = "SQL", binds = [], type_casted_binds = [], statement_name = nil, async: false)
         if binds.any? && (type_casted_binds.nil? || type_casted_binds.empty?)
-          type_casted_binds = ->{ extract_raw_bind_values(binds) }
+          type_casted_binds = ->{ binds.map(&:value_for_database) } # extract_raw_bind_values
         end
         super
       end

data/lib/arjdbc/abstract/database_statements.rb

@@ -10,6 +10,8 @@ module ArJdbc
       NO_BINDS = [].freeze
 
       def exec_insert(sql, name = nil, binds = NO_BINDS, pk = nil, sequence_name = nil)
+        sql = transform_query(sql)
+
         if preventing_writes?
           raise ActiveRecord::ReadOnlyError, "Write query attempted while in readonly mode: #{sql}"
         end
@@ -31,6 +33,8 @@ module ArJdbc
       # It appears that at this point (AR 5.0) "prepare" should only ever be true
       # if prepared statements are enabled
       def exec_query(sql, name = nil, binds = NO_BINDS, prepare: false, async: false)
+        sql = transform_query(sql)
+
         if preventing_writes? && write_query?(sql)
           raise ActiveRecord::ReadOnlyError, "Write query attempted while in readonly mode: #{sql}"
         end
@@ -52,6 +56,8 @@ module ArJdbc
       end
 
       def exec_update(sql, name = nil, binds = NO_BINDS)
+        sql = transform_query(sql)
+
         if preventing_writes?
           raise ActiveRecord::ReadOnlyError, "Write query attempted while in readonly mode: #{sql}"
         end
@@ -70,6 +76,8 @@ module ArJdbc
       alias :exec_delete :exec_update
 
       def execute(sql, name = nil, async: false)
+        sql = transform_query(sql)
+        
         if preventing_writes? && write_query?(sql)
           raise ActiveRecord::ReadOnlyError, "Write query attempted while in readonly mode: #{sql}"
         end

data/lib/arjdbc/discover.rb

@@ -23,26 +23,6 @@ module ArJdbc
     require('arjdbc/sqlite3') || true if name =~ /sqlite/i
   end
   
-  # Other supported adapters :
-
-  extension :Derby do |name, config|
-    if name =~ /derby/i
-      require 'arjdbc/derby'
-
-      if config && config[:username].nil? # set the database schema name (:username) :
-        begin
-          ArJdbc.with_meta_data_from_data_source_if_any(config) do
-            |meta_data| config[:username] = meta_data.getUserName
-          end
-        rescue => e
-          ArJdbc.warn("failed to set :username from (Derby) database meda-data: #{e.inspect}")
-        end
-      end
-
-      true
-    end
-  end
-
   extension :H2 do |name|
     require('arjdbc/h2') || true if name =~ /\.h2\./i
   end
@@ -54,51 +34,4 @@ module ArJdbc
   extension :MSSQL do |name|
     require('arjdbc/mssql') || true if name =~ /sqlserver|tds|Microsoft SQL/i
   end
-
-  extension :DB2 do |name, config|
-    if name =~ /db2/i && name !~ /as\/?400/i && config[:url] !~ /^jdbc:derby:net:/
-      require 'arjdbc/db2'
-      true
-    end
-  end
-  
-  extension :AS400 do |name, config|
-    # The native JDBC driver always returns "DB2 UDB for AS/400"
-    if name =~ /as\/?400/i
-      require 'arjdbc/db2'
-      require 'arjdbc/db2/as400'
-      true
-    end
-  end
-
-  # NOTE: following ones are likely getting deprecated :
-  
-  extension :FireBird do |name|
-    if name =~ /firebird/i
-      require 'arjdbc/firebird'
-      true
-    end
-  end
-
-  extension :Sybase do |name|
-    if name =~ /sybase|tds/i
-      require 'arjdbc/sybase'
-      true
-    end
-  end
-  
-  extension :Informix do |name|
-    if name =~ /informix/i
-      require 'arjdbc/informix'
-      true
-    end
-  end
-
-  extension :Mimer do |name|
-    if name =~ /mimer/i
-      require 'arjdbc/mimer'
-      true
-    end
-  end
-  
 end

data/lib/arjdbc/jdbc/adapter.rb

@@ -431,7 +431,7 @@ module ActiveRecord
       private
 
       # Helper useful during {#quote} since AREL might pass in it's literals
-      # to be quoted, fixed since AREL 4.0.0.beta1 : http://git.io/7gyTig
+      # to be quoted, fixed since AREL 4.0.0.beta1 : https://github.com/rails/arel/commit/9c514f3
       def sql_literal?(value); ::Arel::Nodes::SqlLiteral === value; end
 
       # Helper to get local/UTC time (based on `ActiveRecord::default_timezone`).

data/lib/arjdbc/jdbc/column.rb

@@ -28,21 +28,6 @@ module ActiveRecord
           end
         end
 
-        if ArJdbc::AR52
-          # undefined method `cast' for #<ActiveRecord::ConnectionAdapters::SqlTypeMetadata> on AR52
-        else
-          default = args[0].cast(default)
-
-          sql_type = args.delete_at(1)
-          type = args.delete_at(0)
-
-          args.unshift(SqlTypeMetadata.new(:sql_type => sql_type, :type => type))
-        end
-
-        # super <= 4.1: (name, default, sql_type = nil, null = true)
-        # super >= 4.2: (name, default, cast_type, sql_type = nil, null = true)
-        # super >= 5.0: (name, default, sql_type_metadata = nil, null = true)
-
         super(name, default, *args)
         init_column(name, default, *args)
       end
@@ -80,18 +65,8 @@ module ActiveRecord
       end
 
       class << self
-
-        include Jdbc::TypeCast if ::ActiveRecord::VERSION::STRING >= '4.2'
-
-        if ActiveRecord::VERSION::MAJOR > 3 && ActiveRecord::VERSION::STRING < '4.2'
-
-          # @private provides compatibility between AR 3.x/4.0 API
-          def string_to_date(value); value_to_date(value) end
-
-        end
-
+        include Jdbc::TypeCast
       end
-
     end
   end
 end

data/lib/arjdbc/jdbc.rb

@@ -1,13 +1,6 @@
 require 'active_support/deprecation'
 
 module ArJdbc
-
-  # @private
-  AR42 = ::ActiveRecord::VERSION::STRING >= '4.2'
-
-  # @private
-  AR52 = ::ActiveRecord::VERSION::STRING >= '5.2'
-
   class << self
 
     # @private Internal API

data/lib/arjdbc/mysql/adapter.rb

@@ -107,7 +107,8 @@ module ActiveRecord
 
       # Reloading the type map in abstract/statement_cache.rb blows up postgres
       def clear_cache!
-        reload_type_map
+        # FIXME: This seems to have disappeared in Rails 7?
+        # reload_type_map
         super
       end
 

data/lib/arjdbc/oracle/adapter.rb

@@ -40,7 +40,7 @@ module ArJdbc
       return if @@_initialized; @@_initialized = true
 
       require 'arjdbc/util/serialized_attributes'
-      Util::SerializedAttributes.setup /LOB\(|LOB$/i, 'after_save_with_oracle_lob'
+      Util::SerializedAttributes.setup %r{LOB\(|LOB$}i, 'after_save_with_oracle_lob'
 
       unless ActiveRecord::ConnectionAdapters::AbstractAdapter.
           instance_methods(false).detect { |m| m.to_s == "prefetch_primary_key?" }
@@ -285,7 +285,7 @@ module ArJdbc
           execute "ALTER TABLE #{quote_table_name(table_name)} ADD CONSTRAINT #{quote_column_name(index_name)} #{index_type} (#{quoted_column_names})"
         end
       end
-    end if AR42
+    end
 
     # @private
     def add_index_options(table_name, column_name, options = {})
@@ -309,7 +309,7 @@ module ArJdbc
 
       quoted_column_names = column_names.map { |e| quote_column_name_or_expression(e) }.join(", ")
       [ index_name, index_type, quoted_column_names, tablespace, index_options ]
-    end if AR42
+    end
 
     # @override
     def remove_index(table_name, options = {})
@@ -327,12 +327,7 @@ module ArJdbc
       end
       execute "ALTER TABLE #{quote_table_name(table_name)} DROP CONSTRAINT #{quote_column_name(index_name)}" rescue nil
       execute "DROP INDEX #{quote_column_name(index_name)}"
-    end if AR42
-
-    # @private
-    def remove_index(table_name, options = {})
-      execute "DROP INDEX #{index_name(table_name, options)}"
-    end unless AR42
+    end
 
     def change_column_default(table_name, column_name, default)
       execute "ALTER TABLE #{quote_table_name(table_name)} MODIFY #{quote_column_name(column_name)} DEFAULT #{quote(default)}"
@@ -361,25 +356,11 @@ module ArJdbc
         "RENAME COLUMN #{quote_column_name(column_name)} TO #{quote_column_name(new_column_name)}"
     end
 
-    if ActiveRecord::VERSION::MAJOR >= 4
-
     # @override
     def remove_column(table_name, column_name, type = nil, options = {})
       do_remove_column(table_name, column_name)
     end
 
-    else
-
-    # @override
-    def remove_column(table_name, *column_names)
-      for column_name in column_names.flatten
-        do_remove_column(table_name, column_name)
-      end
-    end
-    alias remove_columns remove_column
-
-    end
-
     def do_remove_column(table_name, column_name)
       execute "ALTER TABLE #{quote_table_name(table_name)} DROP COLUMN #{quote_column_name(column_name)}"
     end