activerecord-jdbc-adapter 50.8-java → 51.1-java

data/lib/arjdbc/mysql/adapter.rb

@@ -31,16 +31,8 @@ module ActiveRecord
 
       include ArJdbc::MySQL
 
-      def initialize(connection, logger, connection_parameters, config)
-        # workaround to skip version check on JNDI to be lazy, dummy version is high enough for Rails 5.0 - 6.0
-        is_jndi = ::ActiveRecord::ConnectionAdapters::JdbcConnection.jndi_config?(config)
-        @version = '8.1.5' if is_jndi
-
-        super
-
-        # set to nil to have it lazy-load the real value when required
-        @version = nil if is_jndi
-
+      def initialize(connection, logger, config)
+        super(connection, logger, nil, config)
         @prepared_statements = false unless config.key?(:prepared_statements)
         # configure_connection taken care of at ArJdbc::Abstract::Core
       end
@@ -61,6 +53,10 @@ module ActiveRecord
         true
       end
 
+      def supports_transaction_isolation?
+        true
+      end
+
       # HELPER METHODS ===========================================
 
       # Reloading the type map in abstract/statement_cache.rb blows up postgres
@@ -92,7 +88,14 @@ module ActiveRecord
 
       #--
       # QUOTING ==================================================
-      #++
+      #+
+
+      # FIXME: 5.1 crashes without this.  I think this is Arel hitting a fallback path in to_sql.rb.
+      # So maybe an untested code path in their source.  Still means we are doing something wrong to
+      # even hit it.
+      def quote(value, comment=nil)
+        super(value)
+      end
 
       # NOTE: quote_string(string) provided by ArJdbc::MySQL (native code),
       # this piece is also native (mysql2) under MRI: `@connection.escape(string)`

data/lib/arjdbc/mysql/connection_methods.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 ArJdbc::ConnectionMethods.module_eval do
   def mysql_connection(config)
-    config = config.deep_dup
     # NOTE: this isn't "really" necessary but Rails (in tests) assumes being able to :
     #   ActiveRecord::Base.mysql2_connection ActiveRecord::Base.configurations['arunit'].merge(database: ...)
     config = symbolize_keys_if_necessary(config)
@@ -11,20 +10,14 @@ ArJdbc::ConnectionMethods.module_eval do
 
     return jndi_connection(config) if jndi_config?(config)
 
-    driver = config[:driver]
-    mysql_driver = driver.nil? || driver.to_s.start_with?('com.mysql.')
-    mariadb_driver = ! mysql_driver && driver.to_s.start_with?('org.mariadb.')
+    driver = config[:driver] ||=
+      defined?(::Jdbc::MySQL.driver_name) ? ::Jdbc::MySQL.driver_name : 'com.mysql.jdbc.Driver'
 
     begin
       require 'jdbc/mysql'
       ::Jdbc::MySQL.load_driver(:require) if defined?(::Jdbc::MySQL.load_driver)
     rescue LoadError # assuming driver.jar is on the class-path
-    end if mysql_driver
-
-    if driver.nil?
-      config[:driver] ||=
-        defined?(::Jdbc::MySQL.driver_name) ? ::Jdbc::MySQL.driver_name : 'com.mysql.jdbc.Driver'
-    end
+    end if mysql_driver = driver[0, 10] == 'com.mysql.'
 
     config[:username] = 'root' unless config.key?(:username)
     # jdbc:mysql://[host][,failoverhost...][:port]/[database]
@@ -32,16 +25,15 @@ ArJdbc::ConnectionMethods.module_eval do
     # - if the port is not specified, it defaults to 3306
     # - alternate fail-over syntax: [host:port],[host:port]/[database]
     unless config[:url]
-      host = config[:host]
-      host ||= 'localhost' if mariadb_driver
-      host = host.join(',') if host.respond_to?(:join)
+      host = config[:host]; host = host.join(',') if host.respond_to?(:join)
       config[:url] = "jdbc:mysql://#{host}#{ config[:port] ? ":#{config[:port]}" : nil }/#{config[:database]}"
     end
 
+    mariadb_driver = ! mysql_driver && driver.start_with?('org.mariadb.')
+
     properties = ( config[:properties] ||= {} )
     if mysql_driver
-      properties['zeroDateTimeBehavior'] ||=
-        config[:driver].to_s.start_with?('com.mysql.cj.') ? 'CONVERT_TO_NULL' : 'convertToNull'
+      properties['zeroDateTimeBehavior'] ||= 'convertToNull'
       properties['jdbcCompliantTruncation'] ||= false
       # NOTE: this is "better" than passing what users are used to set on MRI
       # e.g. 'utf8mb4' will fail cause the driver will check for a Java charset
@@ -71,8 +63,8 @@ ArJdbc::ConnectionMethods.module_eval do
     end
     if config[:sslkey] || sslcert = config[:sslcert] # || config[:use_ssl]
       properties['useSSL'] ||= true # supported by MariaDB as well
+      properties['requireSSL'] ||= true if mysql_driver
       if mysql_driver
-        properties['requireSSL'] ||= true
         properties['clientCertificateKeyStoreUrl'] ||= java.io.File.new(sslcert).to_url.to_s if sslcert
         if sslca = config[:sslca]
           properties['trustCertificateKeyStoreUrl'] ||= java.io.File.new(sslca).to_url.to_s
@@ -113,8 +105,7 @@ ArJdbc::ConnectionMethods.module_eval do
     rescue LoadError # assuming driver.jar is on the class-path
     end
 
-    config[:driver] ||=
-      defined?(::Jdbc::MariaDB.driver_name) ? ::Jdbc::MariaDB.driver_name : 'org.mariadb.jdbc.Driver'
+    config[:driver] ||= 'org.mariadb.jdbc.Driver'
 
     mysql_connection(config)
   end

data/lib/arjdbc/postgresql/adapter.rb

@@ -7,6 +7,7 @@ require 'active_record/connection_adapters/postgresql/column'
 require 'active_record/connection_adapters/postgresql/explain_pretty_printer'
 require 'active_record/connection_adapters/postgresql/quoting'
 require 'active_record/connection_adapters/postgresql/referential_integrity'
+require 'active_record/connection_adapters/postgresql/schema_creation'
 require 'active_record/connection_adapters/postgresql/schema_dumper'
 require 'active_record/connection_adapters/postgresql/schema_statements'
 require 'active_record/connection_adapters/postgresql/type_metadata'
@@ -54,30 +55,8 @@ module ArJdbc
       @postgresql_version ||=
         begin
           version = @connection.database_product
-          if match = version.match(/([\d\.]*\d).*?/)
-            version = match[1].split('.').map(&:to_i)
-            # PostgreSQL version representation does not have more than 4 digits
-            # From version 10 onwards, PG has changed its versioning policy to
-            # limit it to only 2 digits. i.e. in 10.x, 10 being the major
-            # version and x representing the patch release
-            # Refer to:
-            #   https://www.postgresql.org/support/versioning/
-            #   https://www.postgresql.org/docs/10/static/libpq-status.html -> PQserverVersion()
-            # for more info
-
-            if version.size >= 3
-              (version[0] * 100 + version[1]) * 100 + version[2]
-            elsif version.size == 2
-              if version[0] >= 10
-                version[0] * 100 * 100 + version[1]
-              else
-                (version[0] * 100 + version[1]) * 100
-              end
-            elsif version.size == 1
-              version[0] * 100 * 100
-            else
-              0
-            end
+          if version =~ /PostgreSQL (\d+)\.(\d+)\.(\d+)/
+            ($1.to_i * 10000) + ($2.to_i * 100) + $3.to_i
           else
             0
           end
@@ -146,8 +125,7 @@ module ArJdbc
     ActiveRecordError = ::ActiveRecord::ActiveRecordError
 
     NATIVE_DATABASE_TYPES = {
-      bigserial:    'bigserial',
-      primary_key:  'serial primary key',
+      primary_key:  'bigserial primary key',
       bigint:       { name: 'bigint' },
       binary:       { name: 'bytea' },
       bit:          { name: 'bit' },
@@ -178,10 +156,10 @@ module ArJdbc
       money:        { name: 'money' },
       numeric:      { name: 'numeric' },
       numrange:     { name: 'numrange' },
+      oid:          { name: 'oid' },
       path:         { name: 'path' },
       point:        { name: 'point' },
       polygon:      { name: 'polygon' },
-      serial:       { name: 'serial' }, # auto-inc integer, bigserial, smallserial
       string:       { name: 'character varying' },
       text:         { name: 'text' },
       time:         { name: 'time' },
@@ -239,8 +217,6 @@ module ArJdbc
 
     def supports_ddl_transactions?; true end
 
-    def supports_advisory_locks?; true end
-
     def supports_explain?; true end
 
     def supports_expression_index?; true end
@@ -249,22 +225,14 @@ module ArJdbc
 
     def supports_index_sort_order?; true end
 
-    def supports_migrations?; true end
-
     def supports_partial_index?; true end
 
-    def supports_primary_key?; true end # Supports finding primary key on non-Active Record tables
-
     def supports_savepoints?; true end
 
-    def supports_transaction_isolation?(level = nil); true end
+    def supports_transaction_isolation?; true end
 
     def supports_views?; true end
 
-    def supports_datetime_with_precision?; true end
-
-    def supports_comments?; true end
-
     # Does PostgreSQL support standard conforming strings?
     def supports_standard_conforming_strings?
       standard_conforming_strings?
@@ -275,18 +243,14 @@ module ArJdbc
       postgresql_version >= 90000
     end
 
-    def supports_materialized_views?
-      postgresql_version >= 90300
-    end
-
-    def supports_json?
-      postgresql_version >= 90200
-    end
-
     def supports_insert_with_returning?
       postgresql_version >= 80200
     end
 
+    def supports_pgcrypto_uuid?
+      postgresql_version >= 90400
+    end
+
     # Range data-types weren't introduced until PostgreSQL 9.2.
     def supports_ranges?
       postgresql_version >= 90200
@@ -296,6 +260,11 @@ module ArJdbc
       postgresql_version >= 90200
     end
 
+    # From AR 5.1 postgres_adapter.rb
+    def default_index_type?(index) # :nodoc:
+      index.using == :btree || super
+    end
+
     def enable_extension(name)
       execute("CREATE EXTENSION IF NOT EXISTS \"#{name}\"")
     end
@@ -347,7 +316,7 @@ module ArJdbc
       select_value("SELECT pg_advisory_unlock(#{lock_id})")
     end
 
-    # Returns the configured supported identifier length supported by PostgreSQL
+    # Returns the max identifier length supported by PostgreSQL
     def max_identifier_length
       @max_identifier_length ||= select_one('SHOW max_identifier_length', 'SCHEMA'.freeze)['max_identifier_length'].to_i
     end
@@ -395,7 +364,8 @@ module ArJdbc
     # 'DISCARD ALL' fails if we are inside a transaction
     def clear_cache!
       super
-      @connection.execute 'DEALLOCATE ALL' if supports_statement_cache? && @connection.active?
+      # Make sure all query plans are *really* gone
+      @connection.execute 'DEALLOCATE ALL' if active?
     end
 
     def reset!
@@ -406,12 +376,6 @@ module ArJdbc
       @connection.configure_connection
     end
 
-    def default_sequence_name(table_name, pk = "id") #:nodoc:
-      serial_sequence(table_name, pk)
-    rescue ActiveRecord::StatementInvalid
-      %Q("#{table_name}_#{pk}_seq")
-    end
-
     def last_insert_id_result(sequence_name)
       exec_query("SELECT currval('#{sequence_name}')", 'SQL')
     end
@@ -511,7 +475,7 @@ module ArJdbc
                col_description(a.attrelid, a.attnum) AS comment
           FROM pg_attribute a
           LEFT JOIN pg_attrdef d ON a.attrelid = d.adrelid AND a.attnum = d.adnum
-         WHERE a.attrelid = '#{quote_table_name(table_name)}'::regclass
+         WHERE a.attrelid = #{quote(quote_table_name(table_name))}::regclass
            AND a.attnum > 0 AND NOT a.attisdropped
          ORDER BY a.attnum
       end_sql
@@ -522,6 +486,67 @@ module ArJdbc
       execute "TRUNCATE TABLE #{quote_table_name(table_name)}", name
     end
 
+    # Returns an array of indexes for the given table.
+    def indexes(table_name, name = nil)
+      if name
+        ActiveSupport::Deprecation.warn(<<-MSG.squish)
+              Passing name to #indexes is deprecated without replacement.
+        MSG
+      end
+
+      # FIXME: AR version => table = Utils.extract_schema_qualified_name(table_name.to_s)
+      schema, table = extract_schema_and_table(table_name.to_s)
+
+      result = query(<<-SQL, 'SCHEMA')
+            SELECT distinct i.relname, d.indisunique, d.indkey, pg_get_indexdef(d.indexrelid), t.oid,
+                            pg_catalog.obj_description(i.oid, 'pg_class') AS comment,
+            (SELECT COUNT(*) FROM pg_opclass o
+               JOIN (SELECT unnest(string_to_array(d.indclass::text, ' '))::int oid) c
+                 ON o.oid = c.oid WHERE o.opcdefault = 'f')
+            FROM pg_class t
+            INNER JOIN pg_index d ON t.oid = d.indrelid
+            INNER JOIN pg_class i ON d.indexrelid = i.oid
+            LEFT JOIN pg_namespace n ON n.oid = i.relnamespace
+            WHERE i.relkind = 'i'
+              AND d.indisprimary = 'f'
+              AND t.relname = '#{table}'
+              AND n.nspname = #{schema ? "'#{schema}'" : 'ANY (current_schemas(false))'}
+            ORDER BY i.relname
+      SQL
+
+      result.map do |row|
+        index_name = row[0]
+        # FIXME: These values [1,2] are returned in a different format than AR expects, maybe we could update it on the Java side to be more accurate
+        unique = row[1].is_a?(String) ? row[1] == 't' : row[1] # JDBC gets us a boolean
+        indkey = row[2].is_a?(Java::OrgPostgresqlUtil::PGobject) ? row[2].value : row[2]
+        indkey = indkey.split(" ").map(&:to_i)
+        inddef = row[3]
+        oid = row[4]
+        comment = row[5]
+        opclass = row[6]
+
+        using, expressions, where = inddef.scan(/ USING (\w+?) \((.+?)\)(?: WHERE (.+))?\z/m).flatten
+
+        if indkey.include?(0) || opclass > 0
+          columns = expressions
+        else
+          columns = Hash[query(<<-SQL.strip_heredoc, "SCHEMA")].values_at(*indkey).compact
+                SELECT a.attnum, a.attname
+                FROM pg_attribute a
+                WHERE a.attrelid = #{oid}
+                AND a.attnum IN (#{indkey.join(",")})
+          SQL
+
+          # add info on sort order for columns (only desc order is explicitly specified, asc is the default)
+          orders = Hash[
+              expressions.scan(/(\w+) DESC/).flatten.map { |order_column| [order_column, :desc] }
+          ]
+        end
+
+        IndexDefinition.new(table_name, index_name, unique, columns, [], orders, where, nil, using.to_sym, comment.presence)
+      end.compact
+    end
+
     # @private
     def column_name_for_operation(operation, node)
       case operation
@@ -556,13 +581,22 @@ module ArJdbc
     end
 
     def translate_exception(exception, message)
+      # TODO: Can we base these on an error code of some kind?
       case exception.message
       when /duplicate key value violates unique constraint/
         ::ActiveRecord::RecordNotUnique.new(message)
+      when /violates not-null constraint/
+        ::ActiveRecord::NotNullViolation.new(message)
       when /violates foreign key constraint/
         ::ActiveRecord::InvalidForeignKey.new(message)
       when /value too long/
         ::ActiveRecord::ValueTooLong.new(message)
+      when /out of range/
+        ::ActiveRecord::RangeError.new(message)
+      when /could not serialize/
+        ::ActiveRecord::SerializationFailure.new(message)
+      when /deadlock detected/
+        ::ActiveRecord::Deadlocked.new(message)
       else
         super
       end
@@ -634,11 +668,12 @@ module ActiveRecord::ConnectionAdapters
     # AR expects OID to be available on the adapter
     OID = ActiveRecord::ConnectionAdapters::PostgreSQL::OID
 
-    def initialize(connection, logger = nil, connection_parameters = nil, config = {})
+    def initialize(connection, logger = nil, config = {})
       # @local_tz is initialized as nil to avoid warnings when connect tries to use it
       @local_tz = nil
+      @max_identifier_length = nil
 
-      super(connection, logger, config) # configure_connection happens in super
+      super # configure_connection happens in super
 
       initialize_type_map(@type_map = Type::HashLookupTypeMap.new)
 
@@ -652,7 +687,6 @@ module ActiveRecord::ConnectionAdapters
 
     require 'active_record/connection_adapters/postgresql/schema_definitions'
 
-    ColumnDefinition = ActiveRecord::ConnectionAdapters::PostgreSQL::ColumnDefinition
     ColumnMethods = ActiveRecord::ConnectionAdapters::PostgreSQL::ColumnMethods
     TableDefinition = ActiveRecord::ConnectionAdapters::PostgreSQL::TableDefinition
     Table = ActiveRecord::ConnectionAdapters::PostgreSQL::Table
@@ -661,6 +695,21 @@ module ActiveRecord::ConnectionAdapters
       TableDefinition.new(*args)
     end
 
+    def exec_query(sql, name = nil, binds = [], prepare: false)
+      super
+    rescue ActiveRecord::StatementInvalid => e
+      raise unless e.cause.message.include?('cached plan must not change result type'.freeze)
+
+      if open_transactions > 0
+        # In a transaction, have to fail it - See AR code for details
+        raise ActiveRecord::PreparedStatementCacheExpired.new(e.cause.message)
+      else
+        # Not in a transaction, clear the prepared statement and try again
+        delete_cached_statement(sql)
+        retry
+      end
+    end
+
     public :sql_for_insert
 
     def schema_creation # :nodoc:
@@ -679,7 +728,7 @@ module ActiveRecord::ConnectionAdapters
 
     # Prepared statements aren't schema aware so we need to make sure we
     # store different PreparedStatement objects for different schemas
-    def sql_key(sql)
+    def cached_statement_key(sql)
       "#{schema_search_path}-#{sql}"
     end
 

data/lib/arjdbc/postgresql/column.rb

@@ -15,7 +15,7 @@ module ArJdbc
       end
 
       # Extracts the value from a PostgreSQL column default definition.
-      def extract_value_from_default(default)
+      def extract_value_from_default(default) # :nodoc:
         case default
           # Quoted types
           when /\A[\(B]?'(.*)'.*::"?([\w. ]+)"?(?:\[\])?\z/m
@@ -41,13 +41,10 @@ module ArJdbc
         end
       end
 
-      def extract_default_function(default_value, default)
-        default if has_default_function?(default_value, default)
+      def extract_default_function(default_value, default) # :nodoc:
+        default if ! default_value && ( %r{\w+\(.*\)|\(.*\)::\w+} === default )
       end
 
-      def has_default_function?(default_value, default)
-        !default_value && %r{\w+\(.*\)|\(.*\)::\w+|CURRENT_DATE|CURRENT_TIMESTAMP} === default
-      end
     end
 
   end