activerecord-jdbc-adapter 1.2.9.1 → 1.3.0.beta1

data/test/db/mysql/connection_test.rb

@@ -0,0 +1,51 @@
+require 'db/mysql'
+
+class MySQLConnectionTest < Test::Unit::TestCase
+
+  def test_mysql_default_in_strict_mode
+    assert_equal [["STRICT_ALL_TABLES"]], select_rows("SELECT @@SESSION.sql_mode")
+  end if ar_version('4.0')
+
+  def test_mysql_strict_mode_disabled
+    run_without_connection do |orig_connection|
+      ActiveRecord::Base.establish_connection(orig_connection.merge({:strict => false}))
+      assert_equal [['']], select_rows("SELECT @@SESSION.sql_mode")
+    end
+  end
+  
+  def test_mysql_set_session_variable
+    run_without_connection do |orig_connection|
+      ActiveRecord::Base.establish_connection(orig_connection.deep_merge({:variables => {:default_week_format => 3}}))
+      rows = select_rows("SELECT @@SESSION.DEFAULT_WEEK_FORMAT")
+      assert_equal 3, rows.first.first.to_i
+    end
+  end
+
+  def test_mysql_set_session_variable_to_default
+    run_without_connection do |orig_connection|
+      ActiveRecord::Base.establish_connection(orig_connection.deep_merge({:variables => {:default_week_format => :default}}))
+      global_mode_rows = select_rows "SELECT @@GLOBAL.DEFAULT_WEEK_FORMAT"
+      session_mode_rows = select_rows "SELECT @@SESSION.DEFAULT_WEEK_FORMAT"
+      assert_equal global_mode_rows, session_mode_rows
+    end
+  end
+  
+  protected
+  
+  def select_rows(sql)
+    result = ActiveRecord::Base.connection.exec_query(sql)
+    result.respond_to?(:rows) ? result.rows : [ result.first.map { |_,value| value } ]
+  end
+  
+  private
+
+  def run_without_connection
+    original_connection = ActiveRecord::Base.remove_connection
+    begin
+      yield original_connection
+    ensure
+      ActiveRecord::Base.establish_connection(original_connection)
+    end
+  end
+
+end

data/test/{mysql_schema_dump_test.rb → db/mysql/schema_dump_test.rb}

@@ -28,10 +28,12 @@ class MysqlSchemaDumpTest < Test::Unit::TestCase
       t.text   :normal_text, :limit => 65535
       t.text   :medium_text, :limit => 16777215
       t.text   :long_text,   :limit => 2147483647
-      t.text   :just_text, :null => false
+      t.text   :just_text,    :null => false
       # MySQL does not allow default values for blobs. 
       # Fake it out with a big varchar below.
       t.string :string_col, :null => true, :default => '', :limit => 1024
+      t.binary :var_binary, :limit => 255
+      t.binary :var_binary_large, :limit => 4095
     end
   end
   
@@ -52,6 +54,12 @@ class MysqlSchemaDumpTest < Test::Unit::TestCase
     assert_match %r{t.text\s+"long_text",\s+:limit => 2147483647$}, output
   end
   
+  def test_schema_dump_includes_length_for_mysql_binary_fields
+    output = standard_dump
+    assert_match %r{t.binary\s+"var_binary",[\s|:]+limit[\s\:\=\>]+255$}, output
+    assert_match %r{t.binary\s+"var_binary_large",[\s|:]+limit[\s\:\=\>]+4095$}, output
+  end
+  
 end
 
 class MysqlInfoTest < Test::Unit::TestCase

data/test/{mysql_simple_test.rb → db/mysql/simple_test.rb}

@@ -12,7 +12,9 @@ class MysqlSimpleTest < Test::Unit::TestCase
   include SimpleTestMethods
   include ActiveRecord3TestMethods
   include ColumnNameQuotingTests
+  include DirtyAttributeTests
   include XmlColumnTests
+  include CustomSelectTestMethods
 
   column_quote_char "`"
 
@@ -92,12 +94,18 @@ class MysqlSimpleTest < Test::Unit::TestCase
   end
 
   def test_find_in_other_schema_with_include
+    user_1 = User.create :login => 'user1'
+    user_2 = User.create :login => 'user2'
+    Entry.create :title => 'title1', :content => '', :rating => 0, :user_id => user_1.id
+    Entry.create :title => 'title2', :content => '', :rating => 1, :user_id => user_2.id
+    
     old_entries_table_name = Entry.table_name
     old_users_table_name   = User.table_name
+    database = MYSQL_CONFIG[:database]
     begin
-      User.table_name  = "#{MYSQL_CONFIG[:database]}.users"
-      Entry.table_name = "#{MYSQL_CONFIG[:database]}.entries"
-      assert !Entry.all(:include => :user).empty?
+      User.table_name  = "#{database}.users"
+      Entry.table_name = "#{database}.entries"
+      assert_not_empty Entry.all(:include => :user)
     ensure
       Entry.table_name = old_entries_table_name
       User.table_name  = old_users_table_name
@@ -106,6 +114,11 @@ class MysqlSimpleTest < Test::Unit::TestCase
 
   include ExplainSupportTestMethods if ar_version("3.1")
   
+  def test_reports_server_version
+    assert_instance_of Array, ActiveRecord::Base.connection.send(:version)
+    assert_equal 3, ActiveRecord::Base.connection.send(:version).size
+  end
+  
   def test_update_sql_public_and_returns_rows_affected
     ActiveRecord::Base.connection.update_sql "UPDATE entries SET title = NULL"
     
@@ -117,11 +130,6 @@ class MysqlSimpleTest < Test::Unit::TestCase
     assert_equal 'updated content', e1.reload.content
     assert_equal 'updated content', e2.reload.content
   end
-
-  def test_reports_server_version
-    assert_instance_of Array, ActiveRecord::Base.connection.send(:version)
-    assert_equal 3, ActiveRecord::Base.connection.send(:version).size
-  end
   
 end
 

data/test/db/mysql/transaction_test.rb

@@ -0,0 +1,6 @@
+require 'db/mysql'
+require 'transaction'
+
+class MySQLTransactionTest < Test::Unit::TestCase
+  include TransactionTestMethods
+end

data/test/db/mysql/types_test.rb

@@ -0,0 +1,30 @@
+require 'db/mysql'
+
+class MySQLTypesTest < Test::Unit::TestCase
+  
+  def test_binary_types
+    assert_equal 'varbinary(64)', type_to_sql(:binary, 64)
+    assert_equal 'varbinary(4095)', type_to_sql(:binary, 4095)
+    assert_equal 'blob(4096)', type_to_sql(:binary, 4096)
+    assert_equal 'blob', type_to_sql(:binary)
+  end
+
+  def type_to_sql(*args)
+    ActiveRecord::Base.connection.type_to_sql(*args)
+  end
+
+  def self.startup
+    ActiveRecord::Base.connection.execute "CREATE TABLE enum_tests ( enum_column ENUM('true','false') )"
+  end
+  
+  def self.shutdown
+    ActiveRecord::Base.connection.execute "DROP TABLE IF EXISTS enum_tests;"
+  end
+  
+  class EnumTest < ActiveRecord::Base; end
+
+  def test_enum_limit
+    assert_equal 5, EnumTest.columns.first.limit
+  end
+  
+end 

data/test/{mysql_test.rb → db/mysql/unit_test.rb}

@@ -1,7 +1,7 @@
 # encoding: ASCII-8BIT
 require 'test_helper'
 
-class MySQLTest < Test::Unit::TestCase
+class MySQLUnitTest < Test::Unit::TestCase
 
   class MySQLImpl
     include ArJdbc::MySQL

data/test/db/mysql_config.rb

@@ -4,4 +4,4 @@ MYSQL_CONFIG = {
   :adapter  => 'mysql',
   :database => 'arjdbc_test',
   :host     => 'localhost'
-}
+}

data/test/db/oracle.rb

@@ -1,4 +1,4 @@
-require 'jdbc_common'
+require 'test_helper'
 
 config = {
   :adapter  => 'oracle',

data/test/db/oracle/multibyte_test.rb

@@ -0,0 +1,22 @@
+require 'db/oracle'
+require 'simple'
+
+class OracleMultibyteTest < Test::Unit::TestCase
+  include MultibyteTestMethods
+
+  def self.startup
+    super
+    MigrationSetup.setup!
+    ActiveRecord::Base.logger.level = Logger::DEBUG
+  end
+  
+  def self.shutdown
+    ActiveRecord::Base.logger.level = Logger::WARN
+    MigrationSetup.teardown!
+    super
+  end
+
+  def setup!; end # MigrationSetup#setup!
+  def teardown!; end # MigrationSetup#teardown!
+  
+end

data/test/{oracle_simple_test.rb → db/oracle/simple_test.rb}

@@ -1,10 +1,22 @@
-require 'jdbc_common'
 require 'db/oracle'
+require 'simple'
 
 class OracleSimpleTest < Test::Unit::TestCase
   include SimpleTestMethods
+  include ActiveRecord3TestMethods
+  include DirtyAttributeTests
+  include XmlColumnTests
+  
+  def xml_sql_type; 'XMLTYPE'; end
 
+  # #override
+  def test_insert_returns_id
+    # TODO not supported/implemented
+  end
+  
   def test_default_id_type_is_integer
+    user = User.create! :login => 'id_type'
+    Entry.create! :title => 'first', :user_id => user.id
     assert Integer === Entry.first.id
   end
 
@@ -68,6 +80,7 @@ class OracleSimpleTest < Test::Unit::TestCase
 
   def assert_date_equal expected, actual
     # Oracle doesn't distinguish btw date/datetime
+    expected = expected.respond_to?(:to_date) ? expected.to_date : expected
     assert_equal expected, actual.to_date
   end
   
@@ -77,21 +90,3 @@ class OracleSimpleTest < Test::Unit::TestCase
   end
   
 end
-
-class OracleMultibyteTest < Test::Unit::TestCase
-  include MultibyteTestMethods
-
-  def self.startup
-    super
-    MigrationSetup.setup!
-  end
-  
-  def self.shutdown
-    MigrationSetup.teardown!
-    super
-  end
-
-  def setup!; end # MigrationSetup#setup!
-  def teardown!; end # MigrationSetup#teardown!
-  
-end

data/test/{oracle_specific_test.rb → db/oracle/specific_test.rb}

@@ -1,6 +1,6 @@
 require 'test_helper'
-require 'jdbc_common'
 require 'db/oracle'
+require 'simple'
 
 class OracleSpecificTest < Test::Unit::TestCase
   include MigrationSetup
@@ -21,17 +21,29 @@ class OracleSpecificTest < Test::Unit::TestCase
     java_connection.createStatement.execute "
       INSERT INTO DEFAULT_NUMBERS (ID, VALUE, DATUM, FPOINT, VALUE2)
         VALUES (1, 0.076, TIMESTAMP'2009-11-05 00:00:00', 1000.01, 1234)"
-    java_connection.createStatement.execute "CREATE SYNONYM POSTS FOR ENTRIES"
     
     MigrationSetup.setup!
+    
+    java_connection.createStatement.execute "CREATE SYNONYM POSTS FOR ENTRIES"
+    
+    java_connection.createStatement.execute "CREATE VIEW GOOD_ENTRIES AS SELECT * FROM entries WHERE rating >= 1.0"
+    
+    # MV will be populated IMMEDIATELY by default :
+    user = User.create! :login => 'sandokan'
+    Entry.create! :title => 'SANDOKAAAN!', :rating => 4.95, :user_id => user.id
+    
+    java_connection.createStatement.execute "CREATE MATERIALIZED VIEW USER_ENTRIES AS " + 
+      "SELECT e.id, e.title, e.user_id FROM users u, entries e WHERE e.user_id = u.id "
   end
 
   def self.shutdown
-    MigrationSetup.teardown!
-    
     java_connection = @@java_connection
     java_connection.createStatement.execute "DROP TABLE DEFAULT_NUMBERS"
     java_connection.createStatement.execute "DROP SYNONYM POSTS"
+    java_connection.createStatement.execute "DROP VIEW GOOD_ENTRIES"
+    java_connection.createStatement.execute "DROP MATERIALIZED VIEW USER_ENTRIES"
+    
+    MigrationSetup.teardown!
     
     @@java_connection.close
     super
@@ -91,26 +103,60 @@ class OracleSpecificTest < Test::Unit::TestCase
     obj = DefaultNumber.first
     assert obj.datum.nil?
   end
+  
+  test "synonym table exists" do
+    assert_true ActiveRecord::Base.connection.table_exists? 'posts'
+    assert_true ActiveRecord::Base.connection.table_exists? 'POSTS'
+  end
+  
+  test "view table exists (despite not being among reported tables)" do
+    assert_true ActiveRecord::Base.connection.table_exists? 'GOOD_ENTRIES'
+    assert_false ActiveRecord::Base.connection.tables.include?('GOOD_ENTRIES')
+  end
 
-  def test_model_access_by_synonym
+  test "materialized view table exists" do
+    assert_true ActiveRecord::Base.connection.table_exists? 'USER_ENTRIES'
+  end
+  
+  test 'model access by synonym' do
     @klass = Class.new(ActiveRecord::Base)
     @klass.table_name = "POSTS" # alias
     entry_columns = Entry.columns_hash
-    @klass.columns.each do |c|
-      assert ec = entry_columns[c.name]
-      assert_equal ec.sql_type, c.sql_type
-      assert_equal ec.type, c.type
+    @klass.columns.each do |column|
+      assert entry_column = entry_columns[column.name]
+      assert_equal entry_column.sql_type, column.sql_type
+      assert_equal entry_column.type, column.type
     end
   end
 
-  #
-
-  def test_oracle_identifier_lengths
-    assert_equal 30, connection.table_alias_length
-    assert_equal 30, connection.table_name_length
-    assert_equal 30, connection.index_name_length
-    assert_equal 30, connection.column_name_length
+  class Post < ActiveRecord::Base; end
+  
+  test "post synonym" do
+    Entry.create! :title => 'first', :content => 'SOME CONTENT', :rating => 0.5
+    assert_equal Entry.count, Post.count
+    assert_equal Entry.first.title, Post.first.title
   end
+  
+  test 'model access by materialized view' do
+    @klass = Class.new(ActiveRecord::Base)
+    @klass.table_name = "USER_ENTRIES" # MV
+    entry_columns = Entry.columns_hash
+    
+    assert_equal 3, @klass.columns.size
+    assert column = @klass.columns_hash['id']
+    assert_equal entry_columns['id'].sql_type, column.sql_type
+    assert_equal entry_columns['id'].type, column.type
+    assert column = @klass.columns_hash['title']
+    assert_equal entry_columns['title'].sql_type, column.sql_type
+    assert_equal entry_columns['title'].type, column.type
+    assert column = @klass.columns_hash['user_id']
+    assert_equal entry_columns['user_id'].sql_type, column.sql_type
+    assert_equal entry_columns['user_id'].type, column.type
+    
+    assert @klass.first # sandokan was here !
+  end
+  
+  #
 
   def test_current_user
     puts "ORA current_user: #{connection.current_user}"

data/test/db/oracle/transaction_test.rb

@@ -0,0 +1,31 @@
+require 'db/oracle'
+require 'transaction'
+
+class OracleTransactionTest < Test::Unit::TestCase
+  include TransactionTestMethods
+  
+  def test_supports_transaction_isolation
+    assert ActiveRecord::Base.connection.supports_transaction_isolation?
+    assert ActiveRecord::Base.connection.supports_transaction_isolation?(:read_committed)
+    assert ActiveRecord::Base.connection.supports_transaction_isolation?(:serializable)
+  end
+  
+  # Oracle supports TRANSACTION_SERIALIZABLE and TRANSACTION_READ_COMMITTED
+  
+  def test_transaction_isolation_read_uncommitted
+    assert ! ActiveRecord::Base.connection.supports_transaction_isolation?(:read_uncommitted)
+    
+    assert_raise ActiveRecord::TransactionIsolationError do
+      super
+    end
+  end if Test::Unit::TestCase.ar_version('4.0')
+  
+  def test_transaction_isolation_repeatable_read
+    assert ! ActiveRecord::Base.connection.supports_transaction_isolation?(:repeatable_read)
+    
+    assert_raise ActiveRecord::TransactionIsolationError do
+      super
+    end
+  end if Test::Unit::TestCase.ar_version('4.0')
+  
+end