activerecord-jdbc-adapter 0.9.7-java → 1.0.0.beta1-java

data/src/java/arjdbc/jdbc/SQLBlock.java

@@ -0,0 +1,48 @@
+/*
+ **** BEGIN LICENSE BLOCK *****
+ * Copyright (c) 2006-2010 Nick Sieger <nick@nicksieger.com>
+ * Copyright (c) 2006-2007 Ola Bini <ola.bini@gmail.com>
+ * Copyright (c) 2008-2009 Thomas E Enebo <enebo@acm.org>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+ * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+ * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ ***** END LICENSE BLOCK *****/
+
+package arjdbc.jdbc;
+
+import java.sql.Connection;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Statement;
+
+/**
+ *
+ * @author nicksieger
+ */
+public abstract class SQLBlock {
+    abstract Object call(Connection c) throws SQLException;
+
+    public void close(Statement statement) {
+        RubyJdbcConnection.close(statement);
+    }
+
+    public void close(ResultSet resultSet) {
+        RubyJdbcConnection.close(resultSet);
+    }
+}

data/src/java/{jdbc_adapter → arjdbc/mssql}/MssqlRubyJdbcConnection.java

@@ -1,6 +1,6 @@
 /*
  **** BEGIN LICENSE BLOCK *****
- * Copyright (c) 2006-2009 Nick Sieger <nick@nicksieger.com>
+ * Copyright (c) 2006-2010 Nick Sieger <nick@nicksieger.com>
  * Copyright (c) 2006-2007 Ola Bini <ola.bini@gmail.com>
  * Copyright (c) 2008-2009 Thomas E Enebo <enebo@acm.org>
  *
@@ -23,11 +23,14 @@
  * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
  * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  ***** END LICENSE BLOCK *****/
-package jdbc_adapter;
+package arjdbc.mssql;
 
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Types;
+
+import arjdbc.jdbc.RubyJdbcConnection;
+
 import org.jruby.Ruby;
 import org.jruby.RubyClass;
 import org.jruby.runtime.ObjectAllocator;

data/src/java/{jdbc_adapter/JdbcMySQLSpec.java → arjdbc/mysql/MySQLModule.java}

@@ -1,7 +1,7 @@
 /***** BEGIN LICENSE BLOCK *****
- * Copyright (c) 2006-2009 Nick Sieger <nick@nicksieger.com>
+ * Copyright (c) 2006-2010 Nick Sieger <nick@nicksieger.com>
  * Copyright (c) 2006-2007 Ola Bini <ola.bini@gmail.com>
- * 
+ *
  * Permission is hereby granted, free of charge, to any person obtaining
  * a copy of this software and associated documentation files (the
  * "Software"), to deal in the Software without restriction, including
@@ -9,10 +9,10 @@
  * distribute, sublicense, and/or sell copies of the Software, and to
  * permit persons to whom the Software is furnished to do so, subject to
  * the following conditions:
- * 
+ *
  * The above copyright notice and this permission notice shall be
  * included in all copies or substantial portions of the Software.
- * 
+ *
  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
  * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
  * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
@@ -22,7 +22,7 @@
  * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  ***** END LICENSE BLOCK *****/
 
-package jdbc_adapter;
+package arjdbc.mysql;
 
 import java.sql.Connection;
 
@@ -35,10 +35,10 @@ import org.jruby.runtime.builtin.IRubyObject;
 
 import org.jruby.util.ByteList;
 
-public class JdbcMySQLSpec {
-    public static void load(RubyModule jdbcSpec) {
-        RubyModule mysql = jdbcSpec.defineModuleUnder("MySQL");
-        mysql.defineAnnotatedMethods(JdbcMySQLSpec.class);
+public class MySQLModule {
+    public static void load(RubyModule arJdbc) {
+        RubyModule mysql = arJdbc.defineModuleUnder("MySQL");
+        mysql.defineAnnotatedMethods(MySQLModule.class);
     }
 
     private final static byte BACKQUOTE = '`';
@@ -56,9 +56,9 @@ public class JdbcMySQLSpec {
     public static IRubyObject quote_string(ThreadContext context, IRubyObject recv, IRubyObject string) {
         ByteList bytes = ((RubyString) string).getByteList();
         ByteList newBytes = new ByteList();
-        
+
         newBytes.append(bytes);
-        
+
         for(int i = newBytes.begin; i < newBytes.begin + newBytes.realSize; i++) {
             byte[] rep = null;
             switch (newBytes.bytes[i]) {
@@ -94,7 +94,7 @@ public class JdbcMySQLSpec {
 
         return context.getRuntime().newString(newBytes);
     }
-    
+
     @JRubyMethod(name = "quote_table_name", frame=false)
     public static IRubyObject quote_table_name(ThreadContext context, IRubyObject recv, IRubyObject arg) {
         ByteList bytes = arg.asString().getByteList();

data/src/java/{jdbc_adapter/PostgresRubyJdbcConnection.java → arjdbc/postgresql/PostgresqlRubyJdbcConnection.java}

@@ -1,6 +1,6 @@
 /*
  **** BEGIN LICENSE BLOCK *****
- * Copyright (c) 2006-2009 Nick Sieger <nick@nicksieger.com>
+ * Copyright (c) 2006-2010 Nick Sieger <nick@nicksieger.com>
  * Copyright (c) 2006-2007 Ola Bini <ola.bini@gmail.com>
  * Copyright (c) 2008-2009 Thomas E Enebo <enebo@acm.org>
  *
@@ -23,7 +23,9 @@
  * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
  * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  ***** END LICENSE BLOCK *****/
-package jdbc_adapter;
+package arjdbc.postgresql;
+
+import arjdbc.jdbc.RubyJdbcConnection;
 
 import org.jruby.Ruby;
 import org.jruby.RubyClass;
@@ -34,22 +36,22 @@ import org.jruby.runtime.builtin.IRubyObject;
  *
  * @author enebo
  */
-public class PostgresRubyJdbcConnection extends RubyJdbcConnection {
-    protected PostgresRubyJdbcConnection(Ruby runtime, RubyClass metaClass) {
+public class PostgresqlRubyJdbcConnection extends RubyJdbcConnection {
+    protected PostgresqlRubyJdbcConnection(Ruby runtime, RubyClass metaClass) {
         super(runtime, metaClass);
     }
 
-    public static RubyClass createPostgresJdbcConnectionClass(Ruby runtime, RubyClass jdbcConnection) {
+    public static RubyClass createPostgresqlJdbcConnectionClass(Ruby runtime, RubyClass jdbcConnection) {
         RubyClass clazz = RubyJdbcConnection.getConnectionAdapters(runtime).defineClassUnder("PostgresJdbcConnection",
-                jdbcConnection, POSTGRES_JDBCCONNECTION_ALLOCATOR);
-        clazz.defineAnnotatedMethods(PostgresRubyJdbcConnection.class);
+                jdbcConnection, POSTGRESQL_JDBCCONNECTION_ALLOCATOR);
+        clazz.defineAnnotatedMethods(PostgresqlRubyJdbcConnection.class);
 
         return clazz;
     }
 
-    private static ObjectAllocator POSTGRES_JDBCCONNECTION_ALLOCATOR = new ObjectAllocator() {
+    private static ObjectAllocator POSTGRESQL_JDBCCONNECTION_ALLOCATOR = new ObjectAllocator() {
         public IRubyObject allocate(Ruby runtime, RubyClass klass) {
-            return new PostgresRubyJdbcConnection(runtime, klass);
+            return new PostgresqlRubyJdbcConnection(runtime, klass);
         }
     };
 }

data/src/java/arjdbc/sqlite3/Sqlite3RubyJdbcConnection.java

@@ -0,0 +1,64 @@
+/*
+ **** BEGIN LICENSE BLOCK *****
+ * Copyright (c) 2006-2010 Nick Sieger <nick@nicksieger.com>
+ * Copyright (c) 2006-2007 Ola Bini <ola.bini@gmail.com>
+ * Copyright (c) 2008-2009 Thomas E Enebo <enebo@acm.org>
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining
+ * a copy of this software and associated documentation files (the
+ * "Software"), to deal in the Software without restriction, including
+ * without limitation the rights to use, copy, modify, merge, publish,
+ * distribute, sublicense, and/or sell copies of the Software, and to
+ * permit persons to whom the Software is furnished to do so, subject to
+ * the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be
+ * included in all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+ * LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+ * OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ ***** END LICENSE BLOCK *****/
+
+package arjdbc.sqlite3;
+
+import arjdbc.jdbc.RubyJdbcConnection;
+
+import org.jruby.Ruby;
+import org.jruby.RubyClass;
+import org.jruby.runtime.ObjectAllocator;
+import org.jruby.runtime.ThreadContext;
+import org.jruby.runtime.builtin.IRubyObject;
+
+/**
+ *
+ * @author enebo
+ */
+public class Sqlite3RubyJdbcConnection extends RubyJdbcConnection {
+    protected Sqlite3RubyJdbcConnection(Ruby runtime, RubyClass metaClass) {
+        super(runtime, metaClass);
+    }
+
+    public static RubyClass createSqlite3JdbcConnectionClass(Ruby runtime, RubyClass jdbcConnection) {
+        RubyClass clazz = RubyJdbcConnection.getConnectionAdapters(runtime).defineClassUnder("Sqlite3JdbcConnection",
+                jdbcConnection, SQLITE3_JDBCCONNECTION_ALLOCATOR);
+        clazz.defineAnnotatedMethods(Sqlite3RubyJdbcConnection.class);
+
+        return clazz;
+    }
+
+    private static ObjectAllocator SQLITE3_JDBCCONNECTION_ALLOCATOR = new ObjectAllocator() {
+        public IRubyObject allocate(Ruby runtime, RubyClass klass) {
+            return new Sqlite3RubyJdbcConnection(runtime, klass);
+        }
+    };
+
+    @Override
+    protected IRubyObject tables(ThreadContext context, String catalog, String schemaPattern, String tablePattern, String[] types) {
+        return (IRubyObject) withConnectionAndRetry(context, tableLookupBlock(context.getRuntime(), catalog, schemaPattern, tablePattern, types, true));
+    }
+}

data/test/abstract_db_create.rb

@@ -9,6 +9,9 @@ module Rails
       @config ||= Object.new
     end
   end
+  def self.application
+    Rails::Application
+  end
 end
 
 module AbstractDbCreate
@@ -22,7 +25,7 @@ module AbstractDbCreate
     setup_rails
     set_rails_constant("env", "unittest")
     set_rails_constant("root", ".")
-    load File.dirname(__FILE__) + '/../lib/jdbc_adapter/jdbc.rake' if jruby?
+    load File.dirname(__FILE__) + '/../lib/arjdbc/jdbc/jdbc.rake' if jruby?
     task :environment do
       ActiveRecord::Base.configurations = configurations
     end

data/test/activerecord/connection_adapters/type_conversion_test.rb

@@ -1,6 +1,6 @@
 require 'java'
 require 'models/data_types'
-require 'active_record/connection_adapters/jdbc_adapter'
+require 'arjdbc'
 require 'db/derby'
 require 'test/unit'
 

data/test/db/derby.rb

@@ -1,14 +1,12 @@
-require 'logger'
-
-config = {
-  :adapter => 'derby',
-  :database => "derby-testdb"
-}
-
-ActiveRecord::Base.establish_connection(config)
-
-at_exit {  
-  # Clean up derby files
-  require 'fileutils'
-  FileUtils.rm_rf('derby-testdb')
-}
+config = {
+  :adapter => 'derby',
+  :database => "derby-testdb"
+}
+
+ActiveRecord::Base.establish_connection(config)
+
+at_exit {
+  # Clean up derby files
+  require 'fileutils'
+  FileUtils.rm_rf('derby-testdb')
+}

data/test/db/hsqldb.rb

@@ -7,6 +7,7 @@ ActiveRecord::Base.establish_connection(config)
 
 at_exit {
   # Clean up hsqldb when done
-  Dir['test.db*'].each {|f| File.delete(f)}
-  File.delete('hsqldb-testdb.log') rescue nil #can't delete on windows
+  require "fileutils"
+  Dir['test.db*'].each {|f| FileUtils.rm_rf(f)}
+  FileUtils.rm_rf('hsqldb-testdb.log') rescue nil #can't delete on windows
 }

data/test/db/jndi_config.rb

@@ -1,12 +1,12 @@
 require 'fileutils'
-require 'active_record/connection_adapters/jdbc_adapter'
+require 'arjdbc'
 
 System = java.lang.System
 Context = javax.naming.Context
 InitialContext = javax.naming.InitialContext
 Reference = javax.naming.Reference
 StringRefAddr = javax.naming.StringRefAddr
-  
+
 System.set_property(Context::INITIAL_CONTEXT_FACTORY,
                     'com.sun.jndi.fscontext.RefFSContextFactory')
 project_path = File.expand_path(File.dirname(__FILE__) + '/../..')
@@ -18,9 +18,9 @@ System.set_property(Context::PROVIDER_URL, "file://#{jndi_dir}")
 derby_ref = Reference.new('javax.sql.DataSource',
                           'org.apache.commons.dbcp.BasicDataSourceFactory',
                           nil)
-derby_ref.add StringRefAddr.new('driverClassName', 
+derby_ref.add StringRefAddr.new('driverClassName',
                                 'org.apache.derby.jdbc.EmbeddedDriver')
-derby_ref.add StringRefAddr.new('url', 
+derby_ref.add StringRefAddr.new('url',
                                 'jdbc:derby:derby-testdb;create=true')
 derby_ref.add StringRefAddr.new('username', 'sa')
 derby_ref.add StringRefAddr.new('password', '')

data/test/db/sqlite3.rb

@@ -1,10 +1,6 @@
-require 'jdbc/sqlite3' if jruby?
-
 config = {
-  :adapter => jruby? ? 'jdbcsqlite3' : 'sqlite3', 
-  :dbfile  => 'test.sqlite3.db'
-#  :url => 'jdbc:sqlite:test.sqlite3.db',
-#  :driver => 'org.sqlite.JDBC'
+  :adapter => 'sqlite3',
+  :database  => 'test.sqlite3.db'
 }
 
 ActiveRecord::Base.establish_connection(config)

data/test/db2_simple_test.rb

@@ -8,3 +8,26 @@ end
 class DB2HasManyThroughTest < Test::Unit::TestCase
   include HasManyThroughMethods
 end
+
+class DB2Test < Test::Unit::TestCase
+  def setup
+    @inst = Object.new
+    @inst.extend ArJdbc::DB2
+    @column = Object.new
+    class << @column
+      attr_accessor :type
+    end
+  end
+
+  def test_quote_decimal
+    assert_equal %q{'123.45'}, @inst.quote("123.45")
+    @column.type = :decimal
+    assert_equal %q{123.45}, @inst.quote("123.45", @column), "decimal columns should not have quotes"
+  end
+
+  def test_primary_key_generation
+    @column.type = :primary_key
+    assert_equal 'int not null generated by default as identity (start with 1) primary key', @inst.modify_types({:string => {}, :integer => {}, :boolean => {}})[:primary_key]
+  end
+
+end

data/test/derby_migration_test.rb

@@ -8,14 +8,61 @@ class CreateDummies < ActiveRecord::Migration
     end
     add_index :dummies, :year, :unique => true
   end
-  
+
+end
+
+class ChangeColumn < ActiveRecord::Migration
+  def self.up
+    create_table :people, :id => false, :force => true do |t|
+      t.string :id, :limit => 22, :null => false
+      t.string :name, :null => false
+    end
+    change_column(:people, :name, :string, {:limit=>22})
+    execute("SELECT id FROM people WHERE id = 'some string'")
+  end
+
+  def self.down
+  end
+
+end
+
+class CreateIndex < ActiveRecord::Migration
+  def self.up
+    create_table :people, :id => false, :force => true do |t|
+      t.string :id, :limit => 22, :null => false
+      t.string :first_name, :null => false
+      t.string :last_name, :null => false
+      t.string :nickname, :null => false
+      t.string :long_name, :null => false
+      t.string :very_long_name, :null => false
+      t.string :extremely_long_name, :null => false
+    end
+
+    add_index(:people, [:first_name, :last_name, :nickname, :long_name, :very_long_name, :extremely_long_name], :unique => true)
+
+    remove_index(:people, [:first_name, :last_name, :nickname, :long_name, :very_long_name, :extremely_long_name])
+  end
+
+  def self.down
+  end
+
 end
 
-class DerbyQuotingTest < Test::Unit::TestCase
+class DerbyMigrationTest < Test::Unit::TestCase
   include FixtureSetup
 
   def test_create_table_column_quoting_vs_keywords
     CreateDummies.up
   end
-  
+
+  def test_migrate_change_column_for_non_standard_id
+    ChangeColumn.up
+    ChangeColumn.down
+  end
+
+  def test_migrate_create_index
+    CreateIndex.up
+    CreateIndex.down
+  end
+
 end