activerecord-jdbc-adapter 0.9.1 → 0.9.2

data/test/db/mysql.rb

@@ -1,4 +1,4 @@
-config = {
+MYSQL_CONFIG = {
   :username => 'blog',
   :password => '',
   :adapter  => 'mysql',
@@ -6,5 +6,5 @@ config = {
   :host     => 'localhost'
 }
 
-ActiveRecord::Base.establish_connection(config)
+ActiveRecord::Base.establish_connection(MYSQL_CONFIG)
 

data/test/db/postgres.rb

@@ -1,4 +1,4 @@
-config = { 
+POSTGRES_CONFIG = {
   :adapter => 'postgresql',
   :database => 'weblog_development',
   :host => 'localhost',
@@ -6,4 +6,4 @@ config = {
   :password => ''
 }
 
-ActiveRecord::Base.establish_connection(config)
+ActiveRecord::Base.establish_connection(POSTGRES_CONFIG)

data/test/helper.rb

@@ -0,0 +1,5 @@
+module Kernel
+  def find_executable?(name)
+    ENV['PATH'].split(File::PATH_SEPARATOR).detect {|p| File.executable?(File.join(p, name))}
+  end
+end

data/test/jdbc_adapter/jdbc_db2_test.rb

@@ -18,4 +18,9 @@ class JdbcSpec::DB2Test < Test::Unit::TestCase
     assert_equal %q{123.45}, @inst.quote("123.45", @column), "decimal columns should not have quotes"
   end
   
+  def test_primary_key_generation
+    @column.type = :primary_key
+    assert_equal 'int not null generated by default as identity (start with 1) primary key', @inst.modify_types({:string => {}, :integer => {}, :boolean => {}})[:primary_key]
+  end
+  
 end

data/test/jdbc_common.rb

@@ -14,8 +14,10 @@ require 'models/auto_id'
 require 'models/entry'
 require 'models/data_types'
 require 'models/add_not_null_column_to_table'
+require 'models/validates_uniqueness_of_string'
 require 'simple'
 require 'has_many_through'
+require 'helper'
 require 'test/unit'
 
 # Comment/uncomment to enable logging to be loaded for any of the database adapters

data/test/models/entry.rb

@@ -17,4 +17,7 @@ class CreateEntries < ActiveRecord::Migration
 end
 
 class Entry < ActiveRecord::Base
+  def to_param
+    "#{id}-#{title.gsub(/[^a-zA-Z0-9]/, '-')}"
+  end
 end

data/test/models/validates_uniqueness_of_string.rb

@@ -0,0 +1,19 @@
+class CreateValidatesUniquenessOf < ActiveRecord::Migration
+  def self.up
+    create_table "validates_uniqueness_of", :force => true do |t|
+      t.column :cs_string, :string
+      t.column :ci_string, :string
+      t.column :content, :text
+    end
+  end
+
+  def self.down
+    drop_table "validates_uniqueness_of"
+  end
+end
+
+class ValidatesUniquenessOfString < ActiveRecord::Base
+  self.set_table_name "validates_uniqueness_of"
+  validates_uniqueness_of :cs_string, :case_sensitive => true
+  validates_uniqueness_of :ci_string, :case_sensitive => false
+end

data/test/mysql_db_create_test.rb

@@ -0,0 +1,25 @@
+require 'abstract_db_create'
+require 'db/mysql'
+
+class MysqlDbCreateTest < Test::Unit::TestCase
+  include AbstractDbCreate
+
+  def db_config
+    MYSQL_CONFIG
+  end
+
+  if find_executable?("mysql")
+    def test_rake_db_create
+      Rake::Task["db:create"].invoke
+      output = nil
+      IO.popen("mysql -u #{MYSQL_CONFIG[:username]} --password=#{MYSQL_CONFIG[:password]}", "r+") do |mysql|
+        mysql << "show databases where `Database` = '#{@db_name}';"
+        mysql.close_write
+        assert mysql.read =~ /#{@db_name}/m
+      end
+    end
+  else
+    def test_skipped
+    end
+  end
+end

data/test/mysql_nonstandard_primary_key_test.rb

@@ -0,0 +1,42 @@
+require 'jdbc_common'
+require 'db/mysql'
+
+class Project < ActiveRecord::Migration
+  def self.up
+    create_table :project, :primary_key => "project_id" do |t|
+      t.string      :projectType, :limit => 31
+      t.boolean     :published
+      t.datetime    :created_date
+      t.text        :abstract, :title
+    end
+  end
+
+  def self.down
+    drop_table :project
+  end
+
+end
+
+class MysqlNonstandardPrimaryKeyTest < Test::Unit::TestCase
+
+  def setup
+    Project.up
+  end
+
+  def teardown
+    Project.down
+  end
+
+  def standard_dump
+    stream = StringIO.new
+    ActiveRecord::SchemaDumper.ignore_tables = []
+    ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
+    stream.string
+  end
+
+  def test_nonstandard_primary_key
+    output = standard_dump
+    assert_match %r(:primary_key => "project_id"), output, "non-standard primary key not preserved"
+  end
+
+end

data/test/mysql_simple_test.rb

@@ -19,6 +19,11 @@ class MysqlSimpleTest < Test::Unit::TestCase
     assert_equal "a'a", s2
     assert_equal "'a\\'a'", ActiveRecord::Base.connection.quote(s2)
   end
+
+  def test_table_name_quoting_with_dot
+    s = "weblog_development.posts"
+    assert_equal "`weblog_development`.`posts`", ActiveRecord::Base.connection.quote_table_name(s)
+  end
 end
 
 class MysqlHasManyThroughTest < Test::Unit::TestCase

data/test/postgres_db_create_test.rb

@@ -0,0 +1,21 @@
+require 'abstract_db_create'
+require 'db/postgres'
+
+class PostgresDbCreateTest < Test::Unit::TestCase
+  include AbstractDbCreate
+
+  def db_config
+    POSTGRES_CONFIG
+  end
+
+  if find_executable?("psql")
+    def test_rake_db_create
+      Rake::Task["db:create"].invoke
+      output = `psql -c '\\l'`
+      assert output =~ /#{@db_name}/m
+    end
+  else
+    def test_skipped
+    end
+  end
+end

data/test/postgres_nonseq_pkey_test.rb

@@ -0,0 +1,40 @@
+require 'rubygems'
+require 'active_record'
+require 'jdbc_common'
+require 'db/postgres'
+
+class CreateUrls < ActiveRecord::Migration
+  def self.up
+    create_table 'urls', :id => false do |t|
+      t.text :uhash, :null => false
+      t.text :url,  :null => false
+    end
+    execute "ALTER TABLE urls ADD PRIMARY KEY (uhash)"
+  end
+  def self.down
+    drop_table 'urls'
+  end
+end
+
+class Url < ActiveRecord::Base
+  set_primary_key :uhash
+  #Shouldn't be needed: set_sequence_name nil
+end
+
+class PostgresNonSeqPKey < Test::Unit::TestCase
+  def setup
+    CreateUrls.up
+  end
+
+  def teardown
+    CreateUrls.down
+  end
+
+  def test_create
+    url = Url.create! do |u|
+      u.uhash = 'uhash'
+      u.url = 'http://url'
+    end
+    assert_equal( 'uhash', url.uhash )
+  end
+end

data/test/simple.rb

@@ -10,6 +10,7 @@ module MigrationSetup
     DbTypeMigration.up
     CreateEntries.up
     CreateAutoIds.up
+    CreateValidatesUniquenessOf.up
 
     @connection = ActiveRecord::Base.connection
   end
@@ -18,6 +19,7 @@ module MigrationSetup
     DbTypeMigration.down
     CreateEntries.down
     CreateAutoIds.down
+    CreateValidatesUniquenessOf.down
     ActiveRecord::Base.clear_active_connections!
   end
 end
@@ -47,6 +49,12 @@ module SimpleTestMethods
     assert_equal 0, Entry.count
   end
 
+  def test_find_with_string_slug
+    new_entry = Entry.create(:title => "Blah")
+    entry = Entry.find(new_entry.to_param)
+    assert_equal new_entry.id, entry.id
+  end
+
   def test_insert_returns_id
     unless ActiveRecord::Base.connection.adapter_name =~ /oracle/i
       value = ActiveRecord::Base.connection.insert("INSERT INTO entries (title, content, rating) VALUES('insert_title', 'some content', 1)")
@@ -160,7 +168,7 @@ module SimpleTestMethods
     e = DbType.find(:first)
     assert_equal(true, e.sample_boolean)
   end
-  
+
   def test_integer
     # An unset boolean should default to nil
     e = DbType.find(:first)
@@ -294,6 +302,59 @@ module SimpleTestMethods
     AddNotNullColumnToTable.down
   end
 
+  def test_validates_uniqueness_of_strings_case_sensitive
+    # MySQL string cmps are case-insensitive by default, so skip this test
+    return if ActiveRecord::Base.connection.config[:adapter] =~ /mysql/
+
+    name_lower = ValidatesUniquenessOfString.new(:cs_string => "name", :ci_string => '1')
+    name_lower.save!
+
+    name_upper = ValidatesUniquenessOfString.new(:cs_string => "NAME", :ci_string => '2')
+    assert_nothing_raised do
+      name_upper.save!
+    end
+
+    name_lower_collision = ValidatesUniquenessOfString.new(:cs_string => "name", :ci_string => '3')
+    assert_raise ActiveRecord::RecordInvalid do
+      name_lower_collision.save!
+    end
+
+    name_upper_collision = ValidatesUniquenessOfString.new(:cs_string => "NAME", :ci_string => '4')
+    assert_raise ActiveRecord::RecordInvalid do
+      name_upper_collision.save!
+    end
+  end
+
+  def test_validates_uniqueness_of_strings_case_insensitive
+    name_lower = ValidatesUniquenessOfString.new(:cs_string => '1', :ci_string => "name")
+    name_lower.save!
+
+    name_upper = ValidatesUniquenessOfString.new(:cs_string => '2', :ci_string => "NAME")
+    assert_raise ActiveRecord::RecordInvalid do
+      name_upper.save!
+    end
+
+    name_lower_collision = ValidatesUniquenessOfString.new(:cs_string => '3', :ci_string => "name")
+    assert_raise ActiveRecord::RecordInvalid do
+      name_lower_collision.save!
+    end
+
+    alternate_name_upper = ValidatesUniquenessOfString.new(:cs_string => '4', :ci_string => "ALTERNATE_NAME")
+    assert_nothing_raised do
+      alternate_name_upper.save!
+    end
+
+    alternate_name_upper_collision = ValidatesUniquenessOfString.new(:cs_string => '5', :ci_string => "ALTERNATE_NAME")
+    assert_raise ActiveRecord::RecordInvalid do
+      alternate_name_upper_collision.save!
+    end
+
+    alternate_name_lower = ValidatesUniquenessOfString.new(:cs_string => '6', :ci_string => "alternate_name")
+    assert_raise ActiveRecord::RecordInvalid do
+      alternate_name_lower.save!
+    end
+  end
+
   class ChangeEntriesTable < ActiveRecord::Migration
     def self.up
       change_table :entries do |t|

data/test/sqlite3_simple_test.rb

@@ -1,10 +1,11 @@
 require 'jdbc_common'
 require 'db/sqlite3'
 require 'models/data_types'
+require 'models/validates_uniqueness_of_string'
 
 class SQLite3SimpleTest < Test::Unit::TestCase
   include SimpleTestMethods
-  
+
   def test_recreate_database
     assert @connection.tables.include?(Entry.table_name)
     db = @connection.database_name
@@ -12,27 +13,169 @@ class SQLite3SimpleTest < Test::Unit::TestCase
     assert (not @connection.tables.include? Entry.table_name)
     self.setup # avoid teardown complaining
   end
-  
+
   def test_execute_insert
     assert_equal 1, Entry.count
     id = @connection.execute "INSERT INTO entries (title, content) VALUES ('Execute Insert', 'This now works with SQLite3')"
     assert_equal Entry.last.id, id
     assert_equal 2, Entry.count
   end
-  
+
   def test_execute_update
     affected_rows = @connection.execute "UPDATE entries SET title = 'Execute Update' WHERE id = #{Entry.first.id}"
-    assert_equal 1, affected_rows    
+    assert_equal 1, affected_rows
     assert_equal 'Execute Update', Entry.first.title
   end
-  
+
   def test_columns
     cols = ActiveRecord::Base.connection.columns("entries")
     assert cols.find {|col| col.name == "title"}
   end
-  
+
+  def test_remove_column
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        add_column "entries", "test_remove_column", :string
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    assert cols.find {|col| col.name == "test_remove_column"}
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        remove_column "entries", "test_remove_column"
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    assert !cols.find {|col| col.name == "test_remove_column"}
+  end
+
+  def test_rename_column
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        rename_column "entries", "title", "name"
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    assert cols.find {|col| col.name == "name"}
+    assert !cols.find {|col| col.name == "title"}
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        rename_column "entries", "name", "title"
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    assert cols.find {|col| col.name == "title"}
+    assert !cols.find {|col| col.name == "name"}
+  end
+
+  def test_rename_column_preserves_content
+    post = Entry.find(:first)
+    assert_equal @title, post.title
+    assert_equal @content, post.content
+    assert_equal @rating, post.rating
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        rename_column "entries", "title", "name"
+      end
+    end
+
+    post = Entry.find(:first)
+    assert_equal @title, post.name
+    assert_equal @content, post.content
+    assert_equal @rating, post.rating
+  end
+
+  def test_rename_column_preserves_index
+    assert_equal(0, @connection.indexes(:entries).size)
+
+    index_name = "entries_index"
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        add_index "entries", "title", :name => index_name
+      end
+    end
+
+    indexes = @connection.indexes(:entries)
+    assert_equal(1, indexes.size)
+    assert_equal "entries", indexes.first.table.to_s
+    assert_equal index_name, indexes.first.name
+    assert !indexes.first.unique
+    assert_equal ["title"], indexes.first.columns
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        rename_column "entries", "title", "name"
+      end
+    end
+
+    indexes = @connection.indexes(:entries)
+    assert_equal(1, indexes.size)
+    assert_equal "entries", indexes.first.table.to_s
+    assert_equal index_name, indexes.first.name
+    assert !indexes.first.unique
+    assert_equal ["name"], indexes.first.columns
+  end
+
+  def test_change_column_default
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        add_column "entries", "test_change_column_default", :string, :default => "unchanged"
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    col = cols.find{|col| col.name == "test_change_column_default"}
+    assert col
+    assert_equal col.default, 'unchanged'
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        change_column_default "entries", "test_change_column_default", "changed"
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    col = cols.find{|col| col.name == "test_change_column_default"}
+    assert col
+    assert_equal col.default, 'changed'
+  end
+
+  def test_change_column
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        add_column "entries", "test_change_column", :string
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    col = cols.find{|col| col.name == "test_change_column"}
+    assert col
+    assert_equal col.type, :string
+
+    assert_nothing_raised do
+      ActiveRecord::Schema.define do
+        change_column "entries", "test_change_column", :integer
+      end
+    end
+
+    cols = ActiveRecord::Base.connection.columns("entries")
+    col = cols.find{|col| col.name == "test_change_column"}
+    assert col
+    assert_equal col.type, :integer
+  end
+
 end
-  
+
+# assert_raise ActiveRecord::RecordInvalid do
+
 class SQLite3HasManyThroughTest < Test::Unit::TestCase
   include HasManyThroughMethods
 end
@@ -42,7 +185,7 @@ if jruby?
 else
   JInteger = Fixnum
   class Fixnum
-    # Arbitrary value...we could pick 
+    # Arbitrary value...we could pick
     MAX_VALUE = 2
   end
 end
@@ -51,7 +194,7 @@ class SQLite3TypeConversionTest < Test::Unit::TestCase
   TEST_TIME = Time.at(1169964202)
   TEST_BINARY = "Some random binary data % \0 and then some"
   def setup
-    DbTypeMigration.up  
+    DbTypeMigration.up
     DbType.create(
       :sample_timestamp => TEST_TIME,
       :sample_datetime => TEST_TIME,
@@ -80,7 +223,7 @@ class SQLite3TypeConversionTest < Test::Unit::TestCase
     types = DbType.find(:first)
     assert_equal(3, DbType.columns_hash["sample_small_decimal"].precision)
   end
-  
+
   def test_binary
     types = DbType.find(:first)
     assert_equal(TEST_BINARY, types.sample_binary)