activerecord-instrumentation 0.6.0.jhemphill3 → 0.6.1.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95c186a845e1f54640ec23d41c6f4af63672c70a2b40eead66abd7dfdfa9a5d9
-  data.tar.gz: 5dbd6b7b69424ff53fe2aaaecd2c9980ea427f32ac85b69f779b6bd60fbfe1c5
+  metadata.gz: e0c5d0d44e18ee992c3f8458ab3e4a8f6fe3738ce47cbb553224aec647901113
+  data.tar.gz: 73152d2108ae460ee4c4795b1e3b50e4af567cc8292469b0c02ee7b7f251046b
 SHA512:
-  metadata.gz: 1542c660df6a46953df85ed993648afcf28b3a5195560176b528d7f03dd148ad404bbe53e732ea8ac4a0fa6f81cc471e89bb8931da42aa0c181ac93c819f8b36
-  data.tar.gz: bf4172f41056e08ef86bbcab7a6c56cd2d044d90f18ccd600ac59758ead73abf056283e7b2424771460b6a1ed6fd9a74d0d36ac790986629810d429167d259b6
+  metadata.gz: 51ba7e18ebd147dd0ea8f80c50f675f8655f29bb77b360b95f1d1b94685c7c9d00f00a1ca5083055e21d48a520a73e8ff6d1228ac19dfc9032c9ac995911bd2e
+  data.tar.gz: c108734ef121ad092f5fe24b7a477a287c6cabc57ca956f407547eddf77e13d5663d1174c8f77960cfb28889d2f1bd9c390900531edd19f51c1c85f070487e56

data/CHANGELOG.md

@@ -1,8 +1,11 @@
 Changelog
 =========
 
-## 0.6.0.jhemphill3 07/11/2022
-  * Fixed query tagging for empty queries
+## 0.6.1.pre 09/07/2022
+  * Splat hash when passing method expecting keyword args
+
+## 0.6.0 07/11/2022
+  * Improved pper address tag to reflect the current database when using the mysql adapter
 
 ## 0.5.2 01/24/2022
   * Fixed query tagging for empty queries

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    activerecord-instrumentation (0.6.0.jhemphill3)
+    activerecord-instrumentation (0.6.1.pre)
       activerecord
       opentracing (~> 0.5)
 

data/lib/active_record/open_tracing/processor.rb

@@ -54,7 +54,7 @@ module ActiveRecord
 
         if (exception = payload[:exception_object])
           span.set_tag("error", true)
-          span.log_kv(exception_metadata(exception))
+          span.log_kv(**exception_metadata(exception))
         end
 
         span.finish(end_time: finish)
@@ -73,14 +73,15 @@ module ActiveRecord
       end
 
       def tags_for_payload(payload)
+        db_config = connection_config(payload[:connection])
+
         {
           "component" => COMPONENT_NAME,
           "span.kind" => SPAN_KIND,
           "db.instance" => db_instance,
           "db.cached" => payload.fetch(:cached, false),
           "db.type" => DB_TYPE,
-          "peer.mysql_db_name" => mysql_db_name_tag(payload.fetch(:connection, nil)&.raw_connection),
-          "peer.address" => peer_address_tag
+          "peer.address" => peer_address_tag(db_config)
         }.merge(db_statement(payload))
       end
 
@@ -105,29 +106,36 @@ module ActiveRecord
         sanitizer ? sanitizer.sanitize(sql) : sql
       end
 
-      def mysql_db_name_tag(db_connection)
-        return db_connection.host if db_connection.respond_to?(:host)
-        return nil
-      end
-
-      def peer_address_tag
-        @peer_address_tag ||=
-          [
-            "#{connection_config.fetch(:adapter)}://",
-            connection_config[:username],
-            connection_config[:host] && "@#{connection_config[:host]}",
-            "/#{db_instance}"
-          ].join
+      def peer_address_tag(config)
+        @peer_address_tag ||= [
+          "#{config.fetch(:adapter)}://",
+          config[:username],
+          config[:host] && "@#{config[:host]}",
+          "/#{db_instance}"
+        ].join
       end
 
       def db_instance
         @db_instance ||= connection_config.fetch(:database)
       end
 
-      def connection_config
-        # Rails 6.2 will deprecate ActiveRecord::Base.connection_config
-        @connection_config ||=
-          ActiveRecord::Base.try(:connection_db_config)&.configuration_hash || ActiveRecord::Base.connection_config
+      # If a connection is passed in, pull the db config options hash from it.  This connection
+      # is likely to be attached to the query/query client.  Fall back to the application level
+      # config.  This change will show writer vs reader/replica dbs in spans when it is determined
+      # at the query level.
+      def connection_config(connection = nil)
+        unless defined? @connection_config
+          if connection.raw_connection && connection.raw_connection.respond_to?(:query_options)
+            # you have a mysql client
+            @connection_config = connection.raw_connection.query_options
+          else
+            # Rails 6.2 will deprecate ActiveRecord::Base.connection_config
+            @connection_config = ActiveRecord::Base.try(:connection_db_config)&.configuration_hash ||
+                                  ActiveRecord::Base.connection_config
+          end
+        end
+
+        @connection_config
       end
     end
   end

data/lib/active_record/open_tracing/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module OpenTracing
-    VERSION = "0.6.0.jhemphill3"
+    VERSION = "0.6.1.pre"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-instrumentation
 version: !ruby/object:Gem::Version
-  version: 0.6.0.jhemphill3
+  version: 0.6.1.pre
 platform: ruby
 authors:
 - SaleMove TechMovers
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-12 00:00:00.000000000 Z
+date: 2022-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -213,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.3.11
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: ActiveRecord OpenTracing intrumenter