activerecord-ignored_columns 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34cb084e3712cc29485d1fb9f450e69102409250
-  data.tar.gz: 4beb51ce466e565d1aad4360f12371017e929202
+  metadata.gz: 60079b7a4f640136599f6cefae3a7e387c5ccbfa
+  data.tar.gz: bef78372c460f1e85e83319532b02a4a97230442
 SHA512:
-  metadata.gz: c4d46280d55c2d82569c1429b3c4b60e2356be0456c84e241be003a03afb1e2de73745b81dbcded785ee3c9a3b660b6ad55f319d14713ab2088323cb174e1156
-  data.tar.gz: 99bb597554af13e82e8980e3f9e9034342b30d4ff29276e0740320efbd27aed2debdbdd5e74620afefae5036a6cecc7532f62e4588d26175619dd1e84cdb42e4
+  metadata.gz: e5e20c3edd7c0c43beccb528038750de607167cfe11176574521ad82be0f2c7a3606d37c308b0c867560a856a818ff9bfe5f5aef29a3511ff23f14c3e0cda93c
+  data.tar.gz: 1a3dfe98983acb3cac9ef4cdf3a9b7c40441bd9fff7b5c78183590cd61796b28a942eae2e47a5cc9bad28238a703e29b98585e2096a30147478cf4d5276b61bf

data/CHANGELOG.md

@@ -0,0 +1,16 @@
+# CHANGELOG
+
+## [0.2.0](https://github.com/yasaichi/activerecord-ignored_columns/releases/tag/v0.2.0) (July 6, 2019)
+
+### Enhancements
+
+- [Add support of Rails 4.0](https://github.com/yasaichi/activerecord-ignored_columns/pull/2)
+
+### Breaking changes
+
+- Rename `Activerecord` to `ActiveRecord`
+- Remove an unused Rake task
+
+## [0.1.0](https://github.com/yasaichi/activerecord-ignored_columns/releases/tag/v0.1.0) (July 5, 2019)
+
+- The initial release

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2019 yasaichi
+Copyright 2019 Yuichi Goto
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,10 +1,17 @@
-# Activerecord::IgnoredColumns
-Short description and motivation.
+# activerecord-ignored_columns
 
-## Usage
-How to use my plugin.
+[![Gem Version](https://badge.fury.io/rb/activerecord-ignored_columns.svg)](http://badge.fury.io/rb/activerecord-ignored_columns)
+[![Build Status](https://travis-ci.org/yasaichi/activerecord-ignored_columns.svg?branch=master)](https://travis-ci.org/yasaichi/activerecord-ignored_columns)
+[![Code Climate](https://codeclimate.com/github/yasaichi/activerecord-ignored_columns/badges/gpa.svg)](https://codeclimate.com/github/yasaichi/activerecord-ignored_columns)
+[![Test Coverage](https://codeclimate.com/github/yasaichi/activerecord-ignored_columns/badges/coverage.svg)](https://codeclimate.com/github/yasaichi/activerecord-ignored_columns/coverage)
+
+`activerecord-ignored_columns` is a backport of `ActiveRecord::Base.ignored_columns` (introduced in
+Rails 5) into Rails 4.  
+You can also use this gem for Rails 5.0 because it fixes one serious bug in the version (see
+[PR #30980](https://github.com/rails/rails/pull/30980)).
 
 ## Installation
+
 Add this line to your application's Gemfile:
 
 ```ruby
@@ -12,17 +19,33 @@ gem 'activerecord-ignored_columns'
 ```
 
 And then execute:
+
 ```bash
 $ bundle
 ```
 
-Or install it yourself as:
-```bash
-$ gem install activerecord-ignored_columns
+## Usage
+
+Set columns names that a model should ignore as follows:
+
+```ruby
+class UserProfile < ActiveRecord::Base
+  self.ignored_columns = %i(full_name)
+end
 ```
 
+Ignored columns won't have attribute accessors defined, and won't be referenced in SQL queries.
+
 ## Contributing
-Contribution directions go here.
+
+You should follow the steps below.
+
+1. [Fork the repository](https://help.github.com/articles/fork-a-repo/)
+2. Create a feature branch: `git checkout -b add-new-feature`
+3. Commit your changes: `git commit -am 'Add new feature'`
+4. Push the branch: `git push origin add-new-feature`
+5. [Send us a pull request](https://help.github.com/articles/about-pull-requests/)
 
 ## License
+
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

data/Rakefile

@@ -10,7 +10,7 @@ require "rdoc/task"
 
 RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = "rdoc"
-  rdoc.title    = "Activerecord::IgnoredColumns"
+  rdoc.title    = "ActiveRecord::IgnoredColumns"
   rdoc.options << "--line-numbers"
   rdoc.rdoc_files.include("README.md")
   rdoc.rdoc_files.include("lib/**/*.rb")

data/lib/activerecord/ignored_columns/model_schema.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module Activerecord
+module ActiveRecord
   module IgnoredColumns
     module ModelSchema
       def self.included(active_record_base)
@@ -11,6 +11,7 @@ module Activerecord
       end
 
       module ClassMethods
+        # Override
         def columns
           @columns ||= super.reject { |column| ignored_columns.include?(column.name) }
         end

data/lib/activerecord/ignored_columns/query_methods.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module Activerecord
+module ActiveRecord
   module IgnoredColumns
     module QueryMethods
       def self.included(active_record_relation)
@@ -8,13 +8,20 @@ module Activerecord
       end
 
       module PrependMethods
-        private def build_select(arel)
-          return super if select_values.any? || !klass.ignored_columns.any?
+        # Override
+        private def build_select(arel, selects = [])
+          if !selects.empty? || select_values.any? || !klass.ignored_columns.any?
+            return former_build_select_implementation? ? super : super(arel)
+          end
 
           arel.project(*klass.column_names.map { |name|
-            table[attribute_alias?(name) ? attribute_alias(name) : name]
+            table[klass.attribute_aliases[name] || name]
           })
         end
+
+        private def former_build_select_implementation?
+          @former_build_select_implementation ||= method(:build_select).super_method.arity == 2
+        end
       end
     end
   end

data/lib/activerecord/ignored_columns/railtie.rb

@@ -5,20 +5,20 @@ require "rails/railtie"
 require_relative "model_schema"
 require_relative "query_methods"
 
-module Activerecord
+module ActiveRecord
   module IgnoredColumns
     class Railtie < ::Rails::Railtie
       initializer "active_record.ignored_columns" do
         ::ActiveSupport.on_load(:active_record) do
-          rails_version = Rails.respond_to?(:gem_version) ?
-            Rails.gem_version : Gem::Version.create(Rails.version)
+          rails_version = ::Rails.respond_to?(:gem_version) ?
+            ::Rails.gem_version : ::Gem::Version.create(::Rails.version)
 
-          if rails_version < Gem::Version.create("5")
-            include ::Activerecord::IgnoredColumns::ModelSchema
+          if rails_version < ::Gem::Version.create("5")
+            include ::ActiveRecord::IgnoredColumns::ModelSchema
           end
 
-          if rails_version < Gem::Version.create("5.1")
-            ::ActiveRecord::Relation.include(::Activerecord::IgnoredColumns::QueryMethods)
+          if rails_version < ::Gem::Version.create("5.1")
+            ::ActiveRecord::Relation.include(::ActiveRecord::IgnoredColumns::QueryMethods)
           end
         end
       end

data/lib/activerecord/ignored_columns/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-module Activerecord
+module ActiveRecord
   module IgnoredColumns
-    VERSION = "0.1.0"
+    VERSION = "0.2.0".freeze
   end
 end

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-ignored_columns
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
-- yasaichi
+- Yuichi Goto
 autorequire: 
 bindir: bin
 cert_chain: []
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.1'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.1'
@@ -100,6 +100,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -114,13 +128,14 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.4.0
-description: Backport of ActiveRecord::Base.ignored_columns to Rails 4.1 ~ 5.0
+description: Backport of ActiveRecord::Base.ignored_columns into Rails 4 and 5.0
 email:
 - yasaichi@users.noreply.github.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
 - MIT-LICENSE
 - README.md
 - Rakefile
@@ -129,7 +144,6 @@ files:
 - lib/activerecord/ignored_columns/query_methods.rb
 - lib/activerecord/ignored_columns/railtie.rb
 - lib/activerecord/ignored_columns/version.rb
-- lib/tasks/activerecord/ignored_columns_tasks.rake
 homepage: https://github.com/yasaichi/activerecord-ignored_columns
 licenses:
 - MIT

data/lib/tasks/activerecord/ignored_columns_tasks.rake

@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-# desc "Explaining what the task does"
-# task :activerecord_ignored_columns do
-#   # Task goes here
-# end