activerecord-duplicate 0.6.0 → 0.6.1

data/CHANGELOG.md

@@ -1,6 +1,14 @@
-# 0.6.0 (April 24, 2012)
+## 0.6.1 (April 25, 2012)
+* `attr_duplicatable` works more like `attr_accessible`, e.g it allows multiple calls and respects whitelisted attributes from the parent STI class. Should fix #1.
 
-* Associations must be declared explicit as duplicatable as well, e.g. `belongs_to :posts; attr_duplicatable :text, :posts`.
+## 0.6.0 (April 24, 2012)
+
+* Associations must be declared explicit as duplicatable as well, e.g:
+  ```ruby
+  belongs_to :posts
+  
+  attr_duplicatable :text, :posts
+  ```
 
 * Without specifying `attr_duplicatable`, all attributes (except the primary-key) and associations will be duplicated automatically.
   This allows you to skip the `attr_duplicatable` declarations completely, if you don't have special requirements.

data/README.md

@@ -1,4 +1,4 @@
-## activerecord-duplicate [![Build Status](https://secure.travis-ci.org/haihappen/activerecord-duplicate.png)](http://travis-ci.org/haihappen/activerecord-duplicate)
+# activerecord-duplicate [![Build Status](https://secure.travis-ci.org/haihappen/activerecord-duplicate.png)](http://travis-ci.org/haihappen/activerecord-duplicate)
 
 Duplicating ActiveRecords is easy again. All you have to do:
 

data/activerecord-duplicate.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = 'activerecord-duplicate'
-  gem.version       = '0.6.0'
+  gem.version       = '0.6.1'
   gem.authors       = 'Mario Uher'
   gem.email         = 'uher.mario@gmail.com'
   gem.description   = gem.summary = 'Duplicating ActiveRecords is easy again.'

data/lib/activerecord-duplicate/duplicate.rb

@@ -67,7 +67,8 @@ module ActiveRecord::Duplicate
 
   module ClassMethods
     def attr_duplicatable(*attributes)
-      self._duplicatable_attributes = attributes.map(&:to_sym) if attributes.present?
+      self._duplicatable_attributes ||= []
+      self._duplicatable_attributes = _duplicatable_attributes | attributes.map(&:to_sym) if attributes.present?
       self._duplicatable_attributes
     end
 

data/spec/acts_as_duplicator_spec.rb

@@ -23,6 +23,24 @@ describe ActiveRecord::Duplicate do
       
       klass.attr_duplicatable.must_equal([:created_at, :updated_at])
     end
+
+
+    it 'allows multiple calls' do
+      klass.attr_duplicatable(:created_at)
+      klass.attr_duplicatable(:updated_at)
+      
+      klass.attr_duplicatable.must_equal([:created_at, :updated_at])
+    end
+
+
+    it '' do
+      klass.attr_duplicatable(:created_at)
+      
+      sti_klass = Class.new(klass)
+      sti_klass.attr_duplicatable(:updated_at)
+      
+      sti_klass.attr_duplicatable.must_equal([:created_at, :updated_at])
+    end
   end
 
 

data/spec/integration_spec.rb

@@ -7,9 +7,11 @@ describe 'Integration' do
       
       create_table :posts do |t|
         t.belongs_to :blog
+        t.string     :type
         t.string     :title
         t.text       :content
         t.boolean    :is_copyrighted
+        t.string     :url
         t.timestamp  :published_at
       end
       
@@ -40,9 +42,17 @@ describe 'Integration' do
       has_many :comments
       has_many :ratings, as: :parent
       
-      attr_duplicatable :title, :content, :blog, :ratings
+      attr_duplicatable :title, :blog, :ratings
       
       validates :title, presence: true, uniqueness: true
+      
+      class Video < Post
+        attr_duplicatable :url
+      end
+      
+      class Text < Post
+        attr_duplicatable :content
+      end
     end
 
     class Comment < ActiveRecord::Base
@@ -90,6 +100,21 @@ describe 'Integration' do
     end
 
 
+    it 'works with STI classes too' do
+      blog.posts << Post::Video.new(title: 'My Video Post', url: 'http://youtube.com')
+      blog.posts << Post::Text.new(title: 'My Text Post', content: 'text')
+      
+      Post.attr_duplicatable.must_equal([:title, :blog, :ratings])
+      Post::Video.attr_duplicatable.must_equal([:title, :blog, :ratings, :url])
+      Post::Text.attr_duplicatable.must_equal([:title, :blog, :ratings, :content])
+      
+      subject.save!
+      
+      Blog.count.must_equal(2)
+      Post.count.must_equal(4)
+    end
+
+
     it 'sets blog association' do
       %w[Sample Blog Post].each do |title|
         post = blog.posts.create!(title: title)
@@ -123,12 +148,11 @@ describe 'Integration' do
 
 
     it 'ignores posts published_at timestamp' do
-      post = blog.posts.create!(title: 'Post', content: 'Lorem', published_at: Time.now)
+      post = blog.posts.create!(title: 'Post', published_at: Time.now)
       rating = post.ratings.create!(value: 5)
       
       post = subject.posts.first
       post.wont_be_nil
-      post.content.must_equal('Lorem')
       post.published_at.must_be_nil
       
       subject.save!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-duplicate
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-24 00:00:00.000000000 Z
+date: 2012-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70185001321060 !ruby/object:Gem::Requirement
+  requirement: &70166658693380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70185001321060
+  version_requirements: *70166658693380
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &70185001320660 !ruby/object:Gem::Requirement
+  requirement: &70166658692980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70185001320660
+  version_requirements: *70166658692980
 - !ruby/object:Gem::Dependency
   name: purdytest
-  requirement: &70185001369300 !ruby/object:Gem::Requirement
+  requirement: &70166658692520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70185001369300
+  version_requirements: *70166658692520
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70185001368800 !ruby/object:Gem::Requirement
+  requirement: &70166658692020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *70185001368800
+  version_requirements: *70166658692020
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70185001368380 !ruby/object:Gem::Requirement
+  requirement: &70166658691600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70185001368380
+  version_requirements: *70166658691600
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &70185001367920 !ruby/object:Gem::Requirement
+  requirement: &70166658691140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70185001367920
+  version_requirements: *70166658691140
 description: Duplicating ActiveRecords is easy again.
 email: uher.mario@gmail.com
 executables: []