activerecord-deprecated_finders 1.0.0 → 1.0.1

data/lib/active_record/deprecated_finders/collection_proxy.rb

@@ -6,7 +6,7 @@ module ActiveRecord
           match = DynamicMatchers::Method.match(klass, method)
           sanitized_method = match.class.prefix + match.class.suffix if match
 
-          if match && self.respond_to?(sanitized_method)
+          if match && self.respond_to?(sanitized_method) && proxy_association.reflection.options[:through].present?
             self.send(sanitized_method, Hash[match.attribute_names.zip(args)])
 
           elsif match && match.is_a?(DynamicMatchers::Instantiator)

data/lib/active_record/deprecated_finders/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module DeprecatedFinders
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/test/associations_test.rb

@@ -5,6 +5,7 @@ describe 'associations' do
     @klass = Class.new(ActiveRecord::Base)
     def @klass.name; 'Post'; end
     @klass.table_name = 'posts'
+    Appointment.delete_all
   end
 
   it 'find_or_create_by on has_many through should work' do
@@ -15,6 +16,14 @@ describe 'associations' do
     assert_equal 1, Appointment.count
   end
 
+  it 'find_or_create_by on has_many should work' do
+    physician = Physician.create!
+    ActiveSupport::Deprecation.silence do
+      appointment = physician.appointments.find_or_create_by_status(status: 'active', week_day: 'sunday')
+      assert_equal appointment, physician.appointments.find_or_create_by_status(status: 'active', week_day: 'sunday')
+    end
+  end
+
   it 'translates hash scope options into scopes' do
     assert_deprecated do
       @klass.has_many :comments, readonly: 'a', order: 'b', limit: 'c', group: 'd', having: 'e',

data/test/helper.rb

@@ -21,6 +21,8 @@ ActiveRecord::Schema.define do
   create_table :appointments do |t|
     t.integer :physician_id
     t.integer :patient_id
+    t.string :week_day
+    t.string :status
   end
 
   create_table :physicians do |t|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-deprecated_finders
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors: