activerecord-deprecated_finders 0.0.1

data/test/finder_options_test.rb

@@ -0,0 +1,86 @@
+require 'helper'
+
+describe 'apply_finder_options' do
+  before do
+    @deprecation_behavior = ActiveSupport::Deprecation.behavior
+    ActiveSupport::Deprecation.behavior = :silence
+  end
+
+  after do
+    ActiveSupport::Deprecation.behavior = @deprecation_behavior
+  end
+
+  it 'is deprecated' do
+    assert_deprecated { Post.scoped.apply_finder_options(:conditions => 'foo') }
+  end
+
+  it 'supports :conditions' do
+    scope = Post.scoped.apply_finder_options(:conditions => 'foo')
+    scope.where_values.must_equal ['foo']
+  end
+
+  it 'supports :include' do
+    scope = Post.scoped.apply_finder_options(:include => :foo)
+    scope.includes_values.must_equal [:foo]
+  end
+
+  it 'supports :joins' do
+    scope = Post.scoped.apply_finder_options(:joins => :foo)
+    scope.joins_values.must_equal [:foo]
+  end
+
+  it 'supports :limit' do
+    scope = Post.scoped.apply_finder_options(:limit => 5)
+    scope.limit_value.must_equal 5
+  end
+
+  it 'supports :offset' do
+    scope = Post.scoped.apply_finder_options(:offset => 5)
+    scope.offset_value.must_equal 5
+  end
+
+  it 'supports :extend' do
+    mod   = Module.new
+    scope = Post.scoped.apply_finder_options(:extend => mod)
+    scope.extensions.must_include mod
+  end
+
+  it "does not support :references (as it's new in 4.0)" do
+    lambda { Post.scoped.apply_finder_options(references: :foo) }.must_raise ArgumentError
+  end
+
+  it 'supports :order' do
+    scope = Post.scoped.apply_finder_options(:order => :foo)
+    scope.order_values.must_equal [:foo]
+  end
+
+  it 'supports :select' do
+    scope = Post.scoped.apply_finder_options(:select => :foo)
+    scope.select_values.must_equal [:foo]
+  end
+
+  it 'supports :readonly' do
+    scope = Post.scoped.apply_finder_options(:readonly => :foo)
+    scope.readonly_value.must_equal :foo
+  end
+
+  it 'supports :group' do
+    scope = Post.scoped.apply_finder_options(:group => :foo)
+    scope.group_values.must_equal [:foo]
+  end
+
+  it 'supports :having' do
+    scope = Post.scoped.apply_finder_options(:having => :foo)
+    scope.having_values.must_equal [:foo]
+  end
+
+  it 'supports :from' do
+    scope = Post.scoped.apply_finder_options(:from => :foo)
+    scope.from_value.must_equal [:foo, nil]
+  end
+
+  it 'supports :lock' do
+    scope = Post.scoped.apply_finder_options(:lock => true)
+    scope.lock_value.must_equal true
+  end
+end

data/test/finder_test.rb

@@ -0,0 +1,69 @@
+require 'helper'
+
+describe 'finders' do
+  before do
+    @posts = 3.times.map { |i| Post.create id: i + 1 }
+  end
+
+  after do
+    Post.delete_all
+  end
+
+  it 'supports find(:all) with no options' do
+    assert_deprecated { Post.find(:all) }.must_equal @posts
+  end
+
+  it 'supports find(:all) with options' do
+    assert_deprecated { Post.find(:all, conditions: 'id >= 2') }.must_equal [@posts[1], @posts[2]]
+  end
+
+  it 'supports all with options' do
+    assert_deprecated { Post.all(conditions: 'id >= 2') }.must_equal [@posts[1], @posts[2]]
+  end
+
+  it 'returns an array from all when there are options' do
+    posts = ActiveSupport::Deprecation.silence { Post.all(conditions: 'id >= 2') }
+    posts.class.must_equal Array
+  end
+
+  it 'returns a relation from all when there are no options' do
+    posts = Post.all
+    posts.is_a?(ActiveRecord::Relation).must_equal true
+  end
+
+  it 'deprecates #all on a relation' do
+    relation = Post.where('id >= 2')
+    assert_deprecated { relation.all }.must_equal [@posts[1], @posts[2]]
+  end
+
+  it 'supports find(:first) with no options' do
+    assert_deprecated { Post.order(:id).find(:first) }.must_equal @posts.first
+  end
+
+  it 'supports find(:first) with options' do
+    assert_deprecated { Post.order(:id).find(:first, conditions: 'id >= 2') }.must_equal @posts[1]
+  end
+
+  it 'supports first with options' do
+    assert_deprecated { Post.order(:id).first(conditions: 'id >= 2') }.must_equal @posts[1]
+  end
+
+  it 'supports find(:last) with no options' do
+    assert_deprecated { Post.order(:id).find(:last) }.must_equal @posts.last
+  end
+
+  it 'supports find(:last) with options' do
+    assert_deprecated { Post.order(:id).find(:last, conditions: 'id <= 2') }.must_equal @posts[1]
+  end
+
+  it 'supports last with options' do
+    assert_deprecated { Post.order(:id).last(conditions: 'id <= 2') }.must_equal @posts[1]
+  end
+
+  it 'support find(1) etc with options' do
+    assert_deprecated do
+      Post.find(1, conditions: '1=1').must_equal Post.find(1)
+      lambda { Post.find(1, conditions: '0=1') }.must_raise(ActiveRecord::RecordNotFound)
+    end
+  end
+end

data/test/helper.rb

@@ -0,0 +1,37 @@
+require 'bundler/setup'
+require 'minitest/spec'
+require 'minitest/autorun'
+require 'active_record'
+require 'active_record/deprecated_finders'
+
+ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
+
+ActiveRecord::Schema.verbose = false
+ActiveRecord::Schema.define do
+  create_table :posts do |t|
+    t.string :title
+    t.string :category
+  end
+
+  create_table :comments do |t|
+    t.string :title
+    t.references :post
+  end
+end
+
+class Post < ActiveRecord::Base
+  has_many :comments
+end
+
+class Comment < ActiveRecord::Base
+  def self.lol
+    "lol"
+  end
+end
+
+require 'active_support/testing/deprecation'
+ActiveSupport::Deprecation.debug = true
+
+class MiniTest::Spec
+  include ActiveSupport::Testing::Deprecation
+end

data/test/scope_test.rb

@@ -0,0 +1,17 @@
+require 'helper'
+
+describe 'scope' do
+  before do
+    @klass = Class.new(ActiveRecord::Base)
+  end
+
+  it 'supports a finder hash' do
+    assert_deprecated { @klass.scope :foo, conditions: :foo }
+    @klass.foo.where_values.must_equal [:foo]
+  end
+
+  it 'supports a finder hash inside a callable' do
+    @klass.scope :foo, ->(v) { { conditions: v } }
+    assert_deprecated { @klass.foo(:bar) }.where_values.must_equal [:bar]
+  end
+end

data/test/scoped_test.rb

@@ -0,0 +1,20 @@
+require 'helper'
+
+describe 'scoped' do
+  it 'accepts a deprecated conditions option' do
+    assert_deprecated { Post.scoped(conditions: :foo) }.where_values.must_equal [:foo]
+  end
+
+  it 'accepts a deprecated include option' do
+    assert_deprecated { Post.scoped(include: :foo) }.includes_values.must_equal [:foo]
+  end
+
+  it 'accepts a deprecated extend option' do
+    mod = Module.new
+    assert_deprecated { Post.scoped(extend: mod) }.extensions.must_equal [mod]
+  end
+
+  it 'is deprecated' do
+    assert_deprecated { Post.scoped }
+  end
+end

data/test/update_all_test.rb

@@ -0,0 +1,24 @@
+require 'helper'
+
+describe 'update_all' do
+  after do
+    Post.destroy_all
+  end
+
+  it 'supports conditions' do
+    foo = Post.create title: 'foo'
+    bar = Post.create title: 'bar'
+
+    assert_deprecated { Post.update_all({ title: 'omg' }, title: 'foo') }
+
+    foo.reload.title.must_equal 'omg'
+    bar.reload.title.must_equal 'bar'
+  end
+
+  it 'supports limit and order' do
+    posts = 3.times.map { Post.create }
+    assert_deprecated { Post.update_all({ title: 'omg' }, nil, limit: 2, order: :id) }
+
+    posts.each(&:reload).map(&:title).must_equal ['omg', 'omg', nil]
+  end
+end

data/test/with_scope_test.rb

@@ -0,0 +1,36 @@
+require 'helper'
+
+describe 'with_scope' do
+  before do
+    Post.create(id: 1, title: 'foo')
+    Post.create(id: 2, title: 'bar')
+  end
+
+  after do
+    Post.delete_all
+  end
+
+  it 'applies a scoping' do
+    assert_deprecated do
+      Post.with_scope(find: { conditions: { title: 'foo' } }) do
+        assert_equal [1], Post.all.map(&:id)
+      end
+    end
+  end
+
+  it 'applies an exclusive scoping' do
+    ActiveSupport::Deprecation.silence do
+      Post.with_scope(find: { conditions: { title: 'foo' } }) do
+        Post.send(:with_exclusive_scope, find: { conditions: { title: 'bar' } }) do
+          assert_equal [2], Post.all.map(&:id)
+        end
+      end
+    end
+  end
+
+  it 'gives a deprecation for #with_exclusive_scope' do
+    assert_deprecated do
+      Post.send(:with_exclusive_scope) {}
+    end
+  end
+end

metadata

@@ -0,0 +1,131 @@
+--- !ruby/object:Gem::Specification
+name: activerecord-deprecated_finders
+version: !ruby/object:Gem::Version
+  version: 0.0.1
+  prerelease: 
+platform: ruby
+authors:
+- Jon Leighton
+autorequire: 
+bindir: bin
+cert_chain: []
+date: 2012-12-26 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 4.0.0.beta
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 4.0.0.beta
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+description: This gem contains deprecated finder APIs extracted from Active Record.
+email:
+- j@jonathanleighton.com
+executables: []
+extensions: []
+extra_rdoc_files: []
+files:
+- .gitignore
+- .travis.yml
+- Gemfile
+- LICENSE
+- README.md
+- Rakefile
+- activerecord-deprecated_finders.gemspec
+- lib/active_record/deprecated_finders.rb
+- lib/active_record/deprecated_finders/association_builder.rb
+- lib/active_record/deprecated_finders/base.rb
+- lib/active_record/deprecated_finders/collection_proxy.rb
+- lib/active_record/deprecated_finders/dynamic_matchers.rb
+- lib/active_record/deprecated_finders/relation.rb
+- lib/active_record/deprecated_finders/version.rb
+- test/associations_test.rb
+- test/calculate_test.rb
+- test/default_scope_test.rb
+- test/dynamic_methods_test.rb
+- test/find_in_batches_test.rb
+- test/finder_options_test.rb
+- test/finder_test.rb
+- test/helper.rb
+- test/scope_test.rb
+- test/scoped_test.rb
+- test/update_all_test.rb
+- test/with_scope_test.rb
+homepage: https://github.com/rails/activerecord-deprecated_finders
+licenses: []
+post_install_message: 
+rdoc_options: []
+require_paths:
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements: []
+rubyforge_project: 
+rubygems_version: 1.8.23
+signing_key: 
+specification_version: 3
+summary: This gem contains deprecated finder APIs extracted from Active Record.
+test_files:
+- test/associations_test.rb
+- test/calculate_test.rb
+- test/default_scope_test.rb
+- test/dynamic_methods_test.rb
+- test/find_in_batches_test.rb
+- test/finder_options_test.rb
+- test/finder_test.rb
+- test/helper.rb
+- test/scope_test.rb
+- test/scoped_test.rb
+- test/update_all_test.rb
+- test/with_scope_test.rb