activerecord-delay_touching 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb3ab2ee2253bda6f6205c8f7c29f36a916b232d
-  data.tar.gz: 252006c75ba9b36df90da8cfe805cd58716d278b
+  metadata.gz: 81d58f8a4a53021f8034c2da68790d7648b2b4f3
+  data.tar.gz: 2d975e4e5c14ee8baecaaf762aaa8a8ebb003bef
 SHA512:
-  metadata.gz: e0582f5ab6cecfbbe5ab2e28411154b5b5d7ddf8eb851dd3fe68e3a712bd17915e4931c59edaca46bd15e88e262dadb0d6689c743c8a507340f4274fc2fe8ef6
-  data.tar.gz: ea148565acd6d3d2138b748e44589b828df5d2168f8a71c8b2f17216af0d3ac1b1ea9db51bce193a03ee22afee4a1b15d0103f95f8da57f8361702b421408b0b
+  metadata.gz: 46209cc3478f9f81e932644e79364bb2ff012d536cabc2e3927cca61c74a641b0b9fc94e6522574c2c0c21281e1a0fda4df0be6db40c0f58b001d73c7ead5008
+  data.tar.gz: 89654bba87280ab7976c0d464d43f4a9e0760643ce614532c12910b4e9b9602b38635815251bde5877bbd24a2c95742ca13ffac0b55bb7461a1786c0e5c077a7

data/README.md

@@ -1,5 +1,7 @@
 # Activerecord::DelayTouching
 
+> **Note:** this version supports ActiveRecord 3.2 through 4.1 only. For ActiveRecord 4.2+, please see the Master branch.
+
 Batch up your ActiveRecord "touch" operations for better performance.
 
 When you want to invalidate a cache in Rails, you use `touch: true`. But when
@@ -13,7 +15,7 @@ round-trips as possible. Instead of N touches you get 1 touch.
 
 Add this line to your application's Gemfile:
 
-    gem 'activerecord-delay_touching'
+    gem 'activerecord-delay_touching', '~> 0.0.3'
 
 And then execute:
 
@@ -21,7 +23,7 @@ And then execute:
 
 Or install it yourself:
 
-    $ gem install activerecord-delay_touching
+    $ gem install activerecord-delay_touching -v 0.0.3
 
 ## Usage
 

data/lib/activerecord/delay_touching.rb

@@ -86,6 +86,7 @@ module ActiveRecord
           column = column.to_s
           changes[column] = current_time
           records.each do |record|
+            next if record.destroyed?
             record.instance_eval do
               write_attribute column, current_time
               @changed_attributes.except!(*changes.keys)

data/lib/activerecord/delay_touching/version.rb

@@ -1,5 +1,5 @@
 module Activerecord
   module DelayTouching
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/activerecord/delay_touching_spec.rb

@@ -151,6 +151,28 @@ describe Activerecord::DelayTouching do
     end
   end
 
+  context 'dependent deletes' do
+
+    let(:post) { Post.create! }
+    let(:user) { User.create! }
+    let(:comment) { Comment.create! }
+
+    before do
+      post.comments << comment
+      user.comments << comment
+    end
+
+    it 'does not attempt to touch deleted records' do
+      expect do
+        ActiveRecord::Base.delay_touching do
+          post.destroy
+        end
+      end.not_to raise_error
+      expect(post.destroyed?).to eq true
+    end
+
+  end
+
   def expect_updates(tables)
     expected_sql = tables.map do |entry|
       if entry.kind_of?(Hash)

data/spec/support/models.rb

@@ -5,3 +5,16 @@ end
 class Pet < ActiveRecord::Base
   belongs_to :person, touch: true, inverse_of: :pets
 end
+
+class Post < ActiveRecord::Base
+  has_many :comments, dependent: :destroy
+end
+
+class User < ActiveRecord::Base
+  has_many :comments, dependent: :destroy
+end
+
+class Comment < ActiveRecord::Base
+  belongs_to :post, touch: true
+  belongs_to :user, touch: true
+end

data/spec/support/schema.rb

@@ -16,4 +16,18 @@ ActiveRecord::Schema.define do
     t.timestamps
   end
 
+  create_table :posts, force: true do |t|
+    t.timestamps null: false
+  end
+
+  create_table :users, force: true do |t|
+    t.timestamps null: false
+  end
+
+  create_table :comments, force: true do |t|
+    t.integer :post_id
+    t.integer :user_id
+    t.timestamps null: false
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-delay_touching
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Brian Morearty
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-05 00:00:00.000000000 Z
+date: 2015-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -186,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Batch up your ActiveRecord "touch" operations for better performance.