activerecord-databasevalidations 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a7d5be15344fd9bf8b1c3acfca03f3ac9e0c3ca97b18360b120b291b6a6b4d1
-  data.tar.gz: 6c87a9818c8bbf67a5ff8af94a078f6b93a53f46d7492c046489bcfd0668d29b
+  metadata.gz: 19a316a681935a58dfcc28e3b1f61533b939f238c33b5e59168815b659fd46e9
+  data.tar.gz: 652292e8f015dd4a68ed58e3bda8875dc9cd692a073f62690dc25dacb6bd27b5
 SHA512:
-  metadata.gz: 77bbf9e2ac7a0876889abb7c338dfc06934740bac6ef4e13aab64e92a4184552bce96729196e0e9f548ec7a1cc3ab14b83c82d57064acee5abc8a7f88bf1f19e
-  data.tar.gz: da0d21684e48d7f3569014881bf87ea1ddc4fd3872e970f2a5b079f8b95f2dc780a922327e694b8ad7f4f7befb8e10c8ee2faa394835025df1c128a41a8f7062
+  metadata.gz: 1a3e18729c91ed650c349a68daf2b2187453d8516fac073ca6f518469d775c9180e70e9f775236e8ca2ab5b2e4395ba7a9d8f2d14c0f5ffd142b4fad7a7713f9
+  data.tar.gz: '0659a85b324c4e939b7321e62c651c27a51f61f32fa42dc2f65abdb0c21f2db18f69b078c39864d632125290d144bec6fc5632db736a7c11d394680a4f17d59a'

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Unreleased
 
+# 1.0.3 (Mar 6, 2025)
+
+* Disable string truncation helpers for non-MySQL adapters.
+
 # 1.0.2 (Feb 5, 2025)
 
 * Disable size + range validations for non-MySQL adapters.

data/lib/active_record/database_validations/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module DatabaseValidations
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

data/lib/active_record/validations/adapter_helper.rb

@@ -0,0 +1,9 @@
+module ActiveRecord
+  module Validations
+    module AdapterHelper
+      def mysql_adapter?(connection)
+        connection.is_a?(ConnectionAdapters::AbstractMysqlAdapter)
+      end
+    end
+  end
+end

data/lib/active_record/validations/database_constraints.rb

@@ -1,9 +1,12 @@
 require 'active_model/validations/bytesize'
 require 'active_model/validations/not_null'
+require 'active_record/validations/adapter_helper'
 
 module ActiveRecord
   module Validations
     class DatabaseConstraintsValidator < ActiveModel::EachValidator
+      include Validations::AdapterHelper
+
       attr_reader :constraints
 
       VALID_CONSTRAINTS = Set[:size, :not_null, :range]
@@ -35,7 +38,7 @@ module ActiveRecord
 
       def size_validator(klass, column)
         return unless constraints.include?(:size)
-        return unless mysql_adapter?(klass)
+        return unless mysql_adapter?(klass.connection)
         return unless column.text? || column.binary?
 
         maximum, type, encoding = ActiveRecord::DatabaseValidations::MySQL.column_size_limit(column)
@@ -48,7 +51,7 @@ module ActiveRecord
 
       def range_validator(klass, column)
         return unless constraints.include?(:range)
-        return unless mysql_adapter?(klass)
+        return unless mysql_adapter?(klass.connection)
         return unless column.number?
 
         args = { attributes: [column.name.to_sym], class: klass, allow_nil: true }
@@ -79,12 +82,6 @@ module ActiveRecord
           validator.validate(record)
         end
       end
-
-      private
-
-      def mysql_adapter?(klass)
-        klass.connection.class < ::ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter
-      end
     end
   end
 end

data/lib/active_record/validations/string_truncator.rb

@@ -1,9 +1,13 @@
+require 'active_record/validations/adapter_helper'
+
 module ActiveRecord
   module DatabaseValidations
     module StringTruncator
       extend ActiveSupport::Concern
+      include Validations::AdapterHelper
 
       def truncate_value_to_field_limit(field, value)
+        return value unless mysql_adapter?(self.class.connection)
         return if value.nil?
 
         column = self.class.columns_hash[field.to_s]

data/test/string_truncator_test.rb

@@ -23,6 +23,19 @@ class MagicalCreature < ActiveRecord::Base
   truncate_to_field_limit :another_string
 end
 
+class MagicalSqliteCreature < ActiveRecord::Base
+  establish_connection(adapter: "sqlite3", database: ":memory:")
+  connection.create_table("magical_sqlite_creatures", force: true) do |t|
+    t.string :string, limit: 255
+    t.string :another_string, limit: 255
+  end
+
+  include ActiveRecord::DatabaseValidations::StringTruncator
+
+  before_validation truncate_string(:string)
+  truncate_to_field_limit :another_string
+end
+
 class StringTruncatorTest < Minitest::Test
   def test_handles_nil_gracefully
     u_nil = MagicalCreature.create!(string: 'present', tinytext: 'present')
@@ -72,4 +85,14 @@ class StringTruncatorTest < Minitest::Test
     u6 = MagicalCreature.new(another_string: 'a' * 256)
     assert_equal 'a' * 255, u6.another_string
   end
+
+  def test_skips_truncate_for_non_mysql_adapter
+    record = MagicalSqliteCreature.new(string: 'a' * 256)
+    assert(record.valid?)
+    assert_equal 'a' * 256, record.string
+
+    record.another_string = 'a' * 256
+    assert(record.valid?)
+    assert_equal 'a' * 256, record.another_string
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-databasevalidations
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Willem van Bergen
 bindir: bin
 cert_chain: []
-date: 2025-02-05 00:00:00.000000000 Z
+date: 2025-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -121,6 +121,7 @@ files:
 - lib/active_record/database_validations/varchar_191.rb
 - lib/active_record/database_validations/varchar_255.rb
 - lib/active_record/database_validations/version.rb
+- lib/active_record/validations/adapter_helper.rb
 - lib/active_record/validations/database_constraints.rb
 - lib/active_record/validations/string_truncator.rb
 - lib/active_record/validations/typed_column.rb
@@ -153,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.3
+rubygems_version: 3.6.5
 specification_version: 4
 summary: Add validations to your ActiveRecord models based on MySQL database constraints.
 test_files: