activerecord-cursor 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a2535f2c0d21228e6cfba576bc8ee249fb1e5fbe
-  data.tar.gz: df2ba240dcc29b2b5b9113a3fd74d89b7c6f080a
+  metadata.gz: 5468fa164f47c75c904c47a9d0db02d2646e71b5
+  data.tar.gz: 1e45fb4a1f00265a16a0b37176ead58af1b2c2c3
 SHA512:
-  metadata.gz: 4346da805065a8595341f7d5a993e533ade462b4a72584c886db54ef36f4a33f64d970a3240bf8a7a134d5a08a4ee7297ad6155ee9a14d44c09d2edc487a60f3
-  data.tar.gz: 4a8cb139ef303251fe7d198a815e957a90153954b6e21c9966123e055c5d1e6bf208171c5ce27581291c815275b505625f79124b400b52d10814e298bd498596
+  metadata.gz: 1b332c7fecc4403daca4be9d5be8b3365ff312ef4c8fafae00beefcd0874f818cf015dbfb339d5e3317aa85f1780a879f643f9c9b928cc4714e2a7065d579548
+  data.tar.gz: 285d945a97d383a5c05ff194afd6560fb7e25c5a1050740ac31a5a807642b72a89f56b370b8502530ca9a50f01cc660a966ee350faaf5e400709268054176c9d

data/README.md

@@ -29,7 +29,7 @@ Post.all
   #<Post id: 4, published: false, score: 2, created_at: "2018-12-30 19:38:30", updated_at: "2018-12-30 19:38:30">
 ]
 Post.cursor(key: :created_at)
-=> [#<Post id: 1, published: false, created_at: "2018-12-30 19:38:27", updated_at: "2018-12-30 19:38:27">]
+=> [#<Post id: 1, published: false, score: 0, created_at: "2018-12-30 19:38:27", updated_at: "2018-12-30 19:38:27">]
 Post.where(published: true).cursor(key: :created_at, reverse: true)
 => [#<Post id: 3, published: true, score: 1, created_at: "2018-12-30 19:38:29", updated_at: "2018-12-30 19:38:29">]
 Post.where(published: true).cursor(key: :created_at, reverse: true, start: Post.next_cursor) # Get next page

data/lib/activerecord/cursor/model_extension.rb

@@ -42,7 +42,7 @@ module ActiveRecord
         end
 
         def in_order
-          reorder("#{column} #{by}", "#{table_name}.id #{by}")
+          order("#{column} #{by}", "#{table_name}.id #{by}")
         end
 
         private
@@ -101,9 +101,8 @@ module ActiveRecord
           record = @records[0]
           @next = generate_cursor(record) if record
           size = @records.size
-          @records = @records.limit(@options[:size]).sort do |a, b|
-            b.public_send(@options[:key]) <=> a.public_send(@options[:key])
-          end
+          reverse_by = by == 'asc' ? 'desc' : 'asc'
+          @records = @records.reorder("#{column} #{reverse_by}").limit(@options[:size])
           return unless size == @options[:size] + 1
 
           @prev = generate_cursor(record)

data/lib/activerecord/cursor/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Cursor
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.2.1'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-cursor
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tomohiro Suwa
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-31 00:00:00.000000000 Z
+date: 2019-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord