activerecord-cubrid2-adapter 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa9bb76dd730abb53dfc4a0dd0eed73aae65807102e0785f0f745e251b62a09f
-  data.tar.gz: 2584cfda25294f6534eebe581f37d6c87ef3fd3cafb08bb7bda5029ecf86d110
+  metadata.gz: 5a4def5956cfad3d9c280869241d377182f2007624ff1ba2e9c90eb2ea456423
+  data.tar.gz: 21f100c281de6bb731613f8c2846c222330bd1044fd8785ba48b35611a6658b9
 SHA512:
-  metadata.gz: cbcec064f78631b61d99e198e99cd4c969a5933b4266b184597c9904daa2e5955ad45568a277a803f0a7285a9d4c08d972a64b7a66e67eac610951061d230bd3
-  data.tar.gz: 8f56f4cf68b369bf042bb0be92d818882b3764d283a63de6d50ec6ad524bab14b12ba67a5349e9c149ed73df9a2e6b08bf371a408efb75906f27f10edead70a8
+  metadata.gz: 35f826c22d9adec406b63ef687ca5ac12757fe59ffa2a7ebb534cbfa3ad6e28a45f154adcb809d1181f537b055e6569b0bb53abc33c49b63c1bc4b3e4b476651
+  data.tar.gz: c64e3974cfd3f960fa12d3e1fd8c3348f41a976d1f3d8797544fc128f01f299edd1c1bedf00790e2b5f8ce20e06a19ec669590f060a5c9ce9eedad3e6fbf679b

data/.gitignore

@@ -17,3 +17,4 @@ tests/test_cubrid3.rb
 tests/test_mysql.rb
 tests/test_pg.rb
 
+activerecord-cubrid2-adapter-*.gem

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/activerecord-cubrid2-adapter.gemspec

@@ -21,6 +21,6 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord', '>= 6.0'
-  spec.add_dependency 'cubrid', '>= 10.0'
+  spec.add_runtime_dependency 'activerecord', '~> 6.0', '>= 6.0'
+  spec.add_runtime_dependency 'cubrid', '~> 10.0', '>= 10.0'
 end

data/lib/active_record/connection_adapters/abstract_cubrid2_adapter.rb

@@ -326,7 +326,12 @@ module ActiveRecord
         if supports_rename_index?
           validate_index_length!(table_name, new_name)
 
-          execute "ALTER TABLE #{quote_table_name(table_name)} RENAME INDEX #{quote_table_name(old_name)} TO #{quote_table_name(new_name)}"
+          # NOTE: Renaming table index SQL would not work.
+          # See: https://www.cubrid.org/manual/ko/10.2/sql/schema/index_stmt.html#alter-index
+          #      https://www.cubrid.com/index.php?mid=qna&document_srl=3802148
+          _query = "ALTER INDEX #{quote_table_name(old_name)} ON #{quote_table_name(table_name)} RENAME TO #{quote_table_name(new_name)}"
+          puts "Warning: renaming index not work as manual. Ignoring: #{_query}"
+          # execute _query
         else
           super
         end

data/lib/active_record/connection_adapters/cubrid2/database_statements.rb

@@ -127,7 +127,8 @@ module ActiveRecord
         end
 
         def execute_batch(statements, name = nil)
-          combine_multi_statements(statements).each do |statement|
+          # ss = combine_multi_statements(statements)
+          statements.each do |statement|
             execute(statement, name)
           end
         end

data/lib/active_record/connection_adapters/cubrid2_adapter.rb

@@ -16,11 +16,9 @@ module ActiveRecord
       client = Cubrid2::Client.new(config)
       ConnectionAdapters::Cubrid2Adapter.new(client, logger, nil, config)
     rescue Cubrid2::Error => e
-      if e.error_number == ER_DATABASE_CONNECTION_ERROR
-        raise ActiveRecord::NoDatabaseError
-      else
-        raise
-      end
+      raise ActiveRecord::NoDatabaseError if e.error_number == ER_DATABASE_CONNECTION_ERROR
+
+      raise
     end
   end
 
@@ -72,7 +70,7 @@ module ActiveRecord
         stmt = result.is_a?(Array) ? result.first : result
         if block_given?
           if result && stmt
-            while row = stmt.fetch_hash
+            while (row = stmt.fetch_hash)
               yield row.symbolize_keys
             end
           end
@@ -92,8 +90,7 @@ module ActiveRecord
       def quote_string(string)
         # escaping with backslash is only allowed when 'no_backslash_escapes' == 'yes' in cubrid config, default is yes.
         # See: https://www.cubrid.org/manual/ko/11.2/sql/literal.html#id5
-        # "'#{string.gsub("'", "''")}'"
-        string
+        "#{string.gsub("'", "''")}"
       end
 
       #--
@@ -120,7 +117,7 @@ module ActiveRecord
 
       def discard! # :nodoc:
         super
-        #@connection.automatic_close = false
+        # @connection.automatic_close = false
         @connection = nil
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-cubrid2-adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Eui-Taik Na
@@ -14,6 +14,9 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -21,6 +24,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -28,6 +34,9 @@ dependencies:
   name: cubrid
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
@@ -35,6 +44,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '10.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'