activerecord-cte 0.1.5 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa6017d175139cbb92a4428130dc7ca14c10018a9a32d9c3dba0a6b68e41e348
-  data.tar.gz: 139a0430c0f9732e36de816475d9c3d8fc12bd326ef1349401549193112652f2
+  metadata.gz: fec64d2dc3623acd9cfb623957035c94ce160ac7f1f5bc8df2777d37e8e496b6
+  data.tar.gz: 12d66f36eb856b43a5e23568234884b81db258a67bbed86417e2f28d90449dce
 SHA512:
-  metadata.gz: '095fb61691550d6b95064d6d64e821759fd57d820f065eef9785284329bc8edceb69f8a29e244a25258851acc540bbc99446823f2309f4a1f2e6d8454cde779d'
-  data.tar.gz: 308d0fe1766731ff4977783249d12a0ac9f845321124b4db793ef5ed13c00585af36afa4958e7ee5fe57d7175ac5d481f1a822fe0151552a9a9856050712ad10
+  metadata.gz: 28a0be826ae1b0914f8fa4b9e7dd7d9f0221b67b453abfa9f680f943453f12a9436d756378059aade81e4341e352598309dc799441e063d8215c846a00df6ec0
+  data.tar.gz: 78839e99683a7ee08bae702361010986678e1f8a8eaa95e2508edf75188d359a6b3d3295630e4d2a7fb367214dc15d17df69c14a1b8d0d3970f2a5d3a35d49e7

data/.github/workflows/test-with-mysql.yml

@@ -6,7 +6,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        active_record: [6.1.4, 6.0.4, 5.2.6]
+        active_record: [6.1.7.2, 6.0.6, 5.2.8.1]
+        ruby: [2.6, 2.7, '3.0', 3.1, 3.2]
+        exclude:
+          - active_record: 5.2.8.1
+            ruby: '3.0'
+          - active_record: 5.2.8.1
+            ruby: 3.1
+          - active_record: 5.2.8.1
+            ruby: 3.2
     env:
       ACTIVE_RECORD_VERSION: ${{ matrix.active_record }}
       DATABASE_ADAPTER: mysql
@@ -20,6 +28,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
+          ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
       - name: Run tests
         run: bundle exec rake test

data/.github/workflows/test-with-postgresql.yml

@@ -3,11 +3,19 @@ on: [pull_request]
 jobs:
   Test-With-PostgreSQL:
     runs-on: ubuntu-latest
-    container: ruby:2.7
+    container: ruby:${{ matrix.ruby }}
     strategy:
       fail-fast: false
       matrix:
-        active_record: [6.1.4, 6.0.4, 5.2.6]
+        active_record: [6.1.7.2, 6.0.6, 5.2.8.1]
+        ruby: [2.6, 2.7, '3.0', 3.1, 3.2]
+        exclude:
+          - active_record: 5.2.8.1
+            ruby: '3.0'
+          - active_record: 5.2.8.1
+            ruby: 3.1
+          - active_record: 5.2.8.1
+            ruby: 3.2
     env:
       ACTIVE_RECORD_VERSION: ${{ matrix.active_record }}
       DATABASE_ADAPTER: postgresql
@@ -28,6 +36,8 @@ jobs:
     steps:
       - name: Check out repository code
         uses: actions/checkout@v2
+      - name: Update bundler
+        run: gem update bundler # Use the latest bundler
       - name: Bundle dependencies
         run: bundle install
       - name: Run tests

data/.github/workflows/test-with-sqlite.yml

@@ -6,7 +6,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        active_record: [6.1.4, 6.0.4, 5.2.6]
+        active_record: [6.1.7.2, 6.0.6, 5.2.8.1]
+        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
+        ruby: [2.6, 2.7, '3.0', 3.1, 3.2]
+        exclude:
+          - active_record: 5.2.8.1
+            ruby: '3.0'
+          - active_record: 5.2.8.1
+            ruby: 3.1
+          - active_record: 5.2.8.1
+            ruby: 3.2
+
     env:
       ACTIVE_RECORD_VERSION: ${{ matrix.active_record }}
       DATABASE_ADAPTER: sqlite3
@@ -17,6 +27,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
+          ruby-version: ${{ matrix.ruby }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
       - name: Run tests
         run: bundle exec rake test

data/.ruby-version

@@ -1 +1 @@
-2.7.3
+3.1.2

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:2.7
+FROM ruby:3.1
 
 ENV APP_HOME /activerecord_cte
 RUN mkdir $APP_HOME

data/Gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in activerecord-cte.gemspec
 gemspec
 
-ACTIVE_RECORD_VERSION = ENV.fetch("ACTIVE_RECORD_VERSION", "6.0.4")
+ACTIVE_RECORD_VERSION = ENV.fetch("ACTIVE_RECORD_VERSION", "6.1.7.2")
 
 gem "activerecord", ACTIVE_RECORD_VERSION
 

data/README.md

@@ -5,7 +5,7 @@
 ![PostgreSQL](https://github.com/vlado/activerecord-cte/actions/workflows/test-with-postgresql.yml/badge.svg)
 ![SQLite](https://github.com/vlado/activerecord-cte/actions/workflows/test-with-sqlite.yml/badge.svg)
 
-Adds Common Table Expression support to ActiveRecord (Rails).
+Adds [Common Table Expression](https://en.wikipedia.org/wiki/Hierarchical_and_recursive_queries_in_SQL#Common_table_expression) support to ActiveRecord (Rails).
 
 It adds `.with` query method and makes it super easy to build and chain complex CTE queries. Let's explain it using simple example.
 
@@ -27,6 +27,8 @@ WITH posts_with_comments AS (
 SELECT * FROM posts
 ```
 
+**Please note that this creates the expressions but is not using them yet. See [Taking it further](#taking-it-further) for more info.**
+
 Without this gem you would need to use `Arel` directly.
 
 ```ruby

data/bin/test

@@ -4,16 +4,8 @@
 require "English"
 require "yaml"
 
-active_record_versions = []
-database_adapters = []
-
-# Extract ActiveRecord versions and database adapters from CI workflows
-Dir[".github/workflows/test-**.yml"].each do |path|
-  yml = YAML.load_file(path)
-  job = yml["jobs"].values.first
-  active_record_versions << job["strategy"]["matrix"]["active_record"]
-  database_adapters << job["env"]["DATABASE_ADAPTER"]
-end
+active_record_versions = %w[6.1.7.2 6.0.6]
+database_adapters = %w[mysql postgresql sqlite3]
 
 class Matrix
   def initialize(active_record_versions, database_adapters)
@@ -28,7 +20,7 @@ class Matrix
       run_with_active_record_version(ar_version)
     end
     puts "----> Reverting back to original ActiveRecord version (#{original_ar_version})"
-    cmd("ACTIVE_RECORD_VERSION=#{original_ar_version} bundle update activerecord")
+    cmd("ACTIVE_RECORD_VERSION=#{original_ar_version} bundle update")
 
     exit(@exit_status_code) unless @exit_status_code.zero?
   end
@@ -42,7 +34,7 @@ class Matrix
 
   def run_with_active_record_version(ar_version)
     puts "----> Switching ActiveRecord to version #{ar_version}"
-    cmd("ACTIVE_RECORD_VERSION=#{ar_version} bundle update activerecord")
+    cmd("ACTIVE_RECORD_VERSION=#{ar_version} bundle update")
 
     @database_adapters.each do |adapter|
       puts "----> Running tests with ActiveRecord #{ar_version} and #{adapter} adapter"

data/lib/activerecord/cte/core_ext.rb

@@ -15,6 +15,7 @@ module ActiveRecord
     private
 
     def merge_withs
+      relation.recursive_with = true if other.recursive_with?
       other_values = other.with_values.reject { |value| relation.with_values.include?(value) }
       relation.with!(*other_values) if other_values.any?
     end
@@ -30,7 +31,12 @@ module ActiveRecord
     end
 
     def with!(opts, *rest)
-      self.with_values += [opts] + rest
+      if opts == :recursive
+        self.recursive_with = true
+        self.with_values += rest
+      else
+        self.with_values += [opts] + rest
+      end
       self
     end
 
@@ -44,9 +50,19 @@ module ActiveRecord
       @values[:with] = values
     end
 
+    def recursive_with?
+      @values[:recursive_with]
+    end
+
+    def recursive_with=(value)
+      raise ImmutableRelation if @loaded
+
+      @values[:recursive_with] = value
+    end
+
     private
 
-    def build_arel(*args, **kwargs)
+    def build_arel(*args)
       arel = super
       build_with(arel) if @values[:with]
       arel
@@ -55,7 +71,6 @@ module ActiveRecord
     def build_with(arel) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
       return if with_values.empty?
 
-      recursive = with_values.delete(:recursive)
       with_statements = with_values.map do |with_value|
         case with_value
         when String then Arel::Nodes::SqlLiteral.new(with_value)
@@ -67,7 +82,7 @@ module ActiveRecord
         end
       end
 
-      recursive ? arel.with(:recursive, with_statements) : arel.with(with_statements)
+      recursive_with? ? arel.with(:recursive, with_statements) : arel.with(with_statements)
     end
 
     def build_with_value_from_array(array)

data/lib/activerecord/cte/version.rb

@@ -2,6 +2,6 @@
 
 module Activerecord
   module Cte
-    VERSION = "0.1.5"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-cte
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.3.0
 platform: ruby
 authors:
 - Vlado Cingel
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-02 00:00:00.000000000 Z
+date: 2023-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -174,7 +174,7 @@ metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/vlado/activerecord-cte
   source_code_uri: https://github.com/vlado/activerecord-cte
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -189,8 +189,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.11
+signing_key:
 specification_version: 4
 summary: Brings Common Table Expressions support to ActiveRecord and makes it super
   easy to build and chain complex CTE queries