activerecord-column_metadata 0.0.3 → 0.1.0

checksums.yaml

@@ -0,0 +1,15 @@
+---
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZTYxNzQ2NTgyNzk5MDViYzJiN2Q0ZDUwYTExYTFjMzBiNGQ2MDZmZg==
+  data.tar.gz: !binary |-
+    NGM5ODg5NjI2YWQ0MzFjMDliNzczM2QzNjIxMzJhY2JjNWJiZDU4YQ==
+SHA512:
+  metadata.gz: !binary |-
+    OTVjZjMzMGVhM2FiZTg4NWQ1M2FkNDQyNGQ4NjU1NTg0ZjkyNjE1YjkzOGFh
+    MzZjMzcyNDcxODI5NDYxZDQyYTM4ZDZjZGI1NjUzY2YzYjY5NzMyMmZjNDFh
+    ZDkzMzUxMjQzN2RhNGIwMzM5MTNjNzViYmM4Y2I1MWZlNTYxZjY=
+  data.tar.gz: !binary |-
+    NmVhZWNmNTgwN2UwNWZkNWFkOWM1Y2VhODhhNGIzMDVkZjE4ZTYyNGQyMDgx
+    M2I0NWFkYjMzOGY5ODM2YWRhY2Y1YzAyNDNkZTI3ZGJiYzk0Y2I1NDRiNWU5
+    MTc2NmE4NjdiMmQxZjQzOTMyYzJjMTA5NzkwMDQ1MDhmZDRlOWM=

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.1.0 (24 September 2014)
+
+Fix add_column with no metadata
+
 ## 0.0.3 (12 July 2013)
 
 Add column_metadata(table_name, column_name, metadata) for use in migrations

data/activerecord-column_metadata.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", "~>3.0.3"
+  spec.add_dependency "activerecord", ">=3.0.3", "<4"
   spec.add_dependency "pg"
-  
+
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"

data/lib/active_record/column_metadata/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   class ColumnMetadata
-    VERSION = "0.0.3"
+    VERSION = "0.1.0"
   end
 end

data/lib/active_record/column_metadata/write.rb

@@ -9,20 +9,20 @@ module ActiveRecord
         def column_metadata(column, hash)
           add_comment(column, hash)
         end
-      
+
         def add_comment(column, comment)
           @comments ||= []
           @comments << [column, comment]
         end
-    
+
         def comments
           @comments
         end
       end
-      
+
       include ColumnMetadata
     end
-    
+
     module SchemaStatements
       # works only with databases that support comments on columns
       def create_table(table_name,options={},&block)
@@ -43,7 +43,7 @@ module ActiveRecord
         table_definition.comments.each{ |c| write_json_comment(table_name, c.to_a.first, c.to_a.last) } if table_definition.comments
       end
     end
-    
+
     class PostgreSQLAdapter < AbstractAdapter
       def add_column_with_metadata(*args)
         add_column_without_metadata(*args)
@@ -51,13 +51,13 @@ module ActiveRecord
         write_json_comment(args[0], args[1], options[:metadata])
       end
       alias_method_chain :add_column, :metadata
-      
+
       def column_metadata(table_name, column_name, metadata)
         write_json_comment(table_name, column_name, metadata)
       end
-      
+
       def write_json_comment(table_name, column_name, comment)
-        execute "COMMENT ON COLUMN #{quote_table_name(table_name)}.#{quote_column_name(column_name)} IS #{quote(comment.to_json)}"
+        execute "COMMENT ON COLUMN #{quote_table_name(table_name)}.#{quote_column_name(column_name)} IS #{quote(comment.to_json)}" unless comment.blank?
       end
     end
   end

data/spec/activerecord_column_metadata_spec.rb

@@ -25,20 +25,20 @@ describe ActiveRecord::ColumnMetadata do
       end
     end
   end
-  
+
   class AddColumnMigration < ActiveRecord::Migration
     def self.up
       add_column :people, :surname, :string, :metadata => {full_text_search: "double_metaphone"}
     end
   end
-  
+
   describe 'write should add JSON in comment' do
     it 'with create_table' do
       CreateTableMigration.up
       res = get_comments("people")
       expect(res).to include( ["name",'{"something":true}'])
     end
-  
+
     it 'with add_column' do
       CreateTableMigration.up
       AddColumnMigration.up
@@ -51,20 +51,41 @@ describe ActiveRecord::ColumnMetadata do
         column_metadata :people, :name, {completely: "different"}
       end
     end
-    
-    it 'with add_column_metadata' do
+
+    it 'with column_metadata' do
       CreateTableMigration.up
       AddColumnMetadataMigration.up
       res = get_comments("people")
       expect(res).to include( ['name', '{"completely":"different"}'])
     end
+
+    class AddColumnWithoutMetadataMigration < ActiveRecord::Migration
+      def self.up
+        add_column :people, :surname, :string
+      end
+    end
+
+    class CreateTableWithoutMetadataMigration < ActiveRecord::Migration
+      def self.up
+        create_table(:people) do |t|
+          t.string :name
+        end
+      end
+    end
+
+    it 'without any metadata given' do
+      CreateTableWithoutMetadataMigration.up
+      AddColumnWithoutMetadataMigration.up
+      res = get_comments('people')
+      expect(res).to contain_exactly ["id", nil], ["name", nil], ["surname", nil]
+    end
   end
-  
+
   describe 'read' do
     it '#to_a should return a column comments as an array of arrays' do
       CreateTableMigration.up
       res = ActiveRecord::ColumnMetadata.to_a(:people)
       res.should == [["name", {"something" => true}]]
     end
-  end 
+  end
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-column_metadata
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Sava Chankov
@@ -10,28 +9,31 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-12 00:00:00.000000000 Z
+date: 2014-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.3
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 3.0.3
+    - - <
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -39,7 +41,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -47,7 +48,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -55,7 +55,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -63,7 +62,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -71,7 +69,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -79,7 +76,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -87,7 +83,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -95,7 +90,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -103,7 +97,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
@@ -136,30 +129,28 @@ files:
 homepage: http://github.com/tutuf/activerecord-column_metadata
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.4.1
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ActiveRecord extension to store column metadata in database
 test_files:
 - spec/activerecord_column_metadata_spec.rb
 - spec/database.yml
 - spec/spec_helper.rb
-has_rdoc: