activerecord-cockroachdb-adapter 8.0.3 → 8.1.0

data/test/excludes/ActiveRecord/ConnectionAdapters/RegistrationIsolatedTest.rb

@@ -0,0 +1,14 @@
+exclude "test_#resolve_raises_if_the_adapter_is_using_the_pre_7.2_adapter_registration_API", "One adapter is missing in the test, added below"
+
+test "#resolve raises if the adapter is using the pre 7.2 adapter registration API with CRDB" do
+  exception = assert_raises(ActiveRecord::AdapterNotFound) do
+    ActiveRecord::ConnectionAdapters.resolve("fake_legacy")
+  end
+
+  assert_equal(
+    "Database configuration specifies nonexistent 'fake_legacy' adapter. Available adapters are: abstract, cockroachdb, fake, mysql2, postgresql, sqlite3, trilogy. Ensure that the adapter is spelled correctly in config/database.yml and that you've added the necessary adapter gem to your Gemfile if it's not in the list of available adapters.",
+    exception.message
+  )
+ensure
+  ActiveRecord::ConnectionAdapters.instance_variable_get(:@adapters).delete("fake_legacy")
+end

data/test/excludes/ActiveRecord/Encryption/EncryptionPerformanceTest.rb

@@ -0,0 +1 @@
+exclude :test_reading_an_encrypted_attribute_multiple_times_is_as_fast_as_reading_a_regular_attribute, "Test is flaky and tests an internal rails feature"

data/test/excludes/ActiveRecord/Encryption/EnvelopeEncryptionPerformanceTest.rb

@@ -0,0 +1 @@
+exclude :test_performance_when_saving_records, "Test is flaky and tests an internal rails feature"

data/test/excludes/ActiveRecord/Encryption/ExtendedDeterministicQueriesPerformanceTest.rb

@@ -0,0 +1 @@
+exclude "test_finding_without_prepared_statement_caching_by_encrypted_columns_(deterministic)", "Test is flaky and tests an internal rails feature"

data/test/excludes/ActiveRecord/Encryption/StoragePerformanceTest.rb

@@ -0,0 +1,2 @@
+exclude :test_storage_overload_storing_keys_is_acceptable_for_EnvelopeEncryptionKeyProvider, "Test is flaky and tests an internal rails feature"
+exclude :test_storage_overload_storing_keys_is_acceptable_for_DerivedSecretKeyProvider, "Test is flaky and tests an internal rails feature"

data/test/excludes/ActiveRecord/InstrumentationTest.rb

@@ -0,0 +1,16 @@
+require "support/copy_cat"
+
+# We override this test since in our codebase, there is a SCHEMA call
+# made with `SHOW max_identifier_length`.
+# TODO: We should however inspect why that is.
+#
+# See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/392
+#
+# From: notification.first
+#   To: notification.last
+CopyCat.copy_methods(self, self, :test_payload_name_on_eager_load) do
+  def on_send(node)
+    return super unless node in [:send, [:lvar, :notification], :first]
+    replace(node.loc.expression, "notification.last")
+  end
+end

data/test/excludes/ActiveRecord/InvertibleMigrationTest.rb

@@ -0,0 +1,2 @@
+exclude :test_migrate_enable_and_disable_extension, "CockroachDB doesn't support enabling/disabling extensions."
+exclude :test_migrate_revert_change_column_default, "The test fails because type information is stripped from string column default values when the default is changed in the database. Possibly caused by https://github.com/cockroachdb/cockroach/issues/47285."

data/test/excludes/ActiveRecord/Migration/ChangeSchemaTest.rb

@@ -0,0 +1,7 @@
+exclude :test_change_column_quotes_column_names, "This functionality is not yet implemented in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851"
+exclude :test_create_table_without_id, "Tables cannot be created without a pk in CockroachDB"
+exclude :test_create_table_with_limits, "The only assertion that fails is on the default sql_type; this is bigint instead of integer in CockroachDB"
+exclude :test_add_column_with_primary_key_attribute, "PK can be re-assigned to a new column, but it must be done in a separate statement. In other words, the target column must already exist. See https://www.cockroachlabs.com/docs/v20.1/alter-primary-key.html"
+exclude :test_drop_table_if_exists, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"
+exclude :test_change_column_null, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"
+exclude :test_keeping_default_and_notnull_constraints_on_change, "It's not possible to check for the result of an operation in the same txn as which the operation is performed"

data/test/excludes/ActiveRecord/Migration/CheckConstraintTest.rb

@@ -0,0 +1,6 @@
+exclude :test_validate_check_constraint_by_name, "This test is failing with transactions due to cockroachdb/cockroach#19444"
+exclude :test_remove_check_constraint, "This test is failing with transactions due to cockroachdb/cockroach#19444"
+exclude :test_check_constraints, "Re-implementing because some constraints are now written in parenthesis"
+exclude :test_add_check_constraint, "Re-implementing because some constraints are now written in parenthesis"
+exclude :test_schema_dumping_with_validate_false, "Re-implementing because some constraints are now written in parenthesis"
+exclude :test_schema_dumping_with_validate_true, "Re-implementing because some constraints are now written in parenthesis"

data/test/excludes/ActiveRecord/Migration/ColumnsTest.rb

@@ -0,0 +1,4 @@
+exclude :test_change_column, "This operation is not currently supported in CockroachDB, see cockroachdb/cockroach#9851"
+exclude :test_change_column_default, "This test fails because type information is stripped from string column default values when the default is changed in the database. Possibly caused by https://github.com/cockroachdb/cockroach/issues/47285."
+exclude :test_change_column_default_with_from_and_to, "This test fails because type information is stripped from string column default values when the default is changed in the database. Possibly caused by https://github.com/cockroachdb/cockroach/issues/47285."
+exclude :test_remove_column_with_multi_column_index, "This test fails because it lacks the requisite CASCADE clause to fully remove the column"

data/test/excludes/ActiveRecord/Migration/CompatibilityTest.rb

@@ -0,0 +1,50 @@
+exclude :test_legacy_change_column_with_null_executes_update, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_add_foreign_key_with_deferrable_true, "CRDB does not support DEFERRABLE constraints"
+exclude :test_disable_extension_on_7_0, "CRDB does not support enabling/disabling extensions."
+
+# exclude :test_add_index_errors_on_too_long_name_7_0, "The max length in CRDB is 128, not 64."
+# exclude :test_create_table_add_index_errors_on_too_long_name_7_0, "The max length in CRDB is 128, not 64."
+
+require "support/copy_cat"
+
+CopyCat.copy_methods(self, self,
+  :test_add_index_errors_on_too_long_name_7_0,
+  :test_create_table_add_index_errors_on_too_long_name_7_0
+) do
+  def on_sym(node)
+    return unless node.children[0] == :very_long_column_name_to_test_with
+
+    insert_after(node.loc.expression, "_and_actually_way_longer_because_cockroach_is_in_the_128_game")
+  end
+end
+
+# CockroachDB does not support DDL transactions. Hence the migration is
+# not rolled back and the already removed index is not restored.
+#
+# From:
+#     if current_adapter?(:PostgreSQLAdapter, :SQLite3Adapter)
+#       assert_equal 2, foreign_keys.size
+#     else
+#       assert_equal 1, foreign_keys.size
+#     end
+# To:
+#     assert_equal 1, foreign_keys.size
+CopyCat.copy_methods(self, self, :test_remove_foreign_key_on_8_0) do
+  def on_if(node)
+    return unless node in
+      [:if,
+        [:send, nil, :current_adapter?,
+          [:sym, :PostgreSQLAdapter],
+          [:sym, :SQLite3Adapter]],
+        [:send, nil, :assert_equal,
+          [:int, 2],
+            [:send,
+              [:lvar, :foreign_keys], :size]],
+        [:send, nil, :assert_equal,
+          [:int, 1],
+            [:send,
+              [:lvar, :foreign_keys], :size]] => else_block]
+
+    replace(node.loc.expression, else_block.location.expression.source)
+  end
+end

data/test/excludes/ActiveRecord/Migration/CompositeForeignKeyTest.rb

@@ -0,0 +1,2 @@
+exclude :test_add_composite_foreign_key_raises_without_options, "Updated regexp to remove quotes"
+exclude :test_schema_dumping, ExcludeMessage::VALIDATE_BUG

data/test/excludes/ActiveRecord/Migration/CreateJoinTableTest.rb

@@ -0,0 +1,2 @@
+exclude :test_create_join_table_with_index, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_create_and_drop_join_table_with_common_prefix, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"

data/test/excludes/ActiveRecord/Migration/ForeignKeyInCreateTest.rb

@@ -0,0 +1 @@
+exclude :test_foreign_keys, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/ActiveRecord/Migration/ForeignKeyTest.rb

@@ -0,0 +1,35 @@
+exclude :test_add_foreign_key_inferes_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_on_delete_restrict_foreign_key, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_on_delete_cascade_foreign_key, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_on_delete_nullify_foreign_key, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_on_update, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_foreign_key_exists, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_foreign_key_exists_by_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_foreign_key_exists_by_name, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_inferes_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_by_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_by_symbol_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_by_name, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_invalid_foreign_key, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_validate_foreign_key_infers_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_validate_foreign_key_by_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_validate_foreign_key_by_symbol_column, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_validate_foreign_key_by_name, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_validate_constraint_by_name, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_schema_dumping, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_schema_dumping_on_delete_and_on_update_options, ExcludeMessage::VALIDATE_BUG
+exclude :test_schema_dumping_with_validate_false, ExcludeMessage::VALIDATE_BUG
+exclude :test_schema_dumping_with_validate_true, ExcludeMessage::VALIDATE_BUG
+exclude :test_schema_dumping_with_custom_fk_ignore_pattern, ExcludeMessage::VALIDATE_BUG
+exclude :test_add_foreign_key_is_reversible, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_foreign_key_constraint_is_not_cached_incorrectly, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_prefix, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_suffix, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_foreign_keys, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_schema_dumping_with_options, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_remove_foreign_key_by_the_select_one_on_the_same_table, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_with_if_exists_not_set, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_remove_foreign_key_with_if_exists_set, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_if_not_exists_not_set, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."
+exclude :test_add_foreign_key_with_if_not_exists_set, "This test fails due to the transactional nature of the test. Disabling transactions will make the test pass."

data/test/excludes/ActiveRecord/Migration/InvalidOptionsTest.rb

@@ -0,0 +1,14 @@
+module Ext
+  def invalid_add_column_option_exception_message(key)
+    default_keys = [":limit", ":precision", ":scale", ":default", ":null", ":collation", ":comment", ":primary_key", ":if_exists", ":if_not_exists"]
+
+    # PostgreSQL specific options
+    default_keys.concat([":array", ":using", ":cast_as", ":as", ":type", ":enum_type", ":stored"])
+
+    # CockroachDB specific options
+    default_keys.concat([":srid", ":has_z", ":has_m", ":geographic", ":spatial_type", ":hidden"])
+
+    "Unknown key: :#{key}. Valid keys are: #{default_keys.join(", ")}"
+  end
+end
+prepend Ext

data/test/excludes/ActiveRecord/Migration/PGChangeSchemaTest.rb

@@ -0,0 +1,8 @@
+exclude :test_change_string_to_date, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol_with_timestamptz, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol_using_datetime, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol_using_timestamp_with_timestamptz_as_default, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol_with_timestamptz_as_default, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_symbol_using_datetime_with_timestamptz_as_default, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."
+exclude :test_change_type_with_array, "Changing column data types is not supported in a transaction in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/9851."

data/test/excludes/ActiveRecord/Migration/ReferencesForeignKeyTest.rb

@@ -0,0 +1,7 @@
+exclude :test_foreign_keys_can_be_created_while_changing_the_table,  "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_foreign_keys_accept_options_when_changing_the_table,  "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_foreign_key_column_can_be_removed, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_removing_column_removes_foreign_key, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_foreign_key_methods_respect_pluralize_table_names,  "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_multiple_foreign_keys_can_be_removed_to_the_selected_one, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"
+exclude :test_multiple_foreign_keys_can_be_added_to_the_same_table, "Results of an operation cannot be accessed prior to completion of that operation's transaction. See https://www.cockroachlabs.com/docs/v19.2/architecture/transaction-layer.html#transaction-conflicts"

data/test/excludes/ActiveRecord/Migration/ReferencesIndexTest.rb

@@ -0,0 +1,7 @@
+exclude :test_creates_index_by_default_even_if_index_option_is_not_passed, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_index_for_existing_table_even_if_index_option_is_not_passed, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_index_with_options, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_polymorphic_index_for_existing_table, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_index_for_existing_table, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_polymorphic_index, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_creates_index, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/ActiveRecord/Migration/ReferencesStatementsTest.rb

@@ -0,0 +1,3 @@
+exclude :test_deletes_reference_type_column, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_does_not_delete_reference_type_column, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_deletes_polymorphic_index, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/ActiveRecord/MysqlDBCreateWithInvalidPermissionsTest.rb

@@ -0,0 +1 @@
+exclude :test_raises_error, "No link with MySQL"

data/test/excludes/ActiveRecord/OrTest.rb

@@ -0,0 +1 @@
+exclude :test_or_when_grouping, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/ActiveRecord/PostgreSQLStructureDumpTest.rb

@@ -0,0 +1,10 @@
+exclude :test_structure_dump, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_execution_fails, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_dump_schemas_string, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_extra_flags, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_schema_search_path, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_schema_search_path_and_dump_schemas_all, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_hash_extra_flags_for_a_different_driver, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_ssl_env, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_env, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."
+exclude :test_structure_dump_with_hash_extra_flags_for_the_correct_driver, "Skipping for now because the exclusion of postgis tables from the SchemaDumper is causing the test to fail due to expected argument mismatch (because our arguments include the excluded tables)."

data/test/excludes/ActiveRecord/PostgresqlConnectionTest.rb

@@ -0,0 +1,12 @@
+exclude :test_get_and_release_advisory_lock, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_reconnection_after_actual_disconnection_with_verify, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_reset, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_release_non_existent_advisory_lock, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_table_alias_length_logs_name, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_statement_key_is_logged, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_connection_options, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_reset_with_transaction, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_set_session_variable_true, "Re-implemented with a CockroachDB compatible session variable."
+exclude :test_set_session_variable_false, "Re-implemented with a CockroachDB compatible session variable."
+exclude :test_set_session_variable_nil, "Re-implemented with a CockroachDB compatible session variable."
+exclude :test_set_session_variable_default, "Re-implemented with a CockroachDB compatible session variable."

data/test/excludes/ActiveRecord/PostgresqlTransactionNestedTest.rb

@@ -0,0 +1,14 @@
+
+# > In CRDB SERIALIZABLE, reads block on in-progress writes for
+# > as long as those writes are in progress. However, PG does
+# > not have this "read block on write" behavior, and so rather
+# > than allowing the left-hand-side to execute, it must instead
+# > abort that transaction. Both are valid ways to implement SERIALIZABLE.
+#
+# See discussion: https://github.com/cockroachdb/activerecord-cockroachdb-adapter/pull/333
+message = "SERIALIZABLE transactions are different in CockroachDB."
+
+exclude :test_deadlock_raises_Deadlocked_inside_nested_SavepointTransaction, message
+exclude :test_unserializable_transaction_raises_SerializationFailure_inside_nested_SavepointTransaction, message
+exclude :test_SerializationFailure_inside_nested_SavepointTransaction_is_recoverable, message
+exclude :test_deadlock_inside_nested_SavepointTransaction_is_recoverable, message

data/test/excludes/ActiveRecord/PostgresqlTransactionTest.rb

@@ -0,0 +1,4 @@
+exclude :test_raises_LockWaitTimeout_when_lock_wait_timeout_exceeded, "The test tries to set lock_timeout, but lock_timeout is not supported by CockroachDB."
+exclude :test_raises_QueryCanceled_when_canceling_statement_due_to_user_request, "CockroachDB doesn't support pg_cancel_backend()."
+exclude :test_raises_Deadlocked_when_a_deadlock_is_encountered, "Causes CI to hand. Skip while debugging."
+exclude :test_raises_SerializationFailure_when_a_serialization_failure_occurs, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/ActiveRecord/RelationTest.rb

@@ -0,0 +1,2 @@
+exclude :test_relation_with_annotation_filters_sql_comment_delimiters, "This test is overridden for CockroachDB because this adapter adds quotes to numeric values."
+exclude :test_relation_with_annotation_includes_comment_in_to_sql, "This test is overridden for CockroachDB because this adapter adds quotes to numeric values."

data/test/excludes/ActiveRecord/TooManyOrTest.rb

@@ -0,0 +1 @@
+exclude :test_too_many_or, "This test takes a very long time to run, so we are skipping until we can fix it later."

data/test/excludes/ActiveSupportSubclassWithFixturesTest.rb

@@ -0,0 +1 @@
+exclude :test_foo, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/AssociationDeprecationTest/NotifyModeTest.rb

@@ -0,0 +1,2 @@
+require_relative "fix_backtrace_cleaner"
+include(FixBacktraceCleaner)

data/test/excludes/AssociationDeprecationTest/RaiseBacktraceModeTest.rb

@@ -0,0 +1,2 @@
+require_relative "fix_backtrace_cleaner"
+include(FixBacktraceCleaner)

data/test/excludes/AssociationDeprecationTest/RaiseModeTest.rb

@@ -0,0 +1,2 @@
+require_relative "fix_backtrace_cleaner"
+include(FixBacktraceCleaner)

data/test/excludes/AssociationDeprecationTest/WarnBacktraceModeTest.rb

@@ -0,0 +1,2 @@
+require_relative "fix_backtrace_cleaner"
+include(FixBacktraceCleaner)

data/test/excludes/AssociationDeprecationTest/WarnModeTest.rb

@@ -0,0 +1,2 @@
+require_relative "fix_backtrace_cleaner"
+include(FixBacktraceCleaner)

data/test/excludes/AssociationDeprecationTest/fix_backtrace_cleaner.rb

@@ -0,0 +1,10 @@
+module FixBacktraceCleaner
+  def setup
+    super
+    bc = ActiveSupport::BacktraceCleaner.new
+    bc.remove_silencers!
+    bc.remove_filters!
+    bc.add_silencer { !_1.include?(::AssociationDeprecationTest::TestCase::THIS_FILE) }
+    ActiveRecord::LogSubscriber.backtrace_cleaner = bc
+  end
+end

data/test/excludes/BasicsTest.rb

@@ -0,0 +1 @@
+exclude :test_column_names_are_escaped, "Rewritten for CockroachDB"

data/test/excludes/BulkAlterTableMigrationsTest.rb

@@ -0,0 +1,7 @@
+exclude :test_changing_columns, "Type conversion from DATE to TIMESTAMP requires overwriting existing values which is not yet implemented. https://github.com/cockroachdb/cockroach/issues/9851"
+exclude :test_changing_column_null_with_default, "Type conversion from DATE to TIMESTAMP requires overwriting existing values which is not yet implemented. https://github.com/cockroachdb/cockroach/issues/9851"
+
+exclude :test_adding_indexes, "Need to reference the specific query count for CockroachDB"
+exclude :test_removing_index, "Need to reference the specific query count for CockroachDB"
+exclude :test_adding_multiple_columns, "Need to reference the specific query count for CockroachDB"
+exclude :test_changing_index, "Need to reference the specific query count for CockroachDB"

data/test/excludes/CalculationsTest.rb

@@ -0,0 +1,4 @@
+exclude :test_group_by_with_order_by_virtual_count_attribute, "Ordering with virtual count attributes is not supported against CockroachDB."
+exclude :test_group_by_with_limit, "The test fails because ActiveRecord strips out the query order clause making it impossible to guarantee the results order. See bug issue https://github.com/rails/rails/issues/38936."
+exclude :test_group_by_with_offset, "The test fails because ActiveRecord strips out the query order clause making it impossible to guarantee the results order. See bug issue https://github.com/rails/rails/issues/38936."
+exclude :test_group_by_with_limit_and_offset, "The test fails because ActiveRecord strips out the query order clause making it impossible to guarantee the results order. See bug issue https://github.com/rails/rails/issues/38936."

data/test/excludes/CommentTest.rb

@@ -0,0 +1,2 @@
+exclude :test_remove_comment_from_column, "The test fails because altered columns cannot change comments. We implement our own version."
+exclude :test_schema_dump_with_comments, "The test fails because altered columns cannot change comments. We implement our own version."

data/test/excludes/CoreTest.rb

@@ -0,0 +1 @@
+exclude :test_pretty_print_persisted, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/CreateOrFindByWithinTransactions.rb

@@ -0,0 +1,3 @@
+ref = "See issue https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/306"
+exclude :test_multiple_find_or_create_by_bang_within_transactions, ref
+exclude :test_multiple_find_or_create_by_within_transactions, ref

data/test/excludes/DefaultsUsingMultipleSchemasAndDomainTest.rb

@@ -0,0 +1,7 @@
+message = "Custom domains are not supported. See https://github.com/cockroachdb/cockroach/issues/27796"
+exclude :test_text_defaults_in_new_schema_when_overriding_domain, message
+exclude :test_string_defaults_in_new_schema_when_overriding_domain, message
+exclude :test_decimal_defaults_in_new_schema_when_overriding_domain, message
+exclude :test_bpchar_defaults_in_new_schema_when_overriding_domain, message
+exclude :test_text_defaults_after_updating_column_default, message
+exclude :test_default_containing_quote_and_colons, message

data/test/excludes/DirtyTest.rb

@@ -0,0 +1,3 @@
+exclude :test_field_named_field, "Rails transactional tests are being used while making schema changes. See https://www.cockroachlabs.com/docs/stable/online-schema-changes.html#limited-support-for-schema-changes-within-transactions."
+exclude :test_partial_update_with_optimistic_locking, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_virtual_attributes_are_not_written_with_partial_writes_off, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/EachTest.rb

@@ -0,0 +1,8 @@
+require "support/copy_cat"
+
+# CockroachDB doesn't update schema information when adding an
+# index until the transaction is done. Hence impossible to delete
+# this index before completion of the transaction.
+exclude_from_transactional_tests :test_in_batches_iterating_using_custom_columns
+exclude_from_transactional_tests :test_in_batches_with_custom_columns_raises_when_non_unique_columns
+exclude_from_transactional_tests :test_in_batches_when_loaded_iterates_using_custom_column

data/test/excludes/EagerLoadPolyAssocsTest.rb

@@ -0,0 +1 @@
+exclude :test_include_query, "The test setup doesn't properly handle random unique primary keys. This is a bug in ActiveRecord, so exclude the test until it's fixed there. See https://github.com/rails/rails/pull/38883. Note: any bug fix is unlikely to be backported to older versions of Rails."

data/test/excludes/ExplicitlyNamedIndexMigrationTest.rb

@@ -0,0 +1 @@
+exclude :test_drop_index_by_name, "This isn't supported by CockroachDB; see https://www.cockroachlabs.com/docs/stable/online-schema-changes.html#examples-of-statements-that-fail for more information"

data/test/excludes/FixturesResetPkSequenceTest.rb

@@ -0,0 +1,3 @@
+exclude "test_resets_to_min_pk_with_specified_pk_and_sequence", "This test doesn't work against CockroachDB because serial primary keys default to using unique_rowid() instead of a sequence. See https://www.cockroachlabs.com/docs/v19.2/serial.html#modes-of-operation"
+exclude "test_resets_to_min_pk_with_default_pk_and_sequence", "This test doesn't work against CockroachDB because serial primary keys default to using unique_rowid() instead of a sequence. See https://www.cockroachlabs.com/docs/v19.2/serial.html#modes-of-operation"
+exclude "test_create_fixtures_resets_sequences_when_not_cached", "This test doesn't work against CockroachDB because serial primary keys default to using unique_rowid() instead of a sequence. See https://www.cockroachlabs.com/docs/v19.2/serial.html#modes-of-operation"

data/test/excludes/FixturesTest.rb

@@ -0,0 +1,21 @@
+exclude :test_bulk_insert_multiple_table_with_a_multi_statement_query, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_bulk_insert_with_a_multi_statement_query_in_a_nested_transaction, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_clean_fixtures, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+exclude :test_auto_value_on_primary_key, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+exclude :test_multiple_clean_fixtures, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+exclude :test_bulk_insert_with_a_multi_statement_query_raises_an_exception_when_any_insert_fails, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+exclude :test_inserts_with_pre_and_suffix, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+exclude :test_create_symbol_fixtures, "Skipping the PostgreSQL test, but reimplemented for CockroachDB in test/cases/fixtures_test.rb"
+
+module Replacement
+  def test_insert_with_default_function
+    before = Time.now.utc
+    create_fixtures("aircrafts")
+    after = Time.now.utc
+
+    aircraft = Aircraft.find_by(name: "boeing-with-no-manufactured-at")
+    assert before <= aircraft.manufactured_at && aircraft.manufactured_at <= after
+  end
+end
+
+prepend Replacement

data/test/excludes/FixturesWithForeignKeyViolationsTest.rb

@@ -0,0 +1,2 @@
+exclude :test_raises_fk_violations, 'Re-implemented our own version that does not use transactional tests.'
+exclude :test_does_not_raise_if_no_fk_violations, 'Re-implemented our own version that does not use transactional tests.'

data/test/excludes/ForeignTableTest.rb

@@ -0,0 +1,10 @@
+exclude :test_attribute_names, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_foreign_tables, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_table_exists, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_attributes, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_update_record, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_delete_record, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_foreign_table_exists, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_insert_record, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_foreign_tables_are_valid_data_sources, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_does_not_have_a_primary_key, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/InheritanceComputeTypeTest.rb

@@ -0,0 +1 @@
+exclude :test_inheritance_new_with_subclass_as_default, "The test fails because type information is stripped from string column default values when the default is changed in the database. Possibly caused by https://github.com/cockroachdb/cockroach/issues/47285."

data/test/excludes/LeftOuterJoinAssociationTest.rb

@@ -0,0 +1,2 @@
+exclude :test_construct_finder_sql_applies_aliases_tables_on_association_conditions, "The test fails because the query result order is not guaranteed."
+exclude :test_does_not_override_select, "The select query fails because strings cannot be concated non-strings in CockroachDB."

data/test/excludes/LegacyPrimaryKeyTest/V4_2.rb

@@ -0,0 +1,6 @@
+exclude :test_legacy_primary_key_in_create_table_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_primary_key_should_be_auto_incremented, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_integer_primary_key_should_not_be_auto_incremented, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_add_column_with_legacy_primary_key_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_join_table_foreign_keys_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_primary_key_in_change_table_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/LegacyPrimaryKeyTest/V5_0.rb

@@ -0,0 +1,6 @@
+exclude :test_legacy_integer_primary_key_should_not_be_auto_incremented, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_primary_key_in_create_table_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_join_table_foreign_keys_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_primary_key_in_change_table_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_legacy_primary_key_should_be_auto_incremented, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_add_column_with_legacy_primary_key_should_be_integer, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/MarshalSerializationTest.rb

@@ -0,0 +1,4 @@
+exclude :test_deserializing_rails_6_1_marshal_basic, "This uses the adapter name to find a file. We run our own version that specifies which file to use."
+exclude :test_deserializing_rails_6_1_marshal_with_loaded_association_cache, "This uses the adapter name to find a file. We run our own version that specifies which file to use."
+exclude :test_deserializing_rails_7_1_marshal_basic, "This uses the adapter name to find a file. We run our own version that specifies which file to use."
+exclude :test_deserializing_rails_7_1_marshal_with_loaded_association_cache, "This uses the adapter name to find a file. We run our own version that specifies which file to use."

data/test/excludes/MaterializedViewTest.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+
+# Materialized views in CRDB do not show up in `pg_class` in
+# the transaction they are created. Try this again to see if
+# it changed:
+#
+# ```sql
+# BEGIN;
+# CREATE MATERIALIZED VIEW foo AS SELECT 1;
+# SELECT * FROM pg_class WHERE relname = 'foo';
+# ```
+self.use_transactional_tests = false

data/test/excludes/MigrationTest.rb

@@ -0,0 +1,2 @@
+exclude :test_add_table_with_decimals, "CockroachDB uses 64-bit signed integers, whereas the default for PG is 32-bit. The Rails test does not accommodate the 64-bit case"
+exclude :test_remove_column_with_if_not_exists_not_set, "We re-implement our own version. CockroachDB does not include the table name in a 'column does not exist' message."

data/test/excludes/MultiDbMigratorTest.rb

@@ -0,0 +1,2 @@
+# We can't add and remove a column in the same transaction with CockroachDB
+exclude_from_transactional_tests :test_internal_metadata_stores_environment

data/test/excludes/NestedRelationScopingTest.rb

@@ -0,0 +1 @@
+exclude :test_merge_options, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/OrTest.rb

@@ -0,0 +1 @@
+exclude :test_or_when_grouping, "This test produces a non-deterministic result. See rails/rails#38978 for fix; patch replicated in adapter test"

data/test/excludes/PersistenceTest.rb

@@ -0,0 +1,3 @@
+exclude :test_model_with_no_auto_populated_fields_still_returns_primary_key_after_insert, "This test is using PL-PGSQL not compatible with CockroachDB"
+exclude :test_reset_column_information_resets_children, "This test fails because the column is created in the same transaction in which the test attempts to assert/operate further."
+exclude :test_fills_auto_populated_columns_on_creation, "See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/308"

data/test/excludes/PessimisticLockingTest.rb

@@ -0,0 +1 @@
+exclude :test_lock_sending_custom_lock_statement, "NOWAIT lock wait policy is not supported by CockroachDB. See https://github.com/cockroachdb/cockroach/issues/40476."

data/test/excludes/PostgreSQLExplainTest.rb

@@ -0,0 +1,7 @@
+exclude :test_explain_with_eager_loading, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+exclude :test_explain_for_one_query, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"
+
+no_options = "Explain options are not yet supported by this adapter. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/301"
+exclude :test_explain_with_options_as_symbols, no_options
+exclude :test_explain_with_options_as_strings, no_options
+exclude :test_explain_options_with_eager_loading, no_options

data/test/excludes/PostgreSQLGeometricLineTest.rb

@@ -0,0 +1,3 @@
+exclude :test_geometric_line_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_alternative_format_line_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_schema_dumping_for_line_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."

data/test/excludes/PostgreSQLGeometricTypesTest.rb

@@ -0,0 +1,7 @@
+exclude :test_creating_column_with_point_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_line_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_lseg_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_box_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_path_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_polygon_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."
+exclude :test_creating_column_with_circle_type, "Geometric types are not supported in CockroachDB. See https://github.com/cockroachdb/cockroach/issues/21286."

data/test/excludes/PostgreSQLPartitionsTest.rb

@@ -0,0 +1 @@
+exclude :test_partitions_table_exists, "Skipping until we can triage further. See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48"

data/test/excludes/PostgreSQLReferentialIntegrityTest.rb

@@ -0,0 +1,14 @@
+exclude :test_should_reraise_invalid_foreign_key_exception_and_show_warning,
+    "CockroachDB has a different limitation as there is no " \
+    "'DISABLE TRIGGER' statement."
+
+break_tx = "CockroachDB will always alter transactions when " \
+  "trying to disable referential integrity. Either it cannot " \
+  "work within transaction, or autocommit_before_ddl is set " \
+  "and transactions will be committed."
+exclude :test_does_not_break_transactions, break_tx
+exclude :test_does_not_break_nested_transactions, break_tx
+
+exclude :test_only_catch_active_record_errors_others_bubble_up,
+    "Reimplemented in test/cases/adapters/cockroachdb/referential_integrity_test.rb" \
+    " to use a different trigger for the error."