activerecord-bogacs 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3da20a4a7e44c77643b1cf11b949e5fb818d43ca
-  data.tar.gz: 4bd02da78f04b586079c01ef3d3429d13821337e
+SHA256:
+  metadata.gz: 5010de8016e3c5896dc032a0fa6afc6ab5cbb1808f60e7c6f42b22b280910aeb
+  data.tar.gz: 3290de6d8265973c7efa237e18de7f96253580363b743785b069f34c5c92504a
 SHA512:
-  metadata.gz: bc86fe344a38859c20e2c41c4017a5d5e3d1c802a2879cc80376c8f9f286d7ec9496851217f98197869558edfb08aca4c37eab0c873a4b1538a6f2d1aadbd39b
-  data.tar.gz: 8de7842694c6ad26a9a904c0c8656dc5b1a6924771e3c8a106a53a917f82928a59bfec09123317c93813d89c9a009e1e99c392fa2549d0e6a23e71dc6c805a65
+  metadata.gz: 559b6831696d5e7ca408c735bc1f61bcb5c3fcfad19b0806aff943a47c623ac322462e79c3cefc1aca745df5cdda19986651c405e2024eebb8fa3c4cf02d7296
+  data.tar.gz: 588ccb8e705390652de5162a26cee060ce8fe51887693069602a55cfecfb19175b23268a821a7c956d7494d6be542f486c6bda89a4814932e8ee4249965a97de

data/.github/workflows/test.yml

@@ -0,0 +1,82 @@
+name: Test
+
+on: [push, pull_request]
+
+env:
+  JAVA_OPTS: '-XX:+TieredCompilation -XX:TieredStopAtLevel=1'
+
+jobs:
+
+  rake-test:
+    runs-on: ubuntu-latest
+    services:
+      mysql:
+        image: mysql:5.7
+        env:
+            MYSQL_ALLOW_EMPTY_PASSWORD: yes
+            MYSQL_ROOT_PASSWORD: root
+            MYSQL_DATABASE: ar_bogacs
+        ports:
+          - 3306:3306
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    env:
+      AR_ADAPTER: mysql2
+      AR_USERNAME: root
+      AR_PASSWORD: root
+      AR_HOST: 127.0.0.1
+      AR_VERSION: "~> 4.2"
+      HIKARI_VERSION: 2.3.12
+
+    strategy:
+      matrix:
+        java-version: [ 11 ]
+        ruby-version: [ jruby-9.3.6.0 ]
+        include:
+          - java-version: 11
+            ruby-version: jruby-9.2.20.1
+          - java-version: 11
+            ruby-version: jruby-9.2.10.0
+          - java-version: 17
+            ruby-version: jruby-9.2.20.1
+          - java-version: 8
+            ruby-version: jruby-9.2.9.0
+          - java-version: 8
+            ruby-version: jruby-9.1.17.0
+            env:
+              AR_VERSION: "~> 4.1.14"
+
+      fail-fast: false
+
+    steps:
+      - name: check mysql from host
+        run: |
+          sudo apt install -y mysql-client
+          mysql --host 127.0.0.1 --port 3306 -uroot -proot -e "SHOW DATABASES"
+
+      - name: checkout
+        uses: actions/checkout@v2
+
+      - name: set up java ${{ matrix.java-version }}
+        uses: actions/setup-java@v1.4.3
+        with:
+          java-version: ${{ matrix.java-version }}
+
+      - name: set up ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+
+      - name: install bundler
+        run: jruby -S gem install bundler -v "~>2.2.28"
+
+      - name: bundle install
+        run: jruby -S bundle install
+
+      - name: download jars
+        run: jruby -rbundler/setup -S rake tomcat:jndi:download tomcat:jdbc:download tomcat:dbcp:download hikari:download
+        shell: bash
+
+      - name: rake test
+        run: jruby -rbundler/setup -S rake test
+        shell: bash

data/.travis.yml

@@ -1,63 +1,61 @@
 language: ruby
 sudo: false
 jdk:
-  #- openjdk6
-  - oraclejdk7
+  - openjdk7
   - oraclejdk8
 rvm:
-  - jruby-1.7.24
-  #- 2.1.2
+  - jruby-1.7.25
 before_install:
-  - ((jruby -v | grep 1.8.7) && jruby --1.9 -S gem update --system 2.1.11) || true
+    - unset _JAVA_OPTIONS
+    - export AR_JDBC_VERSION="~> 1.3.24" # due the 50.0   release mess -> not specifying AR ~> 5.0
 before_script:
-  #- echo \"JRUBY_OPTS: $JRUBY_OPTS\"
-  - export JRUBY_OPTS="$JRUBY_OPTS --server -Xcext.enabled=false -Xcompile.invokedynamic=false"
   - export JAVA_OPTS="$JAVA_OPTS" # -Xmx600M
+  - 'echo "JAVA_OPTS: $JAVA_OPTS"'
+  - export JRUBY_OPTS="--server -Xcompile.invokedynamic=false"
+  - 'echo "JRUBY_OPTS: $JRUBY_OPTS"'
 script:
-  - bundle exec rake tomcat:jndi:download tomcat:jdbc:download tomcat:dbcp:download
-  - bundle exec rake c3p0:download
-  - bundle exec rake hikari:download
-  - bundle exec rake dbcp:download
-  - bundle exec rake db:create:mysql db:create:postgresql
+  - jruby -rbundler/setup -S rake tomcat:jndi:download tomcat:jdbc:download tomcat:dbcp:download
+  - jruby -rbundler/setup -S rake c3p0:download hikari:download dbcp:download
+  - jruby -rbundler/setup -S rake db:create:mysql db:create:postgresql
 env:
-  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.9" HIKARI_VERSION="2.3.12"
-  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.1.9" HIKARI_VERSION="2.3.2-java6"
-  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.11" HIKARI_VERSION="2.0.1-java6"
+  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.3.12"
+  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.3.2-java6"
+  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.0.1-java6"
   - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 3.2.18" HIKARI_VERSION="1.4.0"
-  - JRUBY_OPTS="--1.8 $JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 3.2.18" HIKARI_VERSION="2.2.5-java6"
+  - JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.2.8" HIKARI_VERSION="2.2.5-java6"
 matrix:
   #allow_failures:
     #- rvm: jruby-head
   exclude:
-    - rvm: jruby-1.7.24
-      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.9" HIKARI_VERSION="2.3.12"
-      jdk: oraclejdk7
-    - rvm: jruby-1.7.24
-      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.1.9" HIKARI_VERSION="2.3.2-java6"
+    - rvm: jruby-9.1.16.0
+      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="4.2.8" HIKARI_VERSION="2.3.12"
+      jdk: openjdk7
+    - rvm: jruby-9.1.16.0
+      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="4.2.8" HIKARI_VERSION="2.3.2-java6"
       jdk: oraclejdk8
-    - rvm: jruby-1.7.24
-      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.0.1-java6"
+    - rvm: jruby-1.7.25
+      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.16" HIKARI_VERSION="2.0.1-java6"
       jdk: oraclejdk8
-    - rvm: jruby-1.7.24
+    - rvm: jruby-1.7.25
       env: JRUBY_OPTS="--1.8 $JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 3.2.18" HIKARI_VERSION="2.2.5-java6"
       jdk: oraclejdk8
   include:
     - rvm: jruby-9.0.5.0
       env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.2.5-java6"
-      jdk: oraclejdk7
-    - rvm: jruby-9.1.2.0
+      jdk: openjdk7
+    - rvm: jruby-9.1.8.0
       env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 3.2.18" HIKARI_VERSION="2.3.9"
       jdk: oraclejdk8
     # AR 4.2
-    - rvm: jruby-1.7.22
+    - rvm: jruby-1.7.27
       env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.2.5-java6"
-      jdk: oraclejdk7
-    - rvm: jruby-9.1.2.0
-      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.2.4" HIKARI_VERSION="2.3.12"
+      jdk: openjdk7
+    - rvm: jruby-9.1.16.0
+      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=mysql AR_VERSION="~> 4.2.8" HIKARI_VERSION="2.3.12"
       jdk: oraclejdk8
-    - rvm: jruby-1.7.22
-      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.2.4" HIKARI_VERSION="2.2.5-java6"
+    - rvm: jruby-9.1.16.0
+      env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.2.8" HIKARI_VERSION="2.2.5-java6"
       jdk: oraclejdk8
-    - rvm: jruby-9.0.5.0
+    - rvm: jruby-9.1.16.0
       env: JRUBY_OPTS="$JRUBY_OPTS" AR_ADAPTER=postgresql AR_VERSION="~> 4.1.13" HIKARI_VERSION="2.3.12"
-      jdk: oraclejdk7
+      jdk: openjdk7

data/Gemfile

@@ -16,14 +16,6 @@ else
   gem 'activerecord', :require => nil
 end
 
-if RUBY_VERSION.index('1.8') == 0
-  gem 'i18n', '< 0.7.0' # Gem::InstallError: i18n requires Ruby version >= 1.9.3
-  gem 'atomic', '1.1.16' # concurrent-ruby gem only for Ruby version >= 1.9.3
-  gem 'thread_safe', '~> 0.3'
-else
-  gem 'concurrent-ruby', '~> 1.0.0', :require => nil
-end
-
 platform :jruby do
   if version = ENV['AR_JDBC_VERSION']
     if version.index('/') && ::File.exist?(version)
@@ -40,16 +32,11 @@ platform :jruby do
   end
 end
 
-#gem 'thread_safe', :require => nil # "optional" - we can roll without it
-
-if defined?(JRUBY_VERSION) && JRUBY_VERSION < '1.7.0'
-gem 'jruby-openssl', :platform => :jruby
-end
-
 group :test do
   gem 'jdbc-mysql', :require => nil, :platform => :jruby
   gem 'jdbc-postgres', :require => nil, :platform => :jruby
+  gem 'jdbc-sqlite3', :require => nil, :platform => :jruby
 
   gem 'mysql2', :require => nil, :platform => :mri
   gem 'pg', :require => nil, :platform => :mri
-end
+end

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013-2015 [Karol Bucek](http://kares.org)
+Copyright (c) 2013-2018 [Karol Bucek](http://kares.org)
 
 MIT License
 

data/README.md

@@ -6,7 +6,7 @@ ActiveRecord (all-year) pooling "alternatives" ... in a relaxed 'spa' fashion.
 
 Bogács is a village in Borsod-Abaúj-Zemplén county, Hungary.
 
-**WiP: do not put this on production if you do not understand the consequences!**
+**NOTE: do not put this on production if you do not understand the consequences!**
 
 ## Install
 
@@ -22,8 +22,8 @@ add this line to your application's *Gemfile*:
 
 Bogacs' pools rely on a small monkey-patch that allows to change the AR pool.
 The desired pool class needs to be set before `establish_connection` happens,
-thus an initializer won't work, you might consider setting the pool class at
-the bottom of your *application.rb* e.g. :
+thus an initializer (under Rails) won't work, you might consider setting the 
+pool class at the bottom of your *application.rb* e.g. :
 
 ```ruby
 Bundler.require(*Rails.groups)
@@ -34,29 +34,49 @@ module MyApp
   end
 end
 
-# sample AR-Bogacs setup using the "false" pool :
+# sample AR-Bogacs setup using the "default" pool :
 if Rails.env.production?
-  pool_class = ActiveRecord::Bogacs::FalsePool
+  pool_class = ActiveRecord::Bogacs::DefaultPool
   ActiveRecord::ConnectionAdapters::ConnectionHandler.connection_pool_class = pool_class
 end
 ```
 
-pools are expected to work with older ActiveRecord versions, if not let us know.
+Alternatively, for `FalsePool`, there's a configuration convention (no need to path 
+and set the connection_pool_class) :
+```yaml
+production:
+  adapter: mysql2
+  <% if $servlet_context %>
+  jndi: java:comp/env/jdbc/mydb
+  pool: false # use AR::Bogacs::FalsePool
+  <% else %>
+  port: <%= ENV['DATABASE_PORT'] || 3306 %>
+  database: mydb
+  # ...
+  <% end %>
+```
+
+This works only as long as one doesn't set a custom connection handler, since 
+*Bogacs* only sets up its custom `ActiveRecord::Base.default_connection_handler`.
+
+Pools are expected to work with older ActiveRecord versions: 3.x as well as 4.x.
 
-### Default Pool
+### [Default Pool][2]
 
-Meant as a back-port for users stuck with old Rails versions (< 4.0) on production,
-facing potential (pool related) concurrency bugs e.g. with high-loads under JRuby.
+Meant, primarily, as a back-port for users stuck with old Rails versions (< 4.0) 
+on production, facing potential (pool related) concurrency bugs e.g. with highly 
+concurrent loads under JRuby, although it also enhances some of the thread locking
+issues present in 4.x's pool. 
 
 Based on pool code from 4.x (which works much better than any previous version),
 with a few minor tunings and extensions such as `pool_initial: 0.5` which allows
 to specify how many connections to initialize in advance when the pool is created.
 
-### False Pool
+### [False Pool][3]
 
 The false pool won't do any actual pooling, it is assumed that an underlying pool
 is configured. Still, it does maintain a hash of AR connections mapped to threads.
-Ignores pool related configurations such as `pool: 42` or `checkout_timeout: 2.5`.
+Ignores pool related configuration such as `pool: 42` or `checkout_timeout: 2.5`.
 
 **NOTE:** be sure to configure an underlying pool e.g. with Trinidad (using the
 default Tomcat JDBC pool) :
@@ -70,7 +90,7 @@ default Tomcat JDBC pool) :
     mysql_dbpool:
       url: jdbc:mysql:///my_production
       username: root
-      jndi: jdbc/BogacsDB
+      jndi: jdbc/MyDB
       initialSize: <%= ENV['POOL_INITIAL'] || 25 %> # connections created on start
       maxActive: <%= ENV['POOL_SIZE'] || 100 %> # default 100 (AR pool: size)
       maxIdle: <%= ENV['POOL_SIZE'] || 100 %> # max connections kept in the pool
@@ -82,13 +102,13 @@ default Tomcat JDBC pool) :
       maxWait: <%= (( ENV['POOL_TIMEOUT'] || 5.0 ).to_f * 1000).to_i %> # default 30s
 ```
 
-ActiveRecord-JDBC adapter allows you to lookup connection from JNDI using the
+[ActiveRecord-JDBC][5] adapter allows you to lookup connection from JNDI using the
 following configuration :
 
 ```
 production:
   adapter: mysql2
-  jndi: java:/comp/env/jdbc/BogacsDB
+  jndi: java:/comp/env/jdbc/MyDB
 ```
 
 **NOTE:** when using `FalsePool` there's nothing to configure (in *database.yml*)!
@@ -97,7 +117,7 @@ production:
 
 This pool allows for a database connection to be "shared" among threads, this is
 very **dangerous** normally. You will need to understand the underlying driver's
-connection whether it is thread-safe.
+connection implementation (whether its thread-safe).
 
 You'll need to manually declare blocks that run with a shared connection (**make
 sure** only read operations happen within such blocks) similar to the built-in
@@ -109,15 +129,19 @@ cache_fetch( [ 'user', user_id ] ) do
 end
 ```
 
-The pool will only share connections among such blocks and only if it runs out
-of all connections (until than it will always prefer checking out a connection
-just like a "regular" pool).
+The pool "might" share connections among such blocks but only if it runs out of 
+all connections (pool size is reached), until than it will always prefer checking 
+out a connection just like `with_connection` does.
 
-Only tested with ActiveRecord-JDBC-Adapter using the official Postgres' driver.
+Tested with ActiveRecord-JDBC-Adapter using the official Postgres' driver (< 42).
 
 ## Copyright
 
-Copyright (c) 2015 [Karol Bucek](http://kares.org).
+Copyright (c) 2018 [Karol Bucek](http://kares.org).
 See LICENSE (http://en.wikipedia.org/wiki/MIT_License) for details.
 
-[0]: http://res.cloudinary.com/kares/image/upload/c_scale,h_600,w_800/v1406451696/bogacs.jpg
+[0]: http://res.cloudinary.com/kares/image/upload/c_scale,h_600,w_800/v1406451696/bogacs.jpg
+[1]: http://www.rubydoc.info/gems/activerecord-bogacs/
+[2]: http://www.rubydoc.info/gems/activerecord-bogacs/ActiveRecord/Bogacs/DefaultPool
+[3]: http://www.rubydoc.info/gems/activerecord-bogacs/ActiveRecord/Bogacs/FalsePool
+[5]: https://github.com/jruby/activerecord-jdbc-adapter

data/Rakefile

@@ -105,9 +105,11 @@ def _download(uri, download_dir, as_file_name)
   FileUtils.rm_r temp_dir
 end
 
+MAVEN_BASE_URL = 'https://repo.maven.apache.org/maven2'
+
 namespace :tomcat do
 
-  tomcat_maven_repo = 'http://repo2.maven.org/maven2/org/apache/tomcat'
+  tomcat_maven_repo = "#{MAVEN_BASE_URL}/org/apache/tomcat"
   download_dir = File.expand_path('test/jars', File.dirname(__FILE__))
   version_default = '7.0.64'
 
@@ -191,7 +193,7 @@ end
 
 namespace :dbcp do # a.k.a DBCP2
 
-  commons_repo = 'http://repo2.maven.org/maven2/org/apache/commons'
+  commons_repo = "#{MAVEN_BASE_URL}/org/apache/commons"
   download_dir = File.expand_path('test/jars', File.dirname(__FILE__))
   version_default = '2.0.1'
 
@@ -213,7 +215,7 @@ end
 
 namespace :c3p0 do
 
-  mchange_base_repo = 'http://repo2.maven.org/maven2/com/mchange'
+  mchange_base_repo = "#{MAVEN_BASE_URL}/com/mchange"
   download_dir = File.expand_path('test/jars', File.dirname(__FILE__))
   c3p0_version = '0.9.5'
   mchange_commons_version = '0.2.9'
@@ -242,9 +244,9 @@ end
 
 namespace :hikari do
 
-  hikari_base_repo = 'http://repo2.maven.org/maven2/com/zaxxer'
-  slf4j_base_repo = 'http://repo2.maven.org/maven2/org/slf4j'
-  javassist_base_repo = 'http://repo2.maven.org/maven2/org/javassist'
+  hikari_base_repo = "#{MAVEN_BASE_URL}/com/zaxxer"
+  slf4j_base_repo = "#{MAVEN_BASE_URL}/org/slf4j"
+  javassist_base_repo = "#{MAVEN_BASE_URL}/org/javassist"
   download_dir = File.expand_path('test/jars', File.dirname(__FILE__))
   hikari_version = '1.4.0'
   slf4j_version = '1.7.10'

data/activerecord-bogacs.gemspec

@@ -9,10 +9,9 @@ Gem::Specification.new do |gem|
   gem.authors = ['Karol Bucek']
   gem.email = ['self@kares.org']
   gem.description = %q{Improved ActiveRecord::ConnectionAdapters::ConnectionPool alternatives}
-  gem.summary = 'Bogacs contains several pool implementations that can be used as a replacement ' <<
-  "for ActiveRecord's built-in pool, e.g. DefaultPool is an upstream tuned version with an API " <<
-  'that is compatible with older AR versions.' <<
-  "\n\nNOTE: you'll need concurrent-ruby or thread_safe gem."
+  gem.summary = 'Bogacs contains several pool implementations that can be used as a replacement ' +
+  "for ActiveRecord's built-in pool, e.g. DefaultPool is an upstream tuned version with an API " +
+  'that is compatible with older AR versions.'
   gem.homepage = "http://github.com/kares/activerecord-bogacs"
   gem.licenses = ['MIT']
 
@@ -21,8 +20,9 @@ Gem::Specification.new do |gem|
   gem.test_files = gem.files.grep(%r{^test/})
   gem.require_paths = ["lib"]
 
-  gem.add_development_dependency 'concurrent-ruby', '>= 0.9' if RUBY_VERSION.index('1.8') != 0
+  gem.add_dependency 'activerecord', '< 6' # '>= 4.0' # depends on: concurrent-ruby ~> 1.0, >= 1.0.2
+  gem.add_dependency 'concurrent-ruby', '~> 1.0'
 
-  gem.add_development_dependency 'rake', '~> 10.3'
+  gem.add_development_dependency 'rake'
   gem.add_development_dependency 'test-unit', '~> 2.5'
 end

data/lib/active_record/bogacs/autoload.rb

@@ -0,0 +1,10 @@
+module ActiveRecord
+  module Bogacs
+    autoload :DefaultPool, 'active_record/bogacs/default_pool'
+    autoload :FalsePool, 'active_record/bogacs/false_pool'
+    autoload :ShareablePool, 'active_record/bogacs/shareable_pool'
+    autoload :Reaper, 'active_record/bogacs/reaper'
+    autoload :Validator, 'active_record/bogacs/validator'
+  end
+  autoload :SharedConnection, 'active_record/shared_connection'
+end

data/lib/active_record/bogacs/connection_handler.rb

@@ -0,0 +1,36 @@
+require 'active_record/version'
+
+require 'active_record/connection_adapters/abstract/connection_pool'
+
+module ActiveRecord
+  module Bogacs
+    class ConnectionHandler < ConnectionAdapters::ConnectionHandler
+
+      if ActiveRecord::VERSION::MAJOR < 5
+
+        def establish_connection(owner, spec)
+          @class_to_pool.clear
+          if spec.config[:pool].eql? false
+            owner_to_pool[owner.name] = ActiveRecord::Bogacs::FalsePool.new(spec)
+          else # super
+            owner_to_pool[owner.name] = ActiveRecord::ConnectionAdapters::ConnectionPool.new(spec)
+          end
+        end
+
+      else
+
+        def establish_connection(config) # (spec) in 5.0
+          pool = super
+          spec = pool.spec
+          if spec.config[:pool].eql? false
+            owner_to_pool[spec.name] = ActiveRecord::Bogacs::FalsePool.new(spec)
+          else
+            pool
+          end
+        end
+
+      end
+
+    end
+  end
+end