activerecord-bitemporal 5.0.0 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25ef613d84eda786e3d04e90aeb9cc95b68887a84863200aa0622be9e89c73ea
-  data.tar.gz: 63920865d4f8f27703b6ffeaf4e0c38d297ea4bff22bf01a3884136875b2ccde
+  metadata.gz: 682d7ade7951759a2237d6395aab4dccc06d5c5ea6d1820b20e1bd1301d2efc7
+  data.tar.gz: a58bb4c8b01a5f7724ad367ab69e45a54f715b96a0d789e7690689798d0f0a88
 SHA512:
-  metadata.gz: 6fbe2830897e6c3f70f29431f591e8fa9cd332ae260e23ef3c23b7afff7259819bc54b8bb9de38d26c07a96c1cd3e93af5f5b7b559d2814b61b3cabfb3dcb2a6
-  data.tar.gz: 3e45d6a45de435475388a77a534521049b603bddc5910046fc5b8f4c2577ad25e75387f397014374d94b4d3c515c4e4456ff76c4673952f06b497446166a7927
+  metadata.gz: a1761e5e97fc83beac29d7e23edec2ab5bb4d02958b5a7600073b099ca800a6ad3ffa3f8f9bc423aafb412c4c11a2bb1cb03d09d4fd36b6d77e7dd02560a9493
+  data.tar.gz: efc543c3eb6b2ab89d3556eb25f342983d8e5854ebbec77ee6cf853c01dd0ccd64945264c53f30bacb9d370a6083ba65b3791e88b26c0c5c4ecea4481ad66e0c

data/.github/auto_assign.yml

@@ -6,15 +6,10 @@ addAssignees: false
 
 # A list of reviewers to be added to pull requests (GitHub user name)
 reviewers:
-  - Dooor
-  - QWYNG
-  - bonobono555
   - krororo
   - lighty
   - mkmn
-  - motsat
   - osyo-manga
-  - wakasa51
   - wata727
   - yono
 

data/CHANGELOG.md

@@ -1,5 +1,30 @@
 # Changelog
 
+## 5.1.0
+
+### Added
+
+### Changed
+
+### Deprecated
+
+### Removed
+
+### Fixed
+
+- [Remove `joinable: false` #156](https://github.com/kufu/activerecord-bitemporal/pull/156)
+
+### Chores
+
+- [Remove database_cleaner #162](https://github.com/kufu/activerecord-bitemporal/pull/162)
+
+## 5.0.1
+
+- [Fix a typo #157](https://github.com/kufu/activerecord-bitemporal/pull/157)
+- [Remove unneeded unscope values #159](https://github.com/kufu/activerecord-bitemporal/pull/159)
+- [Remove unused `without_ignore` option #160](https://github.com/kufu/activerecord-bitemporal/pull/160)
+- [update auto assign #161](https://github.com/kufu/activerecord-bitemporal/pull/161)
+
 ## 5.0.0
 
 ### Breaking Changed

data/activerecord-bitemporal.gemspec

@@ -31,6 +31,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pg"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-byebug"
-  spec.add_development_dependency "database_cleaner"
   spec.add_development_dependency "timecop"
 end

data/lib/activerecord-bitemporal/bitemporal.rb

@@ -359,7 +359,7 @@ module ActiveRecord
       def destroy(force_delete: false, operated_at: nil)
         return super() if force_delete
 
-        ActiveRecord::Base.transaction(requires_new: true, joinable: false) do
+        ActiveRecord::Base.transaction(requires_new: true) do
           @destroyed = false
           _run_destroy_callbacks {
             operated_at ||= Time.current
@@ -577,7 +577,7 @@ module ActiveRecord
             target_datetime
           # NOTE: 新規作成時以外では target_datetime の値を基準としてバリデーションする
           # 更新時にバリデーションする場合、valid_from の時間ではなくて target_datetime の時間を基準としているため
-          # valdi_from を基準としてしまうと整合性が取れなくなってしまう
+          # valid_from を基準としてしまうと整合性が取れなくなってしまう
           elsif !record.new_record?
             target_datetime
           else

data/lib/activerecord-bitemporal/scope.rb

@@ -259,7 +259,7 @@ module ActiveRecord::Bitemporal
               :gteq   # column >= datetime
             ].each { |op|
               module_eval <<-STR, __FILE__, __LINE__ + 1
-                def _#{column}_#{op}(datetime,**)
+                def _#{column}_#{op}(datetime)
                   target_datetime = datetime&.in_time_zone || Time.current
                   bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime)
                     .tap { |relation| break relation.bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime, bitemporal_value[:through].arel_table) if bitemporal_value[:through] }
@@ -355,14 +355,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_transaction_datetime] = :default_scope
           end
 
-          # Calling scope was slow, so don't call scope
-          relation.unscope_values += [
-            { where: "#{table.name}.transaction_from" },
-            { where: "#{table.name}.transaction_to" }
-          ]
           relation = relation
-            ._transaction_from_lteq(transaction_datetime || datetime, without_ignore: true)
-            ._transaction_to_gt(transaction_datetime || datetime, without_ignore: true)
+            ._transaction_from_lteq(transaction_datetime || datetime)
+            ._transaction_to_gt(transaction_datetime || datetime)
         else
           relation.tap { |relation| relation.without_transaction_datetime unless ActiveRecord::Bitemporal.transaction_datetime }
         end
@@ -375,13 +370,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_valid_datetime] = :default_scope
           end
 
-          relation.unscope_values += [
-            { where: "#{table.name}.valid_from" },
-            { where: "#{table.name}.valid_to" }
-          ]
           relation = relation
-            ._valid_from_lteq(valid_datetime || datetime, without_ignore: true)
-            ._valid_to_gt(valid_datetime || datetime, without_ignore: true)
+            ._valid_from_lteq(valid_datetime || datetime)
+            ._valid_to_gt(valid_datetime || datetime)
         else
           relation.tap { |relation| relation.without_valid_datetime unless ActiveRecord::Bitemporal.valid_datetime }
         end

data/lib/activerecord-bitemporal/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Bitemporal
-    VERSION = "5.0.0"
+    VERSION = "5.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-bitemporal
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.1.0
 platform: ruby
 authors:
 - SmartHR
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-02-02 00:00:00.000000000 Z
+date: 2024-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -108,20 +108,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: database_cleaner
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -190,7 +176,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: BiTemporal Data Model for ActiveRecord