activerecord-bitemporal 4.3.0 → 5.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff0157d808949658d0eb00a07b819670383ace1c7896537f6b6e5dfeda9e6c32
-  data.tar.gz: 1e14b06aac74ca12b3db6ee75144078eef8e793eda6048c7179fd8ef3025b01d
+  metadata.gz: f0e6cafe3d918cd4bdf47c2610eaf3760cfcedbec0365a7675ef99790a05baaf
+  data.tar.gz: 79b7823949b22cbcacdfb75b561c70808135ebd3dc1c6a5ff0ef8152c75b8d79
 SHA512:
-  metadata.gz: 6e6ba80c96e30d975d5a1fe5edff0f631e8e4793d98c97e0c859d57948f5919d5aa47ab2990a456712888e8e25913bb370fc0bf3640c9d04eef3686774a00370
-  data.tar.gz: cd5d42d05eb0efe13355906b1547f86605aa1e327d1fae87aebb83475c4fe4162f2cba00875e92e6dcc497451d8a6c0bbe8bfffcbad543c972e5b229a05d0a60
+  metadata.gz: 4331c2b17a26dfea76b5c1c85a6a0feac925a1c0b7d634fa734e35e5f7732e0d49d04172ae4bf6af5ae62b213481bd09da7807312f241578e72f2a9ee952f640
+  data.tar.gz: 98ffa072e196a6af9b61ef01ee5e7d8e3ef83a94abd8f666738831783b35bb16551fd0bd1d561f76a6a55aa522d4609274ec3e6a6a78d311b7c76e53c860b1c4

data/.circleci/config.yml

@@ -9,13 +9,14 @@ jobs:
         type: string
     docker:
       - image: ruby:<< parameters.ruby-version >>
+        environment:
+          BUNDLE_GEMFILE: gemfiles/<< parameters.gemfile >>.gemfile
       - image: cimg/postgres:11.16
     steps:
       - checkout
       - run: gem install bundler
       - run: bundle install
-      - run: bundle exec appraisal << parameters.gemfile >> bundle install
-      - run: bundle exec appraisal << parameters.gemfile >> rspec
+      - run: bundle exec rspec
 
 workflows:
   test:
@@ -24,16 +25,17 @@ workflows:
           matrix:
             parameters:
               ruby-version:
-                - '2.7'
                 - '3.0'
                 - '3.1'
+                - '3.2'
+                - '3.3'
               gemfile:
-                - rails-6.0
-                - rails-6.1
-                - rails-7.0
-                - rails-main
+                - rails_6.1
+                - rails_7.0
+                - rails_7.1
+                - rails_main
             exclude:
-              - ruby-version: '3.0'
-                gemfile: rails-6.0
-              - ruby-version: '3.1'
-                gemfile: rails-6.0
+              - ruby-version: '3.2'
+                gemfile: rails_6.1
+              - ruby-version: '3.3'
+                gemfile: rails_6.1

data/.github/auto_assign.yml

@@ -6,15 +6,10 @@ addAssignees: false
 
 # A list of reviewers to be added to pull requests (GitHub user name)
 reviewers:
-  - Dooor
-  - QWYNG
-  - bonobono555
   - krororo
   - lighty
   - mkmn
-  - motsat
   - osyo-manga
-  - wakasa51
   - wata727
   - yono
 

data/Appraisals

@@ -4,10 +4,6 @@ appraise "rails-main" do
   gem "rails", git: 'https://github.com/rails/rails.git', branch: "main"
 end
 
-appraise "rails-6.0" do
-  gem "rails", "~> 6.0.2"
-end
-
 appraise "rails-6.1" do
   gem "rails", "~> 6.1.0"
 end
@@ -15,3 +11,7 @@ end
 appraise "rails-7.0" do
   gem "rails", "~> 7.0.1"
 end
+
+appraise "rails-7.1" do
+  gem "rails", "~> 7.1.0"
+end

data/CHANGELOG.md

@@ -1,5 +1,39 @@
 # Changelog
 
+## 5.0.1
+
+- [Fix a typo #157](https://github.com/kufu/activerecord-bitemporal/pull/157)
+- [Remove unneeded unscope values #159](https://github.com/kufu/activerecord-bitemporal/pull/159)
+- [Remove unused `without_ignore` option #160](https://github.com/kufu/activerecord-bitemporal/pull/160)
+- [update auto assign #161](https://github.com/kufu/activerecord-bitemporal/pull/161)
+
+## 5.0.0
+
+### Breaking Changed
+
+- [CI against Ruby 3.2, 3.3, Drop Ruby 2.7 and Rails 6.0 #150](https://github.com/kufu/activerecord-bitemporal/pull/150)
+
+### Added
+
+- [Support date type of valid time #149](https://github.com/kufu/activerecord-bitemporal/pull/149)
+- [Add support Rails 7.1 #151](https://github.com/kufu/activerecord-bitemporal/pull/151)
+- [Add Persistence#bitemporal_at and ActiveRecord::Bitemporal.bitemporal_at #152](https://github.com/kufu/activerecord-bitemporal/pull/152)
+
+### Changed
+
+### Deprecated
+
+### Removed
+
+### Fixed
+
+- [Fix deleted time order between associations #154](https://github.com/kufu/activerecord-bitemporal/pull/154)
+
+### Chores
+
+- [Don't use appraisal in CI #145](https://github.com/kufu/activerecord-bitemporal/pull/145)
+- [Remove code for Active Record 6.0 #153](https://github.com/kufu/activerecord-bitemporal/pull/153)
+
 ## 4.3.0
 
 ### Added

data/activerecord-bitemporal.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.description   = %q{Enable ActiveRecord models to be handled as BiTemporal Data Model.}
   spec.homepage      = "https://github.com/kufu/activerecord-bitemporal"
   spec.license       = "Apache 2.0"
-  spec.required_ruby_version = ">= 2.7.0"
+  spec.required_ruby_version = ">= 3.0"
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activerecord", ">= 6.0"
+  spec.add_dependency "activerecord", ">= 6.1"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", "~> 13.0"

data/gemfiles/{rails_6.0.gemfile → rails_7.1.gemfile}

@@ -3,6 +3,6 @@
 source "https://rubygems.org"
 
 gem "appraisal"
-gem "rails", "~> 6.0.2"
+gem "rails", "~> 7.1.0"
 
 gemspec path: "../"

data/lib/activerecord-bitemporal/bitemporal.rb

@@ -68,6 +68,10 @@ module ActiveRecord
           bitemporal_option[:valid_datetime]&.in_time_zone
         end
 
+        def valid_date
+          valid_datetime&.to_date
+        end
+
         def ignore_valid_datetime(&block)
           with_bitemporal_option(ignore_valid_datetime: true, valid_datetime: nil, &block)
         end
@@ -88,6 +92,14 @@ module ActiveRecord
           with_bitemporal_option(ignore_transaction_datetime: true, transaction_datetime: nil, &block)
         end
 
+        def bitemporal_at(datetime, &block)
+          transaction_at(datetime) { valid_at(datetime, &block) }
+        end
+
+        def bitemporal_at!(datetime, &block)
+          transaction_at!(datetime) { valid_at!(datetime, &block) }
+        end
+
         def merge_by(option)
           option_ = option.dup
           if bitemporal_option_storage[:force_valid_datetime]
@@ -224,6 +236,10 @@ module ActiveRecord
           with_bitemporal_option(transaction_datetime: datetime, &block)
         end
 
+        def bitemporal_at(datetime, &block)
+          transaction_at(datetime) { valid_at(datetime, &block) }
+        end
+
         def bitemporal_option_merge_with_association!(other)
           bitemporal_option_merge!(other)
 
@@ -238,6 +254,10 @@ module ActiveRecord
           bitemporal_option[:valid_datetime]&.in_time_zone
         end
 
+        def valid_date
+          valid_datetime&.to_date
+        end
+
         def transaction_datetime
           bitemporal_option[:transaction_datetime]&.in_time_zone
         end
@@ -336,16 +356,17 @@ module ActiveRecord
         end || false
       end
 
-      def destroy(force_delete: false, operated_at: Time.current)
+      def destroy(force_delete: false, operated_at: nil)
         return super() if force_delete
 
-        target_datetime = valid_datetime || operated_at
-
-        duplicated_instance = self.class.find_at_time(target_datetime, self.id).dup
-
         ActiveRecord::Base.transaction(requires_new: true, joinable: false) do
           @destroyed = false
           _run_destroy_callbacks {
+            operated_at ||= Time.current
+            target_datetime = valid_datetime || operated_at
+
+            duplicated_instance = self.class.find_at_time(target_datetime, self.id).dup
+
             @destroyed = update_transaction_to(operated_at)
             @previously_force_updated = force_update?
 
@@ -375,6 +396,18 @@ module ActiveRecord
         false
       end
 
+      if Gem::Version.new("7.1.0") <= ActiveRecord.version
+        # MEMO: Since Rails 7.1 #_find_record refers to a record with find_by!(@primary_key => id)
+        #       But if @primary_key is "id", it can't refer to the intended record, so we hack it to refer to the record based on self.class.bitemporal_id_key
+        #       see: https://github.com/rails/rails/blob/v7.1.0/activerecord/lib/active_record/persistence.rb#L1152-#L1171
+        def _find_record(*)
+          tmp_primary_key, @primary_key = @primary_key, self.class.bitemporal_id_key
+          super
+        ensure
+          @primary_key = tmp_primary_key
+        end
+      end
+
       module ::ActiveRecord::Persistence
         # MEMO: Must be override ActiveRecord::Persistence#reload
         alias_method :active_record_bitemporal_original_reload, :reload unless method_defined? :active_record_bitemporal_original_reload
@@ -403,7 +436,7 @@ module ActiveRecord
             @previously_force_updated = false
             self
           end
-        elsif Gem::Version.new("6.1.0") <= ActiveRecord.version
+        else
           def reload(options = nil)
             return active_record_bitemporal_original_reload(options) unless self.class.bi_temporal_model?
 
@@ -427,29 +460,6 @@ module ActiveRecord
             @previously_force_updated = false
             self
           end
-        else
-          def reload(options = nil)
-            return active_record_bitemporal_original_reload(options) unless self.class.bi_temporal_model?
-
-            self.class.connection.clear_query_cache
-
-            fresh_object =
-              ActiveRecord::Bitemporal.with_bitemporal_option(**bitemporal_option) {
-                if options && options[:lock]
-                  self.class.unscoped { self.class.lock(options[:lock]).bitemporal_default_scope.find(id) }
-                else
-                  self.class.unscoped { self.class.bitemporal_default_scope.find(id) }
-                end
-              }
-
-            @attributes = fresh_object.instance_variable_get("@attributes")
-            @new_record = false
-            # NOTE: Hook to copying swapped_id
-            @_swapped_id_previously_was = nil
-            @_swapped_id = fresh_object.swapped_id
-            @previously_force_updated = false
-            self
-          end
         end
       end
 
@@ -567,7 +577,7 @@ module ActiveRecord
             target_datetime
           # NOTE: 新規作成時以外では target_datetime の値を基準としてバリデーションする
           # 更新時にバリデーションする場合、valid_from の時間ではなくて target_datetime の時間を基準としているため
-          # valdi_from を基準としてしまうと整合性が取れなくなってしまう
+          # valid_from を基準としてしまうと整合性が取れなくなってしまう
           elsif !record.new_record?
             target_datetime
           else
@@ -579,10 +589,13 @@ module ActiveRecord
         valid_from = record.valid_from if record.force_update?
 
         valid_to = record.valid_to.yield_self { |valid_to|
+          # NOTE: `cover?` may give incorrect results, when the time zone is not UTC and `valid_from` is date type
+          #   Therefore, cast to type of `valid_from`
+          record_valid_time = finder_class.type_for_attribute(:valid_from).cast(record.valid_datetime)
           # レコードを更新する時に valid_datetime が valid_from ~ valid_to の範囲外だった場合、
           #   一番近い未来の履歴レコードを参照して更新する
           # という仕様があるため、それを考慮して valid_to を設定する
-          if (record.valid_datetime && (record.valid_from..record.valid_to).cover?(record.valid_datetime)) == false && (record.persisted?)
+          if (record_valid_time && (record.valid_from..record.valid_to).cover?(record_valid_time)) == false && (record.persisted?)
             finder_class.ignore_valid_datetime.where(bitemporal_id: record.bitemporal_id).valid_from_gt(target_datetime).order(valid_from: :asc).first.valid_from
           else
             valid_to

data/lib/activerecord-bitemporal/scope.rb

@@ -47,26 +47,9 @@ module ActiveRecord::Bitemporal
           end
         }
 
-        def each_operatable_node_6_0(nodes = predicates, &block)
+        def each_operatable_node(nodes = predicates, &block)
           if block
             each_operatable_node(nodes).each(&block)
-          else
-            Enumerator.new { |y|
-              Array(nodes).each { |node|
-                case node
-                when Arel::Nodes::LessThan, Arel::Nodes::LessThanOrEqual, Arel::Nodes::GreaterThan, Arel::Nodes::GreaterThanOrEqual
-                  y << node if node && node.left.respond_to?(:relation)
-                when Arel::Nodes::Grouping
-                  each_operatable_node(node.expr) { |node| y << node }
-                end
-              }
-            }
-          end
-        end
-
-        def each_operatable_node_6_1(nodes = predicates, &block)
-          if block
-            each_operatable_node_6_1(nodes).each(&block)
           else
             Enumerator.new { |y|
               Array(nodes).each { |node|
@@ -74,26 +57,18 @@ module ActiveRecord::Bitemporal
                 when Arel::Nodes::LessThan, Arel::Nodes::LessThanOrEqual, Arel::Nodes::GreaterThan, Arel::Nodes::GreaterThanOrEqual
                   y << node if node && node.left.respond_to?(:relation)
                 when Arel::Nodes::And
-                  each_operatable_node_6_1(node.children) { |node| y << node }
+                  each_operatable_node(node.children) { |node| y << node }
                 when Arel::Nodes::Binary
-                  each_operatable_node_6_1(node.left) { |node| y << node }
-                  each_operatable_node_6_1(node.right) { |node| y << node }
+                  each_operatable_node(node.left) { |node| y << node }
+                  each_operatable_node(node.right) { |node| y << node }
                 when Arel::Nodes::Unary
-                  each_operatable_node_6_1(node.expr) { |node| y << node }
+                  each_operatable_node(node.expr) { |node| y << node }
                 end
               }
             }
           end
         end
 
-        def each_operatable_node(nodes = predicates, &block)
-          if Gem::Version.new("6.1.0") <= ActiveRecord.version
-            each_operatable_node_6_1(nodes, &block)
-          else
-            each_operatable_node_6_0(nodes, &block)
-          end
-        end
-
         def bitemporal_query_hash(*names)
           each_operatable_node
             .select { |node| names.include? node.left.name.to_s }
@@ -126,31 +101,6 @@ module ActiveRecord::Bitemporal
       end
     }
 
-    if ActiveRecord.version < Gem::Version.new("6.1.0")
-      class WhereClauseWithCheckTable < ActiveRecord::Relation::WhereClause
-        using NodeBitemporalInclude
-
-        def bitemporal_include?(column)
-          !!predicates.grep(::Arel::Nodes::Node).find do |node|
-            node.bitemporal_include?(column)
-          end
-        end
-
-        private
-
-        def except_predicates(columns)
-          columns = Array(columns)
-          predicates.reject do |node|
-            ::Arel::Nodes::Node === node && node.bitemporal_include?(*columns)
-          end
-        end
-      end
-
-      def where_clause
-        WhereClauseWithCheckTable.new(super.send(:predicates))
-      end
-    end
-
     module MergeWithExceptBitemporalDefaultScope
       using BitemporalChecker
       def merge(other)
@@ -166,6 +116,10 @@ module ActiveRecord::Bitemporal
       bitemporal_clause[:valid_datetime]&.in_time_zone
     end
 
+    def valid_date
+      valid_datetime&.to_date
+    end
+
     def transaction_datetime
       bitemporal_clause[:transaction_datetime]&.in_time_zone
     end
@@ -239,118 +193,80 @@ module ActiveRecord::Bitemporal
         end
       }
 
-      if ActiveRecord.version < Gem::Version.new("6.1.0")
-        module ActiveRecordRelationScope
-          refine ::ActiveRecord::Relation do
-            %i(valid_from valid_to transaction_from transaction_to).each { |column|
-              module_eval <<-STR, __FILE__, __LINE__ + 1
-                def _ignore_#{column}
-                  unscope(where: "\#{table.name}.#{column}")
-                    .tap { |relation| relation.merge!(bitemporal_value[:through].unscoped._ignore_#{column}) if bitemporal_value[:through] }
-                end
-
-                def _except_#{column}
-                  return self unless where_clause.bitemporal_include?("\#{table.name}.#{column}")
-                  all._ignore_#{column}.tap { |relation|
-                    relation.unscope_values.delete({ where: "\#{table.name}.#{column}" })
-                  }
-                end
-              STR
-
-              [
-                :lt,    # column <  datetime
-                :lteq,  # column <= datetime
-                :gt,    # column >  datetime
-                :gteq   # column >= datetime
-              ].each { |op|
-                module_eval <<-STR, __FILE__, __LINE__ + 1
-                  def _#{column}_#{op}(datetime, without_ignore: false)
-                    target_datetime = datetime&.in_time_zone || Time.current
-                    relation = self.tap { |relation| break relation._ignore_#{column} unless without_ignore }
-                    relation.bitemporal_where_bind!(:#{column}, :#{op}, target_datetime)
-                      .tap { |relation| relation.merge!(bitemporal_value[:through].unscoped._#{column}_#{op}(target_datetime)) if bitemporal_value[:through] }
-                  end
-                STR
-              }
-            }
-          end
-        end
-      else
-        module ActiveRecordRelationScope
-          module EqualAttributeName
-            refine ::Object do
-              def equal_attribute_name(*)
-                false
-              end
+      module ActiveRecordRelationScope
+        module EqualAttributeName
+          refine ::Object do
+            def equal_attribute_name(*)
+              false
             end
-            refine ::Hash do
-              def equal_attribute_name(other)
-                self[:where].equal_attribute_name(other)
-              end
+          end
+          refine ::Hash do
+            def equal_attribute_name(other)
+              self[:where].equal_attribute_name(other)
             end
-            refine ::Array do
-              def equal_attribute_name(other)
-                first.equal_attribute_name(other)
-              end
+          end
+          refine ::Array do
+            def equal_attribute_name(other)
+              first.equal_attribute_name(other)
             end
-            refine ::String do
-              def equal_attribute_name(other)
-                self == other.to_s
-              end
+          end
+          refine ::String do
+            def equal_attribute_name(other)
+              self == other.to_s
             end
-            refine ::Symbol do
-              def equal_attribute_name(other)
-                self.to_s == other.to_s
-              end
+          end
+          refine ::Symbol do
+            def equal_attribute_name(other)
+              self.to_s == other.to_s
             end
-            refine ::Arel::Attributes::Attribute do
-              def equal_attribute_name(other)
-                "#{relation.name}.#{name}" == other.to_s
-              end
+          end
+          refine ::Arel::Attributes::Attribute do
+            def equal_attribute_name(other)
+              "#{relation.name}.#{name}" == other.to_s
             end
           end
+        end
 
-          refine ::ActiveRecord::Relation do
-            using EqualAttributeName
-            using NodeBitemporalInclude
+        refine ::ActiveRecord::Relation do
+          using EqualAttributeName
+          using NodeBitemporalInclude
 
-            def bitemporal_rewhere_bind(attr_name, operator, value, table = self.table)
-              rewhere(table[attr_name].public_send(operator, predicate_builder.build_bind_attribute(attr_name, value)))
-            end
+          def bitemporal_rewhere_bind(attr_name, operator, value, table = self.table)
+            rewhere(table[attr_name].public_send(operator, predicate_builder.build_bind_attribute(attr_name, value)))
+          end
 
-            %i(valid_from valid_to transaction_from transaction_to).each { |column|
-              module_eval <<-STR, __FILE__, __LINE__ + 1
-                def _ignore_#{column}
-                  unscope(where: :"\#{table.name}.#{column}")
-                    .tap { |relation| relation.unscope!(where: bitemporal_value[:through].arel_table["#{column}"]) if bitemporal_value[:through] }
-                end
+          %i(valid_from valid_to transaction_from transaction_to).each { |column|
+            module_eval <<-STR, __FILE__, __LINE__ + 1
+              def _ignore_#{column}
+                unscope(where: :"\#{table.name}.#{column}")
+                  .tap { |relation| relation.unscope!(where: bitemporal_value[:through].arel_table["#{column}"]) if bitemporal_value[:through] }
+              end
 
-                def _except_#{column}
-                  return self unless where_clause.send(:predicates).find { |node|
-                    node.bitemporal_include?("\#{table.name}.#{column}")
-                  }
-                  _ignore_#{column}.tap { |relation|
-                    relation.unscope_values.reject! { |query| query.equal_attribute_name("\#{table.name}.#{column}") }
-                  }
+              def _except_#{column}
+                return self unless where_clause.send(:predicates).find { |node|
+                  node.bitemporal_include?("\#{table.name}.#{column}")
+                }
+                _ignore_#{column}.tap { |relation|
+                  relation.unscope_values.reject! { |query| query.equal_attribute_name("\#{table.name}.#{column}") }
+                }
+              end
+            STR
+
+            [
+              :lt,    # column <  datetime
+              :lteq,  # column <= datetime
+              :gt,    # column >  datetime
+              :gteq   # column >= datetime
+            ].each { |op|
+              module_eval <<-STR, __FILE__, __LINE__ + 1
+                def _#{column}_#{op}(datetime)
+                  target_datetime = datetime&.in_time_zone || Time.current
+                  bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime)
+                    .tap { |relation| break relation.bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime, bitemporal_value[:through].arel_table) if bitemporal_value[:through] }
                 end
               STR
-
-              [
-                :lt,    # column <  datetime
-                :lteq,  # column <= datetime
-                :gt,    # column >  datetime
-                :gteq   # column >= datetime
-              ].each { |op|
-                module_eval <<-STR, __FILE__, __LINE__ + 1
-                  def _#{column}_#{op}(datetime,**)
-                    target_datetime = datetime&.in_time_zone || Time.current
-                    bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime)
-                      .tap { |relation| break relation.bitemporal_rewhere_bind("#{column}", :#{op}, target_datetime, bitemporal_value[:through].arel_table) if bitemporal_value[:through] }
-                  end
-                STR
-              }
             }
-          end
+          }
         end
       end
       using ActiveRecordRelationScope
@@ -439,14 +355,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_transaction_datetime] = :default_scope
           end
 
-          # Calling scope was slow, so don't call scope
-          relation.unscope_values += [
-            { where: "#{table.name}.transaction_from" },
-            { where: "#{table.name}.transaction_to" }
-          ]
           relation = relation
-            ._transaction_from_lteq(transaction_datetime || datetime, without_ignore: true)
-            ._transaction_to_gt(transaction_datetime || datetime, without_ignore: true)
+            ._transaction_from_lteq(transaction_datetime || datetime)
+            ._transaction_to_gt(transaction_datetime || datetime)
         else
           relation.tap { |relation| relation.without_transaction_datetime unless ActiveRecord::Bitemporal.transaction_datetime }
         end
@@ -459,13 +370,9 @@ module ActiveRecord::Bitemporal
             relation.bitemporal_value[:with_valid_datetime] = :default_scope
           end
 
-          relation.unscope_values += [
-            { where: "#{table.name}.valid_from" },
-            { where: "#{table.name}.valid_to" }
-          ]
           relation = relation
-            ._valid_from_lteq(valid_datetime || datetime, without_ignore: true)
-            ._valid_to_gt(valid_datetime || datetime, without_ignore: true)
+            ._valid_from_lteq(valid_datetime || datetime)
+            ._valid_to_gt(valid_datetime || datetime)
         else
           relation.tap { |relation| relation.without_valid_datetime unless ActiveRecord::Bitemporal.valid_datetime }
         end

data/lib/activerecord-bitemporal/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Bitemporal
-    VERSION = "4.3.0"
+    VERSION = "5.0.1"
   end
 end

data/lib/activerecord-bitemporal/visualizer.rb

@@ -49,7 +49,8 @@ module ActiveRecord::Bitemporal
         prev_valid_times.each do |valid_time|
           headers.print('|', line: line, column: columns[valid_time])
         end
-        headers.print("| #{valid_time.strftime('%F %T.%3N')}", line: line, column: columns[valid_time])
+        valid_time_str = valid_time.kind_of?(Date) ? valid_time.strftime('%F') : valid_time.strftime('%F %T.%3N')
+        headers.print("| #{valid_time_str}", line: line, column: columns[valid_time])
         prev_valid_times << valid_time
       end
   
@@ -92,13 +93,14 @@ module ActiveRecord::Bitemporal
         end
       end
 
+      valid_label = valid_times[0].kind_of?(Date) ? 'valid_date' : 'valid_datetime'
       transaction_label = 'transaction_datetime'
       right_margin = time_length + 1 - transaction_label.size
 
       label = if right_margin >= 0
-        "#{transaction_label + ' ' * right_margin}| valid_datetime"
+        "#{transaction_label + ' ' * right_margin}| #{valid_label}"
       else
-        "#{transaction_label[0...right_margin]}| valid_datetime"
+        "#{transaction_label[0...right_margin]}| #{valid_label}"
       end
 
       "#{label}\n#{headers.to_s}\n#{body.to_s}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-bitemporal
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 5.0.1
 platform: ruby
 authors:
 - SmartHR
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-08-08 00:00:00.000000000 Z
+date: 2024-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -159,9 +159,9 @@ files:
 - bin/console
 - bin/setup
 - docker-compose.yml
-- gemfiles/rails_6.0.gemfile
 - gemfiles/rails_6.1.gemfile
 - gemfiles/rails_7.0.gemfile
+- gemfiles/rails_7.1.gemfile
 - gemfiles/rails_main.gemfile
 - lib/activerecord-bitemporal.rb
 - lib/activerecord-bitemporal/bitemporal.rb
@@ -183,14 +183,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: BiTemporal Data Model for ActiveRecord