activerecord-after-transaction 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13b1839b4cea12bd935bd31f7fd7d2a70b73faa2
-  data.tar.gz: ea8486b878ef73152c2788a4d15a111367117d83
+  metadata.gz: 8c7628dfc2746e467f424e85396a743ef483bb63
+  data.tar.gz: fc7f8a21fce29ec827dda67d9c7ad4124845631b
 SHA512:
-  metadata.gz: 6992f5baa3a47fc8d45ff34575df6337fa71a371b5908d86818cdb096dcda2965063d588860dc066fe6f0fefe03e0b52cbd07004cba58c41e91b96037189a6cf
-  data.tar.gz: 672442a654d24ff95bc05795f7f750b0288a425ea389e5227b8ebb3e32f574d2a738b9df131e19d6a5de48f42c5814ef7c4484804353f6f64a394dc15cf5072a
+  metadata.gz: 5680857fc20de8921ec1f709bf07264a4951b6a5ec44ed879111ec99983cfcde671ca9cf08b2ad129c197b7883ef6ac397a766b802fde14a82b11e810be3d7b2
+  data.tar.gz: 8a64d651643698a3768d9c7a9a6b9b17ef6df7e1f3d3de24536d3f6c1908222b6368f0aed1625cf47508b99aefd401ac7b19f9845b54accb73331aec91491a4c

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/lib/activerecord-after-transaction/methods.rb

@@ -16,8 +16,10 @@ module ActiveRecord::AfterTransaction
       logger && logger.debug("Push #{block}")
     end
 
+    private
+
     def execute_after_transaction
-      queue = @after_transaction_queue
+      queue = @after_transaction_queue ||= []
       if !queue.empty?
         logger && logger.debug("Execute the queue")
         queue = queue.dup
@@ -31,6 +33,7 @@ module ActiveRecord::AfterTransaction
 
     def clear_after_transaction
       logger && logger.debug("Clear the queue")
+      @after_transaction_queue ||= []
       @after_transaction_queue.clear
     end
   end

data/spec/after_transaction/methods_spec.rb

@@ -9,6 +9,34 @@ describe ActiveRecord::AfterTransaction::Methods do
   end
   subject { klass.new }
 
+  shared_examples 'without error' do
+    it 'does not raise error in the after_commit callback' do
+      step = 1
+      subject.class_eval do
+        after_commit do
+          step = 2
+        end
+      end
+      klass.transaction do
+        subject.save!
+      end
+      expect(step).to eq 2
+    end
+    it 'does not raise error in the after_rollback callback' do
+      step = 1
+      subject.class_eval do
+        after_rollback do
+          step = 2
+        end
+      end
+      klass.transaction do
+        subject.save!
+        raise ActiveRecord::Rollback
+      end
+      expect(step).to eq 2
+    end
+  end
+
   describe 'in a transaction' do
     it 'executes the proc after transaction' do
       step = 1
@@ -43,6 +71,10 @@ describe ActiveRecord::AfterTransaction::Methods do
       end
       expect(step).to eq 1
     end
+    it_behaves_like 'without error'
+    describe 'with empty queue' do
+      it_behaves_like 'without error'
+    end
   end
   describe 'not in a transaction' do
     it 'executes the proc immediately' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-after-transaction
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Daisuke Taniwaki