activerabbit-ai 0.4.2 → 0.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 48326a10836bf940aea7ebf3b6eca91f60086eb69e51e5e94266db5012d47ad9
-  data.tar.gz: 9244e314ba69d85fd9652604014520f8cbc6a4ab2c6da046b28a7f9c540a402e
+  metadata.gz: e2afb9bf892d3e3a7e83a65e224c791855aa7d6e86feb476ee0f66c108f617cd
+  data.tar.gz: 20e74e7fa56e865bd707ccd852e62894fa73fc1d5ac2145d7d6a606dff351722
 SHA512:
-  metadata.gz: 866f2f2f296c7a254526691e02e6c182aade30274985de6ca69f8e715b9af4036b489437eb2742840bf9fe1a582a0eaafae3ad0605342da4acde3dc6ee4d752a
-  data.tar.gz: f59a2b3dcfd170f048f96751f870cc238333fc576fbf200668ef040db9a88b97de8b1a0f60cf8c6490c3ee3f8c4ee1941318571d39d644921e0f04e2a2ae29c8
+  metadata.gz: 40e742a6578a155441efe51fd97de272e8bfc7fe2e024cc2abe17e29ac2ee664079c6eb3093ae0aa311dea8f5438c96b60d88ba0a50e2477fdc2cc01b7b32006
+  data.tar.gz: 55fe08ec494af877576561418a7d3c9b63fd0b0bd34d3c04c3e59d5cb39d3d032992369ac056dc6e2417e75bad363fb5ac1dce115d3150765be7870b7859c34b

data/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.4.4] - 2025-10-22
+
+### Improved
+- **Time-based error deduplication**: Changed from "once per server lifecycle" to time-window based
+- Added `dedupe_window` configuration option (default: 300 seconds / 5 minutes)
+- Set `dedupe_window` to `0` to disable deduplication (useful for development/testing)
+- Automatic memory cleanup of old dedupe entries (keeps last hour only)
+- Better logging when errors are deduplicated
+
+### Fixed
+- Error deduplication no longer prevents same error from being reported after time window expires
+- Memory leak prevention by cleaning old deduplication entries
+
+## [0.4.3] - 2025-10-22
+
+### Fixed
+- **Critical bug fix**: Removed reference to non-existent `ActiveRabbit::Client::Dedupe` class in error reporter
+- Error tracking now works properly via Rails error reporter integration
+- Errors are successfully captured and sent to ActiveRabbit API
+
 ## [0.4.2] - 2025-01-04
 
 ### Fixed

data/README.md

@@ -236,6 +236,65 @@ ActiveRabbit::Client.configure do |config|
 end
 ```
 
+### Recommended Exceptions to Capture
+
+Below is a practical list of exceptions APMs should capture by default in a Rails app. Some are optional/noisy and typically excluded unless needed.
+
+- Core (Ruby/Stdlib)
+  - `StandardError`, `RuntimeError`, `NoMethodError`, `NameError`, `ArgumentError`, `TypeError`, `IndexError`, `KeyError`
+  - `Timeout::Error`, `JSON::ParserError`, `OpenSSL::SSL::SSLError`, `SocketError`, `Errno::ECONNREFUSED`/`ETIMEDOUT`/`EHOSTUNREACH`
+
+- ActionPack / Controllers
+  - `ActionController::ParameterMissing`
+  - `ActionController::BadRequest`
+  - `ActionController::InvalidAuthenticityToken` (optional; can be noisy)
+  - `ActionController::UnknownFormat`
+  - `ActionController::NotImplemented`
+
+- Routing (optional/noisy)
+  - `ActionController::RoutingError` (commonly excluded; enable only if needed)
+
+- Views / Templates
+  - `ActionView::Template::Error`
+  - `ActionView::MissingTemplate`
+  - `Encoding::UndefinedConversionError` (template rendering)
+
+- ActiveRecord / Database
+  - `ActiveRecord::RecordInvalid`
+  - `ActiveRecord::RecordNotFound` (optional; may be expected business logic)
+  - `ActiveRecord::StatementInvalid` (includes `PG::Error` subclasses)
+  - `ActiveRecord::Deadlocked`, `ActiveRecord::LockWaitTimeout`
+  - `ActiveRecord::RecordNotUnique`
+  - `ActiveRecord::ConnectionTimeoutError`
+  - `ActiveRecord::SerializationFailure`
+
+- Background Jobs (ActiveJob/Sidekiq)
+  - `ActiveJob::DeserializationError`
+  - Any unhandled exception raised in job `perform`
+
+- Networking/HTTP Clients
+  - `Net::OpenTimeout`, `Net::ReadTimeout`
+  - `Faraday::TimeoutError`, `Faraday::ConnectionFailed`
+  - `HTTP::Error` (http.rb), `RestClient::Exception`
+
+- Caching/Redis
+  - `Redis::BaseError`, `Redis::TimeoutError`, `Redis::CannotConnectError`
+
+- ActiveStorage
+  - `ActiveStorage::IntegrityError`
+  - `ActiveStorage::FileNotFoundError`
+
+- ActionCable
+  - `ActionCable::Connection::Authorization::UnauthorizedError` (if applicable)
+
+- Security/Crypto
+  - `ActiveSupport::MessageEncryptor::InvalidMessage`
+  - `ActiveSupport::MessageVerifier::InvalidSignature`
+
+Notes:
+- Optional/noisy: `RoutingError`, `RecordNotFound`, `InvalidAuthenticityToken`. Consider monitoring via metrics or targeted capture.
+- If exceptions are rescued by your app, enable reporting of rescued exceptions (`before_send_exception`/custom middleware) so they are still tracked when appropriate.
+
 ### Callbacks
 
 ```ruby

data/lib/active_rabbit/client/configuration.rb

@@ -14,6 +14,7 @@ module ActiveRabbit
       attr_accessor :ignored_exceptions, :ignored_user_agents, :ignore_404
       attr_accessor :release, :server_name, :logger
       attr_accessor :before_send_event, :before_send_exception
+      attr_accessor :dedupe_window  # Time window in seconds for error deduplication (0 = disabled)
 
       def initialize
         @api_url = ENV.fetch("active_rabbit_API_URL", "https://api.activerabbit.ai")
@@ -60,6 +61,9 @@ module ActiveRabbit
           /Twitterbot/i
         ]
 
+        # Deduplication (0 = disabled, time in seconds for same error to be considered duplicate)
+        @dedupe_window = 300  # 5 minutes by default
+
         # Metadata
         @release = detect_release
         @server_name = detect_server_name

data/lib/active_rabbit/client/error_reporter.rb

@@ -10,21 +10,32 @@ module ActiveRabbit
           begin
             Rails.logger.info "[ActiveRabbit] Error reporter caught: #{exception.class}: #{exception.message}" if defined?(Rails.logger)
 
-            # Initialize de-dup set
-            $reported_errors ||= Set.new
+            # Time-based deduplication: track errors with timestamps
+            $reported_errors ||= {}
 
             # Generate a unique key for this error
             error_key = "#{exception.class.name}:#{exception.message}:#{exception.backtrace&.first}"
 
-            # Only report if we haven't seen this error before and not deduped in short window
-            unless $reported_errors.include?(error_key)
-              $reported_errors.add(error_key)
+            # Get dedupe window from config (default 5 minutes, 0 = disabled)
+            dedupe_window = defined?(ActiveRabbit::Client.configuration.dedupe_window) ?
+                            ActiveRabbit::Client.configuration.dedupe_window : 300
 
-              dedupe_context = { request_id: (context && (context[:request_id] || context[:request]&.[](:request_id))) }
-              unless ActiveRabbit::Client::Dedupe.seen_recently?(exception, dedupe_context)
-                enriched = build_enriched_context(exception, handled: handled, severity: severity, context: context)
-                ActiveRabbit::Client.track_exception(exception, handled: handled, context: enriched)
-              end
+            current_time = Time.now.to_i
+            last_seen = $reported_errors[error_key]
+
+            # Report if: never seen before, OR dedupe disabled (0), OR outside dedupe window
+            should_report = last_seen.nil? || dedupe_window == 0 || (current_time - last_seen) > dedupe_window
+
+            if should_report
+              $reported_errors[error_key] = current_time
+
+              # Clean old entries to prevent memory leak (keep last hour)
+              $reported_errors.delete_if { |_, timestamp| current_time - timestamp > 3600 }
+
+              enriched = build_enriched_context(exception, handled: handled, severity: severity, context: context)
+              ActiveRabbit::Client.track_exception(exception, handled: handled, context: enriched)
+            else
+              Rails.logger.debug "[ActiveRabbit] Error deduplicated (last seen #{current_time - last_seen}s ago)" if defined?(Rails.logger)
             end
           rescue => e
             Rails.logger.error "[ActiveRabbit] Error in ErrorReporter::Subscriber#report: #{e.class} - #{e.message}" if defined?(Rails.logger)

data/lib/active_rabbit/client/railtie.rb

@@ -46,15 +46,18 @@ module ActiveRabbit
         setup_exception_tracking(app) if ActiveRabbit::Client.configured?
       end
 
-      initializer "active_rabbit.subscribe_to_notifications" do |app|
-        # Defer subscription until after application initializers (configuration complete)
+      initializer "active_rabbit.subscribe_to_notifications", after: :load_config_initializers do |app|
+        Rails.logger.info "[ActiveRabbit] Setting up performance notifications subscriptions"
+        # Subscribe regardless; each handler guards on configured?
+        subscribe_to_controller_events
+        subscribe_to_active_record_events
+        subscribe_to_action_view_events
+        subscribe_to_action_mailer_events if defined?(ActionMailer)
+        subscribe_to_exception_notifications
+        Rails.logger.info "[ActiveRabbit] Subscriptions setup complete"
+
+        # Defer complex subscriptions until after initialization
         app.config.after_initialize do
-          # Subscribe regardless; each handler guards on configured?
-          subscribe_to_controller_events
-          subscribe_to_active_record_events
-          subscribe_to_action_view_events
-          subscribe_to_action_mailer_events if defined?(ActionMailer)
-          subscribe_to_exception_notifications
 
           # Fallback: low-level rack.exception subscription (older Rails and deep middleware errors)
           ActiveSupport::Notifications.subscribe("rack.exception") do |*args|
@@ -387,10 +390,19 @@ module ActiveRabbit
       end
 
       def subscribe_to_controller_events
+        Rails.logger.info "[ActiveRabbit] Subscribing to controller events (configured=#{ActiveRabbit::Client.configured?})"
+
         ActiveSupport::Notifications.subscribe "process_action.action_controller" do |name, started, finished, unique_id, payload|
           begin
+            unless ActiveRabbit::Client.configured?
+              Rails.logger.debug "[ActiveRabbit] Skipping performance tracking - not configured"
+              return
+            end
+
             duration_ms = ((finished - started) * 1000).round(2)
 
+            Rails.logger.info "[ActiveRabbit] 📊 Controller action: #{payload[:controller]}##{payload[:action]} - #{duration_ms}ms"
+
             ActiveRabbit::Client.track_performance(
               "controller.action",
               duration_ms,

data/lib/active_rabbit/client/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRabbit
   module Client
-    VERSION = "0.4.2"
+    VERSION = "0.4.5"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerabbit-ai
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.5
 platform: ruby
 authors:
 - Alex Shapalov
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-10-21 00:00:00.000000000 Z
+date: 2025-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby