activeproject 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46d0e95fea9e696d7f35f2f8ad2cc32a82f9c068aaf834a9daa2650824650620
-  data.tar.gz: 709c98e0c3bab903db0447c7d53559c55e5c7c98cffc511a771c3b9f08cfa2fc
+  metadata.gz: 9960da80d5e32d0cdfa4fce3ffe824ebf3c36a8710d0a7782dbac3ec7001b863
+  data.tar.gz: 1ca92b2e165afbe314b70d970cb42817e5987ae3bfaa5a7d0ba58987999afe45
 SHA512:
-  metadata.gz: 7fb8db4e4f952b10364e91727ebec93e6f0e65f6ebf7d5bd331dab77013bd3fc34d100f522a76d5f8d7014d947081a16fdee34535a6327cbabfe6bb74cbfc00b
-  data.tar.gz: 15231c9e5b94a103f21b643f219ffebf4747223f2662a410389ecbf142cc1f618c96384dd5314ba56d00afa6bdf4d0f81cfc0ba33bd580f2fa4999dae8a954eb
+  metadata.gz: 46a0f331e8f7e956d643e6070d21dc20abe3825308c0761067df3773b3a20fcea7b94aa9c07f333c0fc794443945419436486b3daec49e4a19b5e473b05b4c6c
+  data.tar.gz: d78685242c2ea12a5a522a74e64b8f438d613dd2bb2977c14aca0ed7ba918ef953719f17b23b8cf6400723ea23886f7a63df898a9b804214eab4db635c8fb794

data/lib/active_project/adapters/base.rb

@@ -75,6 +75,12 @@ module ActiveProject
         raise NotImplementedError, "#{self.class.name} must implement #update_issue"
       end
 
+      # Base implementation of delete_issue that raises NotImplementedError
+      # This will be included in the base adapter class and overridden by specific adapters
+      def delete_issue(id, context = {})
+        raise NotImplementedError, "The #{self.class.name} adapter does not implement delete_issue"
+      end
+
       # Adds a comment to an issue.
       # @param issue_id [String, Integer] The ID or key of the issue.
       # @param comment_body [String] The text of the comment.

data/lib/active_project/adapters/basecamp/issues.rb

@@ -6,11 +6,12 @@ module ActiveProject
       module Issues
         # Lists To-dos within a specific project.
         # @param project_id [String, Integer] The ID of the Basecamp project.
-        # @param options [Hash] Optional options. Accepts :todolist_id.
+        # @param options [Hash] Optional options. Accepts :todolist_id and :page_size.
         # @return [Array<ActiveProject::Resources::Issue>] An array of issue resources.
         def list_issues(project_id, options = {})
           all_todos = []
           todolist_id = options[:todolist_id]
+          page_size = options[:page_size] || 50
 
           unless todolist_id
             todolist_id = find_first_todolist_id(project_id)
@@ -18,14 +19,16 @@ module ActiveProject
           end
 
           path = "buckets/#{project_id}/todolists/#{todolist_id}/todos.json"
+          query = {}
+          query[:per_page] = page_size if page_size
 
           loop do
-            response = @connection.get(path)
+            response = @connection.get(path, query)
             todos_data = begin
-              JSON.parse(response.body)
-            rescue StandardError
-              []
-            end
+                           JSON.parse(response.body)
+                         rescue StandardError
+                           []
+                         end
             break if todos_data.empty?
 
             todos_data.each do |todo_data|
@@ -37,6 +40,7 @@ module ActiveProject
             break unless next_url
 
             path = next_url.sub(@base_url, "").sub(%r{^/}, "")
+            query = {} # Clear query as pagination is in the URL now
           end
 
           all_todos
@@ -133,6 +137,21 @@ module ActiveProject
 
           find_issue(todo_id, context)
         end
+
+        # Deletes a To-do in Basecamp.
+        # @param todo_id [String, Integer] The ID of the Basecamp To-do to delete.
+        # @param context [Hash] Required context: { project_id: '...' }.
+        # @return [Boolean] True if successfully deleted.
+        def delete_issue(todo_id, context = {})
+          project_id = context[:project_id]
+          unless project_id
+            raise ArgumentError, "Missing required context: :project_id must be provided for BasecampAdapter#delete_issue"
+          end
+
+          path = "buckets/#{project_id}/todos/#{todo_id}.json"
+          make_request(:delete, path)
+          true
+        end
       end
     end
   end

data/lib/active_project/adapters/jira/issues.rb

@@ -4,14 +4,17 @@ module ActiveProject
   module Adapters
     module Jira
       module Issues
+        DEFAULT_FIELDS = %w[summary description status assignee reporter created updated project issuetype duedate priority].freeze
+
         # Lists issues within a specific project, optionally filtered by JQL.
         # @param project_id_or_key [String, Integer] The ID or key of the project.
-        # @param options [Hash] Optional filtering/pagination options.
+        # @param options [Hash] Optional filtering/pagination options. Accepts :jql, :fields, :start_at, :max_results.
         # @return [Array<ActiveProject::Resources::Issue>]
         def list_issues(project_id_or_key, options = {})
           start_at = options.fetch(:start_at, 0)
           max_results = options.fetch(:max_results, 50)
           jql = options.fetch(:jql, "project = '#{project_id_or_key}' ORDER BY created DESC")
+          fields = options[:fields] || DEFAULT_FIELDS
 
           all_issues = []
           path = "/rest/api/3/search"
@@ -20,8 +23,7 @@ module ActiveProject
             jql: jql,
             startAt: start_at,
             maxResults: max_results,
-            fields: %w[summary description status assignee reporter created updated project
-                       issuetype duedate priority]
+            fields: fields
           }.to_json
 
           response_data = make_request(:post, path, payload)
@@ -36,11 +38,12 @@ module ActiveProject
 
         # Finds a specific issue by its ID or key using the V3 endpoint.
         # @param id_or_key [String, Integer] The ID or key of the issue.
-        # @param context [Hash] Optional context (ignored).
+        # @param context [Hash] Optional context. Accepts :fields for field selection.
         # @return [ActiveProject::Resources::Issue]
-        def find_issue(id_or_key, _context = {})
-          fields = "summary,description,status,assignee,reporter,created,updated,project,issuetype,duedate,priority"
-          path = "/rest/api/3/issue/#{id_or_key}?fields=#{fields}"
+        def find_issue(id_or_key, context = {})
+          fields = context[:fields] || DEFAULT_FIELDS
+          fields_param = fields.is_a?(Array) ? fields.join(",") : fields
+          path = "/rest/api/3/issue/#{id_or_key}?fields=#{fields_param}"
 
           issue_data = make_request(:get, path)
           map_issue_data(issue_data)
@@ -54,8 +57,8 @@ module ActiveProject
           path = "/rest/api/3/issue"
 
           unless attributes[:project].is_a?(Hash) && (attributes[:project][:id] || attributes[:project][:key]) &&
-                 attributes[:summary] && !attributes[:summary].empty? &&
-                 attributes[:issue_type] && (attributes[:issue_type][:id] || attributes[:issue_type][:name])
+            attributes[:summary] && !attributes[:summary].empty? &&
+            attributes[:issue_type] && (attributes[:issue_type][:id] || attributes[:issue_type][:name])
             raise ArgumentError,
                   "Missing required attributes for issue creation: :project (must be a Hash with id/key), :summary, :issue_type (with id/name)"
           end
@@ -83,6 +86,8 @@ module ActiveProject
 
           fields_payload[:priority] = attributes[:priority] if attributes.key?(:priority)
 
+          fields_payload[:parent] = attributes[:parent] if attributes.key?(:parent)
+
           payload = { fields: fields_payload }.to_json
           response_data = make_request(:post, path, payload)
 
@@ -92,9 +97,9 @@ module ActiveProject
         # Updates an existing issue in Jira using the V3 endpoint.
         # @param id_or_key [String, Integer] The ID or key of the issue to update.
         # @param attributes [Hash] Issue attributes to update (e.g., :summary, :description, :assignee_id, :due_on, :priority).
-        # @param context [Hash] Optional context (ignored).
+        # @param context [Hash] Optional context. Accepts :fields for field selection on return.
         # @return [ActiveProject::Resources::Issue]
-        def update_issue(id_or_key, attributes, _context = {})
+        def update_issue(id_or_key, attributes, context = {})
           path = "/rest/api/3/issue/#{id_or_key}"
 
           update_fields = {}
@@ -119,12 +124,25 @@ module ActiveProject
 
           update_fields[:priority] = attributes[:priority] if attributes.key?(:priority)
 
-          return find_issue(id_or_key) if update_fields.empty?
+          return find_issue(id_or_key, context) if update_fields.empty?
 
           payload = { fields: update_fields }.to_json
           make_request(:put, path, payload)
 
-          find_issue(id_or_key)
+          find_issue(id_or_key, context)
+        end
+
+        # Deletes an issue from Jira.
+        # @param id_or_key [String, Integer] The ID or key of the issue to delete.
+        # @param context [Hash] Optional context. Accepts :delete_subtasks to indicate whether subtasks should be deleted.
+        # @return [Boolean] True if successfully deleted.
+        def delete_issue(id_or_key, context = {})
+          delete_subtasks = context[:delete_subtasks] || false
+          path = "/rest/api/3/issue/#{id_or_key}"
+          query = { deleteSubtasks: delete_subtasks }
+
+          make_request(:delete, path, nil, query)
+          true
         end
       end
     end

data/lib/active_project/adapters/jira_adapter.rb

@@ -57,8 +57,10 @@ module ActiveProject
       # Initializes the Faraday connection object.
 
       # Makes an HTTP request. Returns parsed JSON or raises appropriate error.
-      def make_request(method, path, body = nil)
-        response = @connection.run_request(method, path, body, nil)
+      def make_request(method, path, body = nil, query = nil)
+        response = @connection.run_request(method, path, body, nil) do |req|
+          req.params = query if query # Add query params to the request
+        end
 
         # Check for AUTHENTICATED_FAILED header even on 200 OK
         if response.status == 200 && response.headers["x-seraph-loginreason"]&.include?("AUTHENTICATED_FAILED")
@@ -78,7 +80,7 @@ module ActiveProject
         status = e.response&.status
         body = e.response&.body
         raise ApiError.new("Jira API connection error (Status: #{status || 'N/A'}): #{e.message}", original_error: e,
-                                                                                                   status_code: status, response_body: body)
+                           status_code: status, response_body: body)
       end
 
       # Handles Faraday errors based on the response object (for non-2xx responses).

data/lib/active_project/adapters/trello/issues.rb

@@ -4,13 +4,17 @@ module ActiveProject
   module Adapters
     module Trello
       module Issues
+        DEFAULT_FIELDS = %w[id name desc closed idList idBoard due dueComplete idMembers].freeze
+
         # Lists Trello cards on a specific board.
         # @param board_id [String] The ID of the Trello board.
-        # @param options [Hash] Optional filtering options.
+        # @param options [Hash] Optional filtering options. Accepts :filter and :fields.
         # @return [Array<ActiveProject::Resources::Issue>]
         def list_issues(board_id, options = {})
           path = "boards/#{board_id}/cards"
-          query = { fields: "id,name,desc,closed,idList,idBoard,due,dueComplete,idMembers", list: true }
+
+          fields = options[:fields] ? Array(options[:fields]).join(",") : DEFAULT_FIELDS.join(",")
+          query = { fields: fields, list: true }
           query[:filter] = options[:filter] if options[:filter]
 
           cards_data = make_request(:get, path, nil, query)
@@ -21,11 +25,14 @@ module ActiveProject
 
         # Finds a specific Card by its ID.
         # @param card_id [String] The ID of the Trello Card.
-        # @param context [Hash] Optional context (ignored).
+        # @param context [Hash] Optional context. Accepts :fields for specific field selection.
         # @return [ActiveProject::Resources::Issue]
-        def find_issue(card_id, _context = {})
+        def find_issue(card_id, context = {})
           path = "cards/#{card_id}"
-          query = { fields: "id,name,desc,closed,idList,idBoard,due,dueComplete,idMembers", list: true }
+
+          fields = context[:fields] ? Array(context[:fields]).join(",") : DEFAULT_FIELDS.join(",")
+          query = { fields: fields, list: true }
+
           card_data = make_request(:get, path, nil, query)
           map_card_data(card_data, card_data["idBoard"])
         end
@@ -58,7 +65,7 @@ module ActiveProject
         # Updates an existing Card in Trello.
         # @param card_id [String] The ID of the Trello Card.
         # @param attributes [Hash] Attributes to update (e.g., :title, :description, :list_id, :closed, :due_on, :assignee_ids, :status).
-        # @param context [Hash] Optional context (ignored).
+        # @param context [Hash] Optional context. Accepts :fields for return data field selection.
         # @return [ActiveProject::Resources::Issue]
         def update_issue(card_id, attributes, context = {})
           update_attributes = attributes.dup
@@ -67,10 +74,10 @@ module ActiveProject
             target_status = update_attributes.delete(:status)
 
             board_id = update_attributes[:board_id] || begin
-              find_issue(card_id).project_id
-            rescue NotFoundError
-              raise NotFoundError, "Trello card with ID '#{card_id}' not found."
-            end
+                                                         find_issue(card_id).project_id
+                                                       rescue NotFoundError
+                                                         raise NotFoundError, "Trello card with ID '#{card_id}' not found."
+                                                       end
 
             unless board_id
               raise ApiError, "Could not determine board ID for card '#{card_id}' to perform status mapping."
@@ -111,6 +118,15 @@ module ActiveProject
           card_data = make_request(:put, path, nil, query_params.compact)
           map_card_data(card_data, card_data["idBoard"])
         end
+
+        # Deletes a Trello card.
+        # @param card_id [String] The ID of the Trello Card to delete.
+        # @return [Boolean] True if successfully deleted.
+        def delete_issue(card_id, **)
+          path = "cards/#{card_id}"
+          make_request(:delete, path)
+          true
+        end
       end
     end
   end

data/lib/active_project/adapters/trello_adapter.rb

@@ -96,7 +96,11 @@ module ActiveProject
       def handle_faraday_error(error)
         status = error.response_status
         body = error.response_body
-        message = body || "Unknown Trello Error"
+        body = JSON.parse(body) if body.is_a?(String) && !body.empty? rescue body
+        if body.is_a?(Hash)
+          message = body["message"]
+        end
+        message ||= body || "Unknown Trello Error"
 
         case status
         when 401, 403

data/lib/active_project/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActiveProject
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: activeproject
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Abdelkader Boudih
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2025-04-10 00:00:00.000000000 Z
@@ -125,6 +126,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/seuros/active_project
   source_code_uri: https://github.com/seuros/active_project
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -139,7 +141,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.5
+rubygems_version: 3.5.22
+signing_key:
 specification_version: 4
 summary: A standardized Ruby interface for multiple project management APIs (Jira,
   Basecamp, Trello, etc.).