activeproject 0.0.0 → 0.1.1

data/lib/active_project/resource_factory.rb

@@ -23,13 +23,11 @@ module ActiveProject
       # Call adapter method with appropriate arguments
       if primary_arg
         @adapter.send(list_method, primary_arg, options)
-      else
+      elsif @adapter.method(list_method).arity.zero?
         # Handle case where list method might not take options (like list_projects)
-        if @adapter.method(list_method).arity == 0
-           @adapter.send(list_method)
-        else
-           @adapter.send(list_method, options)
-        end
+        @adapter.send(list_method)
+      else
+        @adapter.send(list_method, options)
       end
     end
 
@@ -89,7 +87,7 @@ module ActiveProject
     def create(attributes = {})
       # Determine the correct adapter create method based on resource type
       create_method = determine_create_method
-      # Note: Assumes create methods on adapters take attributes hash directly
+      # NOTE: Assumes create methods on adapters take attributes hash directly
       # Context like project_id needs to be part of the attributes hash if required by adapter
       @adapter.send(create_method, attributes)
       # A full implementation would likely involve build then save:
@@ -106,7 +104,11 @@ module ActiveProject
       when "ActiveProject::Resources::Issue" then :list_issues
       else raise "Cannot determine list method for #{@resource_class.name}"
       end
-      raise NotImplementedError, "#{@adapter.class.name} does not implement ##{method_name}" unless @adapter.respond_to?(method_name)
+      unless @adapter.respond_to?(method_name)
+        raise NotImplementedError,
+              "#{@adapter.class.name} does not implement ##{method_name}"
+      end
+
       method_name
     end
 
@@ -116,14 +118,22 @@ module ActiveProject
       when "ActiveProject::Resources::Issue" then :find_issue
       else raise "Cannot determine find method for #{@resource_class.name}"
       end
-      raise NotImplementedError, "#{@adapter.class.name} does not implement ##{method_name}" unless @adapter.respond_to?(method_name)
+      unless @adapter.respond_to?(method_name)
+        raise NotImplementedError,
+              "#{@adapter.class.name} does not implement ##{method_name}"
+      end
+
       method_name
     end
 
     def determine_create_method
       singular_name = @resource_class.name.split("::").last.downcase.to_sym
       method_name = :"create_#{singular_name}"
-      raise NotImplementedError, "#{@adapter.class.name} does not implement ##{method_name}" unless @adapter.respond_to?(method_name)
+      unless @adapter.respond_to?(method_name)
+        raise NotImplementedError,
+              "#{@adapter.class.name} does not implement ##{method_name}"
+      end
+
       method_name
     end
   end

data/lib/active_project/resources/comment.rb

@@ -1,16 +1,11 @@
 # frozen_string_literal: true
 
-require_relative "base_resource"
-
 module ActiveProject
   module Resources
     # Represents a Comment on an Issue
     class Comment < BaseResource
       def_members :id, :body, :author, :created_at, :updated_at, :issue_id,
                   :adapter_source
-      # raw_data and adapter are inherited from BaseResource
-
-      # Add comment-specific methods here later (e.g., save, update, delete)
     end
   end
 end

data/lib/active_project/resources/issue.rb

@@ -7,8 +7,6 @@ module ActiveProject
       def_members :id, :key, :title, :description, :status, :assignees,
                   :reporter, :project_id, :created_at, :updated_at, :due_on,
                   :priority, :adapter_source
-      # raw_data and adapter are inherited from BaseResource
-
 
       # Saves the issue (creates if new, updates if existing).
       # Placeholder - Full implementation requires attribute tracking and adapter delegation.
@@ -28,14 +26,11 @@ module ActiveProject
         raise NotImplementedError, "#update not yet implemented for #{self.class.name}"
       end
 
-
       # Returns an association proxy for accessing comments on this issue.
       # @return [AssociationProxy<Resources::Comment>]
       def comments
         AssociationProxy.new(owner: self, adapter: @adapter, association_name: :comments)
       end
-
-      # Add issue-specific methods here later (e.g., comments association, save, update)
     end
   end
 end

data/lib/active_project/resources/project.rb

@@ -7,14 +7,11 @@ module ActiveProject
       def_members :id, :key, :name, :adapter_source
       # raw_data and adapter are inherited from BaseResource
 
-
       # Returns an association proxy for accessing issues within this project.
       # @return [AssociationProxy<Resources::Issue>]
       def issues
         AssociationProxy.new(owner: self, adapter: @adapter, association_name: :issues)
       end
-
-      # Add project-specific methods here later (e.g., issues association)
     end
   end
 end

data/lib/active_project/resources/user.rb

@@ -7,7 +7,6 @@ module ActiveProject
     # Represents a User
     class User < BaseResource
       def_members :id, :name, :email, :adapter_source
-      # raw_data and adapter are inherited from BaseResource
     end
   end
 end

data/lib/active_project/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ActiveProject
-  VERSION = "0.0.0"
+  VERSION = "0.1.1"
 end

data/lib/activeproject.rb

@@ -1,4 +1,5 @@
 require "zeitwerk"
+require "concurrent"
 require_relative "active_project/errors"
 require_relative "active_project/version"
 
@@ -14,6 +15,11 @@ module ActiveProject
       yield(configuration)
     end
 
+    # Resets all cached adapters, forcing them to be re-initialized with current configuration
+    # @return [void]
+    def reset_adapters
+      adapter_registry.clear if defined?(@adapter_registry) && @adapter_registry
+    end
 
     # Returns the configured User-Agent string, including the gem version.
     # @return [String] The User-Agent string.
@@ -23,33 +29,79 @@ module ActiveProject
     end
 
     # Returns a memoized instance of the requested adapter.
-    # @param adapter_name [Symbol] The name of the adapter (e.g., :jira, :trello).
-    # @return [Adapters::Base] An instance of the requested adapter.
+    # Thread-safe implementation using Concurrent::Map for the adapter registry.
+    # @param adapter_type [Symbol] The name of the adapter (e.g., :jira, :trello).
+    # @param instance_name [Symbol] The name of the adapter instance (default: :primary).
+    # @return [ActiveProject::Adapters::Base] An instance of a specific adapter class that inherits from Base.
     # @raise [ArgumentError] if the adapter configuration is missing or invalid.
     # @raise [LoadError] if the adapter class cannot be found.
-    def adapter(adapter_name)
-      @adapters ||= {}
-      @adapters[adapter_name] ||= begin
-        config = configuration.adapter_config(adapter_name)
+    # @raise [NameError] if the adapter class cannot be found after loading the file.
+    def adapter(adapter_type, instance_name = :primary)
+      key = "#{adapter_type}_#{instance_name}".to_sym
+
+      adapter_registry.fetch_or_store(key) do
+        config = configuration.adapter_config(adapter_type, instance_name)
 
         unless config.is_a?(ActiveProject::Configurations::BaseAdapterConfiguration)
-          raise ArgumentError, "Configuration for adapter ':#{adapter_name}' not found or invalid. Use ActiveProject.configure."
+          available_configs = list_available_configurations
+
+          error_message = "Configuration for adapter ':#{adapter_type}' (instance ':#{instance_name}') not found or invalid.\n\n"
+
+          if available_configs.empty?
+            error_message += "No adapters are currently configured. "
+          else
+            error_message += "Available configurations:\n"
+            available_configs.each do |adapter_key, config_type|
+              error_message += "  * #{adapter_key} (#{config_type})\n"
+            end
+          end
+
+          error_message += "\nTo configure, use:\n"
+          error_message += "  ActiveProject.configure do |config|\n"
+          error_message += "    config.add_adapter :#{adapter_type}, :#{instance_name}, { your_options_here }\n"
+          error_message += "  end"
+
+          raise ArgumentError, error_message
         end
 
-        # Use string-based constant lookup with the full namespace path
-        adapter_class_name = "ActiveProject::Adapters::#{adapter_name.to_s.capitalize}Adapter"
+        adapter_class_name = "ActiveProject::Adapters::#{adapter_type.to_s.capitalize}Adapter"
 
-        # Ensure the adapter class is loaded
-        require "active_project/adapters/#{adapter_name}_adapter"
+        begin
+          require "active_project/adapters/#{adapter_type}_adapter"
+        rescue LoadError => e
+          error_message = "Could not load adapter '#{adapter_type}'.\n"
+          error_message += "Make sure you have defined the class #{adapter_class_name} in active_project/adapters/#{adapter_type}_adapter.rb"
+          raise LoadError, error_message
+        end
 
-        # Get the constant with the full path
-        adapter_class = Object.const_get(adapter_class_name)
+        begin
+          adapter_class = Object.const_get(adapter_class_name)
+        rescue NameError => e
+          error_message = "Could not find adapter class #{adapter_class_name}.\n"
+          error_message += "Make sure you have defined the class correctly in active_project/adapters/#{adapter_type}_adapter.rb"
+          raise NameError, error_message
+        end
 
         adapter_class.new(config: config)
-      rescue LoadError, NameError => e
-        raise LoadError, "Could not find adapter class #{adapter_class_name}: #{e.message}"
       end
     end
+
+    # Lists all available configurations in the format adapter_name:instance_name
+    # @return [Hash] A hash mapping configuration keys to their configuration types
+    def list_available_configurations
+      result = {}
+      configuration.adapter_configs.each do |key, config|
+        config_type = config.class.name.split("::").last
+        result[key] = config_type
+      end
+      result
+    end
+
+    # Returns a thread-safe map that stores adapter instances
+    # @return [Concurrent::Map] Thread-safe hash implementation
+    def adapter_registry
+      @adapter_registry ||= Concurrent::Map.new
+    end
   end
 end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: activeproject
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Abdelkader Boudih
 bindir: bin
 cert_chain: []
-date: 2025-04-07 00:00:00.000000000 Z
+date: 2025-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -35,14 +35,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: faraday-retry
   requirement: !ruby/object:Gem::Requirement
@@ -84,8 +84,26 @@ files:
 - README.md
 - Rakefile
 - lib/active_project/adapters/base.rb
+- lib/active_project/adapters/basecamp/comments.rb
+- lib/active_project/adapters/basecamp/connection.rb
+- lib/active_project/adapters/basecamp/issues.rb
+- lib/active_project/adapters/basecamp/lists.rb
+- lib/active_project/adapters/basecamp/projects.rb
+- lib/active_project/adapters/basecamp/webhooks.rb
 - lib/active_project/adapters/basecamp_adapter.rb
+- lib/active_project/adapters/jira/comments.rb
+- lib/active_project/adapters/jira/connection.rb
+- lib/active_project/adapters/jira/issues.rb
+- lib/active_project/adapters/jira/projects.rb
+- lib/active_project/adapters/jira/transitions.rb
+- lib/active_project/adapters/jira/webhooks.rb
 - lib/active_project/adapters/jira_adapter.rb
+- lib/active_project/adapters/trello/comments.rb
+- lib/active_project/adapters/trello/connection.rb
+- lib/active_project/adapters/trello/issues.rb
+- lib/active_project/adapters/trello/lists.rb
+- lib/active_project/adapters/trello/projects.rb
+- lib/active_project/adapters/trello/webhooks.rb
 - lib/active_project/adapters/trello_adapter.rb
 - lib/active_project/association_proxy.rb
 - lib/active_project/configuration.rb
@@ -101,12 +119,12 @@ files:
 - lib/active_project/version.rb
 - lib/active_project/webhook_event.rb
 - lib/activeproject.rb
-homepage: https://github.com/seuros/activeproject
+homepage: https://github.com/seuros/active_project
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/seuros/activeproject
-  source_code_uri: https://github.com/seuros/activeproject
+  homepage_uri: https://github.com/seuros/active_project
+  source_code_uri: https://github.com/seuros/active_project
 rdoc_options: []
 require_paths:
 - lib
@@ -121,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.5
 specification_version: 4
 summary: A standardized Ruby interface for multiple project management APIs (Jira,
   Basecamp, Trello, etc.).