activemodel 5.0.7.2 → 5.1.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 037004e060b00ef9bdf166f1a123941008eac38445bf7b69de9e4325d27ad729
-  data.tar.gz: 323b17aae456ed4bd2e606dc308edee6cb3abc945d806fb753248e5bc4fe2f7d
+SHA1:
+  metadata.gz: 2722a2216da7e44da498eddfe9cd283628ff4876
+  data.tar.gz: f7d850f4021cf5f4fd5e4209f9359d645bf1d69f
 SHA512:
-  metadata.gz: ad0dec431b9629aa031fbe36c6ae295f51a2d773fa9e325833189d177201c81c678aee6eb1298607a894a415dd0d1bd0f83e91f6edc7785b7b390af6c9e43b89
-  data.tar.gz: 7f5c74e105297822c1d10e088a6aa16641f5cefa6d3d71fde2a2d0e0495bf10565403cb8cd66c00cd241477bb80c997ba1d5a5be3b98ef3dbd8f3d4e142d6186
+  metadata.gz: 6ce16354bc976631475e670f614393ab7859e2cbd32e1348f6d5c58b714ae336af91312b4fcbc3b90346e616c96ab1e03caf8ada1d48a1760aaa49350751c8eb
+  data.tar.gz: b1a4b60136a4a1df7147359ba25f4fb15d366234e65cfb6f965cc8007d7d72289c02a3a9798249ae9216378d74022af18db6ad948469b95e9dacd8952638b3f1

data/CHANGELOG.md

@@ -1,236 +1,32 @@
-## Rails 5.0.7.2 (March 11, 2019) ##
+## Rails 5.1.0.beta1 (February 23, 2017) ##
 
-*   No changes.
+*   Remove deprecated behavior that halts callbacks when the return is false.
 
+    *Rafael Mendonça França*
 
-## Rails 5.0.7.1 (November 27, 2018) ##
-
-*   No changes.
-
-
-## Rails 5.0.7 (March 29, 2018) ##
-
-*   No changes.
-
-
-## Rails 5.0.6 (September 07, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.6.rc1 (August 24, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.5 (July 31, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.5.rc2 (July 25, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.5.rc1 (July 19, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.4 (June 19, 2017) ##
-
-*   Fix regression in numericality validator when comparing Decimal and Float input 
-    values with more scale than the schema.
-
-    *Bradley Priest*
-
-
-## Rails 5.0.3 (May 12, 2017) ##
-
-*   The original string assigned to a model attribute is no longer incorrectly
-    frozen.
-
-    Fixes #24185, #28718.
-
-    *Matthew Draper*
-
-*   Avoid converting integer as a string into float.
-
-    *namusyaka*
-
-
-## Rails 5.0.2 (March 01, 2017) ##
-
-*   No changes.
-
-
-## Rails 5.0.1 (December 21, 2016) ##
-
-*   No changes.
-
-
-## Rails 5.0.1.rc2 (December 10, 2016) ##
-
-*   No changes.
-
-
-## Rails 5.0.1.rc1 (December 01, 2016) ##
-
-*   Fix `Type::Date#serialize` to cast a value to a date object properly.
-    This casting fixes queries for finding records by date column.
-
-    Fixes #25354.
-
-    *Ryuta Kamizono*
-
-
-## Rails 5.0.0 (June 30, 2016) ##
-
-*   `Dirty`'s `*_changed?` methods now return an actual singleton, never `nil`, as in 4.2.
-    Fixes #24220.
-
-    *Sen-Zhang*
-
-*   Ensure that instances of `ActiveModel::Errors` can be marshalled.
-    Fixes #25165.
-
-    *Sean Griffin*
-
-*   Allow passing record being validated to the message proc to generate
-    customized error messages for that object using I18n helper.
-
-    *Prathamesh Sonpatki*
-
-*   Validate multiple contexts on `valid?` and `invalid?` at once.
-
-    Example:
-
-        class Person
-          include ActiveModel::Validations
-
-          attr_reader :name, :title
-          validates_presence_of :name, on: :create
-          validates_presence_of :title, on: :update
-        end
-
-        person = Person.new
-        person.valid?([:create, :update])    # => false
-        person.errors.messages               # => {:name=>["can't be blank"], :title=>["can't be blank"]}
-
-    *Dmitry Polushkin*
-
-*   Add case_sensitive option for confirmation validator in models.
-
-    *Akshat Sharma*
-
-*   Ensure `method_missing` is called for methods passed to
-    `ActiveModel::Serialization#serializable_hash` that don't exist.
-
-    *Jay Elaraj*
-
-*   Remove `ActiveModel::Serializers::Xml` from core.
-
-    *Zachary Scott*
-
-*   Add `ActiveModel::Dirty#[attr_name]_previously_changed?` and
-    `ActiveModel::Dirty#[attr_name]_previous_change` to improve access
-    to recorded changes after the model has been saved.
-
-    It makes the dirty-attributes query methods consistent before and after
-    saving.
-
-    *Fernando Tapia Rico*
-
-*   Deprecate the `:tokenizer` option for `validates_length_of`, in favor of
-    plain Ruby.
-
-    *Sean Griffin*
-
-*   Deprecate `ActiveModel::Errors#add_on_empty` and `ActiveModel::Errors#add_on_blank`
-    with no replacement.
-
-    *Wojciech Wnętrzak*
-
-*   Deprecate `ActiveModel::Errors#get`, `ActiveModel::Errors#set` and
-    `ActiveModel::Errors#[]=` methods that have inconsistent behavior.
-
-    *Wojciech Wnętrzak*
-
-*   Allow symbol as values for `tokenize` of `LengthValidator`.
-
-    *Kensuke Naito*
-
-*   Assigning an unknown attribute key to an `ActiveModel` instance during initialization
-    will now raise `ActiveModel::AttributeAssignment::UnknownAttributeError` instead of
-    `NoMethodError`.
-
-    Example:
-
-        User.new(foo: 'some value')
-        # => ActiveModel::AttributeAssignment::UnknownAttributeError: unknown attribute 'foo' for User.
-
-    *Eugene Gilburg*
-
-*   Extracted `ActiveRecord::AttributeAssignment` to `ActiveModel::AttributeAssignment`
-    allowing to use it for any object as an includable module.
-
-    Example:
-
-        class Cat
-          include ActiveModel::AttributeAssignment
-          attr_accessor :name, :status
-        end
-
-        cat = Cat.new
-        cat.assign_attributes(name: "Gorby", status: "yawning")
-        cat.name   # => 'Gorby'
-        cat.status # => 'yawning'
-        cat.assign_attributes(status: "sleeping")
-        cat.name   # => 'Gorby'
-        cat.status # => 'sleeping'
-
-    *Bogdan Gusiev*
+*   Remove unused `ActiveModel::TestCase` class.
 
-*   Add `ActiveModel::Errors#details`
+    *Yuji Yaginuma*
 
-    To be able to return type of used validator, one can now call `details`
-    on errors instance.
+*   Moved DecimalWithoutScale, Text, and UnsignedInteger from Active Model to Active Record
 
-    Example:
+    *Iain Beeston*
 
-        class User < ActiveRecord::Base
-          validates :name, presence: true
-        end
+*   Allow indifferent access in `ActiveModel::Errors`.
 
-        user = User.new; user.valid?; user.errors.details
-        => {name: [{error: :blank}]}
+    `#include?`, `#has_key?`, `#key?`, `#delete` and `#full_messages_for`.
 
-    *Wojciech Wnętrzak*
+    *Kenichi Kamiya*
 
-*   Change `validates_acceptance_of` to accept `true` by default besides `'1'`.
+*   Removed deprecated `:tokenizer` in the length validator.
 
-    The default for `validates_acceptance_of` is now `'1'` and `true`.
-    In the past, only `"1"` was the default and you were required to pass
-    `accept: true` separately.
+    *Rafael Mendonça França*
 
-    *mokhan*
+*   Removed deprecated methods in `ActiveModel::Errors`.
 
-*   Remove deprecated `ActiveModel::Dirty#reset_#{attribute}` and
-    `ActiveModel::Dirty#reset_changes`.
+    `#get`, `#set`, `[]=`, `add_on_empty` and `add_on_blank`.
 
     *Rafael Mendonça França*
 
-*   Change the way in which callback chains can be halted.
-
-    The preferred method to halt a callback chain from now on is to explicitly
-    `throw(:abort)`.
-    In the past, returning `false` in an Active Model `before_` callback had
-    the side effect of halting the callback chain.
-    This is not recommended anymore and, depending on the value of the
-    `ActiveSupport.halt_callback_chains_on_return_false` option, will
-    either not work at all or display a deprecation warning.
-
-    *claudiob*
 
-Please check [4-2-stable](https://github.com/rails/rails/blob/4-2-stable/activemodel/CHANGELOG.md) for previous changes.
+Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/activemodel/CHANGELOG.md) for previous changes.

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2016 David Heinemeier Hansson
+Copyright (c) 2004-2017 David Heinemeier Hansson
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -239,7 +239,7 @@ The latest version of Active Model can be installed with RubyGems:
 
 Source code can be downloaded as part of the Rails project on GitHub
 
-* https://github.com/rails/rails/tree/5-0-stable/activemodel
+* https://github.com/rails/rails/tree/master/activemodel
 
 
 == License

data/lib/active_model.rb

@@ -1,5 +1,5 @@
 #--
-# Copyright (c) 2004-2016 David Heinemeier Hansson
+# Copyright (c) 2004-2017 David Heinemeier Hansson
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -21,37 +21,36 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 
-require 'active_support'
-require 'active_support/rails'
-require 'active_model/version'
+require "active_support"
+require "active_support/rails"
+require "active_model/version"
 
 module ActiveModel
   extend ActiveSupport::Autoload
 
   autoload :AttributeAssignment
   autoload :AttributeMethods
-  autoload :BlockValidator, 'active_model/validator'
+  autoload :BlockValidator, "active_model/validator"
   autoload :Callbacks
   autoload :Conversion
   autoload :Dirty
-  autoload :EachValidator, 'active_model/validator'
+  autoload :EachValidator, "active_model/validator"
   autoload :ForbiddenAttributesProtection
   autoload :Lint
   autoload :Model
-  autoload :Name, 'active_model/naming'
+  autoload :Name, "active_model/naming"
   autoload :Naming
   autoload :SecurePassword
   autoload :Serialization
-  autoload :TestCase
   autoload :Translation
   autoload :Validations
   autoload :Validator
 
   eager_autoload do
     autoload :Errors
-    autoload :RangeError, 'active_model/errors'
-    autoload :StrictValidationFailed, 'active_model/errors'
-    autoload :UnknownAttributeError, 'active_model/errors'
+    autoload :RangeError, "active_model/errors"
+    autoload :StrictValidationFailed, "active_model/errors"
+    autoload :UnknownAttributeError, "active_model/errors"
   end
 
   module Serializers
@@ -69,5 +68,5 @@ module ActiveModel
 end
 
 ActiveSupport.on_load(:i18n) do
-  I18n.load_path << File.dirname(__FILE__) + '/active_model/locale/en.yml'
+  I18n.load_path << File.dirname(__FILE__) + "/active_model/locale/en.yml"
 end

data/lib/active_model/attribute_assignment.rb

@@ -1,4 +1,4 @@
-require 'active_support/core_ext/hash/keys'
+require "active_support/core_ext/hash/keys"
 
 module ActiveModel
   module AttributeAssignment
@@ -35,18 +35,18 @@ module ActiveModel
 
     private
 
-    def _assign_attributes(attributes)
-      attributes.each do |k, v|
-        _assign_attribute(k, v)
+      def _assign_attributes(attributes)
+        attributes.each do |k, v|
+          _assign_attribute(k, v)
+        end
       end
-    end
 
-    def _assign_attribute(k, v)
-      if respond_to?("#{k}=")
-        public_send("#{k}=", v)
-      else
-        raise UnknownAttributeError.new(self, k)
+      def _assign_attribute(k, v)
+        if respond_to?("#{k}=")
+          public_send("#{k}=", v)
+        else
+          raise UnknownAttributeError.new(self, k)
+        end
       end
-    end
   end
 end

data/lib/active_model/attribute_methods.rb

@@ -1,5 +1,5 @@
-require 'concurrent/map'
-require 'mutex_m'
+require "concurrent/map"
+require "mutex_m"
 
 module ActiveModel
   # Raised when an attribute is not defined.
@@ -289,7 +289,7 @@ module ActiveModel
             generate_method = "define_method_#{matcher.method_missing_target}"
 
             if respond_to?(generate_method, true)
-              send(generate_method, attr_name)
+              send(generate_method, attr_name.to_s)
             else
               define_proxy_call true, generated_attribute_methods, method_name, matcher.method_missing_target, attr_name.to_s
             end
@@ -334,12 +334,11 @@ module ActiveModel
         }.tap { |mod| include mod }
       end
 
-      protected
-        def instance_method_already_implemented?(method_name) #:nodoc:
+      private
+        def instance_method_already_implemented?(method_name)
           generated_attribute_methods.method_defined?(method_name)
         end
 
-      private
         # The methods +method_missing+ and +respond_to?+ of this module are
         # invoked often in a typical rails, both of which invoke the method
         # +matched_attribute_method+. The latter method iterates through an
@@ -349,11 +348,11 @@ module ActiveModel
         # used to alleviate the GC, which ultimately also speeds up the app
         # significantly (in our case our test suite finishes 10% faster with
         # this cache).
-        def attribute_method_matchers_cache #:nodoc:
+        def attribute_method_matchers_cache
           @attribute_method_matchers_cache ||= Concurrent::Map.new(initial_capacity: 4)
         end
 
-        def attribute_method_matchers_matching(method_name) #:nodoc:
+        def attribute_method_matchers_matching(method_name)
           attribute_method_matchers_cache.compute_if_absent(method_name) do
             # Must try to match prefixes/suffixes first, or else the matcher with no prefix/suffix
             # will match every time.
@@ -365,8 +364,8 @@ module ActiveModel
         # Define a method `name` in `mod` that dispatches to `send`
         # using the given `extra` args. This falls back on `define_method`
         # and `send` if the given names cannot be compiled.
-        def define_proxy_call(include_private, mod, name, send, *extra) #:nodoc:
-          defn = if name =~ NAME_COMPILABLE_REGEXP
+        def define_proxy_call(include_private, mod, name, send, *extra)
+          defn = if NAME_COMPILABLE_REGEXP.match?(name)
             "def #{name}(*args)"
           else
             "define_method(:'#{name}') do |*args|"
@@ -374,7 +373,7 @@ module ActiveModel
 
           extra = (extra.map!(&:inspect) << "*args").join(", ".freeze)
 
-          target = if send =~ CALL_COMPILABLE_REGEXP
+          target = if CALL_COMPILABLE_REGEXP.match?(send)
             "#{"self." unless include_private}#{send}(#{extra})"
           else
             "send(:'#{send}', #{extra})"
@@ -393,7 +392,7 @@ module ActiveModel
           AttributeMethodMatch = Struct.new(:target, :attr_name, :method_name)
 
           def initialize(options = {})
-            @prefix, @suffix = options.fetch(:prefix, ''), options.fetch(:suffix, '')
+            @prefix, @suffix = options.fetch(:prefix, ""), options.fetch(:suffix, "")
             @regex = /^(?:#{Regexp.escape(@prefix)})(.*)(?:#{Regexp.escape(@suffix)})$/
             @method_missing_target = "#{@prefix}attribute#{@suffix}"
             @method_name = "#{prefix}%s#{suffix}"
@@ -458,12 +457,11 @@ module ActiveModel
       end
     end
 
-    protected
-      def attribute_method?(attr_name) #:nodoc:
+    private
+      def attribute_method?(attr_name)
         respond_to_without_attributes?(:attributes) && attributes.include?(attr_name)
       end
 
-    private
       # Returns a struct representing the matching attribute method.
       # The struct's attributes are prefix, base and suffix.
       def matched_attribute_method(method_name)