activemodel 4.2.11.3 → 5.0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7f6de69f52b72621f82ed10eb387eb88cc7dc4818a3dff7b82d10a3540102d1
-  data.tar.gz: 2bbead6125859469e32d9b88d25f23f9e305d7ef41c7abe5a448a12677f6e5fd
+  metadata.gz: 037004e060b00ef9bdf166f1a123941008eac38445bf7b69de9e4325d27ad729
+  data.tar.gz: 323b17aae456ed4bd2e606dc308edee6cb3abc945d806fb753248e5bc4fe2f7d
 SHA512:
-  metadata.gz: 4805edb11e6e7034bd7bc4fb398deee1fe458f3cb576bfe73dcbc37577d2363a3fbc98f8230dfd145b8db8af3d328dbab1de5a9923df839954e615220689849d
-  data.tar.gz: 6da204b8c331e8c739d40ceb59f3e3d2b20c0f824f723599a852f750639b932cbb98ca6055dd28fab4f04e2ca2604dae129d9012b45ee31a20be3036a12ac7a8
+  metadata.gz: ad0dec431b9629aa031fbe36c6ae295f51a2d773fa9e325833189d177201c81c678aee6eb1298607a894a415dd0d1bd0f83e91f6edc7785b7b390af6c9e43b89
+  data.tar.gz: 7f5c74e105297822c1d10e088a6aa16641f5cefa6d3d71fde2a2d0e0495bf10565403cb8cd66c00cd241477bb80c997ba1d5a5be3b98ef3dbd8f3d4e142d6186

data/CHANGELOG.md

@@ -1,143 +1,236 @@
-## Rails 4.2.11.3 (May 15, 2020) ##
+## Rails 5.0.7.2 (March 11, 2019) ##
 
 *   No changes.
 
 
-## Rails 4.2.11.2 (May 15, 2020) ##
+## Rails 5.0.7.1 (November 27, 2018) ##
 
 *   No changes.
 
 
-## Rails 4.2.11.1 (March 11, 2019) ##
+## Rails 5.0.7 (March 29, 2018) ##
 
 *   No changes.
 
 
-## Rails 4.2.11 (November 27, 2018) ##
+## Rails 5.0.6 (September 07, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.10 (September 27, 2017) ##
+## Rails 5.0.6.rc1 (August 24, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.9 (June 26, 2017) ##
+## Rails 5.0.5 (July 31, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.8 (February 21, 2017) ##
+## Rails 5.0.5.rc2 (July 25, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.7 (July 12, 2016) ##
+## Rails 5.0.5.rc1 (July 19, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.6 (March 07, 2016) ##
+## Rails 5.0.4 (June 19, 2017) ##
 
-*   No changes.
+*   Fix regression in numericality validator when comparing Decimal and Float input 
+    values with more scale than the schema.
+
+    *Bradley Priest*
+
+
+## Rails 5.0.3 (May 12, 2017) ##
+
+*   The original string assigned to a model attribute is no longer incorrectly
+    frozen.
+
+    Fixes #24185, #28718.
+
+    *Matthew Draper*
+
+*   Avoid converting integer as a string into float.
 
+    *namusyaka*
 
-## Rails 4.2.5.2 (February 26, 2016) ##
+
+## Rails 5.0.2 (March 01, 2017) ##
 
 *   No changes.
 
 
-## Rails 4.2.5.1 (January 25, 2015) ##
+## Rails 5.0.1 (December 21, 2016) ##
 
 *   No changes.
 
 
-## Rails 4.2.5 (November 12, 2015) ##
+## Rails 5.0.1.rc2 (December 10, 2016) ##
 
 *   No changes.
 
 
-## Rails 4.2.4 (August 24, 2015) ##
+## Rails 5.0.1.rc1 (December 01, 2016) ##
 
-* No Changes *
+*   Fix `Type::Date#serialize` to cast a value to a date object properly.
+    This casting fixes queries for finding records by date column.
 
+    Fixes #25354.
 
-## Rails 4.2.3 (June 25, 2015) ##
+    *Ryuta Kamizono*
 
-* No Changes *
 
+## Rails 5.0.0 (June 30, 2016) ##
 
-## Rails 4.2.2 (June 16, 2015) ##
+*   `Dirty`'s `*_changed?` methods now return an actual singleton, never `nil`, as in 4.2.
+    Fixes #24220.
 
-* No Changes *
+    *Sen-Zhang*
 
+*   Ensure that instances of `ActiveModel::Errors` can be marshalled.
+    Fixes #25165.
 
-## Rails 4.2.1 (March 19, 2015) ##
+    *Sean Griffin*
 
-*   No changes.
+*   Allow passing record being validated to the message proc to generate
+    customized error messages for that object using I18n helper.
 
+    *Prathamesh Sonpatki*
 
-## Rails 4.2.0 (December 20, 2014) ##
+*   Validate multiple contexts on `valid?` and `invalid?` at once.
 
-*   Passwords with spaces only allowed in `ActiveModel::SecurePassword`.
+    Example:
 
-    Presence validation can be used to restore old behavior.
+        class Person
+          include ActiveModel::Validations
 
-    *Yevhene Shemet*
+          attr_reader :name, :title
+          validates_presence_of :name, on: :create
+          validates_presence_of :title, on: :update
+        end
 
-*   Validate options passed to `ActiveModel::Validations.validate`.
+        person = Person.new
+        person.valid?([:create, :update])    # => false
+        person.errors.messages               # => {:name=>["can't be blank"], :title=>["can't be blank"]}
 
-    Preventing, in many cases, the simple mistake of using `validate` instead of `validates`.
+    *Dmitry Polushkin*
 
-    *Sonny Michaud*
+*   Add case_sensitive option for confirmation validator in models.
 
-*   Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.
+    *Akshat Sharma*
 
-    These methods may cause confusion with the `reset_changes`, which has
-    different behaviour.
+*   Ensure `method_missing` is called for methods passed to
+    `ActiveModel::Serialization#serializable_hash` that don't exist.
 
-    *Rafael Mendonça França*
+    *Jay Elaraj*
 
-*   Deprecate `ActiveModel::Dirty#reset_changes` in favor of `#clear_changes_information`.
+*   Remove `ActiveModel::Serializers::Xml` from core.
 
-    Method's name is causing confusion with the `reset_#{attribute}` methods.
-    While `reset_name` sets the value of the name attribute to previous value
-    `reset_changes` only discards the changes.
+    *Zachary Scott*
 
-    *Rafael Mendonça França*
+*   Add `ActiveModel::Dirty#[attr_name]_previously_changed?` and
+    `ActiveModel::Dirty#[attr_name]_previous_change` to improve access
+    to recorded changes after the model has been saved.
+
+    It makes the dirty-attributes query methods consistent before and after
+    saving.
+
+    *Fernando Tapia Rico*
+
+*   Deprecate the `:tokenizer` option for `validates_length_of`, in favor of
+    plain Ruby.
+
+    *Sean Griffin*
 
-*   Added `restore_attributes` method to `ActiveModel::Dirty` API which restores
-    the value of changed attributes to previous value.
+*   Deprecate `ActiveModel::Errors#add_on_empty` and `ActiveModel::Errors#add_on_blank`
+    with no replacement.
 
-    *Igor G.*
+    *Wojciech Wnętrzak*
 
-*   Allow proc and symbol as values for `only_integer` of `NumericalityValidator`
+*   Deprecate `ActiveModel::Errors#get`, `ActiveModel::Errors#set` and
+    `ActiveModel::Errors#[]=` methods that have inconsistent behavior.
 
-    *Robin Mehner*
+    *Wojciech Wnętrzak*
 
-*   `has_secure_password` now verifies that the given password is less than 72
-    characters if validations are enabled.
+*   Allow symbol as values for `tokenize` of `LengthValidator`.
 
-    Fixes #14591.
+    *Kensuke Naito*
 
-    *Akshay Vishnoi*
+*   Assigning an unknown attribute key to an `ActiveModel` instance during initialization
+    will now raise `ActiveModel::AttributeAssignment::UnknownAttributeError` instead of
+    `NoMethodError`.
 
-*   Remove deprecated `Validator#setup` without replacement.
+    Example:
 
-    See #10716.
+        User.new(foo: 'some value')
+        # => ActiveModel::AttributeAssignment::UnknownAttributeError: unknown attribute 'foo' for User.
 
-    *Kuldeep Aggarwal*
+    *Eugene Gilburg*
 
-*   Add plural and singular form for length validator's default messages.
+*   Extracted `ActiveRecord::AttributeAssignment` to `ActiveModel::AttributeAssignment`
+    allowing to use it for any object as an includable module.
 
-    *Abd ar-Rahman Hamid*
+    Example:
+
+        class Cat
+          include ActiveModel::AttributeAssignment
+          attr_accessor :name, :status
+        end
+
+        cat = Cat.new
+        cat.assign_attributes(name: "Gorby", status: "yawning")
+        cat.name   # => 'Gorby'
+        cat.status # => 'yawning'
+        cat.assign_attributes(status: "sleeping")
+        cat.name   # => 'Gorby'
+        cat.status # => 'sleeping'
+
+    *Bogdan Gusiev*
+
+*   Add `ActiveModel::Errors#details`
+
+    To be able to return type of used validator, one can now call `details`
+    on errors instance.
+
+    Example:
+
+        class User < ActiveRecord::Base
+          validates :name, presence: true
+        end
+
+        user = User.new; user.valid?; user.errors.details
+        => {name: [{error: :blank}]}
+
+    *Wojciech Wnętrzak*
+
+*   Change `validates_acceptance_of` to accept `true` by default besides `'1'`.
+
+    The default for `validates_acceptance_of` is now `'1'` and `true`.
+    In the past, only `"1"` was the default and you were required to pass
+    `accept: true` separately.
+
+    *mokhan*
+
+*   Remove deprecated `ActiveModel::Dirty#reset_#{attribute}` and
+    `ActiveModel::Dirty#reset_changes`.
+
+    *Rafael Mendonça França*
 
-*   Introduce `validate` as an alias for `valid?`.
+*   Change the way in which callback chains can be halted.
 
-    This is more intuitive when you want to run validations but don't care about
-    the return value.
+    The preferred method to halt a callback chain from now on is to explicitly
+    `throw(:abort)`.
+    In the past, returning `false` in an Active Model `before_` callback had
+    the side effect of halting the callback chain.
+    This is not recommended anymore and, depending on the value of the
+    `ActiveSupport.halt_callback_chains_on_return_false` option, will
+    either not work at all or display a deprecation warning.
 
-    *Henrik Nyh*
+    *claudiob*
 
-Please check [4-1-stable](https://github.com/rails/rails/blob/4-1-stable/activemodel/CHANGELOG.md) for previous changes.
+Please check [4-2-stable](https://github.com/rails/rails/blob/4-2-stable/activemodel/CHANGELOG.md) for previous changes.

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2004-2014 David Heinemeier Hansson
+Copyright (c) 2004-2016 David Heinemeier Hansson
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.rdoc

@@ -49,7 +49,7 @@ behavior out of the box:
         send("#{attr}=", nil)
       end
     end
-  
+
     person = Person.new
     person.clear_name
     person.clear_age
@@ -132,7 +132,7 @@ behavior out of the box:
         "Name"
       end
     end
-  
+
     person = Person.new
     person.name = nil
     person.validate!
@@ -154,8 +154,8 @@ behavior out of the box:
 
 * Making objects serializable
 
-  ActiveModel::Serialization provides a standard interface for your object
-  to provide +to_json+ or +to_xml+ serialization.
+  <tt>ActiveModel::Serialization</tt> provides a standard interface for your object
+  to provide +to_json+ serialization.
 
     class SerialPerson
       include ActiveModel::Serialization
@@ -177,13 +177,6 @@ behavior out of the box:
     s = SerialPerson.new
     s.to_json             # => "{\"name\":null}"
 
-    class SerialPerson
-      include ActiveModel::Serializers::Xml
-    end
-
-    s = SerialPerson.new
-    s.to_xml              # => "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<serial-person...
-
   {Learn more}[link:classes/ActiveModel/Serialization.html]
 
 * Internationalization (i18n) support
@@ -216,10 +209,10 @@ behavior out of the box:
   {Learn more}[link:classes/ActiveModel/Validations.html]
 
 * Custom validators
-  
+
     class HasNameValidator < ActiveModel::Validator
       def validate(record)
-        record.errors[:name] = "must exist" if record.name.blank?
+        record.errors.add(:name, "must exist") if record.name.blank?
       end
     end
 
@@ -242,11 +235,11 @@ behavior out of the box:
 
 The latest version of Active Model can be installed with RubyGems:
 
-  % [sudo] gem install activemodel
+  $ gem install activemodel
 
 Source code can be downloaded as part of the Rails project on GitHub
 
-* https://github.com/rails/rails/tree/4-2-stable/activemodel
+* https://github.com/rails/rails/tree/5-0-stable/activemodel
 
 
 == License
@@ -269,4 +262,3 @@ Bug reports can be filed for the Ruby on Rails project here:
 Feature requests should be discussed on the rails-core mailing list here:
 
 * https://groups.google.com/forum/?fromgroups#!forum/rubyonrails-core
-

data/lib/active_model/attribute_assignment.rb

@@ -0,0 +1,52 @@
+require 'active_support/core_ext/hash/keys'
+
+module ActiveModel
+  module AttributeAssignment
+    include ActiveModel::ForbiddenAttributesProtection
+
+    # Allows you to set all the attributes by passing in a hash of attributes with
+    # keys matching the attribute names.
+    #
+    # If the passed hash responds to <tt>permitted?</tt> method and the return value
+    # of this method is +false+ an <tt>ActiveModel::ForbiddenAttributesError</tt>
+    # exception is raised.
+    #
+    #   class Cat
+    #     include ActiveModel::AttributeAssignment
+    #     attr_accessor :name, :status
+    #   end
+    #
+    #   cat = Cat.new
+    #   cat.assign_attributes(name: "Gorby", status: "yawning")
+    #   cat.name # => 'Gorby'
+    #   cat.status => 'yawning'
+    #   cat.assign_attributes(status: "sleeping")
+    #   cat.name # => 'Gorby'
+    #   cat.status => 'sleeping'
+    def assign_attributes(new_attributes)
+      if !new_attributes.respond_to?(:stringify_keys)
+        raise ArgumentError, "When assigning attributes, you must pass a hash as an argument."
+      end
+      return if new_attributes.nil? || new_attributes.empty?
+
+      attributes = new_attributes.stringify_keys
+      _assign_attributes(sanitize_for_mass_assignment(attributes))
+    end
+
+    private
+
+    def _assign_attributes(attributes)
+      attributes.each do |k, v|
+        _assign_attribute(k, v)
+      end
+    end
+
+    def _assign_attribute(k, v)
+      if respond_to?("#{k}=")
+        public_send("#{k}=", v)
+      else
+        raise UnknownAttributeError.new(self, k)
+      end
+    end
+  end
+end

data/lib/active_model/attribute_methods.rb

@@ -1,4 +1,4 @@
-require 'thread_safe'
+require 'concurrent/map'
 require 'mutex_m'
 
 module ActiveModel
@@ -23,7 +23,7 @@ module ActiveModel
   # The requirements to implement <tt>ActiveModel::AttributeMethods</tt> are to:
   #
   # * <tt>include ActiveModel::AttributeMethods</tt> in your class.
-  # * Call each of its method you want to add, such as +attribute_method_suffix+
+  # * Call each of its methods you want to add, such as +attribute_method_suffix+
   #   or +attribute_method_prefix+.
   # * Call +define_attribute_methods+ after the other methods are called.
   # * Define the various generic +_attribute+ methods that you have declared.
@@ -225,9 +225,9 @@ module ActiveModel
       end
 
       # Declares the attributes that should be prefixed and suffixed by
-      # ActiveModel::AttributeMethods.
+      # <tt>ActiveModel::AttributeMethods</tt>.
       #
-      # To use, pass attribute names (as strings or symbols), be sure to declare
+      # To use, pass attribute names (as strings or symbols). Be sure to declare
       # +define_attribute_methods+ after you define any prefix, suffix or affix
       # methods, or they will not hook in.
       #
@@ -239,7 +239,7 @@ module ActiveModel
       #
       #     # Call to define_attribute_methods must appear after the
       #     # attribute_method_prefix, attribute_method_suffix or
-      #     # attribute_method_affix declares.
+      #     # attribute_method_affix declarations.
       #     define_attribute_methods :name, :age, :address
       #
       #     private
@@ -253,9 +253,9 @@ module ActiveModel
       end
 
       # Declares an attribute that should be prefixed and suffixed by
-      # ActiveModel::AttributeMethods.
+      # <tt>ActiveModel::AttributeMethods</tt>.
       #
-      # To use, pass an attribute name (as string or symbol), be sure to declare
+      # To use, pass an attribute name (as string or symbol). Be sure to declare
       # +define_attribute_method+ after you define any prefix, suffix or affix
       # method, or they will not hook in.
       #
@@ -267,7 +267,7 @@ module ActiveModel
       #
       #     # Call to define_attribute_method must appear after the
       #     # attribute_method_prefix, attribute_method_suffix or
-      #     # attribute_method_affix declares.
+      #     # attribute_method_affix declarations.
       #     define_attribute_method :name
       #
       #     private
@@ -342,7 +342,7 @@ module ActiveModel
       private
         # The methods +method_missing+ and +respond_to?+ of this module are
         # invoked often in a typical rails, both of which invoke the method
-        # +match_attribute_method?+. The latter method iterates through an
+        # +matched_attribute_method+. The latter method iterates through an
         # array doing regular expression matches, which results in a lot of
         # object creations. Most of the time it returns a +nil+ match. As the
         # match result is always the same given a +method_name+, this cache is
@@ -350,7 +350,7 @@ module ActiveModel
         # significantly (in our case our test suite finishes 10% faster with
         # this cache).
         def attribute_method_matchers_cache #:nodoc:
-          @attribute_method_matchers_cache ||= ThreadSafe::Cache.new(initial_capacity: 4)
+          @attribute_method_matchers_cache ||= Concurrent::Map.new(initial_capacity: 4)
         end
 
         def attribute_method_matchers_matching(method_name) #:nodoc:
@@ -363,7 +363,7 @@ module ActiveModel
         end
 
         # Define a method `name` in `mod` that dispatches to `send`
-        # using the given `extra` args. This fallbacks `define_method`
+        # using the given `extra` args. This falls back on `define_method`
         # and `send` if the given names cannot be compiled.
         def define_proxy_call(include_private, mod, name, send, *extra) #:nodoc:
           defn = if name =~ NAME_COMPILABLE_REGEXP
@@ -372,7 +372,7 @@ module ActiveModel
             "define_method(:'#{name}') do |*args|"
           end
 
-          extra = (extra.map!(&:inspect) << "*args").join(", ")
+          extra = (extra.map!(&:inspect) << "*args").join(", ".freeze)
 
           target = if send =~ CALL_COMPILABLE_REGEXP
             "#{"self." unless include_private}#{send}(#{extra})"
@@ -419,7 +419,7 @@ module ActiveModel
     # returned by <tt>attributes</tt>, as though they were first-class
     # methods. So a +Person+ class with a +name+ attribute can for example use
     # <tt>Person#name</tt> and <tt>Person#name=</tt> and never directly use
-    # the attributes hash -- except for multiple assigns with
+    # the attributes hash -- except for multiple assignments with
     # <tt>ActiveRecord::Base#attributes=</tt>.
     #
     # It's also possible to instantiate related objects, so a <tt>Client</tt>
@@ -429,7 +429,7 @@ module ActiveModel
       if respond_to_without_attributes?(method, true)
         super
       else
-        match = match_attribute_method?(method.to_s)
+        match = matched_attribute_method(method.to_s)
         match ? attribute_missing(match, *args, &block) : super
       end
     end
@@ -454,7 +454,7 @@ module ActiveModel
         # but found among all methods. Which means that the given method is private.
         false
       else
-        !match_attribute_method?(method.to_s).nil?
+        !matched_attribute_method(method.to_s).nil?
       end
     end
 
@@ -466,7 +466,7 @@ module ActiveModel
     private
       # Returns a struct representing the matching attribute method.
       # The struct's attributes are prefix, base and suffix.
-      def match_attribute_method?(method_name)
+      def matched_attribute_method(method_name)
         matches = self.class.send(:attribute_method_matchers_matching, method_name)
         matches.detect { |match| attribute_method?(match.attr_name) }
       end

data/lib/active_model/callbacks.rb

@@ -6,7 +6,7 @@ module ActiveModel
   # Provides an interface for any class to have Active Record like callbacks.
   #
   # Like the Active Record methods, the callback chain is aborted as soon as
-  # one of the methods in the chain returns +false+.
+  # one of the methods throws +:abort+.
   #
   # First, extend ActiveModel::Callbacks from the class you are creating:
   #
@@ -49,7 +49,7 @@ module ActiveModel
   #    puts 'block successfully called.'
   #  end
   #
-  # You can choose not to have all three callbacks by passing a hash to the
+  # You can choose to have only specific callbacks by passing a hash to the
   # +define_model_callbacks+ method.
   #
   #   define_model_callbacks :create, only: [:after, :before]
@@ -103,7 +103,7 @@ module ActiveModel
     def define_model_callbacks(*callbacks)
       options = callbacks.extract_options!
       options = {
-        terminator: ->(_,result) { result == false },
+        terminator: deprecated_false_terminator,
         skip_after_callbacks_if_terminated: true,
         scope: [:kind, :name],
         only: [:before, :around, :after]

data/lib/active_model/conversion.rb

@@ -22,7 +22,7 @@ module ActiveModel
   module Conversion
     extend ActiveSupport::Concern
 
-    # If your object is already designed to implement all of the Active Model
+    # If your object is already designed to implement all of the \Active \Model
     # you can use the default <tt>:to_model</tt> implementation, which simply
     # returns +self+.
     #
@@ -33,15 +33,15 @@ module ActiveModel
     #   person = Person.new
     #   person.to_model == person # => true
     #
-    # If your model does not act like an Active Model object, then you should
+    # If your model does not act like an \Active \Model object, then you should
     # define <tt>:to_model</tt> yourself returning a proxy object that wraps
-    # your object with Active Model compliant methods.
+    # your object with \Active \Model compliant methods.
     def to_model
       self
     end
 
-    # Returns an Array of all key attributes if any is set, regardless if
-    # the object is persisted or not. Returns +nil+ if there are no key attributes.
+    # Returns an Array of all key attributes if any of the attributes is set, whether or not
+    # the object is persisted. Returns +nil+ if there are no key attributes.
     #
     #   class Person
     #     include ActiveModel::Conversion