activemodel 3.0.0.rc → 3.0.0.rc2

data/lib/active_model/serialization.rb

@@ -3,25 +3,25 @@ require 'active_support/core_ext/hash/slice'
 
 module ActiveModel
   # == Active Model Serialization
-  # 
+  #
   # Provides a basic serialization to a serializable_hash for your object.
-  # 
+  #
   # A minimal implementation could be:
-  #   
+  #
   #   class Person
-  #   
+  #
   #     include ActiveModel::Serialization
-  #   
+  #
   #     attr_accessor :name
-  #   
+  #
   #     def attributes
   #       @attributes ||= {'name' => 'nil'}
   #     end
-  #   
+  #
   #   end
-  # 
+  #
   # Which would provide you with:
-  # 
+  #
   #   person = Person.new
   #   person.serializable_hash   # => {"name"=>nil}
   #   person.name = "Bob"
@@ -29,38 +29,40 @@ module ActiveModel
   #
   # You need to declare some sort of attributes hash which contains the attributes
   # you want to serialize and their current value.
-  # 
-  # Most of the time though, you will want to include the JSON or XML 
-  # serializations.  Both of these modules automatically include the 
+  #
+  # Most of the time though, you will want to include the JSON or XML
+  # serializations.  Both of these modules automatically include the
   # ActiveModel::Serialization module, so there is no need to explicitly
   # include it.
-  # 
+  #
   # So a minimal implementation including XML and JSON would be:
-  #   
+  #
   #   class Person
-  #   
+  #
   #     include ActiveModel::Serializers::JSON
   #     include ActiveModel::Serializers::Xml
-  #   
+  #
   #     attr_accessor :name
-  #   
+  #
   #     def attributes
   #       @attributes ||= {'name' => 'nil'}
   #     end
-  #   
+  #
   #   end
-  # 
+  #
   # Which would provide you with:
-  # 
+  #
   #   person = Person.new
   #   person.serializable_hash   # => {"name"=>nil}
   #   person.to_json             # => "{\"name\":null}"
   #   person.to_xml              # => "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<serial-person...
-  # 
+  #
   #   person.name = "Bob"
   #   person.serializable_hash   # => {"name"=>"Bob"}
   #   person.to_json             # => "{\"name\":\"Bob\"}"
   #   person.to_xml              # => "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<serial-person...
+  #
+  # Valid options are <tt>:only</tt>, <tt>:except</tt> and <tt>:methods</tt> .
   module Serialization
     def serializable_hash(options = nil)
       options ||= {}

data/lib/active_model/serializers/xml.rb

@@ -52,7 +52,7 @@ module ActiveModel
           @options[:except] = Array.wrap(@options[:except]).map { |n| n.to_s }
         end
 
-        # To replicate the behavior in ActiveRecord#attributes, <tt>:except</tt> 
+        # To replicate the behavior in ActiveRecord#attributes, <tt>:except</tt>
         # takes precedence over <tt>:only</tt>.  If <tt>:only</tt> is not set
         # for a N level model but is set for the N+1 level models,
         # then because <tt>:except</tt> is set to a default value, the second

data/lib/active_model/translation.rb

@@ -3,19 +3,19 @@ require 'active_support/core_ext/hash/reverse_merge'
 module ActiveModel
 
   # == Active Model Translation
-  #   
+  #
   # Provides integration between your object and the Rails internationalization
   # (i18n) framework.
-  # 
+  #
   # A minimal implementation could be:
-  # 
+  #
   #   class TranslatedPerson
   #     extend ActiveModel::Translation
   #   end
-  # 
+  #
   #   TranslatedPerson.human_attribute_name('my_attribute')
-  #   #=> "My attribute"
-  # 
+  #   # => "My attribute"
+  #
   # This also provides the required class methods for hooking into the
   # Rails internationalization API, including being able to define a
   # class based i18n_scope and lookup_ancestors to find translations in
@@ -28,9 +28,9 @@ module ActiveModel
       :activemodel
     end
 
-    # When localizing a string, it goes through the lookup returned by this 
+    # When localizing a string, it goes through the lookup returned by this
     # method, which is used in ActiveModel::Name#human,
-    # ActiveModel::Errors#full_messages and 
+    # ActiveModel::Errors#full_messages and
     # ActiveModel::Translation#human_attribute_name.
     def lookup_ancestors
       self.ancestors.select { |x| x.respond_to?(:model_name) }

data/lib/active_model/validations.rb

@@ -2,47 +2,44 @@ require 'active_support/core_ext/array/extract_options'
 require 'active_support/core_ext/array/wrap'
 require 'active_support/core_ext/class/attribute'
 require 'active_support/core_ext/hash/keys'
+require 'active_support/core_ext/hash/except'
 require 'active_model/errors'
 require 'active_model/validations/callbacks'
 
 module ActiveModel
 
   # == Active Model Validations
-  #   
+  #
   # Provides a full validation framework to your objects.
-  # 
+  #
   # A minimal implementation could be:
-  # 
+  #
   #   class Person
   #     include ActiveModel::Validations
-  # 
+  #
   #     attr_accessor :first_name, :last_name
   #
   #     validates_each :first_name, :last_name do |record, attr, value|
   #       record.errors.add attr, 'starts with z.' if value.to_s[0] == ?z
   #     end
   #   end
-  # 
+  #
   # Which provides you with the full standard validation stack that you
-  # know from ActiveRecord.
-  # 
+  # know from Active Record:
+  #
   #   person = Person.new
-  #   person.valid?
-  #   #=> true
-  #   person.invalid?
-  #   #=> false
+  #   person.valid?                   # => true
+  #   person.invalid?                 # => false
+  #
   #   person.first_name = 'zoolander'
-  #   person.valid?
-  #   #=> false
-  #   person.invalid?
-  #   #=> true
-  #   person.errors
-  #   #=> #<OrderedHash {:first_name=>["starts with z."]}>
-  # 
+  #   person.valid?                   # => false
+  #   person.invalid?                 # => true
+  #   person.errors                   # => #<OrderedHash {:first_name=>["starts with z."]}>
+  #
   # Note that ActiveModel::Validations automatically adds an +errors+ method
   # to your instances initialized with a new ActiveModel::Errors object, so
   # there is no need for you to do this manually.
-  # 
+  #
   module Validations
     extend ActiveSupport::Concern
     include ActiveSupport::Callbacks
@@ -65,7 +62,7 @@ module ActiveModel
       #
       #   class Person
       #     include ActiveModel::Validations
-      # 
+      #
       #     attr_accessor :first_name, :last_name
       #
       #     validates_each :first_name, :last_name do |record, attr, value|
@@ -74,7 +71,7 @@ module ActiveModel
       #   end
       #
       # Options:
-      # * <tt>:on</tt> - Specifies when this validation is active (default is 
+      # * <tt>:on</tt> - Specifies when this validation is active (default is
       #   <tt>:save</tt>, other options <tt>:create</tt>, <tt>:update</tt>).
       # * <tt>:allow_nil</tt> - Skip validation if attribute is +nil+.
       # * <tt>:allow_blank</tt> - Skip validation if attribute is blank.
@@ -99,7 +96,7 @@ module ActiveModel
       #
       #   class Comment
       #     include ActiveModel::Validations
-      # 
+      #
       #     validate :must_be_friends
       #
       #     def must_be_friends
@@ -122,15 +119,29 @@ module ActiveModel
       #   end
       #
       def validate(*args, &block)
-        options = args.last
-        if options.is_a?(Hash) && options.key?(:on)
+        options = args.extract_options!
+        if options.key?(:on)
+          options = options.dup
           options[:if] = Array.wrap(options[:if])
           options[:if] << "validation_context == :#{options[:on]}"
         end
+        args << options
         set_callback(:validate, *args, &block)
       end
 
-      # List all validators that are being used to validate the model using 
+      [:create, :update].each do |type|
+        class_eval <<-RUBY
+          def validate_on_#{type}(*args, &block)
+            msg = "validate_on_#{type} is deprecated. Please use validate(args, :on => :#{type})"
+            ActiveSupport::Deprecation.warn(msg, caller)
+            options = args.extract_options!
+            options[:on] = :#{type}
+            validate(*args.push(options), &block)
+          end
+        RUBY
+      end
+
+      # List all validators that are being used to validate the model using
       # +validates_with+ method.
       def validators
         _validators.values.flatten.uniq
@@ -170,14 +181,14 @@ module ActiveModel
       self.validation_context = current_context
     end
 
-    # Performs the opposite of <tt>valid?</tt>. Returns true if errors were added, 
+    # Performs the opposite of <tt>valid?</tt>. Returns true if errors were added,
     # false otherwise.
     def invalid?(context = nil)
       !valid?(context)
     end
 
-    # Hook method defining how an attribute value should be retrieved. By default 
-    # this is assumed to be an instance named after the attribute. Override this 
+    # Hook method defining how an attribute value should be retrieved. By default
+    # this is assumed to be an instance named after the attribute. Override this
     # method in subclasses should you need to retrieve the value for a given
     # attribute differently:
     #
@@ -196,7 +207,7 @@ module ActiveModel
     alias :read_attribute_for_validation :send
 
   protected
-  
+
     def run_validations!
       _run_validate_callbacks
       errors.empty?

data/lib/active_model/validations/acceptance.rb

@@ -24,7 +24,7 @@ module ActiveModel
     end
 
     module HelperMethods
-      # Encapsulates the pattern of wanting to validate the acceptance of a 
+      # Encapsulates the pattern of wanting to validate the acceptance of a
       # terms of service check box (or similar agreement). Example:
       #
       #   class Person < ActiveRecord::Base
@@ -32,33 +32,33 @@ module ActiveModel
       #     validates_acceptance_of :eula, :message => "must be abided"
       #   end
       #
-      # If the database column does not exist, the +terms_of_service+ attribute 
+      # If the database column does not exist, the +terms_of_service+ attribute
       # is entirely virtual. This check is performed only if +terms_of_service+
       # is not +nil+ and by default on save.
       #
       # Configuration options:
-      # * <tt>:message</tt> - A custom error message (default is: "must be 
+      # * <tt>:message</tt> - A custom error message (default is: "must be
       #   accepted").
       # * <tt>:on</tt> - Specifies when this validation is active (default is
-      #   <tt>:save</tt>, other options are <tt>:create</tt> and 
+      #   <tt>:save</tt>, other options are <tt>:create</tt> and
       #   <tt>:update</tt>).
       # * <tt>:allow_nil</tt> - Skip validation if attribute is +nil+ (default
       #   is true).
-      # * <tt>:accept</tt> - Specifies value that is considered accepted. 
+      # * <tt>:accept</tt> - Specifies value that is considered accepted.
       #   The default value is a string "1", which makes it easy to relate to
-      #   an HTML checkbox. This should be set to +true+ if you are validating 
+      #   an HTML checkbox. This should be set to +true+ if you are validating
       #   a database column, since the attribute is typecast from "1" to +true+
       #   before validation.
       # * <tt>:if</tt> - Specifies a method, proc or string to call to determine
       #   if the validation should occur (e.g. <tt>:if => :allow_validation</tt>,
       #   or <tt>:if => Proc.new { |user| user.signup_step > 2 }</tt>).  The
-      #   method, proc or string should return or evaluate to a true or false 
+      #   method, proc or string should return or evaluate to a true or false
       #   value.
-      # * <tt>:unless</tt> - Specifies a method, proc or string to call to 
-      #   determine if the validation should not occur (for example, 
-      #   <tt>:unless => :skip_validation</tt>, or 
+      # * <tt>:unless</tt> - Specifies a method, proc or string to call to
+      #   determine if the validation should not occur (for example,
+      #   <tt>:unless => :skip_validation</tt>, or
       #   <tt>:unless => Proc.new { |user| user.signup_step <= 2 }</tt>).
-      #   The method, proc or string should return or evaluate to a true or 
+      #   The method, proc or string should return or evaluate to a true or
       #   false value.
       def validates_acceptance_of(*attr_names)
         validates_with AcceptanceValidator, _merge_attributes(attr_names)

data/lib/active_model/validations/callbacks.rb

@@ -14,7 +14,7 @@ module ActiveModel
       #     include ActiveModel::Validations::Callbacks
       #
       #     before_validation :do_stuff_before_validation
-      #     after_validation  :do_tuff_after_validation
+      #     after_validation  :do_stuff_after_validation
       #   end
       #
       #   Like other before_* callbacks if <tt>before_validation</tt> returns false
@@ -28,22 +28,36 @@ module ActiveModel
 
       module ClassMethods
         def before_validation(*args, &block)
-          options = args.last
+          options = args.extract_options!
           if options.is_a?(Hash) && options[:on]
             options[:if] = Array.wrap(options[:if])
             options[:if] << "self.validation_context == :#{options[:on]}"
           end
-          set_callback(:validation, :before, *args, &block)
+          set_callback(:validation, :before, *(args << options), &block)
         end
 
         def after_validation(*args, &block)
           options = args.extract_options!
           options[:prepend] = true
           options[:if] = Array.wrap(options[:if])
-          options[:if] << "!halted && value != false"
+          options[:if] << "!halted"
           options[:if] << "self.validation_context == :#{options[:on]}" if options[:on]
           set_callback(:validation, :after, *(args << options), &block)
         end
+
+        [:before, :after].each do |type|
+          [:create, :update].each do |on|
+            class_eval <<-RUBY
+              def #{type}_validation_on_#{on}(*args, &block)
+                msg = "#{type}_validation_on_#{on} is deprecated. Please use #{type}_validation(arguments, :on => :#{on}"
+                ActiveSupport::Deprecation.warn(msg, caller)
+                options = args.extract_options!
+                options[:on] = :#{on}
+                before_validation(*args.push(options), &block)
+              end
+            RUBY
+          end
+        end
       end
 
     protected

data/lib/active_model/validations/confirmation.rb

@@ -15,13 +15,13 @@ module ActiveModel
     end
 
     module HelperMethods
-      # Encapsulates the pattern of wanting to validate a password or email 
+      # Encapsulates the pattern of wanting to validate a password or email
       # address field with a confirmation. For example:
       #
       #   Model:
       #     class Person < ActiveRecord::Base
       #       validates_confirmation_of :user_name, :password
-      #       validates_confirmation_of :email_address, 
+      #       validates_confirmation_of :email_address,
       #                                 :message => "should match confirmation"
       #     end
       #
@@ -29,12 +29,12 @@ module ActiveModel
       #     <%= password_field "person", "password" %>
       #     <%= password_field "person", "password_confirmation" %>
       #
-      # The added +password_confirmation+ attribute is virtual; it exists only 
+      # The added +password_confirmation+ attribute is virtual; it exists only
       # as an in-memory attribute for validating the password. To achieve this,
-      # the validation adds accessors to the model for the confirmation 
+      # the validation adds accessors to the model for the confirmation
       # attribute.
-      # 
-      # NOTE: This check is performed only if +password_confirmation+ is not 
+      #
+      # NOTE: This check is performed only if +password_confirmation+ is not
       # +nil+, and by default only on save. To require confirmation, make sure
       # to add a presence check for the confirmation attribute:
       #
@@ -48,11 +48,11 @@ module ActiveModel
       # * <tt>:if</tt> - Specifies a method, proc or string to call to determine
       #   if the validation should occur (e.g. <tt>:if => :allow_validation</tt>,
       #   or <tt>:if => Proc.new { |user| user.signup_step > 2 }</tt>).  The
-      #   method, proc or string should return or evaluate to a true or false 
+      #   method, proc or string should return or evaluate to a true or false
       #   value.
-      # * <tt>:unless</tt> - Specifies a method, proc or string to call to 
-      #   determine if the validation should not occur (e.g. 
-      #   <tt>:unless => :skip_validation</tt>, or 
+      # * <tt>:unless</tt> - Specifies a method, proc or string to call to
+      #   determine if the validation should not occur (e.g.
+      #   <tt>:unless => :skip_validation</tt>, or
       #   <tt>:unless => Proc.new { |user| user.signup_step <= 2 }</tt>). The
       #   method, proc or string should return or evaluate to a true or false value.
       def validates_confirmation_of(*attr_names)

data/lib/active_model/validations/length.rb

@@ -34,25 +34,24 @@ module ActiveModel
           end
         end
       end
-        
+
       def validate_each(record, attribute, value)
         value = options[:tokenizer].call(value) if value.kind_of?(String)
 
         CHECKS.each do |key, validity_check|
           next unless check_value = options[key]
-          default_message = options[MESSAGES[key]]
-          options[:message] ||= default_message if default_message
 
-          valid_value = if key == :maximum
-            value.nil? || value.size.send(validity_check, check_value)
-          else
-            value && value.size.send(validity_check, check_value)
-          end
+          value ||= [] if key == :maximum
 
-          next if valid_value
+          next if value && value.size.send(validity_check, check_value)
+
+          errors_options = options.except(*RESERVED_OPTIONS)
+          errors_options[:count] = check_value
+
+          default_message = options[MESSAGES[key]]
+          errors_options[:message] ||= default_message if default_message
 
-          record.errors.add(attribute, MESSAGES[key],
-                            options.except(*RESERVED_OPTIONS).merge!(:count => check_value))
+          record.errors.add(attribute, MESSAGES[key], errors_options)
         end
       end
     end