activemodel-email_address_validator 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5580fb86ca5fc584177916ac313ca624193f64f06679f441521d5904250d4f2
-  data.tar.gz: ea37fa1181553939391da23a0a4894bc4b98186ca8b5f3b3dcb863c041013478
+  metadata.gz: ce32d9302e063c235e291b9743acc89088c167adb42ef820d3869c325b827a13
+  data.tar.gz: 910f0ee9ad0d42d408eb0d3b90aac4e1f647c54f627628a096d3b5a246411f30
 SHA512:
-  metadata.gz: f21ef9f11bf4ed601b420dab39bbe62206c47873226e22ee9c3db0597105aa23ffe8064379cd81f34f9367fbcc742689e5303c417bcb6032eeb7d326e3ff9b35
-  data.tar.gz: 4d4e2b281fec06eb2c15a3e5fce997fb67f9c6bb70899bedd5a681c5cc2318a6a89ac68653a239b7735f7a4b18a78bf979f56abcfa1f496a49cc45bc96c37e6a
+  metadata.gz: 7da25676700ae7c2003a01ad56cc8a5b2a6c9f81f3a38a6b956cccf244c9f6d26bf0d578ce3b5fe9495d2d5663f29cee6155cd198b5fca775ed64f4f66b1fe93
+  data.tar.gz: 7669cf81432b9ba999283832ca89dfefaff6bcaea22d2e6678ef5d91a2a58577541ee806d6f0c1cc8f7632a820f8bb251f6130a68cf31e5939c5efb625e670e9

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "weekly"

data/.github/workflows/ruby.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1']
+        ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
 
     steps:
     - uses: actions/checkout@v2
@@ -31,7 +31,7 @@ jobs:
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: '3.0'
+        ruby-version: '3.1'
         bundler-cache: true # runs 'bundle install' and caches installed gems automatically
     - name: Lint
       run: bundle exec standardrb

data/CHANGELOG.md

@@ -9,7 +9,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
--
+- Support for ActiveModel 7.
+
+- Support for Ruby 3.1 and 3.2.
+
+- Commas are no longer allowed anywhere in an email address. Thanks @prognostikos!
 
 ### Removed
 

data/activemodel-email_address_validator.gemspec

@@ -13,10 +13,9 @@ Gem::Specification.new do |spec|
 
   spec.files = `git ls-files -z`.split("\x0")
   spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activemodel", ">= 4.0", "< 7.0"
+  spec.add_dependency "activemodel", ">= 4.0", "< 8.0"
 
   spec.add_development_dependency "bundler", ">= 1.7"
   spec.add_development_dependency "rake", ">= 10.0"

data/lib/activemodel_email_address_validator/email_address.rb

@@ -20,20 +20,26 @@ module ActiveModelEmailAddressValidator
 
     attr_reader :address
 
+    def valid_host?(host)
+      /^([^,. ~]+\.)+[a-z]+$/.match?(host)
+    end
+
+    def valid_user?(user)
+      /^([^.]+\S)*[^.]+$/.match?(user)
+    end
+
     def valid_using_regex?(regex)
       address.to_s =~ regex
     end
 
     def valid_using_default?
-      return false if /\s+/.match?(address)
-      email_parts = address.split("@", -1)
+      return false if /(\s|["'<>,])+/.match?(address)
 
+      email_parts = address.split("@", -1)
       return false unless email_parts.size == 2
 
       user, host = *email_parts
-      return false unless /^([^.]+\S)*[^. ]+$/.match?(user)
-      return false unless /^([^,. ~]+\.)+[^,. ]+$/.match?(host)
-      true
+      valid_user?(user) && valid_host?(host)
     end
   end
 end

data/lib/activemodel_email_address_validator/version.rb

@@ -1,3 +1,3 @@
 module ActiveModelEmailAddressValidator
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/test/activemodel-email_address_validator/test_email_address.rb

@@ -113,6 +113,10 @@ class EmailAddressValidTest < MiniTest::Test
     reject("my@domain.com,")
   end
 
+  def test_rejects_commas_in_username
+    reject("foo,bar@domain.com")
+  end
+
   def test_rejects_tildes_in_hostname
     reject("my@~domain.com")
   end
@@ -121,6 +125,21 @@ class EmailAddressValidTest < MiniTest::Test
     reject("fernandeztorralbofrancisco@sabadellatlantico.")
   end
 
+  def test_rejects_ip_addresses
+    reject("email@123.123.12.123")
+  end
+
+  def test_rejects_script_injection
+    reject("email_<script></script>_123@example.co.in")
+  end
+
+  def test_rejects_username_with_quotation_mark
+    reject('email"123@example.com')
+    reject('email123@exa"mple.com')
+    reject("email'123@example.com")
+    reject("email123@exa'mple.com")
+  end
+
   private
 
   def accept(email_address)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemodel-email_address_validator
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Jakob Skjerning
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-10 00:00:00.000000000 Z
+date: 2023-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -19,7 +19,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '4.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -79,6 +79,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - CHANGELOG.md
@@ -117,7 +118,4 @@ rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: ActiveModel-style email address format validator
-test_files:
-- test/activemodel-email_address_validator/test_email_address.rb
-- test/minitest_helper.rb
-- test/test_active_model_integration.rb
+test_files: []