activemodel-email_address_validator 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 880e994c63a284ed895dfab2da408360b9cd70f8466176e99c1118d76e830f64
-  data.tar.gz: ef9a1389211791aff43ed9874421515e3417b7e2b00e85ce70ee478c8f8a837b
+  metadata.gz: b5580fb86ca5fc584177916ac313ca624193f64f06679f441521d5904250d4f2
+  data.tar.gz: ea37fa1181553939391da23a0a4894bc4b98186ca8b5f3b3dcb863c041013478
 SHA512:
-  metadata.gz: 0dd406cdb1537d8d8099e71531e8797b9d4ebe3f619842ef65eaf9d43fd1a31062739bbca7ed7fa3f46f63ba2da30a8949f1e0f5795b7af3f26e2ea3cc8c030c
-  data.tar.gz: c8ebc7e19f10ac906503606c8308c7ade2018a08840465743819d38f86598320955323020fbd73d8b0304794c2cc11104195a9a19639c9740bae246295735c73
+  metadata.gz: f21ef9f11bf4ed601b420dab39bbe62206c47873226e22ee9c3db0597105aa23ffe8064379cd81f34f9367fbcc742689e5303c417bcb6032eeb7d326e3ff9b35
+  data.tar.gz: 4d4e2b281fec06eb2c15a3e5fce997fb67f9c6bb70899bedd5a681c5cc2318a6a89ac68653a239b7735f7a4b18a78bf979f56abcfa1f496a49cc45bc96c37e6a

data/.github/workflows/ruby.yml

@@ -0,0 +1,37 @@
+name: Ruby
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1']
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Run tests
+      run: bundle exec rake
+
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '3.0'
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+    - name: Lint
+      run: bundle exec standardrb

data/CHANGELOG.md

@@ -5,6 +5,27 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## Unreleased
+
+### Added
+
+-
+
+### Removed
+
+-
+
+
+## [2.1.0]
+
+### Added
+
+- Support for Ruby 3.0. We've also started testing against Ruby 3.1 to be
+  prepared.
+
+- Email addresses with trailing @'s are no longer accepted. Thanks
+  @prognostikos!
+
 ## [2.0.0]
 
 ### Added

data/Gemfile

@@ -3,4 +3,5 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in activemodel-email_address_validator.gemspec
 gemspec
 
-gem "coveralls", :require => false
+gem "coveralls", require: false
+gem "standard", require: false

data/README.md

@@ -1,7 +1,7 @@
 # Email Address Validator
 ## ActiveModel-style email address format validator
 
-[![Build Status](https://travis-ci.org/substancelab/activemodel-email_address_validator.svg?branch=master)](https://travis-ci.org/substancelab/activemodel-email_address_validator) [![Code Climate](https://codeclimate.com/github/substancelab/activemodel-email_address_validator/badges/gpa.svg)](https://codeclimate.com/github/substancelab/activemodel-email_address_validator) [![Coverage Status](https://coveralls.io/repos/substancelab/activemodel-email_address_validator/badge.svg?branch=more-badges&service=github)](https://coveralls.io/github/substancelab/activemodel-email_address_validator?branch=more-badges)
+[![Code Climate](https://codeclimate.com/github/substancelab/activemodel-email_address_validator/badges/gpa.svg)](https://codeclimate.com/github/substancelab/activemodel-email_address_validator) [![Coverage Status](https://coveralls.io/repos/substancelab/activemodel-email_address_validator/badge.svg?branch=more-badges&service=github)](https://coveralls.io/github/substancelab/activemodel-email_address_validator?branch=more-badges)
 
 Whenever I have wanted to validate an email address it has been because I wanted to be somewhat certain I can send an email to someone. Usually this happens as part of a signup procedure.
 

data/Rakefile

@@ -6,7 +6,7 @@ Rake::TestTask.new(:test) do |t|
   t.libs << "test"
 end
 
-task :default => :test
+task default: :test
 
 desc "Launch an IRB console with the gem loaded"
 task :console do

data/activemodel-email_address_validator.gemspec

@@ -1,20 +1,19 @@
-# coding: utf-8
 lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "activemodel_email_address_validator/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "activemodel-email_address_validator"
-  spec.version       = ActiveModelEmailAddressValidator::VERSION
-  spec.authors       = ["Jakob Skjerning"]
-  spec.email         = ["jakob@mentalized.net"]
-  spec.summary       = "ActiveModel-style email address format validator"
-  spec.homepage      = ""
-  spec.license       = "MIT"
+  spec.name = "activemodel-email_address_validator"
+  spec.version = ActiveModelEmailAddressValidator::VERSION
+  spec.authors = ["Jakob Skjerning"]
+  spec.email = ["jakob@mentalized.net"]
+  spec.summary = "ActiveModel-style email address format validator"
+  spec.homepage = ""
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files -z`.split("\x0")
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activemodel", ">= 4.0", "< 7.0"

data/lib/activemodel_email_address_validator/email_address.rb

@@ -25,14 +25,14 @@ module ActiveModelEmailAddressValidator
     end
 
     def valid_using_default?
-      return false if address =~ /\s+/
-      email_parts = address.split("@")
+      return false if /\s+/.match?(address)
+      email_parts = address.split("@", -1)
 
       return false unless email_parts.size == 2
 
       user, host = *email_parts
-      return false unless user =~ /^([^.]+\S)*[^. ]+$/
-      return false unless host =~ /^([^,. ~]+\.)+[^,. ]+$/
+      return false unless /^([^.]+\S)*[^. ]+$/.match?(user)
+      return false unless /^([^,. ~]+\.)+[^,. ]+$/.match?(host)
       true
     end
   end

data/lib/activemodel_email_address_validator/version.rb

@@ -1,3 +1,3 @@
 module ActiveModelEmailAddressValidator
-  VERSION = "2.0.0"
+  VERSION = "2.1.0"
 end

data/test/activemodel-email_address_validator/test_email_address.rb

@@ -101,6 +101,14 @@ class EmailAddressValidTest < MiniTest::Test
     reject("my@nice@domain.com")
   end
 
+  def test_rejects_leading_at_signs
+    reject("@my@domain.com")
+  end
+
+  def test_rejects_trailing_at_signs
+    reject("my@domain.com@")
+  end
+
   def test_rejects_commas_in_hostname
     reject("my@domain.com,")
   end

data/test/minitest_helper.rb

@@ -7,9 +7,8 @@ require "activemodel-email_address_validator"
 require "minitest/autorun"
 require "minitest/spec"
 
-SIMPLEST_VALIDATION = {:email => {:email_address => true}}
+SIMPLEST_VALIDATION = {email: {email_address: true}}
 
-# rubocop:disable Metrics/MethodLength
 def build_model_with_validations(validations = SIMPLEST_VALIDATION)
   klass = Class.new do
     include ActiveModel::Validations

data/test/test_active_model_integration.rb

@@ -8,7 +8,7 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_accepts_nil_email_address
     @subject = build_model_with_validations(
-      :email => {:email_address => true, :allow_nil => true}
+      email: {email_address: true, allow_nil: true}
     )
     accept(nil, @subject)
   end
@@ -23,7 +23,7 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_adds_errors_to_validated_attribute
     subject = build_model_with_validations(
-      :work_email => {:email_address => true}
+      work_email: {email_address: true}
     )
     subject.work_email = "whatever"
     subject.valid?
@@ -33,7 +33,7 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_validates_with_custom_regular_expression
     subject = build_model_with_validations(
-      :email => {:email_address => {:format => /.+@enterprise\..+/}}
+      email: {email_address: {format: /.+@enterprise\..+/}}
     )
     accept("whatever@enterprise.museum", subject)
     reject("totally@valid.com", subject)
@@ -41,7 +41,7 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_validates_with_custom_regular_as_a_rule
     subject = build_model_with_validations(
-      :email => {:email_address => {:with => /.+@enterprise\..+/}}
+      email: {email_address: {with: /.+@enterprise\..+/}}
     )
     accept("whatever@enterprise.museum", subject)
     reject("totally@valid.com", subject)
@@ -49,9 +49,9 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_validates_with_proc
     subject = build_model_with_validations(
-      :email => {:email_address => {
-        :with => proc { |address| address == "foo" }}
-      }
+      email: {email_address: {
+        with: proc { |address| address == "foo" }
+      }}
     )
     accept("foo", subject)
     reject("foo@bar.com", subject)
@@ -59,12 +59,12 @@ class EmailAddressValidatorTest < MiniTest::Test
 
   def test_validates_with_multiple_procs
     subject = build_model_with_validations(
-      :email => {:email_address => {
-        :with => [
+      email: {email_address: {
+        with: [
           proc { |address| address == "ada" },
           proc { |address| address.reverse == address }
-        ]}
-      }
+        ]
+      }}
     )
     accept("ada", subject)
     reject("bob", subject)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemodel-email_address_validator
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Jakob Skjerning
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-04 00:00:00.000000000 Z
+date: 2021-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -72,15 +72,15 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - jakob@mentalized.net
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -98,7 +98,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -113,8 +113,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key: 
+rubygems_version: 3.2.32
+signing_key:
 specification_version: 4
 summary: ActiveModel-style email address format validator
 test_files:

data/.travis.yml

@@ -1,14 +0,0 @@
-language: ruby
-rvm:
-  - 2.4.6
-  - 2.5.5
-  - 2.6.3
-  - 2.7.0-preview1
-
-before_install:
-  - gem update --system
-  - gem install bundler
-
-notifications:
-  recipients:
-    - jakob@mentalized.net