activemerchant 1.83.0 → 1.84.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bec7d7bb4488b4a853885b567cbe5533dce6e6f
-  data.tar.gz: 3b7150eafd6d15ef759badc91f2f36239564b2ff
+  metadata.gz: 4602e2af4d4ec3329ce11f1576662b177dd71504
+  data.tar.gz: 8d66a22aa55c1e7b78dbcad4673e230e6ee3425f
 SHA512:
-  metadata.gz: 3dd7a5f0297f25668644ffc21512f28da4a5a8745f94c01892888ac06fe932ea023e7c0cb248c015322aade52304dce13f50f2cb22b885eeff7352bc973c1e86
-  data.tar.gz: 7b8157e7de8ca025be5d412663b7af949f312c981d23a890b638ba6afb2b858dccab8b4a6c4f2c7725709613558a5507323ab9aefc77e8af9ab270688e6d5b72
+  metadata.gz: 395ec9d80c88f8d49501e1a06aa9d7035f161bffec4ac6946729fad84efc87c3f2b28b2d185cfb9e2c69013c84477f7922a9413047e7ef2582fddd443c176749
+  data.tar.gz: ada93899bf3c38c65e6d28f516f6093690a764077d50d4d6d76b6e80e5097370dbcf7f44c876460ea4cadeb3e70ba1fbd9283d7466f193dd66fb92372542e5e8

data/CHANGELOG

@@ -2,6 +2,25 @@
 
 == HEAD
 
+== Version 1.84.0 (September 27, 2018)
+* PayU Latam: support partial captures [bpollack] #2974
+* Braintree: Reflect correct test mode in Braintree responses [elfassy] [#2980]
+* FirstPay: Expose error code [curiousepic] #2979
+* Barclaycard Smartpay: Pass device_fingerprint when specified [dtykocki] #2981
+* Komoju: remove no-longer-relevant sandbox URL [miyazawadegica] #2987
+* [POSSIBLE BREAKAGE] Determine credit cards via functions [bpollack] #2983
+* Drop support for Laser cards [bpollack] #2983
+* Improve Maestro card detection [bpollack] #2983
+* Add ROU alpha3 code for Romania [dtykocki] #2989
+* [POSSIBLE BREAKAGE] Drop support for Solo and Switch cards [bpollack] #2991
+* Add support for Carnet cards [bpollack] #2992
+* Stripe: support a reason for voiding a transaction [whitby3001] #2378
+* Payeezy: Add reversal_id in support of timeout reversals [dtykocki] #2997
+* Stripe: support Level 3 transaction fields [bpollack] #2996
+* Conekta: support Carnet cards [bpollack] #2999
+* Openpay: support Carnet cards [bpollack] #2999
+* Adyen: Add support for GooglePay [dtykocki] #2971
+
 == Version 1.83.0 (August 30, 2018)
 * CT Payment: Update How Address is Passed [nfarve] #2960
 * Adyen: Add RecurringProcessingModel [nfarve] #2951

data/lib/active_merchant/billing/base.rb

@@ -49,7 +49,7 @@ module ActiveMerchant #:nodoc:
       #   notification = chronopay.notification(raw_post)
       #
       def self.integration(name)
-        Billing::Integrations.const_get("#{name.to_s.downcase}".camelize)
+        Billing::Integrations.const_get(name.to_s.downcase.camelize)
       end
 
       # A check to see if we're in test mode

data/lib/active_merchant/billing/check.rb

@@ -7,8 +7,8 @@ module ActiveMerchant #:nodoc:
     # You may use Check in place of CreditCard with any gateway that supports it.
     class Check < Model
       attr_accessor :first_name, :last_name,
-                    :bank_name, :routing_number, :account_number,
-                    :account_holder_type, :account_type, :number
+        :bank_name, :routing_number, :account_number,
+        :account_holder_type, :account_type, :number
 
       # Used for Canadian bank accounts
       attr_accessor :institution_number, :transit_number
@@ -53,6 +53,7 @@ module ActiveMerchant #:nodoc:
       def credit_card?
         false
       end
+
       # Routing numbers may be validated by calculating a checksum and dividing it by 10. The
       # formula is:
       #   (3(d1 + d4 + d7) + 7(d2 + d5 + d8) + 1(d3 + d6 + d9))mod 10 = 0

data/lib/active_merchant/billing/compatibility.rb

@@ -29,9 +29,7 @@ module ActiveMerchant
         result = lower_case_and_underscored_word.to_s.dup
         result.gsub!(/_id$/, '')
         result.gsub!(/_/, ' ')
-        result.gsub(/([a-z\d]*)/i) { |match|
-          match.downcase
-        }.gsub(/^\w/) { $&.upcase }
+        result.gsub(/([a-z\d]*)/i, &:downcase).gsub(/^\w/) { $&.upcase }
       end
     end
   end
@@ -102,7 +100,7 @@ module ActiveMerchant
             self.each do |key, messages|
               next unless(messages && !messages.empty?)
               if key == 'base'
-                result << "#{messages.first}"
+                result << messages.first.to_s
               else
                 result << "#{Compatibility.humanize(key)} #{messages.first}"
               end

data/lib/active_merchant/billing/credit_card.rb

@@ -15,12 +15,9 @@ module ActiveMerchant #:nodoc:
     # * American Express
     # * Diner's Club
     # * JCB
-    # * Switch
-    # * Solo
     # * Dankort
     # * Maestro
     # * Forbrugsforeningen
-    # * Laser
     #
     # For testing purposes, use the 'bogus' credit card brand. This skips the vast majority of
     # validations, allowing you to focus on your core concerns until you're ready to be more concerned
@@ -88,12 +85,9 @@ module ActiveMerchant #:nodoc:
       # * +'american_express'+
       # * +'diners_club'+
       # * +'jcb'+
-      # * +'switch'+
-      # * +'solo'+
       # * +'dankort'+
       # * +'maestro'+
       # * +'forbrugsforeningen'+
-      # * +'laser'+
       #
       # Or, if you wish to test your implementation, +'bogus'+.
       #
@@ -121,10 +115,6 @@ module ActiveMerchant #:nodoc:
       # @return [String]
       attr_accessor :last_name
 
-      # Required for Switch / Solo cards
-      attr_reader :start_month, :start_year
-      attr_accessor :issue_number
-
       # Returns or sets the card verification value.
       #
       # This attribute is optional but recommended. The verification value is
@@ -303,8 +293,7 @@ module ActiveMerchant #:nodoc:
 
         errors_hash(
           errors +
-          validate_card_brand_and_number +
-          validate_switch_or_solo_attributes
+          validate_card_brand_and_number
         )
       end
 
@@ -350,7 +339,7 @@ module ActiveMerchant #:nodoc:
         errors = []
 
         if !empty?(brand)
-          errors << [:brand, 'is invalid']  if !CreditCard.card_companies.keys.include?(brand)
+          errors << [:brand, 'is invalid']  if !CreditCard.card_companies.include?(brand)
         end
 
         if empty?(number)
@@ -379,27 +368,6 @@ module ActiveMerchant #:nodoc:
         errors
       end
 
-      def validate_switch_or_solo_attributes #:nodoc:
-        errors = []
-
-        if %w[switch solo].include?(brand)
-          valid_start_month = valid_month?(start_month)
-          valid_start_year = valid_start_year?(start_year)
-
-          if((!valid_start_month || !valid_start_year) && !valid_issue_number?(issue_number))
-            if empty?(issue_number)
-              errors << [:issue_number, 'cannot be empty']
-              errors << [:start_month, 'is invalid'] if !valid_start_month
-              errors << [:start_year,  'is invalid'] if !valid_start_year
-            else
-              errors << [:issue_number, 'is invalid'] if !valid_issue_number?(issue_number)
-            end
-          end
-        end
-
-        errors
-      end
-
       class ExpiryDate #:nodoc:
         attr_reader :month, :year
         def initialize(month, year)
@@ -412,14 +380,13 @@ module ActiveMerchant #:nodoc:
         end
 
         def expiration #:nodoc:
-          begin
-            Time.utc(year, month, month_days, 23, 59, 59)
-          rescue ArgumentError
-            Time.at(0).utc
-          end
+          Time.utc(year, month, month_days, 23, 59, 59)
+        rescue ArgumentError
+          Time.at(0).utc
         end
 
         private
+
         def month_days
           mdays = [nil,31,28,31,30,31,30,31,31,30,31,30,31]
           mdays[2] = 29 if Date.leap?(year)

data/lib/active_merchant/billing/credit_card_formatting.rb

@@ -1,7 +1,6 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     module CreditCardFormatting
-
       def expdate(credit_card)
         "#{format(credit_card.month, :two_digits)}#{format(credit_card.year, :two_digits)}"
       end

data/lib/active_merchant/billing/credit_card_methods.rb

@@ -2,21 +2,24 @@ module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     # Convenience methods that can be included into a custom Credit Card object, such as an ActiveRecord based Credit Card object.
     module CreditCardMethods
-      CARD_COMPANIES = {
-        'visa'               => /^4\d{12}(\d{3})?(\d{3})?$/,
-        'master'             => /^(5[1-5]\d{4}|677189|222[1-9]\d{2}|22[3-9]\d{3}|2[3-6]\d{4}|27[01]\d{3}|2720\d{2})\d{10}$/,
-        'discover'           => /^(6011|65\d{2}|64[4-9]\d)\d{12}|(62\d{14})$/,
-        'american_express'   => /^3[47]\d{13}$/,
-        'diners_club'        => /^3(0[0-5]|[68]\d)\d{11}$/,
-        'jcb'                => /^35(28|29|[3-8]\d)\d{12}$/,
-        'switch'             => /^6759\d{12}(\d{2,3})?$/,
-        'solo'               => /^6767\d{12}(\d{2,3})?$/,
-        'dankort'            => /^5019\d{12}$/,
-        'maestro'            => /^(5[06-8]|6\d)\d{10,17}$/,
-        'forbrugsforeningen' => /^600722\d{10}$/,
-        'laser'              => /^(6304|6706|6709|6771(?!89))\d{8}(\d{4}|\d{6,7})?$/,
-        'sodexo'             => /^(606071|603389|606070|606069|606068|600818)\d{8}$/,
-        'vr'                 => /^(627416|637036)\d{8}$/
+      CARD_COMPANY_DETECTORS = {
+        'visa'               => ->(num) { num =~ /^4\d{12}(\d{3})?(\d{3})?$/ },
+        'master'             => ->(num) { num&.size == 16 && in_bin_range?(num.slice(0, 6), MASTERCARD_RANGES) },
+        'discover'           => ->(num) { num =~ /^(6011|65\d{2}|64[4-9]\d)\d{12}|(62\d{14})$/ },
+        'american_express'   => ->(num) { num =~ /^3[47]\d{13}$/ },
+        'diners_club'        => ->(num) { num =~ /^3(0[0-5]|[68]\d)\d{11}$/ },
+        'jcb'                => ->(num) { num =~ /^35(28|29|[3-8]\d)\d{12}$/ },
+        'dankort'            => ->(num) { num =~ /^5019\d{12}$/ },
+        'maestro'            => ->(num) { (12..19).include?(num&.size) && in_bin_range?(num.slice(0, 6), MAESTRO_RANGES) },
+        'forbrugsforeningen' => ->(num) { num =~ /^600722\d{10}$/ },
+        'sodexo'             => ->(num) { num =~ /^(606071|603389|606070|606069|606068|600818)\d{8}$/ },
+        'vr'                 => ->(num) { num =~ /^(627416|637036)\d{8}$/ },
+        'carnet'             => lambda { |num|
+          num&.size == 16 && (
+            in_bin_range?(num.slice(0, 6), CARNET_RANGES) ||
+            CARNET_BINS.any? { |bin| num.slice(0, bin.size) == bin }
+          )
+        }
       }
 
       # http://www.barclaycard.co.uk/business/files/bin_rules.pdf
@@ -39,12 +42,43 @@ module ActiveMerchant #:nodoc:
         (491730..491759),
       ]
 
+      CARNET_RANGES = [
+        (506199..506499),
+      ]
+
+      CARNET_BINS = Set.new(
+        [
+          '286900', '502275', '606333', '627535', '636318', '636379', '639388',
+          '639484', '639559', '50633601', '50633606', '58877274', '62753500',
+          '60462203', '60462204', '588772'
+        ]
+      )
+
+      # https://www.mastercard.us/content/dam/mccom/global/documents/mastercard-rules.pdf, page 73
+      MASTERCARD_RANGES = [
+        (222100..272099),
+        (510000..559999),
+      ]
+
+      # https://www.mastercard.us/content/dam/mccom/global/documents/mastercard-rules.pdf, page 73
+      MAESTRO_RANGES = [
+        (639000..639099),
+        (670000..679999),
+      ]
+
       def self.included(base)
         base.extend(ClassMethods)
       end
 
+      def self.in_bin_range?(number, ranges)
+        bin = number.to_i
+        ranges.any? do |range|
+          range.cover?(bin)
+        end
+      end
+
       def valid_month?(month)
-        (1..12).include?(month.to_i)
+        (1..12).cover?(month.to_i)
       end
 
       def credit_card?
@@ -77,7 +111,14 @@ module ActiveMerchant #:nodoc:
       end
 
       def card_verification_value_length(brand)
-        brand == 'american_express' ? 4 : 3
+        case brand
+        when 'american_express'
+          4
+        when 'maestro'
+          0
+        else
+          3
+        end
       end
 
       def valid_issue_number?(number)
@@ -103,37 +144,18 @@ module ActiveMerchant #:nodoc:
             valid_checksum?(number)
         end
 
-        # Regular expressions for the known card companies.
-        #
-        # References:
-        # - http://en.wikipedia.org/wiki/Credit_card_number
-        # - http://www.barclaycardbusiness.co.uk/information_zone/processing/bin_rules.html
         def card_companies
-          CARD_COMPANIES
+          CARD_COMPANY_DETECTORS.keys
         end
 
         # Returns a string containing the brand of card from the list of known information below.
-        # Need to check the cards in a particular order, as there is some overlap of the allowable ranges
-        #--
-        # TODO Refactor this method. We basically need to tighten up the Maestro Regexp.
-        #
-        # Right now the Maestro regexp overlaps with the MasterCard regexp (IIRC). If we can tighten
-        # things up, we can boil this whole thing down to something like...
-        #
-        #   def brand?(number)
-        #     return 'visa' if valid_test_mode_card_number?(number)
-        #     card_companies.find([nil]) { |brand, regexp| number =~ regexp }.first.dup
-        #   end
-        #
         def brand?(number)
           return 'bogus' if valid_test_mode_card_number?(number)
 
-          card_companies.reject { |c,p| c == 'maestro' }.each do |company, pattern|
-            return company.dup if number =~ pattern
+          CARD_COMPANY_DETECTORS.each do |company, func|
+            return company.dup if func.call(number)
           end
 
-          return 'maestro' if number =~ card_companies['maestro']
-
           return nil
         end
 
@@ -154,11 +176,12 @@ module ActiveMerchant #:nodoc:
         end
 
         def first_digits(number)
-          number.to_s.slice(0,6)
+          number.slice(0,6)
         end
 
         def last_digits(number)
-          number.to_s.length <= 4 ? number : number.to_s.slice(-4..-1)
+          return '' if number.nil?
+          number.length <= 4 ? number : number.slice(-4..-1)
         end
 
         def mask(number)
@@ -178,16 +201,16 @@ module ActiveMerchant #:nodoc:
         private
 
         def valid_card_number_length?(number) #:nodoc:
-          number.to_s.length >= 12
+          number.length >= 12
         end
 
         def valid_card_number_characters?(number) #:nodoc:
-          !number.to_s.match(/\D/)
+          !number.match(/\D/)
         end
 
         def valid_test_mode_card_number?(number) #:nodoc:
           ActiveMerchant::Billing::Base.test? &&
-            %w[1 2 3 success failure error].include?(number.to_s)
+            %w[1 2 3 success failure error].include?(number)
         end
 
         ODD_LUHN_VALUE = {

data/lib/active_merchant/billing/gateway.rb

@@ -56,8 +56,6 @@ module ActiveMerchant #:nodoc:
       include PostsData
       include CreditCardFormatting
 
-      DEBIT_CARDS = [ :switch, :solo ]
-
       CREDIT_DEPRECATION_MESSAGE = 'Support for using credit to refund existing transactions is deprecated and will be removed from a future release of ActiveMerchant. Please use the refund method instead.'
       RECURRING_DEPRECATION_MESSAGE = 'Recurring functionality in ActiveMerchant is deprecated and will be removed in a future version. Please contact the ActiveMerchant maintainers if you have an interest in taking ownership of a separate gem that continues support for it.'
 
@@ -195,7 +193,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def scrub(transcript)
-        raise RuntimeError.new('This gateway does not support scrubbing.')
+        raise 'This gateway does not support scrubbing.'
       end
 
       def supports_network_tokenization?
@@ -305,11 +303,6 @@ module ActiveMerchant #:nodoc:
         [first_name, last_name]
       end
 
-      def requires_start_date_or_issue_number?(credit_card)
-        return false if card_brand(credit_card).blank?
-        DEBIT_CARDS.include?(card_brand(credit_card).to_sym)
-      end
-
       def requires!(hash, *params)
         params.each do |param|
           if param.is_a?(Array)

data/lib/active_merchant/billing/gateways/adyen.rb

@@ -121,6 +121,7 @@ module ActiveMerchant #:nodoc:
         post[:additionalData] ||= {}
         post[:additionalData][:overwriteBrand] = normalize(options[:overwrite_brand]) if options[:overwrite_brand]
         post[:additionalData][:customRoutingFlag] = options[:custom_routing_flag] if options[:custom_routing_flag]
+        post[:additionalData]['paymentdatasource.type'] = NETWORK_TOKENIZATION_CARD_SOURCE[payment.source.to_s] if payment.is_a?(NetworkTokenizationCreditCard)
       end
 
       def add_shopper_interaction(post, payment, options={})
@@ -248,7 +249,6 @@ module ActiveMerchant #:nodoc:
           test: test?,
           error_code: success ? nil : error_code_from(response)
         )
-
       end
 
       def url

data/lib/active_merchant/billing/gateways/allied_wallet.rb

@@ -128,7 +128,6 @@ module ActiveMerchant #:nodoc:
         post[transactions[action]] = authorization
       end
 
-
       ACTIONS = {
         purchase: 'SALE',
         authorize: 'AUTHORIZE',

data/lib/active_merchant/billing/gateways/authorize_net.rb

@@ -604,7 +604,6 @@ module ActiveMerchant
           xml.zip(truncate(address[:zip], 20))
           xml.country(truncate(address[:country], 60))
         end
-
       end
 
       def add_order_id(xml, options)

data/lib/active_merchant/billing/gateways/axcessms.rb

@@ -8,7 +8,7 @@ module ActiveMerchant #:nodoc:
                                     GI GR HR HU IE IL IM IS IT LI LT LU LV MC MT MX NL
                                     NO PL PT RO RU SE SI SK TR US VA)
 
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :maestro, :solo]
+      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :maestro]
 
       self.homepage_url = 'http://www.axcessms.com/'
       self.display_name = 'Axcess MS'

data/lib/active_merchant/billing/gateways/balanced.rb

@@ -117,8 +117,8 @@ module ActiveMerchant #:nodoc:
         case identifier
         when %r{\|}
           uri = identifier.
-            split('|').
-            detect{|part| part.size > 0}
+                split('|').
+                detect{|part| part.size > 0}
           uri.split('/')[2]
         when %r{\/}
           identifier.split('/')[5]
@@ -172,7 +172,7 @@ module ActiveMerchant #:nodoc:
           message_from(raw_response),
           raw_response,
           authorization: authorization_from(entity_name, raw_response),
-          test: test?,
+          test: test?
         )
       end
 
@@ -236,12 +236,12 @@ module ActiveMerchant #:nodoc:
 
       def headers
         @@ua ||= JSON.dump(
-           bindings_version: ActiveMerchant::VERSION,
-           lang: 'ruby',
-           lang_version: "#{RUBY_VERSION} p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE})",
-           lib_version: BalancedGateway::VERSION,
-           platform: RUBY_PLATFORM,
-           publisher: 'active_merchant'
+          bindings_version: ActiveMerchant::VERSION,
+          lang: 'ruby',
+          lang_version: "#{RUBY_VERSION} p#{RUBY_PATCHLEVEL} (#{RUBY_RELEASE_DATE})",
+          lib_version: BalancedGateway::VERSION,
+          platform: RUBY_PLATFORM,
+          publisher: 'active_merchant'
         )
 
         {