activemerchant 1.83.0 → 1.84.0

data/lib/active_merchant/billing/gateways/linkpoint.rb

@@ -2,7 +2,6 @@ require 'rexml/document'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
-
     # Initialization Options
     # :login                Your store number
     # :pem                  The text of your linkpoint PEM file. Note
@@ -259,6 +258,7 @@ module ActiveMerchant #:nodoc:
       end
 
       private
+
       # Commit the transaction by posting the XML file to the LinkPoint server
       def commit(money, creditcard, options = {})
         response = parse(ssl_post(test? ? self.test_url : self.live_url, post_data(money, creditcard, options)))
@@ -324,7 +324,6 @@ module ActiveMerchant #:nodoc:
       # Set up the parameters hash just once so we don't have to do it
       # for every action.
       def parameters(money, creditcard, options = {})
-
         params = {
           :payment => {
             :subtotal => amount(options[:subtotal]),
@@ -418,7 +417,6 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(xml)
-
         # For reference, a typical response...
         # <r_csp></r_csp>
         # <r_time></r_time>

data/lib/active_merchant/billing/gateways/litle.rb

@@ -364,7 +364,7 @@ module ActiveMerchant #:nodoc:
 
         doc = Nokogiri::XML(xml).remove_namespaces!
         doc.xpath("//litleOnlineResponse/#{kind}Response/*").each do |node|
-          if (node.elements.empty?)
+          if node.elements.empty?
             parsed[node.name.to_sym] = node.text
           else
             node.elements.each do |childnode|

data/lib/active_merchant/billing/gateways/mastercard.rb

@@ -1,7 +1,6 @@
 module ActiveMerchant
   module Billing
     module MastercardGateway
-
       def initialize(options={})
         requires!(options, :userid, :password)
         super
@@ -81,6 +80,7 @@ module ActiveMerchant
       end
 
       private
+
       def new_post
         {
           order: {},
@@ -262,7 +262,6 @@ module ActiveMerchant
         next_transactionid = SecureRandom.uuid
         [orderid, next_transactionid, prev_transactionid]
       end
-
     end
   end
 end

data/lib/active_merchant/billing/gateways/mercado_pago.rb

@@ -119,7 +119,6 @@ module ActiveMerchant #:nodoc:
           ip_address: options[:ip_address]
         }.merge(options[:additional_info] || {})
 
-
         add_address(post, options)
         add_shipping_address(post, options)
       end

data/lib/active_merchant/billing/gateways/merchant_e_solutions.rb

@@ -158,7 +158,6 @@ module ActiveMerchant #:nodoc:
         url = test? ? self.test_url : self.live_url
         parameters[:transaction_amount]  = amount(money) if money unless action == 'V'
 
-
         response = begin
           parse( ssl_post(url, post_data(action,parameters)) )
         rescue ActiveMerchant::ResponseError => e

data/lib/active_merchant/billing/gateways/merchant_one.rb

@@ -77,7 +77,7 @@ module ActiveMerchant #:nodoc:
       def add_creditcard(post, creditcard)
        post['cvv'] = creditcard.verification_value
        post['ccnumber'] = creditcard.number
-       post['ccexp'] =  "#{sprintf("%02d", creditcard.month)}#{"#{creditcard.year}"[-2, 2]}"
+       post['ccexp'] = "#{sprintf("%02d", creditcard.month)}#{creditcard.year.to_s[-2, 2]}"
       end
 
       def commit(action, money, parameters={})

data/lib/active_merchant/billing/gateways/merchant_ware.rb

@@ -293,9 +293,9 @@ module ActiveMerchant #:nodoc:
       def commit(action, request, v4 = false)
         begin
           data = ssl_post(url(v4), request,
-                   'Content-Type' => 'text/xml; charset=utf-8',
-                   'SOAPAction'   => soap_action(action, v4)
-                 )
+            'Content-Type' => 'text/xml; charset=utf-8',
+            'SOAPAction'   => soap_action(action, v4)
+          )
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
           response = parse_error(e.response)

data/lib/active_merchant/billing/gateways/merchant_ware_version_four.rb

@@ -262,9 +262,9 @@ module ActiveMerchant #:nodoc:
       def commit(action, request)
         begin
           data = ssl_post(url, request,
-                   'Content-Type' => 'text/xml; charset=utf-8',
-                   'SOAPAction'   => soap_action(action)
-                 )
+            'Content-Type' => 'text/xml; charset=utf-8',
+            'SOAPAction'   => soap_action(action)
+          )
           response = parse(action, data)
         rescue ActiveMerchant::ResponseError => e
           response = parse_error(e.response, action)

data/lib/active_merchant/billing/gateways/mercury.rb

@@ -319,7 +319,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def authorization_from(response)
-        dollars, cents = (response[:purchase] || '').split('.').collect{|e| e.to_i}
+        dollars, cents = (response[:purchase] || '').split('.').collect(&:to_i)
         dollars ||= 0
         cents ||= 0
         [

data/lib/active_merchant/billing/gateways/micropayment.rb

@@ -12,7 +12,6 @@ module ActiveMerchant #:nodoc:
       self.money_format = :cents
       self.supported_cardtypes = [:visa, :master, :american_express]
 
-
       def initialize(options={})
         requires!(options, :access_key)
         super
@@ -57,7 +56,6 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify(credit_card, options={})
-
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(250, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }

data/lib/active_merchant/billing/gateways/modern_payments.rb

@@ -28,6 +28,7 @@ module ActiveMerchant #:nodoc:
       end
 
       private
+
       def cim
         @cim ||= ModernPaymentsCimGateway.new(@options)
       end

data/lib/active_merchant/billing/gateways/modern_payments_cim.rb

@@ -66,6 +66,7 @@ module ActiveMerchant #:nodoc:
       end
 
       private
+
       def add_payment_details(post, options)
         post[:pmtDate] = (options[:payment_date] || Time.now.utc).strftime('%Y-%m-%dT%H:%M:%SZ')
         post[:pmtType] = PAYMENT_METHOD[options[:payment_method] || :credit_card]
@@ -146,9 +147,9 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, params)
         data = ssl_post(url(action), build_request(action, params),
-                 { 'Content-Type' =>'text/xml; charset=utf-8',
-                   'SOAPAction' => "#{xmlns(action)}#{action}" }
-                )
+          { 'Content-Type' =>'text/xml; charset=utf-8',
+            'SOAPAction' => "#{xmlns(action)}#{action}" }
+        )
 
         response = parse(action, data)
         Response.new(successful?(action, response), message_from(action, response), response,

data/lib/active_merchant/billing/gateways/moneris.rb

@@ -2,7 +2,6 @@ require 'rexml/document'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
-
     # To learn more about the Moneris gateway, please contact
     # eselectplus@moneris.com for a copy of their integration guide. For
     # information on remote testing, please see "Test Environment Penny Value

data/lib/active_merchant/billing/gateways/moneris_us.rb

@@ -2,7 +2,6 @@ require 'rexml/document'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
-
     # To learn more about the Moneris (US) gateway, please contact
     # ussales@moneris.com for a copy of their integration guide. For
     # information on remote testing, please see "Test Environment Penny Value
@@ -58,7 +57,7 @@ module ActiveMerchant #:nodoc:
         post[:order_id]   = options[:order_id]
         post[:address]    = options[:billing_address] || options[:address]
         post[:crypt_type] = options[:crypt_type] || @options[:crypt_type]
-        action = (post[:data_key].blank?) ? 'us_preauth' : 'us_res_preauth_cc'
+        action = post[:data_key].blank? ? 'us_preauth' : 'us_res_preauth_cc'
         commit(action, post)
       end
 

data/lib/active_merchant/billing/gateways/money_movers.rb

@@ -126,7 +126,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def test?
-        (@options[:login].eql?('demo')) && (@options[:password].eql?('password'))
+        @options[:login].eql?('demo') && @options[:password].eql?('password')
       end
 
       def message_from(response)

data/lib/active_merchant/billing/gateways/mundipagg.rb

@@ -247,15 +247,15 @@ module ActiveMerchant #:nodoc:
           test: test?,
           error_code: error_code_from(response)
         )
-        rescue ResponseError => e
-          message = get_error_message(e)
-          return Response.new(
-                   false,
-                   "#{STANDARD_ERROR_MESSAGE_MAPPING[e.response.code]} #{message}",
-                   parse(e.response.body),
-                   test: test?,
-                   error_code: STANDARD_ERROR_CODE_MAPPING[e.response.code],
-                 )
+      rescue ResponseError => e
+        message = get_error_message(e)
+        return Response.new(
+          false,
+          "#{STANDARD_ERROR_MESSAGE_MAPPING[e.response.code]} #{message}",
+          parse(e.response.body),
+          test: test?,
+          error_code: STANDARD_ERROR_CODE_MAPPING[e.response.code]
+        )
       end
 
       def success_from(response)

data/lib/active_merchant/billing/gateways/nab_transact.rb

@@ -41,7 +41,6 @@ module ActiveMerchant #:nodoc:
 
       SUCCESS_CODES = [ '00', '08', '11', '16', '77' ]
 
-
       def initialize(options = {})
         requires!(options, :login, :password)
         super

data/lib/active_merchant/billing/gateways/net_registry.rb

@@ -122,6 +122,7 @@ module ActiveMerchant
       end
 
       private
+
       def add_request_details(params, options)
         params['COMMENT'] = options[:description] unless options[:description].blank?
       end

data/lib/active_merchant/billing/gateways/nmi.rb

@@ -140,7 +140,7 @@ module ActiveMerchant #:nodoc:
       def add_payment_method(post, payment_method, options)
         if(payment_method.is_a?(String))
           post[:customer_vault_id] = payment_method
-        elsif (payment_method.is_a?(NetworkTokenizationCreditCard))
+        elsif payment_method.is_a?(NetworkTokenizationCreditCard)
           post[:ccnumber] = payment_method.number
           post[:ccexp] = exp_date(payment_method)
           post[:token_cryptogram] = payment_method.payment_cryptogram
@@ -214,7 +214,6 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(action, params)
-
         params[action == 'add_customer' ? :customer_vault : :type] = action
         params[:username] = @options[:login]
         params[:password] = @options[:password]

data/lib/active_merchant/billing/gateways/ogone.rb

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 require 'rexml/document'
 
 module ActiveMerchant #:nodoc:
@@ -121,12 +122,10 @@ module ActiveMerchant #:nodoc:
 
       SUCCESS_MESSAGE = 'The transaction was successful'
 
-      THREE_D_SECURE_DISPLAY_WAYS = { :main_window => 'MAINW',  # display the identification page in the main window
-                                                                # (default value).
-                                      :pop_up      => 'POPUP',  # display the identification page in a pop-up window
-                                                                # and return to the main window at the end.
-                                      :pop_ix      => 'POPIX' } # display the identification page in a pop-up window
-                                                                # and remain in the pop-up window.
+      THREE_D_SECURE_DISPLAY_WAYS = { :main_window => 'MAINW',  # display the identification page in the main window (default value).
+
+                                      :pop_up      => 'POPUP',  # display the identification page in a pop-up window and return to the main window at the end.
+                                      :pop_ix      => 'POPIX' } # display the identification page in a pop-up window and remain in the pop-up window.
 
       OGONE_NO_SIGNATURE_DEPRECATION_MESSAGE   = 'Signature usage will be the default for a future release of ActiveMerchant. You should either begin using it, or update your configuration to explicitly disable it (signature_encryptor: none)'
       OGONE_STORE_OPTION_DEPRECATION_MESSAGE   = "The 'store' option has been renamed to 'billing_id', and its usage is deprecated."
@@ -226,10 +225,10 @@ module ActiveMerchant #:nodoc:
 
       def scrub(transcript)
         transcript.
-        gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
-        gsub(%r((&?cardno=)[^&]*)i, '\1[FILTERED]').
-        gsub(%r((&?cvc=)[^&]*)i, '\1[FILTERED]').
-        gsub(%r((&?pswd=)[^&]*)i, '\1[FILTERED]')
+          gsub(%r((Authorization: Basic )\w+), '\1[FILTERED]').
+          gsub(%r((&?cardno=)[^&]*)i, '\1[FILTERED]').
+          gsub(%r((&?cvc=)[^&]*)i, '\1[FILTERED]').
+          gsub(%r((&?pswd=)[^&]*)i, '\1[FILTERED]')
       end
 
       private

data/lib/active_merchant/billing/gateways/openpay.rb

@@ -5,7 +5,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://sandbox-api.openpay.mx/v1/'
 
       self.supported_countries = ['MX']
-      self.supported_cardtypes = [:visa, :master, :american_express]
+      self.supported_cardtypes = [:visa, :master, :american_express, :carnet]
       self.homepage_url = 'http://www.openpay.mx/'
       self.display_name = 'Openpay'
       self.default_currency = 'MXN'
@@ -104,6 +104,7 @@ module ActiveMerchant #:nodoc:
           gsub(%r((cvv2\\?":\\?")\\?"), '\1[BLANK]"').
           gsub(%r((cvv2\\?":\\?")\s+), '\1[BLANK]')
       end
+
       private
 
       def create_post_for_auth_or_purchase(money, creditcard, options)
@@ -126,8 +127,8 @@ module ActiveMerchant #:nodoc:
         elsif creditcard.respond_to?(:number)
           card = {
             card_number: creditcard.number,
-            expiration_month: "#{sprintf("%02d", creditcard.month)}",
-            expiration_year: "#{"#{creditcard.year}"[-2, 2]}",
+            expiration_month: sprintf('%02d', creditcard.month),
+            expiration_year: creditcard.year.to_s[-2, 2],
             cvv2: creditcard.verification_value,
             holder_name: creditcard.name
           }
@@ -208,11 +209,9 @@ module ActiveMerchant #:nodoc:
       end
 
       def response_error(raw_response)
-        begin
-          parse(raw_response)
-        rescue JSON::ParserError
-          json_error(raw_response)
-        end
+        parse(raw_response)
+      rescue JSON::ParserError
+        json_error(raw_response)
       end
 
       def json_error(raw_response)

data/lib/active_merchant/billing/gateways/opp.rb

@@ -1,112 +1,112 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class OppGateway < Gateway
-    # = Open Payment Platform
-    #
-    #  The Open Payment Platform includes a powerful omni-channel transaction processing API,
-    #   enabling you to quickly and flexibly build new applications and services on the platform.
-    #
-    #   This plugin enables connectivity to the Open Payment Platform for activemerchant.
-    #
-    # For any questions or comments please contact support@payon.com
-    #
-    # == Usage
-    #
-    #   gateway = ActiveMerchant::Billing::OppGateway.new(
-    #      user_id: 'merchant user id',
-    #      password: 'password',
-    #      entity_id: 'entity id',
-    #   )
-    #
-    #   # set up credit card object as in main ActiveMerchant example
-    #   creditcard = ActiveMerchant::Billing::CreditCard.new(
-    #     :type       => 'visa',
-    #     :number     => '4242424242424242',
-    #     :month      => 8,
-    #     :year       => 2009,
-    #     :first_name => 'Bob',
-    #     :last_name  => 'Bobsen'
-    #     :verification_value: '123')
-    #
-    #   # Request: complete example, including address, billing address, shipping address
-    #    complete_request_options = {
-    #      order_id: "your merchant/shop order id", # alternative is to set merchantInvoiceId
-    #      merchant_transaction_id: "your merchant/shop transaction id",
-    #      address: address,
-    #      description: 'Store Purchase - Books',
-    #      risk_workflow: false,
-    #      test_mode: 'EXTERNAL' # or 'INTERNAL', valid only for test system
-    #      create_registration: false, # payment details will be stored on the server an latter can be referenced
-    #
-    #     billing_address: {
-    #        address1: '123 Test Street',
-    #        city:     'Test',
-    #        state:    'TE',
-    #        zip:      'AB12CD',
-    #        country:  'GB',
-    #      },
-    #      shipping_address: {
-    #        name:     'Muton DeMicelis',
-    #        address1: 'My Street On Upiter, Apt 3.14/2.78',
-    #        city:     'Munich',
-    #        state:    'Bov',
-    #        zip:      '81675',
-    #        country:  'DE',
-    #      },
-    #      customer: {
-    #        merchant_customer_id:  "your merchant/customer id",
-    #        givenname:  'Jane',
-    #        surname:  'Jones',
-    #        birth_date:  '1965-05-01',
-    #        phone:  '(?!?)555-5555',
-    #        mobile:  '(?!?)234-23423',
-    #        email:  'jane@jones.com',
-    #        company_name:  'JJ Ltd.',
-    #        identification_doctype:  'PASSPORT',
-    #        identification_docid:  'FakeID2342431234123',
-    #        ip:  101.102.103.104,
-    #      },
-    #    }
-    #
-    #    # Request: minimal example
-    #    minimal_request_options = {
-    #      order_id: "your merchant/shop order id", # alternative is to set merchantInvoiceId
-    #      description: 'Store Purchase - Books',
-    #    }
-    #
-    #   options =
-    #   # run request
-    #   response = gateway.purchase(754, creditcard, options) # charge 7,54 EUR
-    #
-    #   response.success?                   # Check whether the transaction was successful
-    #   response.error_code                 # Retrieve the error message - it's mapped to Gateway::STANDARD_ERROR_CODE
-    #   response.message                    # Retrieve the message returned by opp
-    #   response.authorization              # Retrieve the unique transaction ID returned by opp
-    #   response.params['result']['code']   # Retrieve original return code returned by opp server
-    #
-    # == Errors
-    #   If transaction is not successful, response.error_code contains mapped to Gateway::STANDARD_ERROR_CODE error message.
-    #   Complete list of opp error codes can be viewed on https://docs.oppwa.com/
-    #   Because this list is much bigger than Gateway::STANDARD_ERROR_CODE, only fraction is mapped to Gateway::STANDARD_ERROR_CODE.
-    #   All other codes are mapped as Gateway::STANDARD_ERROR_CODE[:processing_error], so if this is the case,
-    #   you may check the original result code from OPP that can be found in response.params['result']['code']
-    #
-    # == Special features
-    #   For purchase method risk check can be forced when options[:risk_workflow] = true
-    #   This will split (on OPP server side) the transaction into two separate transactions: authorize and capture,
-    #   but capture will be executed only if risk checks are successful.
-    #
-    #   For testing you may use the test account details listed fixtures.yml under opp. It is important to note that there are two test modes available:
-    #     options[:test_mode]='EXTERNAL' causes test transactions to be forwarded to the processor's test system for 'end-to-end' testing
-    #     options[:test_mode]='INTERNAL' causes transactions to be sent to opp simulators, which is useful when switching to the live endpoint for connectivity testing.
-    #   If no test_mode parameter is sent, test_mode=INTERNAL is the default behaviour.
-    #
-    #   Billing Address, Shipping Address, Custom Parameters are supported as described under https://docs.oppwa.com/parameters
-    #   See complete example above for details.
-    #
-    #   == Tokenization
-    #  When create_registration is set to true, the payment details will be stored and a token will be returned in registrationId response field,
-    #  which can subsequently be used to reference the stored payment.
+      # = Open Payment Platform
+      #
+      #  The Open Payment Platform includes a powerful omni-channel transaction processing API,
+      #   enabling you to quickly and flexibly build new applications and services on the platform.
+      #
+      #   This plugin enables connectivity to the Open Payment Platform for activemerchant.
+      #
+      # For any questions or comments please contact support@payon.com
+      #
+      # == Usage
+      #
+      #   gateway = ActiveMerchant::Billing::OppGateway.new(
+      #      user_id: 'merchant user id',
+      #      password: 'password',
+      #      entity_id: 'entity id',
+      #   )
+      #
+      #   # set up credit card object as in main ActiveMerchant example
+      #   creditcard = ActiveMerchant::Billing::CreditCard.new(
+      #     :type       => 'visa',
+      #     :number     => '4242424242424242',
+      #     :month      => 8,
+      #     :year       => 2009,
+      #     :first_name => 'Bob',
+      #     :last_name  => 'Bobsen'
+      #     :verification_value: '123')
+      #
+      #   # Request: complete example, including address, billing address, shipping address
+      #    complete_request_options = {
+      #      order_id: "your merchant/shop order id", # alternative is to set merchantInvoiceId
+      #      merchant_transaction_id: "your merchant/shop transaction id",
+      #      address: address,
+      #      description: 'Store Purchase - Books',
+      #      risk_workflow: false,
+      #      test_mode: 'EXTERNAL' # or 'INTERNAL', valid only for test system
+      #      create_registration: false, # payment details will be stored on the server an latter can be referenced
+      #
+      #     billing_address: {
+      #        address1: '123 Test Street',
+      #        city:     'Test',
+      #        state:    'TE',
+      #        zip:      'AB12CD',
+      #        country:  'GB',
+      #      },
+      #      shipping_address: {
+      #        name:     'Muton DeMicelis',
+      #        address1: 'My Street On Upiter, Apt 3.14/2.78',
+      #        city:     'Munich',
+      #        state:    'Bov',
+      #        zip:      '81675',
+      #        country:  'DE',
+      #      },
+      #      customer: {
+      #        merchant_customer_id:  "your merchant/customer id",
+      #        givenname:  'Jane',
+      #        surname:  'Jones',
+      #        birth_date:  '1965-05-01',
+      #        phone:  '(?!?)555-5555',
+      #        mobile:  '(?!?)234-23423',
+      #        email:  'jane@jones.com',
+      #        company_name:  'JJ Ltd.',
+      #        identification_doctype:  'PASSPORT',
+      #        identification_docid:  'FakeID2342431234123',
+      #        ip:  101.102.103.104,
+      #      },
+      #    }
+      #
+      #    # Request: minimal example
+      #    minimal_request_options = {
+      #      order_id: "your merchant/shop order id", # alternative is to set merchantInvoiceId
+      #      description: 'Store Purchase - Books',
+      #    }
+      #
+      #   options =
+      #   # run request
+      #   response = gateway.purchase(754, creditcard, options) # charge 7,54 EUR
+      #
+      #   response.success?                   # Check whether the transaction was successful
+      #   response.error_code                 # Retrieve the error message - it's mapped to Gateway::STANDARD_ERROR_CODE
+      #   response.message                    # Retrieve the message returned by opp
+      #   response.authorization              # Retrieve the unique transaction ID returned by opp
+      #   response.params['result']['code']   # Retrieve original return code returned by opp server
+      #
+      # == Errors
+      #   If transaction is not successful, response.error_code contains mapped to Gateway::STANDARD_ERROR_CODE error message.
+      #   Complete list of opp error codes can be viewed on https://docs.oppwa.com/
+      #   Because this list is much bigger than Gateway::STANDARD_ERROR_CODE, only fraction is mapped to Gateway::STANDARD_ERROR_CODE.
+      #   All other codes are mapped as Gateway::STANDARD_ERROR_CODE[:processing_error], so if this is the case,
+      #   you may check the original result code from OPP that can be found in response.params['result']['code']
+      #
+      # == Special features
+      #   For purchase method risk check can be forced when options[:risk_workflow] = true
+      #   This will split (on OPP server side) the transaction into two separate transactions: authorize and capture,
+      #   but capture will be executed only if risk checks are successful.
+      #
+      #   For testing you may use the test account details listed fixtures.yml under opp. It is important to note that there are two test modes available:
+      #     options[:test_mode]='EXTERNAL' causes test transactions to be forwarded to the processor's test system for 'end-to-end' testing
+      #     options[:test_mode]='INTERNAL' causes transactions to be sent to opp simulators, which is useful when switching to the live endpoint for connectivity testing.
+      #   If no test_mode parameter is sent, test_mode=INTERNAL is the default behaviour.
+      #
+      #   Billing Address, Shipping Address, Custom Parameters are supported as described under https://docs.oppwa.com/parameters
+      #   See complete example above for details.
+      #
+      #   == Tokenization
+      #  When create_registration is set to true, the payment details will be stored and a token will be returned in registrationId response field,
+      #  which can subsequently be used to reference the stored payment.
 
       self.test_url = 'https://test.oppwa.com/v1/payments'
       self.live_url = 'https://oppwa.com/v1/payments'
@@ -313,16 +313,14 @@ module ActiveMerchant #:nodoc:
           response,
           authorization: authorization_from(response),
           test: test?,
-          error_code: success ? nil : error_code_from(response),
+          error_code: success ? nil : error_code_from(response)
         )
       end
 
       def parse(body)
-        begin
-          JSON.parse(body)
-        rescue JSON::ParserError
-          json_error(body)
-        end
+        JSON.parse(body)
+      rescue JSON::ParserError
+        json_error(body)
       end
 
       def json_error(body)