activemerchant 1.86.0 → 1.87.0

data/lib/active_merchant/billing/gateways/payflow.rb

@@ -92,7 +92,7 @@ module ActiveMerchant #:nodoc:
       def recurring_inquiry(profile_id, options = {})
         ActiveMerchant.deprecated RECURRING_DEPRECATION_MESSAGE
 
-        request = build_recurring_request(:inquiry, nil, options.update( :profile_id => profile_id ))
+        request = build_recurring_request(:inquiry, nil, options.update(:profile_id => profile_id))
         commit(request, options.merge(:request_type => :recurring))
       end
 
@@ -143,7 +143,7 @@ module ActiveMerchant #:nodoc:
 
               billing_address = options[:billing_address] || options[:address]
               add_address(xml, 'BillTo', billing_address, options) if billing_address
-              add_address(xml, 'ShipTo', options[:shipping_address],options) if options[:shipping_address]
+              add_address(xml, 'ShipTo', options[:shipping_address], options) if options[:shipping_address]
 
               xml.tag! 'TotalAmt', amount(money), 'Currency' => options[:currency] || currency(money)
             end
@@ -289,7 +289,7 @@ module ActiveMerchant #:nodoc:
                   end
 
                   if action == :add
-                    xml.tag! 'Start', format_rp_date(options[:starting_at] || Date.today + 1 )
+                    xml.tag! 'Start', format_rp_date(options[:starting_at] || Date.today + 1)
                   else
                     xml.tag! 'Start', format_rp_date(options[:starting_at]) unless options[:starting_at].nil?
                   end
@@ -308,7 +308,7 @@ module ActiveMerchant #:nodoc:
                 xml.tag! 'ProfileID', options[:profile_id]
               end
               if action == :inquiry
-                xml.tag! 'PaymentHistory', ( options[:history] ? 'Y' : 'N' )
+                xml.tag! 'PaymentHistory', (options[:history] ? 'Y' : 'N')
               end
             end
           end
@@ -318,20 +318,20 @@ module ActiveMerchant #:nodoc:
       def get_pay_period(options)
         requires!(options, [:periodicity, :bimonthly, :monthly, :biweekly, :weekly, :yearly, :daily, :semimonthly, :quadweekly, :quarterly, :semiyearly])
         case options[:periodicity]
-          when :weekly then 'Weekly'
-          when :biweekly then 'Bi-weekly'
-          when :semimonthly then 'Semi-monthly'
-          when :quadweekly then 'Every four weeks'
-          when :monthly then 'Monthly'
-          when :quarterly then 'Quarterly'
-          when :semiyearly then 'Semi-yearly'
-          when :yearly then 'Yearly'
+        when :weekly then 'Weekly'
+        when :biweekly then 'Bi-weekly'
+        when :semimonthly then 'Semi-monthly'
+        when :quadweekly then 'Every four weeks'
+        when :monthly then 'Monthly'
+        when :quarterly then 'Quarterly'
+        when :semiyearly then 'Semi-yearly'
+        when :yearly then 'Yearly'
         end
       end
 
       def format_rp_date(time)
         case time
-          when Time, Date then time.strftime('%m%d%Y')
+        when Time, Date then time.strftime('%m%d%Y')
         else
           time.to_s
         end

data/lib/active_merchant/billing/gateways/payflow/payflow_common_api.rb

@@ -178,10 +178,10 @@ module ActiveMerchant #:nodoc:
           # down as we do everywhere else. RPPaymentResult elements are not contained
           # in an RPPaymentResults element so we'll come here multiple times
           response[node_name] ||= []
-          response[node_name] << ( payment_result_response = {} )
-          node.xpath('.//*').each{ |e| parse_element(payment_result_response, e) }
+          response[node_name] << (payment_result_response = {})
+          node.xpath('.//*').each { |e| parse_element(payment_result_response, e) }
         when node.xpath('.//*').to_a.any?
-          node.xpath('.//*').each{|e| parse_element(response, e) }
+          node.xpath('.//*').each { |e| parse_element(response, e) }
         when node_name.to_s =~ /amt$/
           # *Amt elements don't put the value in the #text - instead they use a Currency attribute
           response[node_name] = node.attributes['Currency'].to_s
@@ -202,7 +202,7 @@ module ActiveMerchant #:nodoc:
           'X-VPS-Request-ID' => SecureRandom.hex(16)
         }
 
-        headers.merge!('PAYPAL-NVP' => 'Y') if self.use_paypal_nvp
+        headers['PAYPAL-NVP'] = 'Y' if self.use_paypal_nvp
         headers
       end
 

data/lib/active_merchant/billing/gateways/payflow_express.rb

@@ -198,7 +198,7 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'Token', options[:token] unless options[:token].blank?
           xml.tag! 'NoShipping', options[:no_shipping] ? '1' : '0'
           xml.tag! 'AddressOverride', options[:address_override] ? '1' : '0'
-          xml.tag! 'ButtonSource', application_id.to_s.slice(0,32) unless application_id.blank?
+          xml.tag! 'ButtonSource', application_id.to_s.slice(0, 32) unless application_id.blank?
 
           # Customization of the payment page
           xml.tag! 'PageStyle', options[:page_style] unless options[:page_style].blank?

data/lib/active_merchant/billing/gateways/payment_express.rb

@@ -274,9 +274,9 @@ module ActiveMerchant #:nodoc:
           xml.add_element('ClientType').text = client_type
         end
 
-        xml.add_element('TxnData1').text = options[:txn_data1].to_s.slice(0,255) unless options[:txn_data1].blank?
-        xml.add_element('TxnData2').text = options[:txn_data2].to_s.slice(0,255) unless options[:txn_data2].blank?
-        xml.add_element('TxnData3').text = options[:txn_data3].to_s.slice(0,255) unless options[:txn_data3].blank?
+        xml.add_element('TxnData1').text = options[:txn_data1].to_s.slice(0, 255) unless options[:txn_data1].blank?
+        xml.add_element('TxnData2').text = options[:txn_data2].to_s.slice(0, 255) unless options[:txn_data2].blank?
+        xml.add_element('TxnData3').text = options[:txn_data3].to_s.slice(0, 255) unless options[:txn_data3].blank?
       end
 
       def new_transaction
@@ -340,13 +340,13 @@ module ActiveMerchant #:nodoc:
 
       def normalized_client_type(client_type_from_options)
         case client_type_from_options.to_s.downcase
-          when 'web'        then 'Web'
-          when 'ivr'        then 'IVR'
-          when 'moto'       then 'MOTO'
-          when 'unattended' then 'Unattended'
-          when 'internet'   then 'Internet'
-          when 'recurring'  then 'Recurring'
-          else nil
+        when 'web'        then 'Web'
+        when 'ivr'        then 'IVR'
+        when 'moto'       then 'MOTO'
+        when 'unattended' then 'Unattended'
+        when 'internet'   then 'Internet'
+        when 'recurring'  then 'Recurring'
+        else nil
         end
       end
     end

data/lib/active_merchant/billing/gateways/paymentez.rb

@@ -134,6 +134,9 @@ module ActiveMerchant #:nodoc:
         post[:user][:email] = options[:email]
         post[:user][:ip_address] = options[:ip] if options[:ip]
         post[:user][:fiscal_number] = options[:fiscal_number] if options[:fiscal_number]
+        if phone = options[:phone] || options.dig(:billing_address, :phone)
+          post[:user][:phone] = phone
+        end
       end
 
       def add_invoice(post, money, options)

data/lib/active_merchant/billing/gateways/paymill.rb

@@ -82,7 +82,7 @@ module ActiveMerchant #:nodoc:
         post['account.verification'] = credit_card.verification_value
         post['account.email'] = (options[:email] || nil)
         post['presentation.amount3D'] =  (options[:money] || nil)
-        post['presentation.currency3D'] = (options[:currency] || currency( options[:money]))
+        post['presentation.currency3D'] = (options[:currency] || currency(options[:money]))
       end
 
       def headers
@@ -128,9 +128,9 @@ module ActiveMerchant #:nodoc:
       def action_with_token(action, money, payment_method, options)
         options[:money] = money
         case payment_method
-          when String
+        when String
             self.send("#{action}_with_token", money, payment_method, options)
-          else
+        else
             MultiResponse.run do |r|
               r.process { save_card(payment_method, options) }
               r.process { self.send("#{action}_with_token", money, r.authorization, options) }
@@ -314,7 +314,7 @@ module ActiveMerchant #:nodoc:
 
       def response_message(parsed_response)
         return parsed_response['error'] if parsed_response['error']
-        return 'Transaction approved.' if (parsed_response['data'] == [])
+        return 'Transaction approved.' if parsed_response['data'] == []
 
         code = parsed_response['data']['response_code'].to_i
         RESPONSE_CODES[code] || code.to_s

data/lib/active_merchant/billing/gateways/payscout.rb

@@ -102,7 +102,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse(body)
-        Hash[body.split('&').map{|x| x.split('=')}]
+        Hash[body.split('&').map { |x| x.split('=') }]
       end
 
       def commit(action, money, parameters)

data/lib/active_merchant/billing/gateways/paystation.rb

@@ -179,7 +179,7 @@ module ActiveMerchant #:nodoc:
           message  = message_from(response)
 
           PaystationResponse.new(success?(response), message, response,
-            :test          => (response[:tm] && response[:tm].downcase == 't'),
+            :test          => (response[:tm]&.casecmp('t')&.zero?),
             :authorization => response[:paystation_transaction_id]
           )
         end

data/lib/active_merchant/billing/gateways/payu_in.rb

@@ -32,11 +32,11 @@ module ActiveMerchant #:nodoc:
         add_auth(post)
 
         MultiResponse.run do |r|
-          r.process{commit(url('purchase'), post)}
+          r.process { commit(url('purchase'), post) }
           if(r.params['enrolled'].to_s == '0')
-            r.process{commit(r.params['post_uri'], r.params['form_post_vars'])}
+            r.process { commit(r.params['post_uri'], r.params['form_post_vars']) }
           else
-            r.process{handle_3dsecure(r)}
+            r.process { handle_3dsecure(r) }
           end
         end
       end

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -167,7 +167,7 @@ module ActiveMerchant #:nodoc:
         address = options[:billing_address]
         payer = {}
         payer[:fullName] = payment_method.name.strip
-        payer[:contactPhone] = address[:phone] if (address && address[:phone])
+        payer[:contactPhone] = address[:phone] if address && address[:phone]
         payer[:dniNumber] = options[:dni_number] if options[:dni_number]
         payer[:dniType] = options[:dni_type] if options[:dni_type]
         payer[:emailAddress] = options[:email] if options[:email]

data/lib/active_merchant/billing/gateways/payway.rb

@@ -150,7 +150,7 @@ module ActiveMerchant
           post['card.cardHolderName'] = "#{payment_method.first_name} #{payment_method.last_name}"
           post['card.PAN']            = payment_method.number
           post['card.CVN']            = payment_method.verification_value
-          post['card.expiryYear']     = payment_method.year.to_s[-2,2]
+          post['card.expiryYear']     = payment_method.year.to_s[-2, 2]
           post['card.expiryMonth']    = sprintf('%02d', payment_method.month)
         else
           post['customer.customerReferenceNumber'] = payment_method
@@ -177,7 +177,7 @@ module ActiveMerchant
       # Creates the request and returns the summarized result
       def commit(action, post)
         add_auth(post)
-        post.merge!('order.type' => TRANSACTIONS[action])
+        post['order.type'] = TRANSACTIONS[action]
 
         request = post.map { |k, v| "#{k}=#{CGI.escape(v.to_s)}" }.join('&')
         response = ssl_post(self.live_url, request)

data/lib/active_merchant/billing/gateways/plugnpay.rb

@@ -174,7 +174,7 @@ module ActiveMerchant
       private
 
       def commit(action, post)
-        response = parse( ssl_post(self.live_url, post_data(action, post)) )
+        response = parse(ssl_post(self.live_url, post_data(action, post)))
         success = SUCCESS_CODES.include?(response[:finalstatus])
         message = success ? 'Success' : message_from(response)
 
@@ -189,7 +189,7 @@ module ActiveMerchant
       def parse(body)
         body = CGI.unescape(body)
         results = {}
-        body.split('&').collect { |e| e.split('=') }.each do |key,value|
+        body.split('&').collect { |e| e.split('=') }.each do |key, value|
           results[key.downcase.to_sym] = normalize(value.to_s.strip)
         end
 

data/lib/active_merchant/billing/gateways/pro_pay.rb

@@ -317,8 +317,8 @@ module ActiveMerchant #:nodoc:
 
     def underscore(camel_cased_word)
       camel_cased_word.to_s.gsub(/::/, '/').
-        gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
-        gsub(/([a-z\d])([A-Z])/,'\1_\2').
+        gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2').
+        gsub(/([a-z\d])([A-Z])/, '\1_\2').
         tr('-', '_').
         downcase
     end

data/lib/active_merchant/billing/gateways/psigate.rb

@@ -168,7 +168,7 @@ module ActiveMerchant #:nodoc:
 
         if creditcard
           exp_month = sprintf('%.2i', creditcard.month) unless creditcard.month.blank?
-          exp_year = creditcard.year.to_s[2,2] unless creditcard.year.blank?
+          exp_year = creditcard.year.to_s[2, 2] unless creditcard.year.blank?
           card_id_code = (creditcard.verification_value.blank? ? nil : '1')
 
           params.update(

data/lib/active_merchant/billing/gateways/psl_card.rb

@@ -183,7 +183,7 @@ module ActiveMerchant
         address = options[:billing_address] || options[:address]
         return if address.nil?
 
-        post[:QAAddress] = [:address1, :address2, :city, :state].collect{|a| address[a]}.reject(&:blank?).join(' ')
+        post[:QAAddress] = [:address1, :address2, :city, :state].collect { |a| address[a] }.reject(&:blank?).join(' ')
         post[:QAPostcode] = address[:zip]
       end
 
@@ -242,7 +242,7 @@ module ActiveMerchant
       def parse(body)
         fields = {}
         for line in body.split('&')
-          key, value = *line.scan( %r{^(\w+)\=(.*)$} ).flatten
+          key, value = *line.scan(%r{^(\w+)\=(.*)$}).flatten
           fields[key] = CGI.unescape(value)
         end
         fields.symbolize_keys
@@ -257,7 +257,7 @@ module ActiveMerchant
       #   - ActiveMerchant::Billing::Response object
       #
       def commit(request)
-        response = parse( ssl_post(self.live_url, post_data(request)) )
+        response = parse(ssl_post(self.live_url, post_data(request)))
 
         Response.new(response[:ResponseCode] == APPROVED, response[:Message], response,
           :test => test?,

data/lib/active_merchant/billing/gateways/qbms.rb

@@ -101,7 +101,7 @@ module ActiveMerchant #:nodoc:
       #
       def credit(money, identification, options = {})
         ActiveMerchant.deprecated CREDIT_DEPRECATION_MESSAGE
-        refund(money, identification, options = {})
+        refund(money, identification, {})
       end
 
       def refund(money, identification, options = {})

data/lib/active_merchant/billing/gateways/quantum.rb

@@ -44,7 +44,7 @@ module ActiveMerchant #:nodoc:
       #
       def authorize(money, creditcard, options = {})
         setup_address_hash(options)
-        commit(build_auth_request(money, creditcard, options), options )
+        commit(build_auth_request(money, creditcard, options), options)
       end
 
       # Capture an authorization that has previously been requested
@@ -81,7 +81,7 @@ module ActiveMerchant #:nodoc:
 
       def build_auth_request(money, creditcard, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'AUTH_ONLY')
+        add_common_credit_card_info(xml, 'AUTH_ONLY')
         add_purchase_data(xml, money)
         add_creditcard(xml, creditcard)
         add_address(xml, creditcard, options[:billing_address], options)
@@ -94,7 +94,7 @@ module ActiveMerchant #:nodoc:
 
       def build_capture_request(money, authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'PREVIOUS_SALE')
+        add_common_credit_card_info(xml, 'PREVIOUS_SALE')
         transaction_id, _ = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
         xml.target!
@@ -115,7 +115,7 @@ module ActiveMerchant #:nodoc:
 
       def build_void_request(authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'VOID')
+        add_common_credit_card_info(xml, 'VOID')
         transaction_id, _ = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
         xml.target!
@@ -123,7 +123,7 @@ module ActiveMerchant #:nodoc:
 
       def build_credit_request(money, authorization, options)
         xml = Builder::XmlMarkup.new
-        add_common_credit_card_info(xml,'RETURN')
+        add_common_credit_card_info(xml, 'RETURN')
         add_purchase_data(xml, money)
         transaction_id, cc = authorization_parts_from(authorization)
         add_transaction_id(xml, transaction_id)
@@ -182,7 +182,7 @@ module ActiveMerchant #:nodoc:
         xml.tag! 'CreditCardNumber', creditcard.number
         xml.tag! 'ExpireMonth', format(creditcard.month, :two_digits)
         xml.tag! 'ExpireYear', format(creditcard.year, :four_digits)
-        xml.tag!('CVV2', creditcard.verification_value) unless (@options[:ignore_cvv] || creditcard.verification_value.blank? )
+        xml.tag!('CVV2', creditcard.verification_value) unless @options[:ignore_cvv] || creditcard.verification_value.blank?
       end
 
       # Where we actually build the full SOAP request using builder
@@ -251,7 +251,7 @@ module ActiveMerchant #:nodoc:
 
       def parse_element(reply, node)
         if node.has_elements?
-          node.elements.each{|e| parse_element(reply, e) }
+          node.elements.each { |e| parse_element(reply, e) }
         else
           if node.parent.name =~ /item/
             parent = node.parent.name + (node.parent.attributes['id'] ? '_' + node.parent.attributes['id'] : '')

data/lib/active_merchant/billing/gateways/quickbooks.rb

@@ -48,7 +48,7 @@ module ActiveMerchant #:nodoc:
         'PMT-6000' => STANDARD_ERROR_CODE[:processing_error],   # A temporary Issue prevented this request from being processed.
       }
 
-      FRAUD_WARNING_CODES = ['PMT-1000','PMT-1001','PMT-1002','PMT-1003']
+      FRAUD_WARNING_CODES = ['PMT-1000', 'PMT-1001', 'PMT-1002', 'PMT-1003']
 
       def initialize(options = {})
         requires!(options, :consumer_key, :consumer_secret, :access_token, :token_secret, :realm)
@@ -224,17 +224,17 @@ module ActiveMerchant #:nodoc:
         }
 
         # prepare components for signature
-        oauth_signature_base_string = [method.to_s.upcase, request_uri.to_s, oauth_parameters.to_param].map{|v| CGI.escape(v) }.join('&')
-        oauth_signing_key = [@options[:consumer_secret], @options[:token_secret]].map{|v| CGI.escape(v)}.join('&')
+        oauth_signature_base_string = [method.to_s.upcase, request_uri.to_s, oauth_parameters.to_param].map { |v| CGI.escape(v) }.join('&')
+        oauth_signing_key = [@options[:consumer_secret], @options[:token_secret]].map { |v| CGI.escape(v) }.join('&')
         hmac_signature = OpenSSL::HMAC.digest(OpenSSL::Digest.new('sha1'), oauth_signing_key, oauth_signature_base_string)
 
         # append signature to required OAuth parameters
         oauth_parameters[:oauth_signature] = CGI.escape(Base64.encode64(hmac_signature).chomp.gsub(/\n/, ''))
 
         # prepare Authorization header string
-        oauth_parameters = Hash[oauth_parameters.sort_by {|k, _| k}]
+        oauth_parameters = Hash[oauth_parameters.sort_by { |k, _| k }]
         oauth_headers = ["OAuth realm=\"#{@options[:realm]}\""]
-        oauth_headers += oauth_parameters.map {|k, v| "#{k}=\"#{v}\""}
+        oauth_headers += oauth_parameters.map { |k, v| "#{k}=\"#{v}\"" }
 
         {
           'Content-type' => 'application/json',
@@ -258,7 +258,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(response)
-        response['errors'].present? ? response['errors'].map {|error_hash| error_hash['message'] }.join(' ') : response['status']
+        response['errors'].present? ? response['errors'].map { |error_hash| error_hash['message'] }.join(' ') : response['status']
       end
 
       def errors_from(response)

data/lib/active_merchant/billing/gateways/quickpay/quickpay_v10.rb

@@ -78,7 +78,7 @@ module ActiveMerchant
       def store(credit_card, options = {})
         MultiResponse.run do |r|
           r.process { create_store(options) }
-          r.process { authorize_store(r.authorization, credit_card, options)}
+          r.process { authorize_store(r.authorization, credit_card, options) }
         end
       end
 

data/lib/active_merchant/billing/gateways/qvalent.rb

@@ -103,7 +103,7 @@ module ActiveMerchant #:nodoc:
 
       private
 
-      CURRENCY_CODES = Hash.new{|h,k| raise ArgumentError.new("Unsupported currency: #{k}")}
+      CURRENCY_CODES = Hash.new { |h, k| raise ArgumentError.new("Unsupported currency: #{k}") }
       CURRENCY_CODES['AUD'] = 'AUD'
       CURRENCY_CODES['INR'] = 'INR'
 
@@ -197,7 +197,7 @@ module ActiveMerchant #:nodoc:
 
       def parse_element(response, node)
         if node.has_elements?
-          node.elements.each{|element| parse_element(response, element) }
+          node.elements.each { |element| parse_element(response, element) }
         else
           response[node.name.underscore.to_sym] = node.text
         end

data/lib/active_merchant/billing/gateways/realex.rb

@@ -80,6 +80,13 @@ module ActiveMerchant
         commit(request)
       end
 
+      def verify(credit_card, options = {})
+        requires!(options, :order_id)
+
+        request = build_verify_request(credit_card, options)
+        commit(request)
+      end
+
       def supports_scrubbing
         true
       end
@@ -111,7 +118,7 @@ module ActiveMerchant
 
         doc = Nokogiri::XML(xml)
         doc.xpath('//response/*').each do |node|
-          if (node.elements.size == 0)
+          if node.elements.size == 0
             response[node.name.downcase.to_sym] = normalize(node.text)
           else
             node.elements.each do |childnode|
@@ -185,6 +192,20 @@ module ActiveMerchant
         xml.target!
       end
 
+      # Verify initiates an OTB (Open To Buy) request
+      def build_verify_request(credit_card, options)
+        timestamp = new_timestamp
+        xml = Builder::XmlMarkup.new :indent => 2
+        xml.tag! 'request', 'timestamp' => timestamp, 'type' => 'otb' do
+          add_merchant_details(xml, options)
+          xml.tag! 'orderid', sanitize_order_id(options[:order_id])
+          add_card(xml, credit_card)
+          add_comments(xml, options)
+          add_signed_digest(xml, timestamp, @options[:login], sanitize_order_id(options[:order_id]), credit_card.number)
+        end
+        xml.target!
+      end
+
       def add_address_and_customer_info(xml, options)
         billing_address = options[:billing_address] || options[:address]
         shipping_address = options[:shipping_address]
@@ -258,14 +279,14 @@ module ActiveMerchant
         end
         xml.tag! 'supplementarydata' do
           xml.tag! 'item', 'type' => 'mobile' do
-            xml.tag! 'field01', payment.source.to_s.gsub('_','-')
+            xml.tag! 'field01', payment.source.to_s.gsub('_', '-')
           end
         end
       end
 
       def format_address_code(address)
         code = [address[:zip].to_s, address[:address1].to_s + address[:address2].to_s]
-        code.collect{|e| e.gsub(/\D/, '')}.reject(&:empty?).join('|')
+        code.collect { |e| e.gsub(/\D/, '') }.reject(&:empty?).join('|')
       end
 
       def new_timestamp
@@ -286,26 +307,25 @@ module ActiveMerchant
       end
 
       def message_from(response)
-        message = nil
         case response[:result]
         when '00'
-          message = SUCCESS
+          SUCCESS
         when '101'
-          message = response[:message]
+          response[:message]
         when '102', '103'
-          message = DECLINED
+          DECLINED
         when /^2[0-9][0-9]/
-          message = BANK_ERROR
+          BANK_ERROR
         when /^3[0-9][0-9]/
-          message = REALEX_ERROR
+          REALEX_ERROR
         when /^5[0-9][0-9]/
-          message = response[:message]
+          response[:message]
         when '600', '601', '603'
-          message = ERROR
+          ERROR
         when '666'
-          message = CLIENT_DEACTIVATED
+          CLIENT_DEACTIVATED
         else
-          message = DECLINED
+          DECLINED
         end
       end