activemerchant 1.74.0 → 1.75.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9058f19bf43858097b6bbd6a911b01a62aafa568
-  data.tar.gz: 5fc5302b4559796e838bc675a5b03ce61c42aa11
+  metadata.gz: 50bb4461b27b49be6e87608a11f5db29a02d0adc
+  data.tar.gz: d5b76878be3ec6d7334cb343d439837b6fb3d599
 SHA512:
-  metadata.gz: 792627ab57f85f7d6036a94ad5192e4fa0bc266154bde86f9a0f643ec35a8637c874749a758ff55c34b6069476829fc62b1df17ba59ae749a0e204545e88e503
-  data.tar.gz: 9c382d5af0c5c9794c1091b5706c264fd2317b84ea5a9cc6940f599b7981d45d012692f9af77ab5fc8e342035c8340acfbcd6f49cbc10ada944d2c4019bd7dd6
+  metadata.gz: 3eff219643c61371a81f0242548576dadfd8032cd3939a5859e6d5a8ca1aa4b822454754ed6aef844c14096af72a69b90b6ae5cb2ba8491fb662beba6aeb8447
+  data.tar.gz: 2cc15eaa916a7b90c66e8686668ec01cc56cebdfe2029c555033e2e1907fc931842e24bad2c8fb7760d543940cdfb6d84da0d8e1da24ccaa4927adc7646950d9

data/CHANGELOG

@@ -2,6 +2,20 @@
 
 == HEAD
 
+== Version 1.75.0 (November 9, 2017)
+* Barclaycard Smartpay: Clean up test options hashes [bpollack] #2632
+* Barclaycard Smartpay: Extra data fields for credits [bpollack] #2631
+* Cyber Source: Correctly passes subscriptionID for store [deedeelavinder] #2633
+* Ebanx: Pass fields for business person responsible [curiousepic] #2635
+* Ebanx: Support Colombian transactions [bpollack] #2636
+* FirstData E4 (Payeezy): Ensure numeric ECI values are zero padded [jasonwebster] #2630
+* Netbanx: Only send currency and billing_details for auths and sales [anotherjosmith] #2643
+* Netbanx: Revert "Fixes basic auth for netbanx by sending the account_number and api_key" [anotherjosmith] #2644
+* PayU Latam: Adds `partnerID`, adjusts phone preferences, allows empty `ip_address`, and adjusts for no `cvv` [deedeelavinder] #2634
+* Sage Payment Solutions: Scrub check info [curiousepic] #2639
+* Worldbank US: Allow using the backup URL [bpollack] #2641
+* Worldbank US: Allow using the backup URL per-request [bpollack] #2645
+
 == Version 1.74.0 (October 24, 2017)
 * Adyen: Update list of supported countries [dtykocki] #2600
 * Authorize.net CIM: Handle multiple error messages [amandapuff] #2537

data/lib/active_merchant/billing/gateways/barclaycard_smartpay.rb

@@ -60,6 +60,10 @@ module ActiveMerchant #:nodoc:
         post = payment_request(money, options)
         post[:amount] = amount_hash(money, options[:currency])
         post[:card] = credit_card_hash(creditcard)
+        post[:dateOfBirth] = options[:date_of_birth] if options[:date_of_birth]
+        post[:entityType]  = options[:entity_type] if options[:entity_type]
+        post[:nationality] = options[:nationality] if options[:nationality]
+        post[:shopperName] = options[:shopper_name] if options[:shopper_name]
 
         commit('refundWithData', post)
       end

data/lib/active_merchant/billing/gateways/cyber_source.rb

@@ -618,7 +618,7 @@ module ActiveMerchant #:nodoc:
 
         xml.tag! 'recurringSubscriptionInfo' do
           if reference
-            _, subscription_id, _ = reference.split(";")
+            subscription_id = reference.split(";")[6]
             xml.tag! 'subscriptionID',  subscription_id
           end
 
@@ -709,7 +709,7 @@ module ActiveMerchant #:nodoc:
         success = response[:decision] == "ACCEPT"
         message = response[:message]
 
-        authorization = success ? [ options[:order_id], response[:requestID], response[:requestToken], action, amount, options[:currency]].compact.join(";") : nil
+        authorization = success ? authorization_from(response, action, amount, options) : nil
 
         Response.new(success, message, response,
           :test => test?,
@@ -759,6 +759,11 @@ module ActiveMerchant #:nodoc:
         return if reason_code.blank?
         @@response_codes[:"r#{reason_code}"]
       end
+
+      def authorization_from(response, action, amount, options)
+        [options[:order_id], response[:requestID], response[:requestToken], action, amount,
+         options[:currency], response[:subscriptionID]].join(";")
+      end
     end
   end
 end

data/lib/active_merchant/billing/gateways/ebanx.rb

@@ -4,7 +4,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://sandbox.ebanx.com/ws/'
       self.live_url = 'https://api.ebanx.com/ws/'
 
-      self.supported_countries = ['BR', 'MX']
+      self.supported_countries = ['BR', 'MX', 'CO']
       self.default_currency = 'USD'
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club]
 
@@ -149,9 +149,9 @@ module ActiveMerchant #:nodoc:
         post[:payment][:person_type] = options[:person_type] if options[:person_type]
         if options[:person_type] && options[:person_type].downcase == 'business'
           post[:payment][:responsible] = {}
-          post[:payment][:responsible][:name] = customer_name(payment, options)
-          post[:payment][:responsible][:document] = options[:document] if options[:document]
-          post[:payment][:responsible][:birth_date] = options[:birth_date] if options[:birth_date]
+          post[:payment][:responsible][:name] = options[:responsible_name] if options[:responsible_name]
+          post[:payment][:responsible][:document] = options[:responsible_document] if options[:responsible_document]
+          post[:payment][:responsible][:birth_date] = options[:responsible_birth_date] if options[:responsible_birth_date]
         end
       end
 

data/lib/active_merchant/billing/gateways/firstdata_e4.rb

@@ -238,7 +238,7 @@ module ActiveMerchant #:nodoc:
           xml.tag! "CardType", card_type(credit_card.brand)
 
           eci = (credit_card.respond_to?(:eci) ? credit_card.eci : nil) || options[:eci] || DEFAULT_ECI
-          xml.tag! "Ecommerce_Flag", eci
+          xml.tag! "Ecommerce_Flag", eci.to_s =~ /^[0-9]+$/ ? eci.to_s.rjust(2, '0') : eci
 
           add_credit_card_verification_strings(xml, credit_card, options)
         end

data/lib/active_merchant/billing/gateways/netbanx.rb

@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
         post = {}
         add_invoice(post, money, options)
         add_settle_with_auth(post)
-        add_payment(post, payment)
+        add_payment(post, payment, options)
 
         commit(:post, 'auths', post)
       end
@@ -39,7 +39,7 @@ module ActiveMerchant #:nodoc:
       def authorize(money, payment, options={})
         post = {}
         add_invoice(post, money, options)
-        add_payment(post, payment)
+        add_payment(post, payment, options)
 
         commit(:post, 'auths', post)
       end
@@ -132,13 +132,7 @@ module ActiveMerchant #:nodoc:
 
       def add_invoice(post, money, options)
         post[:amount] = amount(money)
-        post[:currencyCode] = options[:currency] if options[:currency]
         add_order_id(post, options)
-
-        if options[:billing_address]
-          post[:billingDetails]  = map_address(options[:billing_address])
-        end
-
       end
 
       def add_payment(post, credit_card_or_reference, options = {})
@@ -150,6 +144,9 @@ module ActiveMerchant #:nodoc:
           post[:card][:cvv]        = credit_card_or_reference.verification_value
           post[:card][:cardExpiry] = expdate(credit_card_or_reference)
         end
+
+        post[:currencyCode] = options[:currency] if options[:currency]
+        post[:billingDetails]  = map_address(options[:billing_address]) if options[:billing_address]
       end
 
       def expdate(credit_card)
@@ -241,15 +238,11 @@ module ActiveMerchant #:nodoc:
         {
           'Accept'        => 'application/json',
           'Content-type'  => 'application/json',
-          'Authorization' => "Basic #{basic_auth}",
+          'Authorization' => "Basic #{Base64.strict_encode64(@options[:api_key].to_s)}",
           'User-Agent'    => "Netbanx-Paysafe v1.0/ActiveMerchant #{ActiveMerchant::VERSION}"
         }
       end
 
-      def basic_auth
-        Base64.strict_encode64("#{@options[:account_number]}:#{@options[:api_key]}")
-      end
-
       def error_code_from(response)
         unless success_from(response)
           case response['errorCode']

data/lib/active_merchant/billing/gateways/payu_latam.rb

@@ -141,7 +141,7 @@ module ActiveMerchant #:nodoc:
         transaction = {}
         transaction[:paymentCountry] = @options[:payment_country] || (options[:billing_address][:country] if options[:billing_address])
         transaction[:type] = type
-        transaction[:ipAddress] = options[:ip] if options[:ip]
+        transaction[:ipAddress] = options[:ip] || ''
         transaction[:userAgent] = options[:user_agent] if options[:user_agent]
         transaction[:cookie] = options[:cookie] if options[:cookie]
         transaction[:deviceSessionId] = options[:device_session_id] if options[:device_session_id]
@@ -151,6 +151,7 @@ module ActiveMerchant #:nodoc:
       def add_order(post, options)
         order = {}
         order[:accountId] = @options[:account_id]
+        order[:partnerId] = options[:partner_id] if options[:partner_id]
         order[:referenceCode] = options[:order_id] || generate_unique_id
         order[:description] = options[:description] || 'unspecified'
         order[:language] = 'en'
@@ -192,7 +193,7 @@ module ActiveMerchant #:nodoc:
           buyer[:dniType] = buyer_hash[:dni_type]
           buyer[:cnpj] = buyer_hash[:cnpj] if options[:payment_country] == 'BR'
           buyer[:emailAddress] = buyer_hash[:email]
-          buyer[:contactPhone] = options[:shipping_address][:phone] if options[:shipping_address]
+          buyer[:contactPhone] = (options[:billing_address][:phone] if options[:billing_address]) || (options[:shipping_address][:phone] if options[:shipping_address]) || ''
           buyer[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
         else
           buyer[:fullName] = payment_method.name.strip
@@ -200,7 +201,7 @@ module ActiveMerchant #:nodoc:
           buyer[:dniType] = options[:dni_type]
           buyer[:cnpj] = options[:cnpj] if options[:payment_country] == 'BR'
           buyer[:emailAddress] = options[:email]
-          buyer[:contactPhone] = (options[:shipping_address][:phone] if options[:shipping_address]) || (options[:billing_address][:phone] if options[:billing_address])
+          buyer[:contactPhone] = (options[:billing_address][:phone] if options[:billing_address]) || (options[:shipping_address][:phone] if options[:shipping_address]) || ''
           buyer[:shippingAddress] = shipping_address_fields(options) if options[:shipping_address]
         end
         post[:transaction][:order][:buyer] = buyer
@@ -268,7 +269,7 @@ module ActiveMerchant #:nodoc:
         else
           credit_card = {}
           credit_card[:number] = payment_method.number
-          credit_card[:securityCode] = add_security_code(payment_method, options)
+          credit_card[:securityCode] = payment_method.verification_value || options[:cvv]
           credit_card[:expirationDate] = format(payment_method.year, :four_digits).to_s + '/' + format(payment_method.month, :two_digits).to_s
           credit_card[:name] = payment_method.name.strip
           credit_card[:processWithoutCvv2] = true if add_process_without_cvv2(payment_method, options)
@@ -277,13 +278,6 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_security_code(payment_method, options)
-        return payment_method.verification_value unless payment_method.verification_value.blank?
-        return options[:cvv] unless options[:cvv].blank?
-        return "0000" if BRAND_MAP[payment_method.brand.to_s] == "AMEX"
-        "000"
-      end
-
       def add_process_without_cvv2(payment_method, options)
         return true if payment_method.verification_value.blank? && options[:cvv].blank?
         false

data/lib/active_merchant/billing/gateways/sage.rb

@@ -102,6 +102,9 @@ module ActiveMerchant #:nodoc:
           gsub(%r((M_key=)[^&]*), '\1[FILTERED]').
           gsub(%r((C_cardnumber=)[^&]*), '\1[FILTERED]').
           gsub(%r((C_cvv=)[^&]*), '\1[FILTERED]').
+          gsub(%r((C_rte=)[^&]*), '\1[FILTERED]').
+          gsub(%r((C_acct=)[^&]*), '\1[FILTERED]').
+          gsub(%r((C_ssn=)[^&]*), '\1[FILTERED]').
           gsub(%r((<ns1:CARDNUMBER>).+(</ns1:CARDNUMBER>)), '\1[FILTERED]\2').
           gsub(%r((<ns1:M_ID>).+(</ns1:M_ID>)), '\1[FILTERED]\2').
           gsub(%r((<ns1:M_KEY>).+(</ns1:M_KEY>)), '\1[FILTERED]\2')

data/lib/active_merchant/billing/gateways/worldpay_us.rb

@@ -3,11 +3,14 @@ require "nokogiri"
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class WorldpayUsGateway < Gateway
+      class_attribute :backup_url
+
       self.display_name = "Worldpay US"
       self.homepage_url = "http://www.worldpay.com/us"
 
       # No sandbox, just use test cards.
-      self.live_url = 'https://trans.worldpay.us/cgi-bin/process.cgi'
+      self.live_url   = 'https://trans.worldpay.us/cgi-bin/process.cgi'
+      self.backup_url = 'https://trans.gwtx01.com/cgi-bin/process.cgi'
 
       self.supported_countries = ['US']
       self.default_currency = 'USD'
@@ -25,7 +28,7 @@ module ActiveMerchant #:nodoc:
         add_payment_method(post, payment_method)
         add_customer_data(post, options)
 
-        commit('purchase', post)
+        commit('purchase', options, post)
       end
 
       def authorize(money, payment, options={})
@@ -34,7 +37,7 @@ module ActiveMerchant #:nodoc:
         add_credit_card(post, payment)
         add_customer_data(post, options)
 
-        commit('authorize', post)
+        commit('authorize', options, post)
       end
 
       def capture(amount, authorization, options={})
@@ -43,7 +46,7 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit('capture', post)
+        commit('capture', options, post)
       end
 
       def refund(amount, authorization, options={})
@@ -52,14 +55,14 @@ module ActiveMerchant #:nodoc:
         add_reference(post, authorization)
         add_customer_data(post, options)
 
-        commit("refund", post)
+        commit("refund", options, post)
       end
 
       def void(authorization, options={})
         post = {}
         add_reference(post, authorization)
 
-        commit('void', post)
+        commit('void', options, post)
       end
 
       def verify(credit_card, options={})
@@ -71,6 +74,10 @@ module ActiveMerchant #:nodoc:
 
       private
 
+      def url(options)
+        options[:use_backup_url].to_s == "true" ? self.backup_url : self.live_url
+      end
+
       def add_customer_data(post, options)
         if(billing_address = (options[:billing_address] || options[:address]))
           post[:ci_companyname] = billing_address[:company]
@@ -162,7 +169,7 @@ module ActiveMerchant #:nodoc:
         "void" => "ns_void",
       }
 
-      def commit(action, post)
+      def commit(action, options, post)
         post[:action] = ACTIONS[action] unless post[:action]
         post[:acctid] = @options[:acctid]
         post[:subid] = @options[:subid]
@@ -170,7 +177,7 @@ module ActiveMerchant #:nodoc:
 
         post[:authonly] = '1' if action == 'authorize'
 
-        raw = parse(ssl_post(live_url, post.to_query))
+        raw = parse(ssl_post(url(options), post.to_query))
 
         succeeded = success_from(raw['result'])
         Response.new(

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.74.0"
+  VERSION = "1.75.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.74.0
+  version: 1.75.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-24 00:00:00.000000000 Z
+date: 2017-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport