activemerchant 1.72.0 → 1.73.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91813c36ae054c9add904f9965d29cfac9a24c35
-  data.tar.gz: d2cb404a124499f46cf62905fe0233ec3a34d39e
+  metadata.gz: 82e5954024edb63baed3b663bb1dee80db73f320
+  data.tar.gz: 8c6113aa891504bd482096bcd1f0de9f0d44209a
 SHA512:
-  metadata.gz: ff2929501d9e434b2ffa8b47be745ae8fcb58ddafb2a74dcdfb7ce7699714f4605c7f75cb9bfccb9b917c9e24c2e01061ca49461573e6f1e0031c194f80869a7
-  data.tar.gz: 9fef03d8d88743d0396c359f0c29ce0a1d617d93c9c9c696ad48d9f0b3e2830dfe3ce524a5ee84f4432dd581bd48b18d0cae6e70c48db5e0d08978c68f6ca853
+  metadata.gz: b7bb0c7735d7e7f1d2b12952e13c22a770704a9c468f2d4c0f0c155f284b4d9565833276eb93fbeea4ff15539d41e5987f0dda381198787a13920c0857cd868a
+  data.tar.gz: 6cb69f41e85f93e904ed140e54c0739eda87cbaf0b550506ac9dee21b1bc96b599ef4b417e06f23cffeff7a085a4e373283f70a346e713a62c882b8d21e1a7d3

data/CHANGELOG

@@ -2,6 +2,13 @@
 
 == HEAD
 
+== Version 1.73.0 (September 28, 2017)
+* Adyen: Use original authorization pspReference on Refunds [lyverovski] #2589
+* Braintree Blue: Explicitly require braintree-ruby version 2.78 [anotherjosmith]
+* FirstData E4: Scrub 3DS cryptogram [jasonwebster] #2596
+* PayHub: Replace single quotes with double quotes in error message [matthewheath] #2572
+* Wirecard: Format non-fractional currency amounts correctly [bdewater] #2594
+
 == Version 1.72.0 (September 20, 2017)
 * Adyen: Fix failing remote tests [dtykocki] #2584
 * Authorize.net: Remove numeric restriction on customer ID [dtykocki] #2579

data/lib/active_merchant/billing/gateways/adyen.rb

@@ -144,7 +144,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_references(post, authorization, options = {})
-        post[:originalReference] = authorization
+        post[:originalReference] = psp_reference_from(authorization)
         post[:reference] = options[:order_id]
       end
 
@@ -169,7 +169,7 @@ module ActiveMerchant #:nodoc:
           success,
           message_from(action, response),
           response,
-          authorization: authorization_from(response),
+          authorization: authorization_from(action, parameters, response),
           test: test?,
           error_code: success ? nil : error_code_from(response)
         )
@@ -207,8 +207,8 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorization_from(response)
-        response['pspReference']
+      def authorization_from(action, parameters, response)
+        [parameters[:originalReference], response['pspReference']].compact.join("#").presence
       end
 
       def init_post(options = {})
@@ -223,6 +223,10 @@ module ActiveMerchant #:nodoc:
         STANDARD_ERROR_CODE_MAPPING[response['errorCode']]
       end
 
+      def psp_reference_from(authorization)
+        authorization.nil? ? nil : authorization.split("#").first
+      end
+
     end
   end
 end

data/lib/active_merchant/billing/gateways/braintree_blue.rb

@@ -6,8 +6,8 @@ rescue LoadError
   raise "Could not load the braintree gem.  Use `gem install braintree` to install it."
 end
 
-unless Braintree::Version::Major == 2 && Braintree::Version::Minor >= 4
-  raise "Need braintree gem >= 2.4.0. Run `gem install braintree --version '~>2.4'` to get the correct version."
+unless Braintree::Version::Major == 2 && Braintree::Version::Minor >= 78
+  raise "Need braintree gem >= 2.78.0. Run `gem install braintree --version '~>2.78'` to get the correct version."
 end
 
 module ActiveMerchant #:nodoc:

data/lib/active_merchant/billing/gateways/firstdata_e4.rb

@@ -141,9 +141,10 @@ module ActiveMerchant #:nodoc:
       end
 
       def scrub(transcript)
-        transcript.
-          gsub(%r((<Card_Number>).+(</Card_Number>)), '\1[FILTERED]\2').
-          gsub(%r((<VerificationStr2>).+(</VerificationStr2>)), '\1[FILTERED]\2')
+        transcript
+          .gsub(%r((<Card_Number>).+(</Card_Number>)), '\1[FILTERED]\2')
+          .gsub(%r((<VerificationStr2>).+(</VerificationStr2>)), '\1[FILTERED]\2')
+          .gsub(%r((<CAVV>).+(</CAVV>)), '\1[FILTERED]\2')
       end
 
       def supports_network_tokenization?

data/lib/active_merchant/billing/gateways/pay_hub.rb

@@ -200,8 +200,8 @@ module ActiveMerchant #:nodoc:
 
       def json_error(raw_response)
         {
-          error_message: 'Invalid response received from the Payhub API.  Please contact wecare@payhub.com if you continue to receive this message.' +
-            '  (The raw response returned by the API was #{raw_response.inspect})'
+          error_message: "Invalid response received from the Payhub API.  Please contact wecare@payhub.com if you continue to receive this message." +
+            "  (The raw response returned by the API was #{raw_response.inspect})"
         }
       end
 

data/lib/active_merchant/billing/gateways/wirecard.rb

@@ -235,7 +235,7 @@ module ActiveMerchant #:nodoc:
               add_address(xml, options[:billing_address])
             when :capture, :bookback
               xml.tag! 'GuWID', options[:preauthorization]
-              add_amount(xml, money)
+              add_amount(xml, money, options)
             when :reversal
               xml.tag! 'GuWID', options[:preauthorization]
             end
@@ -246,7 +246,7 @@ module ActiveMerchant #:nodoc:
 
       # Includes the payment (amount, currency, country) to the transaction-xml
       def add_invoice(xml, money, options)
-        add_amount(xml, money)
+        add_amount(xml, money, options)
         xml.tag! 'Currency', options[:currency] || currency(money)
         xml.tag! 'CountryCode', options[:billing_address][:country]
         xml.tag! 'RECURRING_TRANSACTION' do
@@ -255,8 +255,8 @@ module ActiveMerchant #:nodoc:
       end
 
       # Include the amount in the transaction-xml
-      def add_amount(xml, money)
-        xml.tag! 'Amount', amount(money)
+      def add_amount(xml, money, options)
+        xml.tag! 'Amount', localized_amount(money, options[:currency] || currency(money))
       end
 
       # Includes the credit-card data to the transaction-xml

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.72.0"
+  VERSION = "1.73.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.72.0
+  version: 1.73.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-20 00:00:00.000000000 Z
+date: 2017-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport