activemerchant 1.60.0 → 1.61.0

data/lib/active_merchant/billing/gateways/trans_first_transaction_express.rb

@@ -486,7 +486,7 @@ module ActiveMerchant #:nodoc:
       def add_payment_method(doc, payment_method)
         doc["v1"].card {
           doc["v1"].pan payment_method.number
-          doc["v1"].sec payment_method.verification_value
+          doc["v1"].sec payment_method.verification_value if payment_method.verification_value?
           doc["v1"].xprDt expiration_date(payment_method)
         }
       end

data/lib/active_merchant/billing/gateways/vanco.rb

@@ -22,15 +22,15 @@ module ActiveMerchant
 
       def purchase(money, payment_method, options={})
         MultiResponse.run do |r|
-          r.process { commit(login_request) }
-          r.process { commit(purchase_request(money, payment_method, r.params["response_sessionid"], options)) }
+          r.process { login }
+          r.process { commit(purchase_request(money, payment_method, r.params["response_sessionid"], options), :response_transactionref) }
         end
       end
 
       def refund(money, authorization, options={})
         MultiResponse.run do |r|
-          r.process { commit(login_request) }
-          r.process { commit(refund_request(money, authorization, r.params["response_sessionid"])) }
+          r.process { login }
+          r.process { commit(refund_request(money, authorization, r.params["response_sessionid"]), :response_creditrequestreceived) }
         end
       end
 
@@ -89,10 +89,10 @@ module ActiveMerchant
         end
       end
 
-      def commit(request)
+      def commit(request, success_field_name)
         response = parse(ssl_post(url, request, headers))
+        succeeded = success_from(response, success_field_name)
 
-        succeeded = success_from(response)
         Response.new(
           succeeded,
           message_from(succeeded, response),
@@ -102,8 +102,8 @@ module ActiveMerchant
         )
       end
 
-      def success_from(response)
-        !response[:response_errors]
+      def success_from(response, success_field_name)
+        !empty?(response[success_field_name])
       end
 
       def message_from(succeeded, response)
@@ -252,6 +252,10 @@ module ActiveMerchant
         doc.ClientID(@options[:client_id])
       end
 
+      def login
+        commit(login_request, :response_sessionid)
+      end
+
       def login_request
         build_xml_request do |doc|
           doc.Auth do

data/lib/active_merchant/billing/gateways/worldpay.rb

@@ -147,6 +147,9 @@ module ActiveMerchant #:nodoc:
               end
               add_payment_method(xml, money, payment_method, options)
               add_email(xml, options)
+              if options[:hcg_additional_data]
+                add_hcg_additional_data(xml, options)
+              end
             end
           end
         end
@@ -254,6 +257,14 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_hcg_additional_data(xml, options)
+        xml.tag! 'hcgAdditionalData' do
+          options[:hcg_additional_data].each do |k, v|
+            xml.tag! "param", {name: k.to_s}, v
+          end
+        end
+      end
+
       def address_with_defaults(address)
         address ||= {}
         address.delete_if { |_, v| v.blank? }
@@ -297,6 +308,7 @@ module ActiveMerchant #:nodoc:
           message,
           raw,
           :authorization => authorization_from(raw),
+          :error_code => error_code_from(success, raw),
           :test => test?)
 
       rescue ActiveMerchant::ResponseError => e
@@ -326,6 +338,12 @@ module ActiveMerchant #:nodoc:
         [ success, message ]
       end
 
+      def error_code_from(success, raw)
+        unless success == "SUCCESS"
+          raw[:iso8583_return_code_code] || raw[:error_code] || nil
+        end
+      end
+
       def required_status_message(raw, success_criteria)
         if(!success_criteria.include?(raw[:last_event]))
           "A transaction status of #{success_criteria.collect{|c| "'#{c}'"}.join(" or ")} is required."

data/lib/active_merchant/country.rb

@@ -72,6 +72,7 @@ module ActiveMerchant #:nodoc:
       { alpha2: 'AD', name: 'Andorra', alpha3: 'AND', numeric: '020' },
       { alpha2: 'AO', name: 'Angola', alpha3: 'AGO', numeric: '024' },
       { alpha2: 'AI', name: 'Anguilla', alpha3: 'AIA', numeric: '660' },
+      { alpha2: 'AQ', name: 'Antarctica', alpha3: 'ATA', numeric: '010' },
       { alpha2: 'AG', name: 'Antigua and Barbuda', alpha3: 'ATG', numeric: '028' },
       { alpha2: 'AR', name: 'Argentina', alpha3: 'ARG', numeric: '032' },
       { alpha2: 'AM', name: 'Armenia', alpha3: 'ARM', numeric: '051' },
@@ -90,6 +91,7 @@ module ActiveMerchant #:nodoc:
       { alpha2: 'BM', name: 'Bermuda', alpha3: 'BMU', numeric: '060' },
       { alpha2: 'BT', name: 'Bhutan', alpha3: 'BTN', numeric: '064' },
       { alpha2: 'BO', name: 'Bolivia', alpha3: 'BOL', numeric: '068' },
+      { alpha2: 'BQ', name: 'Bonaire, Sint Eustatius and Saba', alpha3: 'BES', numeric: '535' },
       { alpha2: 'BA', name: 'Bosnia and Herzegovina', alpha3: 'BIH', numeric: '070' },
       { alpha2: 'BW', name: 'Botswana', alpha3: 'BWA', numeric: '072' },
       { alpha2: 'BV', name: 'Bouvet Island', alpha3: 'BVD', numeric: '074' },
@@ -262,15 +264,17 @@ module ActiveMerchant #:nodoc:
       { alpha2: 'SC', name: 'Seychelles', alpha3: 'SYC', numeric: '690' },
       { alpha2: 'SL', name: 'Sierra Leone', alpha3: 'SLE', numeric: '694' },
       { alpha2: 'SG', name: 'Singapore', alpha3: 'SGP', numeric: '702' },
+      { alpha2: 'SX', name: 'Sint Maarten', alpha3: 'SXM', numeric: '534' },
       { alpha2: 'SK', name: 'Slovakia', alpha3: 'SVK', numeric: '703' },
       { alpha2: 'SI', name: 'Slovenia', alpha3: 'SVN', numeric: '705' },
       { alpha2: 'SB', name: 'Solomon Islands', alpha3: 'SLB', numeric: '090' },
       { alpha2: 'SO', name: 'Somalia', alpha3: 'SOM', numeric: '706' },
       { alpha2: 'ZA', name: 'South Africa', alpha3: 'ZAF', numeric: '710' },
       { alpha2: 'GS', name: 'South Georgia and the South Sandwich Islands', alpha3: 'SGS', numeric: '239' },
+      { alpha2: 'SS', name: 'South Sudan', alpha3: 'SSD', numeric: '728' },
       { alpha2: 'ES', name: 'Spain', alpha3: 'ESP', numeric: '724' },
       { alpha2: 'LK', name: 'Sri Lanka', alpha3: 'LKA', numeric: '144' },
-      { alpha2: 'SD', name: 'Sudan', alpha3: 'SDN', numeric: '736' },
+      { alpha2: 'SD', name: 'Sudan', alpha3: 'SDN', numeric: '729' },
       { alpha2: 'SR', name: 'Suriname', alpha3: 'SUR', numeric: '740' },
       { alpha2: 'SJ', name: 'Svalbard and Jan Mayen', alpha3: 'SJM', numeric: '744' },
       { alpha2: 'SZ', name: 'Swaziland', alpha3: 'SWZ', numeric: '748' },
@@ -321,7 +325,7 @@ module ActiveMerchant #:nodoc:
         country_code = CountryCode.new(name)
         country = COUNTRIES.detect{|c| c[country_code.format] == upcase_name }
       else
-        country = COUNTRIES.detect{|c| c[:name] == name }
+        country = COUNTRIES.detect{|c| c[:name].upcase == name.upcase }
       end
       raise InvalidCountryCodeError, "No country could be found for the country #{name}" if country.nil?
       Country.new(country.dup)

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = "1.60.0"
+  VERSION = "1.61.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.60.0
+  version: 1.61.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-04 00:00:00.000000000 Z
+date: 2016-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -196,10 +196,12 @@ files:
 - lib/active_merchant/billing/gateways/cenpos.rb
 - lib/active_merchant/billing/gateways/checkout.rb
 - lib/active_merchant/billing/gateways/checkout_v2.rb
+- lib/active_merchant/billing/gateways/citrus_pay.rb
 - lib/active_merchant/billing/gateways/clearhaus.rb
 - lib/active_merchant/billing/gateways/commercegate.rb
 - lib/active_merchant/billing/gateways/conekta.rb
 - lib/active_merchant/billing/gateways/creditcall.rb
+- lib/active_merchant/billing/gateways/credorax.rb
 - lib/active_merchant/billing/gateways/cyber_source.rb
 - lib/active_merchant/billing/gateways/data_cash.rb
 - lib/active_merchant/billing/gateways/dibs.rb
@@ -243,6 +245,7 @@ files:
 - lib/active_merchant/billing/gateways/latitude19.rb
 - lib/active_merchant/billing/gateways/linkpoint.rb
 - lib/active_merchant/billing/gateways/litle.rb
+- lib/active_merchant/billing/gateways/mastercard.rb
 - lib/active_merchant/billing/gateways/maxipago.rb
 - lib/active_merchant/billing/gateways/merchant_e_solutions.rb
 - lib/active_merchant/billing/gateways/merchant_one.rb
@@ -265,6 +268,7 @@ files:
 - lib/active_merchant/billing/gateways/ncr_secure_pay.rb
 - lib/active_merchant/billing/gateways/net_registry.rb
 - lib/active_merchant/billing/gateways/netaxept.rb
+- lib/active_merchant/billing/gateways/netbanx.rb
 - lib/active_merchant/billing/gateways/netbilling.rb
 - lib/active_merchant/billing/gateways/netpay.rb
 - lib/active_merchant/billing/gateways/network_merchants.rb
@@ -272,6 +276,7 @@ files:
 - lib/active_merchant/billing/gateways/ogone.rb
 - lib/active_merchant/billing/gateways/omise.rb
 - lib/active_merchant/billing/gateways/openpay.rb
+- lib/active_merchant/billing/gateways/opp.rb
 - lib/active_merchant/billing/gateways/optimal_payment.rb
 - lib/active_merchant/billing/gateways/orbital.rb
 - lib/active_merchant/billing/gateways/orbital/orbital_soft_descriptors.rb
@@ -282,6 +287,7 @@ files:
 - lib/active_merchant/billing/gateways/pay_gate_xml.rb
 - lib/active_merchant/billing/gateways/pay_hub.rb
 - lib/active_merchant/billing/gateways/pay_junction.rb
+- lib/active_merchant/billing/gateways/pay_junction_v2.rb
 - lib/active_merchant/billing/gateways/pay_secure.rb
 - lib/active_merchant/billing/gateways/paybox_direct.rb
 - lib/active_merchant/billing/gateways/payeezy.rb
@@ -306,6 +312,7 @@ files:
 - lib/active_merchant/billing/gateways/payscout.rb
 - lib/active_merchant/billing/gateways/paystation.rb
 - lib/active_merchant/billing/gateways/payu_in.rb
+- lib/active_merchant/billing/gateways/payu_latam.rb
 - lib/active_merchant/billing/gateways/payway.rb
 - lib/active_merchant/billing/gateways/pin.rb
 - lib/active_merchant/billing/gateways/plugnpay.rb
@@ -336,6 +343,7 @@ files:
 - lib/active_merchant/billing/gateways/spreedly_core.rb
 - lib/active_merchant/billing/gateways/stripe.rb
 - lib/active_merchant/billing/gateways/swipe_checkout.rb
+- lib/active_merchant/billing/gateways/telr.rb
 - lib/active_merchant/billing/gateways/tns.rb
 - lib/active_merchant/billing/gateways/trans_first.rb
 - lib/active_merchant/billing/gateways/trans_first_transaction_express.rb
@@ -395,7 +403,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: activemerchant
-rubygems_version: 2.2.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Framework and tools for dealing with credit card transactions.