activemerchant 1.43.3 → 1.44.0

data/lib/active_merchant/billing/gateways/exact.rb

@@ -59,7 +59,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def credit(money, authorization, options = {})
-        deprecated CREDIT_DEPRECATION_MESSAGE
+        ActiveMerchant.deprecated CREDIT_DEPRECATION_MESSAGE
         refund(money, authorization, options)
       end
 

data/lib/active_merchant/billing/gateways/fat_zebra.rb

@@ -87,7 +87,7 @@ module ActiveMerchant #:nodoc:
           post[:card_token] = creditcard
           post[:cvv] = options[:cvv]
         elsif creditcard.is_a?(Hash)
-          deprecated "Passing the credit card as a Hash is deprecated. Use a String and put the (optional) CVV in the options hash instead."
+          ActiveMerchant.deprecated "Passing the credit card as a Hash is deprecated. Use a String and put the (optional) CVV in the options hash instead."
           post[:card_token] = creditcard[:token]
           post[:cvv] = creditcard[:cvv]
         else

data/lib/active_merchant/billing/gateways/federated_canada.rb

@@ -58,7 +58,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def credit(money, authorization, options = {})
-        deprecated CREDIT_DEPRECATION_MESSAGE
+        ActiveMerchant.deprecated CREDIT_DEPRECATION_MESSAGE
         refund(money, authorization, options)
       end
 
@@ -107,12 +107,6 @@ module ActiveMerchant #:nodoc:
         post[:cvv] = creditcard.verification_value
       end
 
-      def expdate(creditcard)
-        year  = sprintf("%.4i", creditcard.year)
-        month = sprintf("%.2i", creditcard.month)
-        "#{month}#{year[-2..-1]}"
-      end
-
       def parse(body)
         body.split('&').inject({}) do |memo, x|
           k, v = x.split('=')
@@ -126,7 +120,6 @@ module ActiveMerchant #:nodoc:
         data = ssl_post(self.live_url, post_data(action, parameters))
         response = parse(data)
         message = message_from(response)
-        test_mode = test?
 
         Response.new(success?(response), message, response,
           :test => test?,

data/lib/active_merchant/billing/gateways/finansbank.rb

@@ -3,7 +3,8 @@ require File.dirname(__FILE__) + '/cc5'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class FinansbankGateway < CC5Gateway
-      self.live_url = self.test_url = 'https://www.fbwebpos.com/servlet/cc5ApiServer'
+      self.live_url =  'https://www.fbwebpos.com/servlet/cc5ApiServer'
+      self.test_url = 'https://testsanalpos.est.com.tr/servlet/cc5ApiServer'
 
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US', 'TR']

data/lib/active_merchant/billing/gateways/first_pay.rb

@@ -1,176 +1,160 @@
+require 'nokogiri'
+
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class FirstPayGateway < Gateway
-      class FirstPayPostData < PostData
-        # Fields that will be sent even if they are blank
-        self.required_fields = [ :action, :amount, :trackid ]
-      end
+      self.live_url = 'https://secure.1stpaygateway.net/secure/gateway/xmlgateway.aspx'
 
-      # both URLs are IP restricted
-      self.test_url = 'https://apgcert.first-pay.com/AcqENGIN/SecureCapture'
-      self.live_url = 'https://acqengin.first-pay.com/AcqENGIN/SecureCapture'
-
-      # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US']
+      self.default_currency = 'USD'
+      self.money_format = :dollars
+      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
 
-      # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master]
-
-      # The homepage URL of the gateway
-      self.homepage_url = 'http://www.first-pay.com'
-
-      # The name of the gateway
-      self.display_name = 'First Pay'
-
-      # all transactions are in cents
-      self.money_format = :cents
-
-      ACTIONS = {
-        'sale' => 1,
-        'credit' => 2,
-        'void' => 3
-      }
+      self.homepage_url = 'http://1stpaygateway.net/'
+      self.display_name = '1stPayGateway.Net'
 
-      def initialize(options = {})
-        requires!(options, :login, :password)
+      def initialize(options={})
+        requires!(options, :transaction_center_id, :gateway_id)
         super
       end
 
-      def purchase(money, creditcard, options = {})
-        post = FirstPayPostData.new
-        add_invoice(post, options)
-        add_creditcard(post, creditcard)
-        add_address(post, options)
+      def purchase(money, payment, options={})
+        post = {}
+        add_invoice(post, money, options)
+        add_payment(post, payment)
+        add_address(post, payment, options)
         add_customer_data(post, options)
 
-        commit('sale', money, post)
+        commit('sale', post)
       end
 
-      def refund(money, reference, options = {})
-        requires!(options, :credit_card)
-
-        post = FirstPayPostData.new
-        add_invoice(post, options)
-        add_creditcard(post, options[:credit_card])
-        add_address(post, options)
+      def authorize(money, payment, options={})
+        post = {}
+        add_invoice(post, money, options)
+        add_payment(post, payment)
+        add_address(post, payment, options)
         add_customer_data(post, options)
-        add_credit_data(post, reference)
 
-        commit('credit', money, post)
+        commit('auth', post)
       end
 
-      def credit(money, reference, options = {})
-        deprecated CREDIT_DEPRECATION_MESSAGE
-        refund(money, reference, options)
+      def capture(money, authorization, options={})
+        post = {}
+        add_reference(post, 'settle', money, authorization)
+        commit('settle', post)
       end
 
-      def void(money, creditcard, options = {})
-        post = FirstPayPostData.new
-        add_creditcard(post, creditcard)
-        add_void_data(post, options)
-        add_invoice(post, options)
-        add_customer_data(post, options)
-
-        commit('void', money, post)
+      def refund(money, authorization, options={})
+        post = {}
+        add_reference(post, 'credit', money, authorization)
+        commit('credit', post)
       end
 
+      def void(authorization, options={})
+        post = {}
+        add_reference(post, 'void', nil, authorization)
+        commit('void', post)
+      end
 
       private
 
-      def add_customer_data(post, options)
-        post[:cardip] = options[:ip]
-        post[:email] = options[:email]
+      def add_authentication(post, options)
+        post[:transaction_center_id] = options[:transaction_center_id]
+        post[:gateway_id] = options[:gateway_id]
       end
 
-      def add_address(post, options)
-        if billing_address = options[:billing_address] || options[:address]
-          post[:addr]     = billing_address[:address1].to_s + ' ' + billing_address[:address2].to_s
-          post[:city]     = billing_address[:city]
-          post[:state]    = billing_address[:state]
-          post[:zip]      = billing_address[:zip]
-          post[:country]  = billing_address[:country]
-        end
+      def add_customer_data(post, options)
+        post[:owner_email] = options[:email] if options[:email]
+        post[:remote_ip_address] = options[:ip] if options[:ip]
       end
 
-      def add_invoice(post, options)
-        post[:trackid] = rand(Time.now.to_i)
+      def add_address(post, creditcard, options)
+        address = options[:billing_address] || options[:address]
+        post[:owner_name] = address[:name]
+        post[:owner_street] = address[:address1]
+        post[:owner_street2] = address[:address2] if address[:address2]
+        post[:owner_city] = address[:city]
+        post[:owner_state] = address[:state]
+        post[:owner_zip] = address[:zip]
+        post[:owner_country] = address[:country]
+        post[:owner_phone] = address[:phone] if address[:phone]
       end
 
-      def add_creditcard(post, creditcard)
-        post[:member] = creditcard.first_name.to_s + " " + creditcard.last_name.to_s
-        post[:card] = creditcard.number
-        post[:exp] = expdate(creditcard)
+      def add_invoice(post, money, options)
+        post[:order_id] = options[:order_id]
+        post[:total] = amount(money)
       end
 
-      def expdate(credit_card)
-        year  = sprintf("%.4i", credit_card.year)
-        month = sprintf("%.2i", credit_card.month)
-
-        "#{month}#{year[-2..-1]}"
+      def add_payment(post, payment)
+        post[:card_name] = payment.brand # Unclear if need to map to known names or open text field??
+        post[:card_number] = payment.number
+        post[:card_exp] = expdate(payment)
+        post[:cvv2] = payment.verification_value
       end
 
-      def add_credit_data(post, transaction_id)
-        post[:transid] = transaction_id
+      def add_reference(post, action, money, authorization)
+        post[:"#{action}_amount1"] = amount(money) if money
+        post[:total_number_transactions] = 1
+        post[:reference_number1] = authorization
       end
 
-      def add_void_data(post, options)
-        post[:transid] = options[:transactionid]
-      end
+      def parse(xml)
+        response = {}
 
-      def commit(action, money, post)
-        response = parse( ssl_post(test? ? self.test_url : self.live_url, post_data(action, post, money)) )
+        doc = Nokogiri::XML(xml)
+        doc.root.xpath("//RESPONSE/FIELDS/FIELD").each do |field|
+          response[field['KEY']] = field.text
+        end unless doc.root.nil?
 
-        Response.new(response[:response] == 'CAPTURED', response[:message], response,
-          :test => test?,
-          :authorization => response[:authorization],
-          :avs_result => { :code => response[:avsresponse] },
-          :cvv_result => response[:cvvresponse])
+        response
       end
 
-      def parse(body)
-        response = {}
+      def commit(action, parameters)
+        response = parse(ssl_post(live_url, post_data(action, parameters)))
 
-        # check for an error first
-        if body.include?('!ERROR!')
-          response[:response] = 'ERROR'
-          response[:message] = error_message_from(body)
-        else
-          # a capture / not captured response will be : delimited
-          split = body.split(':')
-          response[:response] = split[0]
-
-          # FirstPay docs are worthless. turns out the transactionid is required for credits
-          # so we need to store that in authorization, not the actual auth.
-          if response[:response] == 'CAPTURED'
-            response[:message] = 'CAPTURED'
-            response[:authorization] = split[9] # actually the transactionid
-            response[:auth] = split[1]
-            response[:avsresponse] = split[3]
-            response[:cvvresponse] = split[17]
-          else
-            # NOT CAPTURED response
-            response[:message] = split[1]
-            response[:transactionid] = split[9]
-          end
-        end
+        Response.new(
+          success_from(response),
+          message_from(response),
+          response,
+          authorization: authorization_from(response),
+          test: test?
+        )
+      end
 
-        return response
+      def success_from(response)
+        (
+          (response['status'] == '1') ||
+          (response['status1'] == '1')
+        )
       end
 
-      def error_message_from(response)
-        # error messages use this format - '!ERROR! 704-MISSING BASIC DATA TYPE:card, exp, zip, addr, member, amount\n'
-        response.split("! ")[1].chomp
+      def message_from(response)
+        # Silly inconsistent gateway. Always make capitalized (but not all caps)
+        msg = (response['auth_response'] || response['response1'])
+        msg.downcase.capitalize if msg
       end
 
-      def post_data(action, post, money)
-        post[:vid]        = @options[:login]
-        post[:password]   = @options[:password]
-        post[:action]     = ACTIONS[action]
-        post[:amount]     = amount(money)
+      def authorization_from(response)
+        response['reference_number'] || response['reference_number1']
+      end
+
+      def post_data(action, parameters = {})
+        parameters[:transaction_center_id] = @options[:transaction_center_id]
+        parameters[:gateway_id] = @options[:gateway_id]
+
+        parameters[:operation_type] = action
 
-        return post.to_post_data
+        xml = Builder::XmlMarkup.new
+        xml.instruct!
+        xml.tag! 'TRANSACTION' do
+          xml.tag! 'FIELDS' do
+            parameters.each do |key, value|
+              xml.tag! 'FIELD', value, { 'KEY' => key }
+            end
+          end
+        end
+        xml.target!
       end
     end
   end
 end
-

data/lib/active_merchant/billing/gateways/firstdata_e4.rb

@@ -6,12 +6,13 @@ module ActiveMerchant #:nodoc:
       self.live_url = "https://api.globalgatewaye4.firstdata.com/transaction/v11"
 
       TRANSACTIONS = {
-        :sale          => "00",
-        :authorization => "01",
-        :capture       => "32",
-        :void          => "33",
-        :credit        => "34",
-        :store         => "05"
+        sale:          "00",
+        authorization: "01",
+        verify:        "05",
+        capture:       "32",
+        void:          "33",
+        credit:        "34",
+        store:         "05"
       }
 
       POST_HEADERS = {
@@ -23,7 +24,15 @@ module ActiveMerchant #:nodoc:
 
       SENSITIVE_FIELDS = [:verification_str2, :expiry_date, :card_number]
 
-      self.supported_cardtypes = [:visa, :master, :american_express, :jcb, :discover]
+      BRANDS = {
+        :visa => 'Visa',
+        :master => "Mastercard",
+        :american_express => "American Express",
+        :jcb => "JCB",
+        :discover => "Discover"
+      }
+
+      self.supported_cardtypes = BRANDS.keys
       self.supported_countries = ["CA", "US"]
       self.default_currency = "USD"
       self.homepage_url = "http://www.firstdata.com"
@@ -66,6 +75,10 @@ module ActiveMerchant #:nodoc:
         commit(:credit, build_capture_or_credit_request(money, authorization, options))
       end
 
+      def verify(credit_card, options = {})
+        commit(:verify, build_sale_or_authorization_request(0, credit_card, options))
+      end
+
       # Tokenize a credit card with TransArmor
       #
       # The TransArmor token and other card data necessary for subsequent
@@ -121,6 +134,7 @@ module ActiveMerchant #:nodoc:
 
         add_customer_data(xml, options)
         add_invoice(xml, options)
+        add_card_authentication_data(xml, options)
 
         xml.target!
       end
@@ -131,6 +145,7 @@ module ActiveMerchant #:nodoc:
         add_identification(xml, identification)
         add_amount(xml, money)
         add_customer_data(xml, options)
+        add_card_authentication_data(xml, options)
 
         xml.target!
       end
@@ -165,12 +180,17 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_credit_card(xml, credit_card, options)
-        xml.tag! "Card_Number", credit_card.number
-        xml.tag! "Expiry_Date", expdate(credit_card)
-        xml.tag! "CardHoldersName", credit_card.name
-        xml.tag! "CardType", credit_card.brand
 
-        add_credit_card_verification_strings(xml, credit_card, options)
+        if credit_card.respond_to?(:track_data) && credit_card.track_data.present?
+          xml.tag! "Track1", credit_card.track_data
+        else
+          xml.tag! "Card_Number", credit_card.number
+          xml.tag! "Expiry_Date", expdate(credit_card)
+          xml.tag! "CardHoldersName", credit_card.name
+          xml.tag! "CardType", card_type(credit_card.brand)
+
+          add_credit_card_verification_strings(xml, credit_card, options)
+        end
       end
 
       def add_credit_card_verification_strings(xml, credit_card, options)
@@ -187,6 +207,12 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_card_authentication_data(xml, options)
+        xml.tag! "CAVV", options[:cavv]
+        xml.tag! "XID", options[:xid]
+        xml.tag! "Ecommerce_Flag", options[:eci]
+      end
+
       def add_credit_card_token(xml, store_authorization)
         params = store_authorization.split(";")
         credit_card = CreditCard.new(
@@ -199,7 +225,7 @@ module ActiveMerchant #:nodoc:
         xml.tag! "TransarmorToken", params[0]
         xml.tag! "Expiry_Date", expdate(credit_card)
         xml.tag! "CardHoldersName", credit_card.name
-        xml.tag! "CardType", credit_card.brand
+        xml.tag! "CardType", card_type(credit_card.brand)
       end
 
       def add_customer_data(xml, options)
@@ -223,6 +249,10 @@ module ActiveMerchant #:nodoc:
         "#{format(credit_card.month, :two_digits)}#{format(credit_card.year, :two_digits)}"
       end
 
+      def card_type(credit_card_brand)
+        BRANDS[credit_card_brand.to_sym] if credit_card_brand
+      end
+
       def commit(action, request, credit_card = nil)
         url = (test? ? self.test_url : self.live_url)
         begin