activemerchant 1.4.2 → 1.5.0

data/test/unit/gateways/skip_jack_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class SkipJackTest < Test::Unit::TestCase
 
@@ -110,6 +110,71 @@ class SkipJackTest < Test::Unit::TestCase
     assert_equal 'M', response.cvv_result['code']
   end
   
+  def test_basic_test_url
+    @gateway.stubs(:test?).returns(true)
+    @gateway.stubs(:advanced?).returns(false)
+    assert_equal "https://developer.skipjackic.com/scripts/evolvcc.dll?AuthorizeAPI", @gateway.send(:url_for, :authorization)
+  end
+  
+  def test_basic_test_url_non_authorization
+    @gateway.stubs(:test?).returns(true)
+    @gateway.stubs(:advanced?).returns(false)
+    assert_equal "https://developer.skipjackic.com/scripts/evolvcc.dll?SJAPI_TransactionChangeStatusRequest", @gateway.send(:url_for, :change_status)
+  end
+  
+  def test_advanced_test_url
+    @gateway.stubs(:test?).returns(true)
+    @gateway.stubs(:advanced?).returns(true)
+    assert_equal "https://developer.skipjackic.com/evolvcc/evolvcc.aspx?AuthorizeAPI", @gateway.send(:url_for, :authorization)
+  end
+  
+  def test_advanced_test_url_non_authorization
+    @gateway.stubs(:test?).returns(true)
+    @gateway.stubs(:advanced?).returns(true)
+    assert_equal "https://developer.skipjackic.com/scripts/evolvcc.dll?SJAPI_TransactionChangeStatusRequest", @gateway.send(:url_for, :change_status)
+  end
+  
+  def test_basic_live_url
+    @gateway.stubs(:test?).returns(false)
+    @gateway.stubs(:advanced?).returns(false)
+    assert_equal "https://www.skipjackic.com/scripts/evolvcc.dll?AuthorizeAPI", @gateway.send(:url_for, :authorization)
+  end
+  
+  def test_basic_live_url_non_authorization
+    @gateway.stubs(:test?).returns(false)
+    @gateway.stubs(:advanced?).returns(false)
+    assert_equal "https://www.skipjackic.com/scripts/evolvcc.dll?SJAPI_TransactionChangeStatusRequest", @gateway.send(:url_for, :change_status)
+  end
+  
+  def test_advanced_live_url
+    @gateway.stubs(:test?).returns(false)
+    @gateway.stubs(:advanced?).returns(true)
+    assert_equal "https://www.skipjackic.com/evolvcc/evolvcc.aspx?AuthorizeAPI", @gateway.send(:url_for, :authorization)
+  end
+  
+  def test_advanced_live_url_non_authorization
+    @gateway.stubs(:test?).returns(false)
+    @gateway.stubs(:advanced?).returns(true)
+    assert_equal "https://www.skipjackic.com/scripts/evolvcc.dll?SJAPI_TransactionChangeStatusRequest", @gateway.send(:url_for, :change_status)
+  end
+  
+  def test_paymentech_authorization_success    
+    @gateway.expects(:ssl_post).returns(successful_paymentech_authorization_response)
+
+    assert response = @gateway.authorize(@amount, @credit_card, @options)
+    assert_instance_of Response, response
+    assert_success response
+    assert_equal '40000024585892.109', response.authorization
+  end
+  
+  def test_paymentech_authorization_failure
+    @gateway.expects(:ssl_post).returns(unsuccessful_paymentech_authorization_response)
+
+    assert response = @gateway.authorize(@amount, @credit_card, @options)
+    assert_instance_of Response, response
+    assert_failure response
+  end
+  
   private
   def successful_authorization_response
     <<-CSV
@@ -130,4 +195,19 @@ class SkipJackTest < Test::Unit::TestCase
 "AUTHCODE","szSerialNumber","szTransactionAmount","szAuthorizationDeclinedMessage","szAVSResponseCode","szAVSResponseMessage","szOrderNumber","szAuthorizationResponseCode","szIsApproved","szCVV2ResponseCode","szCVV2ResponseMessage","szReturnCode","szTransactionFileName","szCAVVResponseCode"\r\n"EMPTY","000386891209","100","","","","b1eec256d0182f29375e0cbae685092d","","0","","","-35","",""
     CSV
   end
+  
+  def unsuccessful_paymentech_authorization_response
+    <<-CSV
+"AUTHCODE","szSerialNumber","szTransactionAmount","szAuthorizationDeclinedMessage","szAVSResponseCode","szAVSResponseMessage","szOrderNumber","szAuthorizationResponseCode","szIsApproved","szCVV2ResponseCode","szCVV2ResponseMessage","szReturnCode","szTransactionFileName","szCAVVResponseCode",
+"EMPTY","000000000000","1.00","","","","43985b7953199d1f02c3017f948e9f13","","0","","","-83","","",    
+    CSV
+  end
+  
+  def successful_paymentech_authorization_response
+    <<-CSV
+"AUTHCODE","szSerialNumber","szTransactionAmount","szAuthorizationDeclinedMessage","szAVSResponseCode","szAVSResponseMessage","szOrderNumber","szAuthorizationResponseCode","szIsApproved","szCVV2ResponseCode","szCVV2ResponseMessage","szReturnCode","szTransactionFileName","szCAVVResponseCode",
+"093223","000000000000","1.00","","Y","Card authorized, exact address match with 5 digit zip code.","5ac0f04e737baea5a5370037afe827f6","093223","1","M","Match","1","40000024585892.109","",    
+    CSV
+  end
 end
+

data/test/unit/gateways/trans_first_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class TransFirstTest < Test::Unit::TestCase
 

data/test/unit/gateways/trust_commerce_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class TrustCommerceTest < Test::Unit::TestCase
   def setup

data/test/unit/gateways/usa_epay_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class UsaEpayTest < Test::Unit::TestCase
   def setup

data/test/unit/gateways/verifi_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class VerifiTest < Test::Unit::TestCase
   include ActiveMerchant::Billing

data/test/unit/gateways/viaklix_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class ViaklixTest < Test::Unit::TestCase
 

data/test/unit/gateways/wirecard_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class WirecardTest < Test::Unit::TestCase
   TEST_AUTHORIZATION_GUWID = 'C822580121385121429927'
@@ -17,6 +17,16 @@ class WirecardTest < Test::Unit::TestCase
       :description => 'Wirecard Purchase',
       :email => 'soleone@example.com'
     }
+    
+    @address_without_state = {
+      :name     => 'Jim Smith',
+      :address1 => '1234 My Street',
+      :company  => 'Widgets Inc',
+      :city     => 'Ottawa',
+      :zip      => 'K12 P2A',
+      :country  => 'CA',
+      :state    => nil,
+    }
   end
 
   def test_successful_authorization
@@ -61,6 +71,14 @@ class WirecardTest < Test::Unit::TestCase
     assert response.message["Could not find referenced transaction for GuWID 1234567890123456789012."]  
   end
 
+  def test_doesnt_raise_an_error_if_no_state_is_provided_in_address
+    options = @options.merge(:billing_address => @address_without_state)
+    @gateway.expects(:ssl_post).returns(unauthorized_capture_response)
+    assert_nothing_raised do
+      @gateway.authorize(@amount, @credit_card, options)
+    end
+  end
+
   private
 
   # Authorization success

data/test/unit/generators/test_generator_helper.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 require 'fileutils'
 
 # Must set before requiring generator libs.

data/test/unit/integrations/action_view_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class ActionViewHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations::ActionViewHelper

data/test/unit/integrations/bogus_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class BogusModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/chronopay_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class ChronopayModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/gestpay_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class GestpayModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/bogus_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class BogusHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/chronopay_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class ChronopayHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/gestpay_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class GestpayHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/hi_trust_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class HiTrustHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/nochex_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class NochexHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/paypal_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class PaypalHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations
@@ -72,12 +72,21 @@ class PaypalHelperTest < Test::Unit::TestCase
   end
 
   def test_phone_parsing
-    @helper.shipping_address :phone => '111-222-3333'
+    @helper.shipping_address :country => 'CA', :phone => '111-222-3333'
 
     assert_field 'night_phone_a', '111'
     assert_field 'night_phone_b', '222'
     assert_field 'night_phone_c', '3333'
   end
+
+
+  def test_phone_parsing_for_non_us
+    @helper.shipping_address :country => 'UK', :phone => '028 38841670'
+
+    assert_field 'night_phone_a', nil
+    assert_field 'night_phone_b', '02838841670'
+    assert_field 'night_phone_c', nil
+  end
   
   
   def test_province

data/test/unit/integrations/helpers/quickpay_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class QuickpayHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/helpers/two_checkout_helper_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class TwoCheckoutHelperTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/hi_trust_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class HiTrustModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/nochex_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class ChronopayModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/chronopay_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class ChronopayNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/gestpay_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class GestpayNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/hi_trust_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class HiTrustNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/nochex_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class NochexNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations
@@ -46,6 +46,6 @@ class NochexNotificationTest < Test::Unit::TestCase
 
   private
   def http_raw_data
-    "transaction_date=27/09/2006 22:30:53&transaction_id=91191&order_id=11&from_email=test2@nochex.com&to_email=test1@nochex.com&amount=31.66&security_key=L254524366479818252491366&status=test&custom="
+    "transaction_date=27/09/2006 22:30:53&transaction_id=91191&order_id=11&from_email=test2@nochex.com&to_email=test1@nochex.com&amount=31.6600&security_key=L254524366479818252491366&status=test&custom="
   end  
 end

data/test/unit/integrations/notifications/notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class NotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/paypal_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class PaypalNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/quickpay_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class QuickpayNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/notifications/two_checkout_notification_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class TwoCheckoutNotificationTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/paypal_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class PaypalModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/quickpay_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class QuickpayModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/chronopay_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class ChronopayReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/gestpay_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class GestpayReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/hi_trust_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class HiTrustReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/nochex_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class NochexReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/paypal_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class PaypalReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class ReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/returns/two_checkout_return_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../../test_helper'
+require 'test_helper'
 
 class TwoCheckoutReturnTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/integrations/two_checkout_module_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../test_helper'
+require 'test_helper'
 
 class TwoCheckoutModuleTest < Test::Unit::TestCase
   include ActiveMerchant::Billing::Integrations

data/test/unit/post_data_test.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../test_helper'
+require 'test_helper'
 
 class MyPost < PostData
   self.required_fields = [ :ccnumber, :ccexp, :firstname, :lastname, :username, :password, :order_id, :key, :time ]

data/test/unit/posts_data_test.rb

@@ -1,14 +1,9 @@
-require File.dirname(__FILE__) + '/../test_helper'
-
-class MockResponse
-  def body
-  end
-end
+require 'test_helper'
 
 class PostsDataTests < Test::Unit::TestCase
-  URL = 'http://example.com'
-  
+
   def setup
+    @url = 'http://example.com'
     @gateway = SimpleTestGateway.new
   end
   
@@ -17,69 +12,22 @@ class PostsDataTests < Test::Unit::TestCase
   end
   
   def test_single_successful_post
-    Net::HTTP.any_instance.expects(:post).once.returns(MockResponse.new)
+    ActiveMerchant::Connection.any_instance.expects(:request).returns('')
     
     assert_nothing_raised do
-      @gateway.ssl_post(URL, '') 
+      @gateway.ssl_post(@url, '') 
     end
   end
   
   def test_multiple_successful_posts
-    responses = [ MockResponse.new, MockResponse.new ]
-    Net::HTTP.any_instance.expects(:post).times(2).returns(*responses)
-    
-    assert_nothing_raised do
-      @gateway.ssl_post(URL, '')
-      @gateway.ssl_post(URL, '') 
-    end
-  end
-  
-  def test_unrecoverable_exception
-    Net::HTTP.any_instance.expects(:post).raises(EOFError)
-    
-    assert_raises(ActiveMerchant::ConnectionError) do
-      @gateway.ssl_post(URL, '') 
-    end
-  end
-  
-  def test_failure_then_success_with_recoverable_exception
-    Net::HTTP.any_instance.expects(:post).times(2).raises(Errno::ECONNREFUSED).then.returns(MockResponse.new)
+    ActiveMerchant::Connection.any_instance.expects(:request).times(2).returns('', '')
     
     assert_nothing_raised do
-      @gateway.ssl_post(URL, '')
+      @gateway.ssl_post(@url, '')
+      @gateway.ssl_post(@url, '') 
     end
   end
-  
-  def test_failure_limit_reached
-    Net::HTTP.any_instance.expects(:post).times(ActiveMerchant::PostsData::MAX_RETRIES).raises(Errno::ECONNREFUSED)
     
-    assert_raises(ActiveMerchant::ConnectionError) do 
-      @gateway.ssl_post(URL, '')
-    end
-  end
-  
-  def test_failure_then_success_with_retry_safe_enabled
-    Net::HTTP.any_instance.expects(:post).times(2).raises(EOFError).then.returns(MockResponse.new)
-    
-    @gateway.retry_safe = true
-    
-    assert_nothing_raised do
-      @gateway.ssl_post(URL, '')
-    end
-  end
-  
-  def test_mixture_of_failures_with_retry_safe_enabled
-    Net::HTTP.any_instance.expects(:post).times(3).raises(Errno::ECONNRESET).
-                                                   raises(Errno::ECONNREFUSED).
-                                                   raises(EOFError)
-      
-    @gateway.retry_safe = true
-                                                     
-    assert_raises(ActiveMerchant::ConnectionError) do  
-      @gateway.ssl_post(URL, '')
-    end
-  end
-  
   def test_setting_ssl_strict_outside_class_definition
     assert_equal SimpleTestGateway.ssl_strict, SubclassGateway.ssl_strict
     SimpleTestGateway.ssl_strict = !SimpleTestGateway.ssl_strict
@@ -87,14 +35,14 @@ class PostsDataTests < Test::Unit::TestCase
   end
 
   def test_setting_timeouts
-    @gateway.class.open_timeout=50
-    @gateway.class.read_timeout=37
-    Net::HTTP.any_instance.expects(:post).once.returns(MockResponse.new)
-    Net::HTTP.any_instance.expects(:open_timeout=).with(50)
-    Net::HTTP.any_instance.expects(:read_timeout=).with(37)
+    @gateway.class.open_timeout = 50
+    @gateway.class.read_timeout = 37
+    ActiveMerchant::Connection.any_instance.expects(:request).returns('')
+    ActiveMerchant::Connection.any_instance.expects(:open_timeout=).with(50)
+    ActiveMerchant::Connection.any_instance.expects(:read_timeout=).with(37)
 
     assert_nothing_raised do
-      @gateway.ssl_post(URL, '')
+      @gateway.ssl_post(@url, '')
     end
   end
 end