activemerchant 1.4.1 → 1.4.2

data/test/unit/gateways/quickpay_test.rb

@@ -13,7 +13,7 @@ class QuickpayTest < Test::Unit::TestCase
   end
   
   def test_successful_purchase
-    @gateway.expects(:ssl_post).times(2).returns(successful_authorization_response, successful_capture_response)
+    @gateway.expects(:ssl_post).returns(successful_authorization_response, successful_capture_response)
     
     assert response = @gateway.purchase(@amount, @credit_card, @options)
     assert_success response
@@ -45,8 +45,8 @@ class QuickpayTest < Test::Unit::TestCase
     response = @gateway.purchase(@amount, @credit_card, @options)
     assert_failure response
     assert_equal '008', response.params['qpstat']
-    assert_equal 'Missing/error in cardnumberMissing/error in expirationdateMissing/error in card verification dataMissing/error in amountMissing/error in ordernumMissing/error in currency', response.params['qpstatmsg']
-    assert_equal 'Missing/error in cardnumber, Missing/error in expirationdate, Missing/error in card verification data, Missing/error in amount, Missing/error in ordernum, and Missing/error in currency', response.message
+    assert_equal 'Missing/error in cardnumber, Missing/error in expirationdate, Missing/error in card verification data, Missing/error in amount, Missing/error in ordernum, Missing/error in currency', response.params['qpstatmsg']
+    assert_equal 'Missing/error in cardnumber, Missing/error in expirationdate, Missing/error in card verification data, Missing/error in amount, Missing/error in ordernum, Missing/error in currency', response.message
   end
   
   def test_merchant_error
@@ -91,22 +91,22 @@ class QuickpayTest < Test::Unit::TestCase
   private
   
   def error_response
-    "<?xml version='1.0' encoding='ISO-8859-1'?><values qpstat='008' qpstatmsg='Missing/error in cardnumberMissing/error in expirationdateMissing/error in card verification dataMissing/error in amountMissing/error in ordernumMissing/error in currency'/>"
+    "<?xml version='1.0' encoding='ISO-8859-1'?><response><qpstat>008</qpstat><qpstatmsg>Missing/error in cardnumber, Missing/error in expirationdate, Missing/error in card verification data, Missing/error in amount, Missing/error in ordernum, Missing/error in currency</qpstatmsg></response>"
   end
   
   def merchant_error
-    "<?xml version='1.0' encoding='ISO-8859-1'?><values qpstat='008' qpstatmsg='Missing/error in merchant'/>"
+    "<?xml version='1.0' encoding='ISO-8859-1'?><response><qpstat>008</qpstat><qpstatmsg>Missing/error in merchant</qpstatmsg></response>"
   end
   
   def successful_authorization_response
-    "<?xml version='1.0' encoding='ISO-8859-1'?><values qpstat='000' transaction='2865261' time='070425223705' ordernum='104680' merchantemail='cody@example.com' pbsstat='000' cardtype='Visa' amount='100' qpstatmsg='OK' merchant='Shopify' msgtype='1110' currency='USD'/>"
+    "<?xml version='1.0' encoding='ISO-8859-1'?><response><qpstat>000</qpstat><transaction>2865261</transaction><time>070425223705</time><ordernum>104680</ordernum><merchantemail>cody@example.com</merchantemail><pbsstat>000</pbsstat><cardtype>Visa</cardtype><amount>100</amount><qpstatmsg>OK</qpstatmsg><merchant>Shopify</merchant><msgtype>1110</msgtype><currency>USD</currency></response>"
   end
   
   def successful_capture_response
-    '<?xml version="1.0" encoding="ISO-8859-1"?><values msgtype="1230" amount="100" time="080107061755" pbsstat="000" qpstat="000" qpstatmsg="OK" currency="DKK" ordernum="4820346075804536193" transaction="2865261" merchant="Shopify" merchantemail="pixels@jadedpixel.com" />'
+    '<?xml version="1.0" encoding="ISO-8859-1"?><response><msgtype>1230</msgtype><amount>100</amount><time>080107061755</time><pbsstat>000</pbsstat><qpstat>000</qpstat><qpstatmsg>OK</qpstatmsg><currency>DKK</currency><ordernum>4820346075804536193</ordernum><transaction>2865261</transaction><merchant>Shopify</merchant><merchantemail>pixels@jadedpixel.com</merchantemail></response>'
   end
   
   def failed_authorization_response
-    '<?xml version="1.0" encoding="ISO-8859-1"?><values qpstat="008" qpstatmsg="Missing/error in card verification data" />'
+    '<?xml version="1.0" encoding="ISO-8859-1"?><response><qpstat>008</qpstat><qpstatmsg>Missing/error in card verification data</qpstatmsg></response>'
   end
 end

data/test/unit/gateways/trust_commerce_test.rb

@@ -58,6 +58,18 @@ class TrustCommerceTest < Test::Unit::TestCase
     assert_equal [:visa, :master, :discover, :american_express, :diners_club, :jcb], TrustCommerceGateway.supported_cardtypes
   end
   
+  def test_test_flag_should_be_set_when_using_test_login_in_production
+    Base.gateway_mode = :production
+    @gateway.expects(:ssl_post).returns(successful_purchase_response)
+    assert response = @gateway.purchase(@amount, @credit_card)
+    assert_success response
+    assert response.test?
+  ensure
+    Base.gateway_mode = :test
+  end
+  
+  private
+  
   def successful_purchase_response
     <<-RESPONSE
 transid=025-0007423614

data/test/unit/integrations/helpers/quickpay_helper_test.rb

@@ -0,0 +1,40 @@
+require File.dirname(__FILE__) + '/../../../test_helper'
+
+class QuickpayHelperTest < Test::Unit::TestCase
+  include ActiveMerchant::Billing::Integrations
+  
+  def setup
+    @helper = Quickpay::Helper.new('order-500','24352435', :amount => 500, :currency => 'USD')
+    @helper.md5secret "mysecretmd5string"
+    @helper.return_url 'http://example.com/ok'
+    @helper.cancel_return_url 'http://example.com/cancel'
+    @helper.notify_url 'http://example.com/notify'
+  end
+ 
+  def test_basic_helper_fields
+    assert_field 'merchant', '24352435'
+    assert_field 'amount', '500'
+    assert_field 'ordernumber', 'order500'
+  end
+  
+  def test_generate_md5string
+    assert_equal '3authorize24352435daorder500500USDhttp://example.com/okhttp://example.com/cancelhttp://example.com/notify00mysecretmd5string', 
+                 @helper.generate_md5string
+  end
+  
+  def test_generate_md5check
+    assert_equal '31a0a94ce953208d05f3f3d255fff31f', @helper.generate_md5check
+  end
+  
+  def test_unknown_mapping
+    assert_nothing_raised do
+      @helper.company_address :address => '500 Dwemthy Fox Road'
+    end
+  end
+  
+  def test_setting_invalid_address_field
+    fields = @helper.fields.dup
+    @helper.billing_address :street => 'My Street'
+    assert_equal fields, @helper.fields
+  end
+end

data/test/unit/integrations/notifications/quickpay_notification_test.rb

@@ -0,0 +1,69 @@
+require File.dirname(__FILE__) + '/../../../test_helper'
+
+class QuickpayNotificationTest < Test::Unit::TestCase
+  include ActiveMerchant::Billing::Integrations
+
+  def setup
+    @quickpay = Quickpay::Notification.new(http_raw_data, :md5secret => "mysecretmd5string")
+  end
+
+  def test_accessors
+    assert @quickpay.complete?
+    assert_equal "000", @quickpay.status
+    assert_equal "88", @quickpay.transaction_id
+    assert_equal "order-4232", @quickpay.item_id
+    assert_equal "89.50", @quickpay.gross
+    assert_equal "DKK", @quickpay.currency
+    assert_equal Time.parse("2008-11-05 21:57:37"), @quickpay.received_at
+    assert @quickpay.test?
+  end
+
+  def test_compositions
+    assert_equal Money.new(8950, 'DKK'), @quickpay.amount
+  end
+
+  def test_acknowledgement    
+    assert @quickpay.acknowledge
+  end
+  
+  def test_failed_acknnowledgement
+    @quickpay = Quickpay::Notification.new(http_raw_data, :md5secret => "badmd5string")
+    assert !@quickpay.acknowledge
+  end
+
+  def test_acknowledgement_with_cardnumber
+    @quickpay = Quickpay::Notification.new(http_raw_data_with_cardnumber, :md5secret => "mysecretmd5string")
+    assert @quickpay.acknowledge
+  end
+  
+  def test_quickpay_attributes
+    assert_equal "Authorized", @quickpay.state
+    assert_equal "authorize", @quickpay.msgtype
+  end
+
+  def test_generate_md5string
+    assert_equal "authorizeorder-42328950DKK081105215737Authorized000Ok000OK89898989info@pinds.com88visa-dkYesmysecretmd5string", 
+                 @quickpay.generate_md5string
+  end
+
+  def test_generate_md5check
+    assert_equal "e70bd0e528dc335ac74d5f1c348fe2f4", @quickpay.generate_md5check
+  end
+
+  def test_respond_to_acknowledge
+    assert @quickpay.respond_to?(:acknowledge)
+  end
+
+  private
+  def http_raw_data
+    "msgtype=authorize&ordernumber=order-4232&amount=8950&currency=DKK&time=081105215737&state=Authorized&" + 
+    "chstat=000&chstatmsg=Ok&qpstat=000&qpstatmsg=OK&merchant=89898989&merchantemail=info@pinds.com&transaction=88&" + 
+    "cardtype=visa-dk&testmode=Yes&md5check=e70bd0e528dc335ac74d5f1c348fe2f4"
+  end  
+
+  def http_raw_data_with_cardnumber
+    "msgtype=authorize&ordernumber=order-4232&amount=8950&currency=DKK&time=081105215737&state=Authorized&" + 
+    "chstat=000&chstatmsg=Ok&qpstat=000&qpstatmsg=OK&merchant=89898989&merchantemail=info@pinds.com&transaction=88&" + 
+    "cardtype=visa-dk&testmode=Yes&cardnumber=XXXXXXXXXXXX4092&md5check=bded8685e10790a9351a9d51285cec9d"
+  end  
+end

data/test/unit/integrations/quickpay_module_test.rb

@@ -0,0 +1,9 @@
+require File.dirname(__FILE__) + '/../../test_helper'
+
+class QuickpayModuleTest < Test::Unit::TestCase
+  include ActiveMerchant::Billing::Integrations
+  
+  def test_notification_method
+    assert_instance_of Quickpay::Notification, Quickpay.notification('name=cody')
+  end
+end 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: activemerchant
 version: !ruby/object:Gem::Version 
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors: 
 - Tobias Luetke
@@ -30,7 +30,7 @@ cert_chain:
   hPaSTyVU0yCSnw==
   -----END CERTIFICATE-----
 
-date: 2008-12-09 00:00:00 -05:00
+date: 2009-04-24 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -41,7 +41,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.4.1
+        version: 2.3.2
     version: 
 - !ruby/object:Gem::Dependency 
   name: builder
@@ -169,6 +169,10 @@ files:
 - lib/active_merchant/billing/integrations/paypal/notification.rb
 - lib/active_merchant/billing/integrations/paypal/return.rb
 - lib/active_merchant/billing/integrations/paypal.rb
+- lib/active_merchant/billing/integrations/quickpay
+- lib/active_merchant/billing/integrations/quickpay/helper.rb
+- lib/active_merchant/billing/integrations/quickpay/notification.rb
+- lib/active_merchant/billing/integrations/quickpay.rb
 - lib/active_merchant/billing/integrations/return.rb
 - lib/active_merchant/billing/integrations/two_checkout
 - lib/active_merchant/billing/integrations/two_checkout/helper.rb
@@ -190,8 +194,6 @@ files:
 - lib/certs/cacert.pem
 - lib/support
 - lib/support/gateway_support.rb
-- lib/tasks
-- lib/tasks/cia.rb
 - test/extra
 - test/extra/binding_of_caller.rb
 - test/extra/breakpoint.rb
@@ -319,6 +321,7 @@ files:
 - test/unit/integrations/helpers/hi_trust_helper_test.rb
 - test/unit/integrations/helpers/nochex_helper_test.rb
 - test/unit/integrations/helpers/paypal_helper_test.rb
+- test/unit/integrations/helpers/quickpay_helper_test.rb
 - test/unit/integrations/helpers/two_checkout_helper_test.rb
 - test/unit/integrations/hi_trust_module_test.rb
 - test/unit/integrations/nochex_module_test.rb
@@ -329,8 +332,10 @@ files:
 - test/unit/integrations/notifications/nochex_notification_test.rb
 - test/unit/integrations/notifications/notification_test.rb
 - test/unit/integrations/notifications/paypal_notification_test.rb
+- test/unit/integrations/notifications/quickpay_notification_test.rb
 - test/unit/integrations/notifications/two_checkout_notification_test.rb
 - test/unit/integrations/paypal_module_test.rb
+- test/unit/integrations/quickpay_module_test.rb
 - test/unit/integrations/returns
 - test/unit/integrations/returns/chronopay_return_test.rb
 - test/unit/integrations/returns/gestpay_return_test.rb

data/lib/tasks/cia.rb

@@ -1,90 +0,0 @@
-# Figure out the root path of this app. The default method will assume that 
-# its the same as the location of the running Rakefile
-ROOT = File.expand_path(FileUtils.pwd) + '/'
-
-# Standard settings, you can override each of them using the environment 
-# e.g. rake cia EMAIL_TO=your@email.com 
-#
-RAKE_TASK   = ENV['RAKE_TASK']  || ''
-EMAIL_TO    = ENV['EMAIL_TO']   || 'tobi@leetsoft.com'
-EMAIL_FROM  = ENV['EMAIL_FROM'] || 'CIA <cia@jadedpixel.com>' 
-
-# Get last segment of application's path and treat it as name. 
-NAME        = ENV['NAME'] || ROOT.scan(/(\w+)\/$/).flatten.first.capitalize 
-
-
-class Build
-  attr_reader :status, :output, :success
-
-  def self.run
-    Build.new.run
-  end
-  
-  def run 
-    update if @status.nil?    
-    make if @success.nil?
-  end
-  
-  def revision
-    info['Revision'].to_i
-  end
-  
-  def url
-    info['URL']
-  end
-  
-  def commit_message
-    `svn log #{ROOT} -rHEAD`
-  end
-  
-  def author
-    info['Last Changed Author']
-  end
-
-  def tests_ok?
-    run if @success.nil?
-    @success == true
-  end
-  
-  def has_changes?
-    update if @status.nil?    
-    @status =~ /[A-Z]\s+[\w\/]+/
-  end
-
-  private
-
-  def update
-    @status = `svn update #{ROOT}`
-  end
-  
-  def info
-    @info ||= YAML.load(`svn info #{ROOT}`)
-  end
-    
-  def make
-    @output, @success = `cd #{ROOT} && rake #{RAKE_TASK}`, ($?.exitstatus == 0)
-  end
-end
-
-task :cia do
-  build = Build.new
-  
-  if build.has_changes? and not build.tests_ok? 
-
-    require 'actionmailer'
-
-    ActionMailer::Base.delivery_method = :sendmail
-
-    class Notifier < ActionMailer::Base
-      def failure(build, sent_at = Time.now)
-        @subject    = "[#{NAME}] Build Failure (##{build.revision})"
-        @recipients, @from, @sent_on = EMAIL_TO, EMAIL_FROM, sent_at
-        @body       = ["#{build.author} broke the build!", build.commit_message, build.output].join("\n\n")
-      end
-    end
-    
-    Notifier.deliver_failure(build)
-
-  end 
-end
-