activemerchant 1.31.0 → 1.32.0

data/CHANGELOG

@@ -1,5 +1,34 @@
 = ActiveMerchant CHANGELOG
 
+== Version 1.32.0 (April 1, 2013)
+
+* Optimal: Submit shipping address with requests [jduff]
+* Iridium: Enable reference transactions for authorize [ntalbott]
+* Stripe: Add authorize and capture methods [melari]
+* Pin: Add a default description if none is specified to fix failures [melari]
+* Litle: Add support for passing optional fields in token based transactions [forest]
+* Add Finansbank gateway [scamurcuoglu]
+* Paymill: Use .com instead of .de for save card url [besi]
+* Worldpay integration: Use more robust endpoint urls [nashbridges]
+* Braintree Blue: Return CC token in transaction hash [cyu]
+* Robokassa: Fix signature for empty amount [ukolovda]
+* Worldpay gateway: Fix error messages for some failures [duff]
+* Worldpay gateway: Allow settled payments to be refunded [dougal]
+* Spreedly: Update urls and terminology [duff]
+* Make card brand error more user friendly [oggy]
+* DataCash: Update test Mastercard number [jamesshipton]
+* DataCash: Update test response fixtures [jamesshipton]
+* Pin: Add Pin.js card token support [nagash]
+* PayPal Express gateway: Fix error when no address information is in response [pierre]
+* Ogone: Use BYPSP for ALIASOPERATION [ntalbott]
+* Paymill: Handle error storing card [duff]
+* SagePay integration: Add referrer field [melari]
+* Pin: Add extra headers [duff]
+
+== Version 1.31.1 (February 25, 2013)
+
+* Cybersource: Bug fixes [natejgreene, jduff]
+
 == Version 1.31.0 (February 20, 2013)
 
 * Worldpay: XML encoding is required to be ISO-8859-1 [dougal]

data/CONTRIBUTORS

@@ -346,6 +346,10 @@ Balanced gateway (July 2012)
 
 * Marshall Jones (mjallday)
 
+PayFast integration (October 2012)
+
+* Vasiliy Ermolovich (nashby)
+
 A1Agregator (November 2012)
 
 * Roman Ivanilov (england)
@@ -384,3 +388,7 @@ Paymill (February 2013)
 EVO Canada (February 2013)
 
 * Alex Dunae (alexdunae)
+
+Finansbank WebPOS (March 2013)
+
+* scamurcuoglu

data/README.md

@@ -100,6 +100,7 @@ The [ActiveMerchant Wiki](http://github.com/Shopify/active_merchant/wikis) conta
 * [E-xact](http://www.e-xact.com) - CA, US
 * [Fat Zebra](https://www.fatzebra.com.au) - AU
 * [Federated Canada](http://www.federatedcanada.com/) - CA
+* [Finansbank WebPOS](https://www.fbwebpos.com/) - US, TR
 * [FirstData Global Gateway e4](http://www.firstdata.com) - CA, US
 * [FirstPay](http://www.first-pay.com) - US
 * [Garanti Sanal POS](https://ccpos.garanti.com.tr/ccRaporlar/garanti/ccReports) - US, TR
@@ -130,6 +131,7 @@ The [ActiveMerchant Wiki](http://github.com/Shopify/active_merchant/wikis) conta
 * [Optimal Payments](http://www.optimalpayments.com/) - CA, US, UK
 * [Orbital Paymentech](http://chasepaymentech.com/) - CA, US, UK, GB
 * [PayBox Direct](http://www.paybox.com) - FR
+* [PayFast](https://www.payfast.co.za/) - ZA
 * [PayGate PayXML](http://paygate.co.za/) - US, ZA
 * [PayJunction](http://www.payjunction.com/) - US
 * [PaymentExpress](http://www.paymentexpress.com/) - AU, MY, NZ, SG, ZA, UK, US

data/lib/active_merchant/billing/credit_card.rb

@@ -229,7 +229,7 @@ module ActiveMerchant #:nodoc:
         end
 
         unless errors.on(:number) || errors.on(:brand)
-          errors.add :brand, "is not the correct card brand" unless CreditCard.matching_brand?(number, brand)
+          errors.add :brand, "does not match the card number" unless CreditCard.matching_brand?(number, brand)
         end
       end
 

data/lib/active_merchant/billing/gateways/authorize_net_cim.rb

@@ -338,7 +338,8 @@ module ActiveMerchant #:nodoc:
       # * <tt>:type</tt> -- The type of transaction. Can be either <tt>:auth_only</tt>, <tt>:capture_only</tt>, <tt>:auth_capture</tt>, <tt>:prior_auth_capture</tt>, <tt>:refund</tt> or <tt>:void</tt>. (REQUIRED)
       # * <tt>:amount</tt> -- The amount for the tranaction. Formatted with a decimal. For example "4.95" (CONDITIONAL)
       #     - :type == :void (NOT USED)
-      #     - :type == (:refund, :auth_only, :capture_only, :auth_capture, :prior_auth_capture) (REQUIRED)
+      #     - :type == :refund (OPTIONAL)
+      #     - :type == (:auth_only, :capture_only, :auth_capture, :prior_auth_capture) (REQUIRED)
       #
       # * <tt>:customer_profile_id</tt> -- The Customer Profile ID of the customer to use in this transaction. (CONDITIONAL)
       #     - :type == (:void, :prior_auth_capture) (OPTIONAL)

data/lib/active_merchant/billing/gateways/beanstream/beanstream_core.rb

@@ -239,6 +239,7 @@ module ActiveMerchant #:nodoc:
 
       def add_recurring_invoice(post, options)
         post[:rbApplyTax1] = options[:apply_tax1]
+        post[:rbApplyTax2] = options[:apply_tax2]
       end
 
       def add_recurring_operation_type(post, operation)

data/lib/active_merchant/billing/gateways/braintree_blue.rb

@@ -340,6 +340,7 @@ module ActiveMerchant #:nodoc:
           "bin"                 => transaction.credit_card_details.bin,
           "last_4"              => transaction.credit_card_details.last_4,
           "card_type"           => transaction.credit_card_details.card_type,
+          "token"               => transaction.credit_card_details.token
         }
 
         {

data/lib/active_merchant/billing/gateways/cc5.rb

@@ -0,0 +1,160 @@
+if RUBY_VERSION < '1.9' && $KCODE == "NONE"
+  $KCODE = 'u'
+end
+
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    # CC5 API is used by many banks in Turkey. Extend this base class to provide
+    # concrete implementations.
+    class CC5Gateway < Gateway
+      self.default_currency = 'TRY'
+
+      CURRENCY_CODES = {
+        'TRY' => 949,
+        'YTL' => 949,
+        'TRL' => 949,
+        'TL'  => 949,
+        'USD' => 840,
+        'EUR' => 978,
+        'GBP' => 826,
+        'JPY' => 392
+      }
+
+      def initialize(options = {})
+        requires!(options, :login, :password, :client_id)
+        super
+      end
+
+      def purchase(money, creditcard, options = {})
+        commit(build_sale_request('Auth', money, creditcard, options))
+      end
+
+      def authorize(money, creditcard, options = {})
+        commit(build_sale_request('PreAuth', money, creditcard, options))
+      end
+
+      def capture(money, authorization, options = {})
+        commit(build_capture_request(money, authorization, options))
+      end
+
+      protected
+
+      def build_sale_request(type, money, creditcard, options = {})
+        requires!(options,  :order_id)
+
+        xml = Builder::XmlMarkup.new :indent => 2
+
+        xml.tag! 'CC5Request' do
+          add_login_tags(xml)
+          xml.tag! 'OrderId', options[:order_id]
+          xml.tag! 'Type', type
+          xml.tag! 'Number', creditcard.number
+          xml.tag! 'Expires', [format(creditcard.month, :two_digits), format(creditcard.year, :two_digits)].join('/')
+          xml.tag! 'Cvv2Val', creditcard.verification_value
+          add_amount_tags(money, options, xml)
+          xml.tag! 'Email', options[:email] if options[:email]
+
+          if(address = (options[:billing_address] || options[:address]))
+            xml.tag! 'BillTo' do
+              add_address(xml, address)
+            end
+            xml.tag! 'ShipTo' do
+              add_address(xml, address)
+            end
+          end
+
+        end
+
+        xml.target!
+      end
+
+      def build_capture_request(money, authorization, options = {})
+        xml = Builder::XmlMarkup.new :indent => 2
+
+        xml.tag! 'CC5Request' do
+          add_login_tags(xml)
+          xml.tag! 'OrderId', authorization
+          xml.tag! 'Type', 'PostAuth'
+          add_amount_tags(money, options, xml)
+        end
+      end
+
+      def add_address(xml, address)
+        xml.tag! 'Name', normalize(address[:name])
+        xml.tag! 'Street1', normalize(address[:address1])
+        xml.tag! 'Street2', normalize(address[:address2]) if address[:address2]
+        xml.tag! 'City', normalize(address[:city])
+        xml.tag! 'PostalCode', address[:zip]
+        xml.tag! 'Country', normalize(address[:country])
+        xml.tag! 'Company', normalize(address[:company])
+        xml.tag! 'TelVoice', address[:phone].to_s.gsub(/[^0-9]/, '') if address[:phone]
+      end
+
+      def add_login_tags(xml)
+        xml.tag! 'Name', @options[:login]
+        xml.tag! 'Password', @options[:password]
+        xml.tag! 'ClientId', @options[:client_id]
+        xml.tag! 'Mode', (test? ? 'T' : 'P')
+      end
+
+      def add_amount_tags(money, options, xml)
+        xml.tag! 'Total', amount(money)
+        xml.tag! 'Currency', currency_code(options[:currency] || currency(money))
+      end
+
+      def currency_code(currency)
+        (CURRENCY_CODES[currency] || CURRENCY_CODES[default_currency])
+      end
+
+      def commit(request)
+        raw_response = ssl_post((test? ? self.test_url : self.live_url), "DATA=" + request)
+
+        response = parse(raw_response)
+
+        success = success?(response)
+
+        Response.new(
+          success,
+          (success ? 'Approved' : "Declined (Reason: #{response[:proc_return_code]} - #{response[:err_msg]})"),
+          response,
+          :test => test?,
+          :authorization => response[:order_id]
+        )
+      end
+
+      def parse(body)
+        xml = REXML::Document.new(body)
+
+        response = {}
+        xml.root.elements.to_a.each do |node|
+          parse_element(response, node)
+        end
+        response
+      end
+
+      def parse_element(response, node)
+        if node.has_elements?
+          node.elements.each{|element| parse_element(response, element) }
+        else
+          response[node.name.underscore.to_sym] = node.text
+        end
+      end
+
+      def success?(response)
+        (response[:response] == "Approved")
+      end
+
+      def normalize(text)
+        return unless text
+
+        if ActiveSupport::Inflector.method(:transliterate).arity == -2
+          ActiveSupport::Inflector.transliterate(text,'')
+        elsif RUBY_VERSION >= '1.9'
+          text.gsub(/[^\x00-\x7F]+/, '')
+        else
+          ActiveSupport::Inflector.transliterate(text).to_s
+        end
+      end
+    end
+  end
+end

data/lib/active_merchant/billing/gateways/cyber_source.rb

@@ -254,7 +254,7 @@ module ActiveMerchant #:nodoc:
       def build_purchase_request(money, payment_method_or_reference, options)
         xml = Builder::XmlMarkup.new :indent => 2
         add_payment_method_or_subscription(xml, money, payment_method_or_reference, options)
-        if card_brand(payment_method_or_reference) == 'check'
+        if !payment_method_or_reference.is_a?(String) && card_brand(payment_method_or_reference) == 'check'
           add_check_service(xml)
         else
           add_purchase_service(xml, options)

data/lib/active_merchant/billing/gateways/data_cash.rb

@@ -65,7 +65,7 @@ module ActiveMerchant
       #      See http://www.datacash.com/services/recurring/historic.php for more details of historic transactions.
       #   * <tt>:address</tt>:: billing address for card
       #
-      # The continuous authority reference will be available in response#params['ca_referece'] if you have requested one
+      # The continuous authority reference will be available in response#params['ca_reference'] if you have requested one
       def purchase(money, authorization_or_credit_card, options = {})
         requires!(options, :order_id)
 
@@ -93,7 +93,7 @@ module ActiveMerchant
       #      See http://www.datacash.com/services/recurring/historic.php for more details of historic transactions.
       #   * <tt>:address</tt>:: billing address for card
       #
-      # The continuous authority reference will be available in response#params['ca_referece'] if you have requested one
+      # The continuous authority reference will be available in response#params['ca_reference'] if you have requested one
       def authorize(money, authorization_or_credit_card, options = {})
         requires!(options, :order_id)
 
@@ -448,7 +448,7 @@ module ActiveMerchant
         end
       end
 
-      # Add credit_card detals to the passed XML Builder doc
+      # Add credit_card details to the passed XML Builder doc
       #
       # Parameters:
       #   -xml: Builder document that is being built up

data/lib/active_merchant/billing/gateways/finansbank.rb

@@ -0,0 +1,22 @@
+require File.dirname(__FILE__) + '/cc5'
+
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    class FinansbankGateway < CC5Gateway
+      self.live_url = self.test_url = 'https://www.fbwebpos.com/servlet/cc5ApiServer'
+
+      # The countries the gateway supports merchants from as 2 digit ISO country codes
+      self.supported_countries = ['US', 'TR']
+
+      # The card types supported by the payment gateway
+      self.supported_cardtypes = [:visa, :master]
+
+      # The homepage URL of the gateway
+      self.homepage_url = 'https://www.fbwebpos.com/'
+
+      # The name of the gateway
+      self.display_name = 'Finansbank WebPOS'
+    end
+  end
+end
+

data/lib/active_merchant/billing/gateways/iridium.rb

@@ -38,8 +38,14 @@ module ActiveMerchant #:nodoc:
         super
       end
 
-      def authorize(money, creditcard, options = {})
-        commit(build_purchase_request('PREAUTH', money, creditcard, options), options)
+      def authorize(money, payment_source, options = {})
+        setup_address_hash(options)
+
+        if payment_source.respond_to?(:number)
+          commit(build_purchase_request('PREAUTH', money, payment_source, options), options)
+        else
+          commit(build_reference_request('PREAUTH', money, payment_source, options), options)
+        end
       end
 
       def purchase(money, payment_source, options = {})