activemerchant 1.3.2 → 1.4.0

data/lib/active_merchant/billing/gateways/modern_payments.rb

@@ -0,0 +1,36 @@
+require File.dirname(__FILE__) + '/modern_payments_cim'
+
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    class ModernPaymentsGateway < Gateway
+      self.supported_countries = ModernPaymentsCimGateway.supported_countries
+      self.supported_cardtypes = ModernPaymentsCimGateway.supported_cardtypes
+      self.homepage_url = ModernPaymentsCimGateway.homepage_url
+      self.display_name = ModernPaymentsCimGateway.display_name
+      
+      def initialize(options = {})
+        requires!(options, :login, :password)
+        @options = options
+        super
+      end
+      
+      def purchase(money, credit_card, options = {})
+        customer_response = cim.create_customer(options)
+        return customer_response unless customer_response.success?
+        
+        customer_id = customer_response.params["create_customer_result"]
+        
+        card_response = cim.modify_customer_credit_card(customer_id, credit_card)
+        return card_response unless card_response.success?
+        
+        cim.authorize_credit_card_payment(customer_id, money)
+      end
+      
+      private
+      def cim
+        @cim ||= ModernPaymentsCimGateway.new(@options)
+      end
+    end
+  end
+end
+

data/lib/active_merchant/billing/gateways/modern_payments_cim.rb

@@ -0,0 +1,214 @@
+module ActiveMerchant #:nodoc:
+  module Billing #:nodoc:
+    class ModernPaymentsCimGateway < Gateway #:nodoc:
+      TEST_URL = "https://secure.modpay.com/netservices/test/ModpayTest.asmx"
+      LIVE_URL = 'https://secure.modpay.com/ws/modpay.asmx'
+      
+      LIVE_XMLNS = "http://secure.modpay.com:81/ws/"
+      TEST_XMLNS = "https://secure.modpay.com/netservices/test/"
+      
+      self.supported_countries = ['US']
+      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.homepage_url = 'http://www.modpay.com'
+      self.display_name = 'Modern Payments'
+      
+      SUCCESS_MESSAGE = "Transaction accepted"
+      FAILURE_MESSAGE = "Transaction failed"
+      ERROR_MESSAGE   = "Transaction error"
+      
+      PAYMENT_METHOD = {
+        :check => 1,
+        :credit_card => 2
+      }
+      
+      def initialize(options = {})
+        requires!(options, :login, :password)
+        @options = options
+        super
+      end  
+      
+      def create_customer(options = {})
+        post = {}
+        add_customer_data(post, options)
+        add_address(post, options)
+        
+        commit('CreateCustomer', post)
+      end
+      
+      def modify_customer_credit_card(customer_id, credit_card)
+        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        
+        post = {}
+        add_customer_id(post, customer_id)
+        add_credit_card(post, credit_card)
+        
+        commit('ModifyCustomerCreditCard', post)
+      end
+      
+      def authorize_credit_card_payment(customer_id, amount)
+        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        
+        post = {}
+        add_customer_id(post, customer_id)
+        add_amount(post, amount)
+        
+        commit('AuthorizeCreditCardPayment', post)
+      end
+      
+      def create_payment(customer_id, amount, options = {})
+        raise ArgumentError, "The customer_id cannot be blank" if customer_id.blank?
+        
+        post = {}
+        add_customer_id(post, customer_id)
+        add_amount(post, amount)
+        add_payment_details(post, options)
+        
+        commit('CreatePayment', post)
+      end
+
+      private
+      def add_payment_details(post, options)
+        post[:pmtDate] = (options[:payment_date] || Time.now.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
+        post[:pmtType] = PAYMENT_METHOD[options[:payment_method] || :credit_card]
+      end
+      
+      def add_amount(post, money)
+        post[:pmtAmount] = amount(money)
+      end
+      
+      def add_customer_id(post, customer_id)
+        post[:custId] = customer_id
+      end
+      
+      def add_customer_data(post, options)
+        post[:acctNum]   = options[:customer]
+      end
+      
+      def add_address(post, options)
+        address = options[:billing_address] || options[:address] || {}
+        
+        if name = address[:name]
+          segments = name.split(' ')
+          post[:lastName] = segments.pop
+          post[:firstName] = segments.join(' ')
+        else
+          post[:firstName] = address[:first_name]
+          post[:lastName]  = address[:last_name]
+        end
+        
+        post[:address]   = address[:address1]
+        post[:city]      = address[:city]
+        post[:state]     = address[:state]
+        post[:zip]       = address[:zip]
+        post[:phone]     = address[:phone]
+        post[:fax]       = address[:fax]
+        post[:email]     = address[:email]
+      end
+      
+      def add_credit_card(post, credit_card)
+        post[:ccName] = credit_card.name
+        post[:ccNum]  = credit_card.number
+        post[:expMonth] = credit_card.month
+        post[:expYear]  = credit_card.year
+      end
+                
+      def build_request(action, params)
+        xml = Builder::XmlMarkup.new :indent => 2
+        xml.instruct!
+        xml.tag! 'env:Envelope',
+          { 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',
+            'xmlns:env' => 'http://schemas.xmlsoap.org/soap/envelope/',
+            'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance' } do
+
+          xml.tag! 'env:Body' do
+            xml.tag! action, { "xmlns" => xmlns(action) } do
+              xml.tag! "clientId", @options[:login]
+              xml.tag! "clientCode", @options[:password]
+              params.each {|key, value| xml.tag! key, value }
+            end
+          end
+        end
+        xml.target!
+      end
+      
+      def xmlns(action)
+        if test? && action == 'AuthorizeCreditCardPayment'
+          TEST_XMLNS
+        else
+          LIVE_XMLNS
+        end
+      end
+      
+      def url(action)
+        if test? && action == 'AuthorizeCreditCardPayment'
+          TEST_URL
+        else
+          LIVE_URL
+        end
+      end
+      
+      def commit(action, params)
+        data = ssl_post(url(action), build_request(action, params), 
+                 { 'Content-Type' =>'text/xml; charset=utf-8', 
+                   'SOAPAction' => "#{xmlns(action)}#{action}" }
+                )
+
+        response = parse(action, data)
+        Response.new(successful?(action, response), message_from(action, response), response, 
+          :test => test?, 
+          :authorization => authorization_from(action, response),
+          :avs_result => { :code => response[:avs_code] }
+        )
+      end
+      
+      def authorization_from(action, response)
+        response[result_key(action)]
+      end
+      
+      def result_key(action)
+        action == "AuthorizeCreditCardPayment" ? :trans_id : "#{action.underscore}_result".to_sym
+      end
+      
+      def successful?(action, response)
+        response[result_key(action)].to_i > 0
+      end
+      
+      def message_from(action, response)
+        if response[:faultcode]
+          ERROR_MESSAGE
+        elsif successful?(action, response)
+          SUCCESS_MESSAGE
+        else
+          FAILURE_MESSAGE
+        end
+      end
+      
+      def parse(action, xml)
+        response = {}
+        response[:action] = action
+        
+        xml = REXML::Document.new(xml)
+        if root = REXML::XPath.first(xml, "//#{action}Response")
+          root.elements.to_a.each do |node|
+            parse_element(response, node)
+          end
+        elsif root = REXML::XPath.first(xml, "//soap:Fault")
+          root.elements.to_a.each do |node|
+            response[node.name.underscore.to_sym] = node.text
+          end
+        end
+
+        response
+      end
+      
+      def parse_element(response, node)
+        if node.has_elements?
+          node.elements.each{|e| parse_element(response, e) }
+        else
+          response[node.name.underscore.to_sym] = node.text
+        end
+      end
+    end
+  end
+end
+

data/lib/active_merchant/billing/gateways/net_registry.rb

@@ -72,6 +72,7 @@ module ActiveMerchant
       # described in "Programming for NetRegistry's E-commerce
       # Gateway." [http://rubyurl.com/hNG]
       def capture(money, authorization, options = {})
+        requires!(options, :credit_card)
         credit_card = options[:credit_card]
 
         params = {

data/lib/active_merchant/billing/gateways/payflow/payflow_common_api.rb

@@ -28,8 +28,8 @@ module ActiveMerchant #:nodoc:
       end
       
       XMLNS = 'http://www.paypal.com/XMLPay'
-      TEST_URL = 'https://pilot-payflowpro.verisign.com'
-      LIVE_URL = 'https://payflowpro.verisign.com'
+      TEST_URL = 'https://pilot-payflowpro.paypal.com'
+      LIVE_URL = 'https://payflowpro.paypal.com'
       
       CARD_MAPPING = {
         :visa => 'Visa',

data/lib/active_merchant/billing/gateways/payflow_express.rb

@@ -1,25 +1,17 @@
 require File.dirname(__FILE__) + '/payflow/payflow_common_api'
 require File.dirname(__FILE__) + '/payflow/payflow_express_response'
+require File.dirname(__FILE__) + '/paypal_express_common'
 
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class PayflowExpressGateway < Gateway 
       include PayflowCommonAPI
+      include PaypalExpressCommon
       
-      LIVE_REDIRECT_URL = 'https://www.paypal.com/cgibin/webscr?cmd=_express-checkout&token='
-      TEST_REDIRECT_URL = 'https://test-expresscheckout.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token='
-      
+      self.test_redirect_url = 'https://test-expresscheckout.paypal.com/cgi-bin/webscr?cmd=_express-checkout&token='      
       self.homepage_url = 'https://www.paypal.com/cgi-bin/webscr?cmd=xpt/merchant/ExpressCheckoutIntro-outside'
       self.display_name = 'PayPal Express Checkout'
       
-      def redirect_url
-        test? ? TEST_REDIRECT_URL : LIVE_REDIRECT_URL
-      end
-      
-      def redirect_url_for(token)
-        "#{redirect_url}#{token}"
-      end
-      
       def authorize(money, options = {})
         requires!(options, :token, :payer_id)
         request = build_sale_or_authorization_request('Authorization', money, options)

data/lib/active_merchant/billing/gateways/payment_express.rb

@@ -21,7 +21,7 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://www.paymentexpress.com/'
       self.display_name = 'PaymentExpress'
       
-      PAYMENT_URL = 'https://www.paymentexpress.com/pxpost.aspx'
+      URL = 'https://www.paymentexpress.com/pxpost.aspx'
       
       APPROVED = '1'
       
@@ -196,7 +196,7 @@ module ActiveMerchant #:nodoc:
         add_transaction_type(request, action)
         
         # Parse the XML response
-        response = parse( ssl_post(PAYMENT_URL, request.to_s) )
+        response = parse( ssl_post(URL, request.to_s) )
         
         # Return a response
         PaymentExpressResponse.new(response[:success] == APPROVED, response[:response_text], response,

data/lib/active_merchant/billing/gateways/paypal/paypal_common_api.rb

@@ -8,7 +8,7 @@ module ActiveMerchant #:nodoc:
         base.cattr_accessor :signature
       end
       
-      API_VERSION = '2.0'
+      API_VERSION = '52.0'
       
       URLS = {
         :test => { :certificate => 'https://api.sandbox.paypal.com/2.0/',
@@ -42,6 +42,8 @@ module ActiveMerchant #:nodoc:
       
       SUCCESS_CODES = [ 'Success', 'SuccessWithWarning' ]
       
+      FRAUD_REVIEW_CODE = "11610"
+      
       # The gateway must be configured with either your PayPal PEM file
       # or your PayPal API Signature.  Only one is required.
       #
@@ -109,7 +111,7 @@ module ActiveMerchant #:nodoc:
 
       private
       def build_reauthorize_request(money, authorization, options)
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
         
         xml.tag! 'DoReauthorizationReq', 'xmlns' => PAYPAL_NAMESPACE do
           xml.tag! 'DoReauthorizationRequest', 'xmlns:n2' => EBAY_NAMESPACE do
@@ -123,7 +125,7 @@ module ActiveMerchant #:nodoc:
       end
           
       def build_capture_request(money, authorization, options)   
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
         
         xml.tag! 'DoCaptureReq', 'xmlns' => PAYPAL_NAMESPACE do
           xml.tag! 'DoCaptureRequest', 'xmlns:n2' => EBAY_NAMESPACE do
@@ -139,7 +141,7 @@ module ActiveMerchant #:nodoc:
       end
       
       def build_credit_request(money, identification, options)
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
             
         xml.tag! 'RefundTransactionReq', 'xmlns' => PAYPAL_NAMESPACE do
           xml.tag! 'RefundTransactionRequest', 'xmlns:n2' => EBAY_NAMESPACE do
@@ -155,7 +157,7 @@ module ActiveMerchant #:nodoc:
       end
       
       def build_void_request(authorization, options)
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
         
         xml.tag! 'DoVoidReq', 'xmlns' => PAYPAL_NAMESPACE do
           xml.tag! 'DoVoidRequest', 'xmlns:n2' => EBAY_NAMESPACE do
@@ -172,7 +174,7 @@ module ActiveMerchant #:nodoc:
         default_options = args.last.is_a?(Hash) ? args.pop : {}
         recipients = args.first.is_a?(Array) ? args : [args]
         
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
         
         xml.tag! 'MassPayReq', 'xmlns' => PAYPAL_NAMESPACE do
           xml.tag! 'MassPayRequest', 'xmlns:n2' => EBAY_NAMESPACE do
@@ -192,19 +194,41 @@ module ActiveMerchant #:nodoc:
         
         xml.target!
       end
-      
+
       def parse(action, xml)
         response = {}
+        
+        error_messages = []
+        error_codes = []
+        
         xml = REXML::Document.new(xml)
         if root = REXML::XPath.first(xml, "//#{action}Response")
-          root.elements.to_a.each do |node|
+          root.elements.each do |node|            
             case node.name
             when 'Errors'
-              response[:message] = node.elements.to_a('//LongMessage').collect{|error| error.text}.join('.')
+              short_message = nil
+              long_message = nil
+              
+              node.elements.each do |child|
+                case child.name
+                when "LongMessage"
+                  long_message = child.text unless child.text.blank?
+                when "ShortMessage"
+                  short_message = child.text unless child.text.blank?
+                when "ErrorCode"
+                  error_codes << child.text unless child.text.blank?
+                end
+              end
+
+              if message = long_message || short_message
+                error_messages << message
+              end
             else
               parse_element(response, node)
             end
           end
+          response[:message] = error_messages.uniq.join(". ") unless error_messages.empty?
+          response[:error_codes] = error_codes.uniq.join(",") unless error_codes.empty?
         elsif root = REXML::XPath.first(xml, "//SOAP-ENV:Fault")
           parse_element(response, root)
           response[:message] = "#{response[:faultcode]}: #{response[:faultstring]} - #{response[:detail]}"
@@ -224,19 +248,8 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def response_type_for(action)
-        case action
-        when 'Authorization', 'Purchase'
-          'DoDirectPaymentResponse'
-        when 'Void'
-          'DoVoidResponse'
-        when 'Capture'
-          'DoCaptureResponse'
-        end
-      end
-
       def build_request(body)
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new
         
         xml.instruct!
         xml.tag! 'env:Envelope', ENVELOPE_NAMESPACES do
@@ -286,11 +299,16 @@ module ActiveMerchant #:nodoc:
         build_response(successful?(response), message_from(response), response,
     	    :test => test?,
     	    :authorization => authorization_from(response),
+    	    :fraud_review => fraud_review?(response),
     	    :avs_result => { :code => response[:avs_code] },
     	    :cvv_result => response[:cvv2_code]
         )
       end
       
+      def fraud_review?(response)
+        response[:error_codes] == FRAUD_REVIEW_CODE
+      end
+      
       def authorization_from(response)
         response[:transaction_id] || response[:authorization_id] # latter one is from reauthorization
       end