activemerchant 1.26.0 → 1.27.0

data/lib/active_merchant/billing/gateways/iridium.rb

@@ -7,7 +7,8 @@ module ActiveMerchant #:nodoc:
     # login to the Iridium Merchant Management System. Instead, you will 
     # use the API username and password you were issued separately.
     class IridiumGateway < Gateway
-      
+      self.live_url = self.test_url = 'https://gw1.iridiumcorp.net/'      
+
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['GB', 'ES']
       self.default_currency = 'EUR'
@@ -35,8 +36,6 @@ module ActiveMerchant #:nodoc:
       def initialize(options = {})
         requires!(options, :login, :password)
         @options = options
-        @test_url = 'https://gw1.iridiumcorp.net/'
-        @live_url = 'https://gw1.iridiumcorp.net/'
         super
       end  
       
@@ -172,7 +171,7 @@ module ActiveMerchant #:nodoc:
 
       def commit(request, options)
         requires!(options, :action)
-        response = parse(ssl_post(test? ? @test_url : @live_url, request,
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, request,
                               {"SOAPAction" => "https://www.thepaymentgateway.net/#{options[:action]}",
                                "Content-Type" => "text/xml; charset=utf-8" }))
   
@@ -255,4 +254,4 @@ module ActiveMerchant #:nodoc:
       end
     end
   end
-end
+end

data/lib/active_merchant/billing/gateways/itransact.rb

@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
     # 1. TransactionStatus is not implemented
     #
     class ItransactGateway < Gateway
-      URL = 'https://secure.paymentclearing.com/cgi-bin/rc/xmltrans2.cgi'
+      self.live_url = self.test_url = 'https://secure.paymentclearing.com/cgi-bin/rc/xmltrans2.cgi'
 
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US']
@@ -386,7 +386,7 @@ module ActiveMerchant #:nodoc:
       def commit(payload)
         # Set the Content-Type header -- otherwise the URL decoding messes up
         # the Base64 encoded payload signature!
-        response = parse(ssl_post(URL, post_data(payload), 'Content-Type' => 'text/xml'))
+        response = parse(ssl_post(self.live_url, post_data(payload), 'Content-Type' => 'text/xml'))
 
         Response.new(successful?(response), response[:error_message], response,
           :test => test?,

data/lib/active_merchant/billing/gateways/jetpay.rb

@@ -1,8 +1,8 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class JetpayGateway < Gateway
-      TEST_URL = 'https://test1.jetpay.com/jetpay'
-      LIVE_URL = 'https://gateway17.jetpay.com/jetpay'
+      self.test_url = 'https://test1.jetpay.com/jetpay'
+      self.live_url = 'https://gateway17.jetpay.com/jetpay'
       
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US']
@@ -167,7 +167,7 @@ module ActiveMerchant #:nodoc:
       end
       
       def commit(money, request)
-        response = parse(ssl_post(test? ? TEST_URL : LIVE_URL, request))
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, request))
         
         success = success?(response)
         Response.new(success, 

data/lib/active_merchant/billing/gateways/linkpoint.rb

@@ -127,11 +127,8 @@ module ActiveMerchant #:nodoc:
       # 
       cattr_accessor :pem_file
       
-      TEST_URL  = 'https://staging.linkpt.net:1129/'
-      LIVE_URL  = 'https://secure.linkpt.net:1129/'
-      
-      # We don't have the certificate to verify LinkPoint
-      self.ssl_strict = false
+      self.test_url  = 'https://staging.linkpt.net:1129/'
+      self.live_url  = 'https://secure.linkpt.net:1129/'
       
       self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
@@ -253,7 +250,7 @@ module ActiveMerchant #:nodoc:
       private
       # Commit the transaction by posting the XML file to the LinkPoint server
       def commit(money, creditcard, options = {})
-        response = parse(ssl_post(test? ? TEST_URL : LIVE_URL, post_data(money, creditcard, options)))
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, post_data(money, creditcard, options)))
         
         Response.new(successful?(response), response[:message], response, 
           :test => test?,

data/lib/active_merchant/billing/gateways/litle.rb

@@ -1,5 +1,3 @@
-require 'LitleOnline'
-
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class LitleGateway < Gateway
@@ -36,8 +34,10 @@ module ActiveMerchant #:nodoc:
       # * <tt>:zip</tt> - The zip or postal code of the customer.
       # * <tt>:phone</tt> - The phone number of the customer.
 
-      TEST_URL = 'https://www.testlitle.com/sandbox/communicator/online'
-      LIVE_URL = 'https://payments.litle.com/vap/communicator/online'
+      self.test_url = 'https://www.testlitle.com/sandbox/communicator/online'
+      self.live_url = 'https://payments.litle.com/vap/communicator/online'
+
+      LITLE_SCHEMA_VERSION = '8.10'
 
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['US']
@@ -54,8 +54,20 @@ module ActiveMerchant #:nodoc:
       self.default_currency = 'USD'
 
       def initialize(options = {})
+        begin
+          require 'LitleOnline'
+        rescue LoadError
+          raise "Could not load the LitleOnline gem (>= 08.13.2).  Use `gem install LitleOnline` to install it."
+        end
+
         @litle = LitleOnline::LitleOnlineRequest.new
-        requires!(options, :merchant_id, :user, :password, :version, :url)
+
+        options[:version]  ||= LITLE_SCHEMA_VERSION
+        options[:merchant] ||= 'Default Report Group'
+        options[:user]     ||= options[:login]
+
+        requires!(options, :merchant_id, :user, :password, :merchant, :version)
+
         @options = options
       end
 
@@ -118,19 +130,28 @@ module ActiveMerchant #:nodoc:
         '40' => 'E'
       }
 
+      def url
+        return @options[:url] if @options[:url].present?
+
+        test? ? self.test_url : self.live_url
+      end
+
       def build_response(kind, litle_response, valid_responses=%w(000))
-        if litle_response.response == "0"
-          detail = litle_response.send("#{kind}Response")
+        response = Hash.from_xml(litle_response.raw_xml.to_s)['litleOnlineResponse']
+
+        if response['response'] == "0"
+          detail = response["#{kind}Response"]
+          fraud = fraud_result(detail)
           Response.new(
-            (valid_responses.include?(detail.response)),
-            detail.message,
-            {:litleOnlineResponse => litle_response},
-            :authorization => detail.litleTxnId,
-            :avs_result => {:code => fraud_result(detail)['avs']},
-            :cvv_result => fraud_result(detail)['cvv']
+            valid_responses.include?(detail['response']),
+            detail['message'],
+            {:litleOnlineResponse => response},
+            :authorization => detail['litleTxnId'],
+            :avs_result => {:code => fraud['avs']},
+            :cvv_result => fraud['cvv']
           )
         else
-          Response.new(false, litle_response.message, :litleOnlineResponse => litle_response)
+          Response.new(false, response['message'], :litleOnlineResponse => response)
         end
       end
 
@@ -232,20 +253,20 @@ module ActiveMerchant #:nodoc:
         hash = {
           'billToAddress' => bill_to_address,
           'shipToAddress' => ship_to_address,
-          'orderId' => (options[:order_id] or @options[:order_id]),
+          'orderId' => (options[:order_id] || @options[:order_id]),
           'customerId' => options[:customer],
-          'reportGroup' => (options[:merchant] or @options[:merchant]),
-          'merchantId' => (options[:merchant_id] or @options[:merchant_id]),
+          'reportGroup' => (options[:merchant] || @options[:merchant]),
+          'merchantId' => (options[:merchant_id] || @options[:merchant_id]),
           'orderSource' => 'ecommerce',
           'enhancedData' => enhanced_data,
           'fraudCheckType' => fraud_check_type,
-          'user' => (options[:user] or @options[:user]),
-          'password' => (options[:password] or @options[:password]),
-          'version' => (options[:version] or @options[:version]),
-          'url' => (options[:url] or @options[:url]),
-          'proxy_addr' => (options[:proxy_addr] or @options[:proxy_addr]),
-          'proxy_port' => (options[:proxy_port] or @options[:proxy_port]),
-          'id' => (options[:id] or options[:order_id] or @options[:order_id])
+          'user' => (options[:user] || @options[:user]),
+          'password' => (options[:password] || @options[:password]),
+          'version' => (options[:version] || @options[:version]),
+          'url' => (options[:url] || url),
+          'proxy_addr' => (options[:proxy_addr] || @options[:proxy_addr]),
+          'proxy_port' => (options[:proxy_port] || @options[:proxy_port]),
+          'id' => (options[:id] || options[:order_id] || @options[:order_id])
         }
 
         if( !money.nil? && money.to_s.length > 0 )
@@ -255,17 +276,12 @@ module ActiveMerchant #:nodoc:
       end
 
       def fraud_result(authorization_response)
-        if authorization_response.respond_to?(:fraudResult)
-          fraud_result = authorization_response.fraudResult
-          if fraud_result.respond_to?(:cardValidationResult)
-            cvv_to_pass = fraud_result.cardValidationResult
-            if(cvv_to_pass == "")
-              cvv_to_pass = "P"
-            end
-          end
-          if fraud_result.respond_to?(:avsResult)
-            avs_to_pass = AVS_RESPONSE_CODE[fraud_result.avsResult]
+        if result = authorization_response['fraudResult']
+          if result.key?('cardValidationResult')
+            cvv_to_pass = result['cardValidationResult'].blank? ? "P" : result['cardValidationResult']
           end
+
+          avs_to_pass = AVS_RESPONSE_CODE[result['avsResult']] unless result['avsResult'].blank?
         end
         {'cvv'=>cvv_to_pass, 'avs'=>avs_to_pass}
       end

data/lib/active_merchant/billing/gateways/merchant_e_solutions.rb

@@ -2,8 +2,8 @@ module ActiveMerchant #:nodoc:
 	module Billing #:nodoc:
 		class MerchantESolutionsGateway < Gateway
 
-			TEST_URL = 'https://cert.merchante-solutions.com/mes-api/tridentApi'
-			LIVE_URL = 'https://api.merchante-solutions.com/mes-api/tridentApi'
+			self.test_url = 'https://cert.merchante-solutions.com/mes-api/tridentApi'
+			self.live_url = 'https://api.merchante-solutions.com/mes-api/tridentApi'
       
 			# The countries the gateway supports merchants from as 2 digit ISO country codes
 			self.supported_countries = ['US']
@@ -114,7 +114,7 @@ module ActiveMerchant #:nodoc:
       
 			def commit(action, money, parameters)
 	  
-				url = test? ? TEST_URL : LIVE_URL
+				url = test? ? self.test_url : self.live_url
 				parameters[:transaction_amount]  = amount(money) if money unless action == 'V'
 		
 				response = parse( ssl_post(url, post_data(action,parameters)) )

data/lib/active_merchant/billing/gateways/merchant_ware.rb

@@ -1,7 +1,7 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class MerchantWareGateway < Gateway
-      URL = 'https://ps1.merchantware.net/MerchantWARE/ws/RetailTransaction/TXRetail.asmx'
+      self.live_url = self.test_url = 'https://ps1.merchantware.net/MerchantWARE/ws/RetailTransaction/TXRetail.asmx'
       
       self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :discover]
@@ -261,7 +261,7 @@ module ActiveMerchant #:nodoc:
             
       def commit(action, request)
         begin
-          data = ssl_post(URL, request, 
+          data = ssl_post(self.live_url, request, 
                    "Content-Type" => 'text/xml; charset=utf-8',
                    "SOAPAction"   => "http://merchantwarehouse.com/MerchantWARE/Client/TransactionRetail/#{ACTIONS[action]}"
                  )

data/lib/active_merchant/billing/gateways/migs.rb

@@ -9,8 +9,12 @@ module ActiveMerchant #:nodoc:
 
       API_VERSION = 1
 
-      SERVER_HOSTED_URL = 'https://migs.mastercard.com.au/vpcpay'
-      MERCHANT_HOSTED_URL = 'https://migs.mastercard.com.au/vpcdps'
+      class_attribute :server_hosted_url, :merchant_hosted_url
+
+      self.server_hosted_url = 'https://migs.mastercard.com.au/vpcpay'
+      self.merchant_hosted_url = 'https://migs.mastercard.com.au/vpcdps'
+
+      self.live_url = self.server_hosted_url
 
       # MiGS is supported throughout Asia Pacific, Middle East and Africa
       # MiGS is used in Australia (AU) by ANZ (eGate), CBA (CommWeb) and more
@@ -154,7 +158,7 @@ module ActiveMerchant #:nodoc:
 
         add_secure_hash(post)
 
-        SERVER_HOSTED_URL + '?' + post_data(post)
+        self.server_hosted_url + '?' + post_data(post)
       end
 
       # Parses a response from purchase_offsite_url once user is redirected back
@@ -208,7 +212,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(post)
-        data = ssl_post MERCHANT_HOSTED_URL, post_data(post)
+        data = ssl_post self.merchant_hosted_url, post_data(post)
         response_hash = parse(data)
         response_object(response_hash)
       end

data/lib/active_merchant/billing/gateways/modern_payments.rb

@@ -8,6 +8,8 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = ModernPaymentsCimGateway.homepage_url
       self.display_name = ModernPaymentsCimGateway.display_name
       
+      self.abstract_class = true
+
       def initialize(options = {})
         requires!(options, :login, :password)
         @options = options

data/lib/active_merchant/billing/gateways/modern_payments_cim.rb

@@ -1,8 +1,8 @@
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class ModernPaymentsCimGateway < Gateway #:nodoc:
-      TEST_URL = "https://secure.modpay.com/netservices/test/ModpayTest.asmx"
-      LIVE_URL = 'https://secure.modpay.com/ws/modpay.asmx'
+      self.test_url = "https://secure.modpay.com/netservices/test/ModpayTest.asmx"
+      self.live_url = 'https://secure.modpay.com/ws/modpay.asmx'
       
       LIVE_XMLNS = "https://secure.modpay.com/ws/"
       TEST_XMLNS = "https://secure.modpay.com/netservices/test/"
@@ -141,9 +141,9 @@ module ActiveMerchant #:nodoc:
       
       def url(action)
         if test? && action == 'AuthorizeCreditCardPayment'
-          TEST_URL
+          self.test_url
         else
-          LIVE_URL
+          self.live_url
         end
       end
       

data/lib/active_merchant/billing/gateways/moneris.rb

@@ -10,8 +10,8 @@ module ActiveMerchant #:nodoc:
     # Response Values", available at Moneris' {eSelect Plus Documentation 
     # Centre}[https://www3.moneris.com/connect/en/documents/index.html].
     class MonerisGateway < Gateway
-      TEST_URL = 'https://esqa.moneris.com/gateway2/servlet/MpgRequest'
-      LIVE_URL = 'https://www3.moneris.com/gateway2/servlet/MpgRequest'
+      self.test_url = 'https://esqa.moneris.com/gateway2/servlet/MpgRequest'
+      self.live_url = 'https://www3.moneris.com/gateway2/servlet/MpgRequest'
       
       self.supported_countries = ['CA']
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover]
@@ -157,7 +157,7 @@ module ActiveMerchant #:nodoc:
       end
   
       def commit(action, parameters = {})
-        response = parse(ssl_post(test? ? TEST_URL : LIVE_URL, post_data(action, parameters)))
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, post_data(action, parameters)))
 
         Response.new(successful?(response), message_from(response[:message]), response,
           :test          => test?,

data/lib/active_merchant/billing/gateways/moneris_us.rb

@@ -10,8 +10,8 @@ module ActiveMerchant #:nodoc:
     # Response Values", available at Moneris' {eSelect Plus Documentation 
     # Centre}[https://www3.moneris.com/connect/en/documents/index.html].
     class MonerisUsGateway < Gateway
-      TEST_URL = 'https://esplusqa.moneris.com/gateway_us/servlet/MpgRequest'
-      LIVE_URL = 'https://esplus.moneris.com/gateway_us/servlet/MpgRequest'
+      self.test_url = 'https://esplusqa.moneris.com/gateway_us/servlet/MpgRequest'
+      self.live_url = 'https://esplus.moneris.com/gateway_us/servlet/MpgRequest'
       
       self.supported_countries = ['US']
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover]
@@ -125,7 +125,7 @@ module ActiveMerchant #:nodoc:
       end
   
       def commit(action, parameters = {})
-        response = parse(ssl_post(test? ? TEST_URL : LIVE_URL, post_data(action, parameters)))
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, post_data(action, parameters)))
 
         Response.new(successful?(response), message_from(response[:message]), response,
           :test          => test?,

data/lib/active_merchant/billing/gateways/nab_transact.rb

@@ -8,10 +8,12 @@ module ActiveMerchant #:nodoc:
       API_VERSION = 'xml-4.2'
       PERIODIC_API_VERSION = "spxml-4.2"
 
-      TEST_URL = 'https://transact.nab.com.au/test/xmlapi/payment'
-      LIVE_URL = 'https://transact.nab.com.au/live/xmlapi/payment'
-      TEST_PERIODIC_URL = "https://transact.nab.com.au/xmlapidemo/periodic"
-      LIVE_PERIODIC_URL = "https://transact.nab.com.au/xmlapi/periodic"
+      class_attribute :test_periodic_url, :live_periodic_url
+
+      self.test_url = 'https://transact.nab.com.au/test/xmlapi/payment'
+      self.live_url = 'https://transact.nab.com.au/live/xmlapi/payment'
+      self.test_periodic_url = 'https://transact.nab.com.au/xmlapidemo/periodic'
+      self.live_periodic_url = 'https://transact.nab.com.au/xmlapi/periodic'
 
       self.supported_countries = ['AU']
 
@@ -192,7 +194,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit(action, request)
-        response = parse(ssl_post(test? ? TEST_URL : LIVE_URL, build_request(action, request)))
+        response = parse(ssl_post(test? ? self.test_url : self.live_url, build_request(action, request)))
 
         Response.new(success?(response), message_from(response), response,
           :test => test?,
@@ -201,7 +203,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def commit_periodic(request)
-        response = parse(ssl_post(test? ? TEST_PERIODIC_URL : LIVE_PERIODIC_URL, build_periodic_request(request)))
+        response = parse(ssl_post(test? ? self.test_periodic_url : self.live_periodic_url, build_periodic_request(request)))
         Response.new(success?(response), message_from(response), response,
           :test => test?,
           :authorization => authorization_from(response)

data/lib/active_merchant/billing/gateways/net_registry.rb

@@ -22,7 +22,7 @@ module ActiveMerchant
     # response will contain a 'receipt' parameter
     # (response.params['receipt']) if a receipt was issued by the gateway.
     class NetRegistryGateway < Gateway
-      URL = 'https://4tknox.au.com/cgi-bin/themerchant.au.com/ecom/external2.pl'
+      self.live_url = self.test_url = 'https://4tknox.au.com/cgi-bin/themerchant.au.com/ecom/external2.pl'
       
       FILTERED_PARAMS = [ 'card_no', 'card_expiry', 'receipt_array' ]
       
@@ -137,7 +137,7 @@ module ActiveMerchant
       # omitted if nil.
       def commit(action, params)
         # get gateway response
-        response = parse( ssl_post(URL, post_data(action, params)) )
+        response = parse( ssl_post(self.live_url, post_data(action, params)) )
         
         Response.new(response['status'] == 'approved', message_from(response), response,          
           :authorization => authorization_from(response, action)

data/lib/active_merchant/billing/gateways/netaxept.rb

@@ -3,8 +3,8 @@ require 'digest/md5'
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     class NetaxeptGateway < Gateway
-      TEST_URL = 'https://epayment-test.bbs.no/'
-      LIVE_URL = 'https://epayment.bbs.no/'
+      self.test_url = 'https://epayment-test.bbs.no/'
+      self.live_url = 'https://epayment.bbs.no/'
       
       # The countries the gateway supports merchants from as 2 digit ISO country codes
       self.supported_countries = ['NO', 'DK', 'SE', 'FI']
@@ -199,7 +199,7 @@ module ActiveMerchant #:nodoc:
       end
       
       def url
-        (test? ? TEST_URL : LIVE_URL)
+        (test? ? self.test_url : self.live_url)
       end
       
       def generate_transaction_id(options)
@@ -211,7 +211,7 @@ module ActiveMerchant #:nodoc:
       end
       
       def build_url(base, parameters=nil)
-        url = "#{test? ? TEST_URL : LIVE_URL}"
+        url = "#{test? ? self.test_url : self.live_url}"
         url << base
         if parameters
           url << '?'