activemerchant 1.113.0 → 1.119.0

data/lib/active_merchant/billing/gateways/jetpay.rb

@@ -290,8 +290,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: authorization_from(response, money, token),
           avs_result: { code: response[:avs] },
-          cvv_result: response[:cvv2]
-        )
+          cvv_result: response[:cvv2])
       end
 
       def url

data/lib/active_merchant/billing/gateways/jetpay_v2.rb

@@ -210,8 +210,8 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'TransactionID', transaction_id.nil? ? generate_unique_id.slice(0, 18) : transaction_id
           xml.tag! 'Origin', options[:origin] || 'INTERNET'
           xml.tag! 'IndustryInfo', 'Type' => options[:industry_info] || 'ECOMMERCE'
-          xml.tag! 'Application', (options[:application] || 'n/a'), {'Version' => options[:application_version] || '1.0'}
-          xml.tag! 'Device', (options[:device] || 'n/a'), {'Version' => options[:device_version] || '1.0'}
+          xml.tag! 'Application', (options[:application] || 'n/a'), { 'Version' => options[:application_version] || '1.0' }
+          xml.tag! 'Device', (options[:device] || 'n/a'), { 'Version' => options[:device_version] || '1.0' }
           xml.tag! 'Library', 'VirtPOS SDK', 'Version' => '1.5'
           xml.tag! 'Gateway', 'JetPay'
           xml.tag! 'DeveloperID', options[:developer_id] || 'n/a'
@@ -302,8 +302,7 @@ module ActiveMerchant #:nodoc:
           authorization: authorization_from(response, money, token),
           avs_result: AVSResult.new(code: response[:avs]),
           cvv_result: CVVResult.new(response[:cvv2]),
-          error_code: success ? nil : error_code_from(response)
-        )
+          error_code: success ? nil : error_code_from(response))
       end
 
       def url
@@ -406,7 +405,7 @@ module ActiveMerchant #:nodoc:
       def add_invoice_data(xml, options)
         xml.tag! 'OrderNumber', options[:order_id] if options[:order_id]
         if tax_amount = options[:tax_amount]
-          xml.tag! 'TaxAmount', tax_amount, {'ExemptInd' => options[:tax_exempt] || 'false'}
+          xml.tag! 'TaxAmount', tax_amount, { 'ExemptInd' => options[:tax_exempt] || 'false' }
         end
       end
 

data/lib/active_merchant/billing/gateways/kushki.rb

@@ -12,26 +12,26 @@ module ActiveMerchant #:nodoc:
       self.money_format = :dollars
       self.supported_cardtypes = %i[visa master american_express discover diners_club alia]
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :public_merchant_id, :private_merchant_id)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         MultiResponse.run() do |r|
           r.process { tokenize(amount, payment_method, options) }
           r.process { charge(amount, r.authorization, options) }
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         MultiResponse.run() do |r|
           r.process { tokenize(amount, payment_method, options) }
           r.process { preauthorize(amount, r.authorization, options) }
         end
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         action = 'capture'
 
         post = {}
@@ -41,7 +41,7 @@ module ActiveMerchant #:nodoc:
         commit(action, post)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         action = 'refund'
 
         post = {}
@@ -50,7 +50,7 @@ module ActiveMerchant #:nodoc:
         commit(action, post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         action = 'void'
 
         post = {}

data/lib/active_merchant/billing/gateways/latitude19.rb

@@ -51,12 +51,12 @@ module ActiveMerchant #:nodoc:
         'jcb' => 'JC'
       }
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :account_number, :configuration_id, :secret)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           auth_or_sale('sale', payment_method, amount, nil, options)
         else
@@ -68,7 +68,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           auth_or_sale('auth', payment_method, amount, nil, options)
         else
@@ -80,7 +80,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         post = {}
         post[:method] = 'deposit'
         add_request_id(post)
@@ -96,7 +96,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         method, pgwTID = split_authorization(authorization)
         case method
         when 'auth'
@@ -109,7 +109,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def credit(amount, payment_method, options={})
+      def credit(amount, payment_method, options = {})
         if payment_method.is_a?(String)
           refundWithCard(payment_method, amount, nil, options)
         else
@@ -121,7 +121,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def verify(payment_method, options={}, action=nil)
+      def verify(payment_method, options = {}, action = nil)
         if payment_method.is_a?(String)
           verifyOnly(action, payment_method, nil, options)
         else
@@ -133,7 +133,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def store(payment_method, options={})
+      def store(payment_method, options = {})
         verify(payment_method, options, 'store')
       end
 
@@ -201,7 +201,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def get_session(options={})
+      def get_session(options = {})
         post = {}
         post[:method] = 'getSession'
         add_request_id(post)
@@ -213,7 +213,7 @@ module ActiveMerchant #:nodoc:
         commit('session', post)
       end
 
-      def get_token(authorization, payment_method, options={})
+      def get_token(authorization, payment_method, options = {})
         post = {}
         post[:method] = 'tokenize'
         add_request_id(post)
@@ -226,7 +226,7 @@ module ActiveMerchant #:nodoc:
         commit('token', post)
       end
 
-      def auth_or_sale(method, authorization, amount, credit_card, options={})
+      def auth_or_sale(method, authorization, amount, credit_card, options = {})
         post = {}
         post[:method] = method
         add_request_id(post)
@@ -246,7 +246,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def verifyOnly(action, authorization, credit_card, options={})
+      def verifyOnly(action, authorization, credit_card, options = {})
         post = {}
         post[:method] = 'verifyOnly'
         add_request_id(post)
@@ -267,7 +267,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def refundWithCard(authorization, amount, credit_card, options={})
+      def refundWithCard(authorization, amount, credit_card, options = {})
         post = {}
         post[:method] = 'refundWithCard'
         add_request_id(post)
@@ -286,7 +286,7 @@ module ActiveMerchant #:nodoc:
         commit('v1/', post)
       end
 
-      def reverse_or_void(method, pgwTID, options={})
+      def reverse_or_void(method, pgwTID, options = {})
         post = {}
         post[:method] = method
         add_request_id(post)

data/lib/active_merchant/billing/gateways/linkpoint.rb

@@ -166,7 +166,7 @@ module ActiveMerchant #:nodoc:
       # :threshold              Tells how many times to retry the transaction (if it fails) before contacting the merchant.
       # :comments               Uh... comments
       #
-      def recurring(money, creditcard, options={})
+      def recurring(money, creditcard, options = {})
         ActiveMerchant.deprecated RECURRING_DEPRECATION_MESSAGE
 
         requires!(options, %i[periodicity bimonthly monthly biweekly weekly yearly daily], :installments, :order_id)
@@ -184,7 +184,7 @@ module ActiveMerchant #:nodoc:
       end
 
       # Buy the thing
-      def purchase(money, creditcard, options={})
+      def purchase(money, creditcard, options = {})
         requires!(options, :order_id)
         options.update(
           ordertype: 'SALE'
@@ -267,8 +267,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: response[:ordernum],
           avs_result: { code: response[:avs].to_s[2, 1] },
-          cvv_result: response[:avs].to_s[3, 1]
-        )
+          cvv_result: response[:avs].to_s[3, 1])
       end
 
       def successful?(response)
@@ -431,7 +430,7 @@ module ActiveMerchant #:nodoc:
         # <r_approved>APPROVED</r_approved>
         # <r_avs></r_avs>
 
-        response = {message: 'Global Error Receipt', complete: false}
+        response = { message: 'Global Error Receipt', complete: false }
 
         xml = REXML::Document.new("<response>#{xml}</response>")
         xml.root&.elements&.each do |node|

data/lib/active_merchant/billing/gateways/litle.rb

@@ -5,7 +5,10 @@ module ActiveMerchant #:nodoc:
     class LitleGateway < Gateway
       SCHEMA_VERSION = '9.14'
 
+      class_attribute :postlive_url
+
       self.test_url = 'https://www.testvantivcnp.com/sandbox/communicator/online'
+      self.postlive_url = 'https://payments.vantivpostlive.com/vap/communicator/online'
       self.live_url = 'https://payments.vantivcnp.com/vap/communicator/online'
 
       self.supported_countries = ['US']
@@ -15,12 +18,12 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'http://www.vantiv.com/'
       self.display_name = 'Vantiv eCommerce'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :login, :password, :merchant_id)
         super
       end
 
-      def purchase(money, payment_method, options={})
+      def purchase(money, payment_method, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           if check?(payment_method)
@@ -36,7 +39,7 @@ module ActiveMerchant #:nodoc:
         check?(payment_method) ? commit(:echeckSales, request, money) : commit(:sale, request, money)
       end
 
-      def authorize(money, payment_method, options={})
+      def authorize(money, payment_method, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           if check?(payment_method)
@@ -52,7 +55,7 @@ module ActiveMerchant #:nodoc:
         check?(payment_method) ? commit(:echeckVerification, request, money) : commit(:authorization, request, money)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         transaction_id, = split_authorization(authorization)
 
         request = build_xml_request do |doc|
@@ -72,7 +75,7 @@ module ActiveMerchant #:nodoc:
         refund(money, authorization, options)
       end
 
-      def refund(money, payment, options={})
+      def refund(money, payment, options = {})
         request = build_xml_request do |doc|
           add_authentication(doc)
           add_descriptor(doc, options)
@@ -84,7 +87,7 @@ module ActiveMerchant #:nodoc:
             elsif check?(payment)
               add_echeck_purchase_params(doc, money, payment, options)
             else
-              add_auth_purchase_params(doc, money, payment, options)
+              add_credit_params(doc, money, payment, options)
             end
           end
         end
@@ -99,7 +102,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         transaction_id, kind, money = split_authorization(authorization)
 
         request = build_xml_request do |doc|
@@ -227,7 +230,18 @@ module ActiveMerchant #:nodoc:
         add_stored_credential_params(doc, options)
       end
 
-      def add_merchant_data(doc, options={})
+      def add_credit_params(doc, money, payment_method, options)
+        doc.orderId(truncate(options[:order_id], 24))
+        doc.amount(money)
+        add_order_source(doc, payment_method, options)
+        add_billing_address(doc, payment_method, options)
+        add_payment_method(doc, payment_method, options)
+        add_pos(doc, payment_method)
+        add_descriptor(doc, options)
+        add_merchant_data(doc, options)
+      end
+
+      def add_merchant_data(doc, options = {})
         if options[:affiliate] || options[:campaign] || options[:merchant_grouping_id]
           doc.merchantData do
             doc.affiliate(options[:affiliate]) if options[:affiliate]
@@ -296,7 +310,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def add_stored_credential_params(doc, options={})
+      def add_stored_credential_params(doc, options = {})
         return unless options[:stored_credential]
 
         if options[:stored_credential][:initial_transaction]
@@ -357,9 +371,9 @@ module ActiveMerchant #:nodoc:
         return unless address
 
         doc.companyName(address[:company]) unless address[:company].blank?
-        doc.addressLine1(address[:address1]) unless address[:address1].blank?
-        doc.addressLine2(address[:address2]) unless address[:address2].blank?
-        doc.city(address[:city]) unless address[:city].blank?
+        doc.addressLine1(truncate(address[:address1], 35)) unless address[:address1].blank?
+        doc.addressLine2(truncate(address[:address2], 35)) unless address[:address2].blank?
+        doc.city(truncate(address[:city], 35)) unless address[:city].blank?
         doc.state(address[:state]) unless address[:state].blank?
         doc.zip(address[:zip]) unless address[:zip].blank?
         doc.country(address[:country]) unless address[:country].blank?
@@ -381,7 +395,7 @@ module ActiveMerchant #:nodoc:
         end
       end
 
-      def order_source(options={})
+      def order_source(options = {})
         return options[:order_source] unless options[:stored_credential]
 
         order_source = nil
@@ -448,7 +462,7 @@ module ActiveMerchant #:nodoc:
         parsed
       end
 
-      def commit(kind, request, money=nil)
+      def commit(kind, request, money = nil)
         parsed = parse(kind, ssl_post(url, request, headers))
 
         options = {
@@ -481,7 +495,7 @@ module ActiveMerchant #:nodoc:
         attributes[:id] = truncate(options[:id] || options[:order_id], 24)
         attributes[:reportGroup] = options[:merchant] || 'Default Report Group'
         attributes[:customerId] = options[:customer]
-        attributes.delete_if { |key, value| value == nil }
+        attributes.delete_if { |_key, value| value == nil }
         attributes
       end
 
@@ -502,6 +516,8 @@ module ActiveMerchant #:nodoc:
       end
 
       def url
+        return postlive_url if @options[:url_override].to_s == 'postlive'
+
         test? ? test_url : live_url
       end
 

data/lib/active_merchant/billing/gateways/mastercard.rb

@@ -1,12 +1,12 @@
 module ActiveMerchant
   module Billing
     module MastercardGateway
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :userid, :password)
         super
       end
 
-      def purchase(amount, payment_method, options={})
+      def purchase(amount, payment_method, options = {})
         if options[:pay_mode]
           post = new_post
           add_invoice(post, amount, options)
@@ -24,7 +24,7 @@ module ActiveMerchant
         end
       end
 
-      def authorize(amount, payment_method, options={})
+      def authorize(amount, payment_method, options = {})
         post = new_post
         add_invoice(post, amount, options)
         add_reference(post, *new_authorization)
@@ -35,7 +35,7 @@ module ActiveMerchant
         commit('authorize', post)
       end
 
-      def capture(amount, authorization, options={})
+      def capture(amount, authorization, options = {})
         post = new_post
         add_invoice(post, amount, options, :transaction)
         add_reference(post, *next_authorization(authorization))
@@ -45,7 +45,7 @@ module ActiveMerchant
         commit('capture', post)
       end
 
-      def refund(amount, authorization, options={})
+      def refund(amount, authorization, options = {})
         post = new_post
         add_invoice(post, amount, options, :transaction)
         add_reference(post, *next_authorization(authorization))
@@ -54,14 +54,14 @@ module ActiveMerchant
         commit('refund', post)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         post = new_post
         add_reference(post, *next_authorization(authorization), :targetTransactionId)
 
         commit('void', post)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -109,12 +109,12 @@ module ActiveMerchant
         }
       end
 
-      def add_invoice(post, amount, options, node=:order)
+      def add_invoice(post, amount, options, node = :order)
         post[node][:amount] = amount(amount)
         post[node][:currency] = (options[:currency] || currency(amount))
       end
 
-      def add_reference(post, orderid, transactionid, transaction_reference, reference_key=:reference)
+      def add_reference(post, orderid, transactionid, transaction_reference, reference_key = :reference)
         post[:orderid] = orderid
         post[:transactionid] = transactionid
         post[:transaction][reference_key] = transaction_reference if transaction_reference
@@ -176,7 +176,7 @@ module ActiveMerchant
       def add_3dsecure_id(post, options)
         return unless options[:threed_secure_id]
 
-        post.merge!({'3DSecureId' => options[:threed_secure_id]})
+        post.merge!({ '3DSecureId' => options[:threed_secure_id] })
       end
 
       def country_code(country)