activemerchant 1.108.0 → 1.109.0

data/lib/active_merchant/billing/gateways/netbilling.rb

@@ -23,7 +23,7 @@ module ActiveMerchant #:nodoc:
         quasi:         'Q'
       }
 
-      SUCCESS_CODES = ['1', 'T']
+      SUCCESS_CODES = %w[1 T]
       SUCCESS_MESSAGE = 'The transaction was approved'
       FAILURE_MESSAGE = 'The transaction failed'
       TEST_LOGIN = '104901072025'
@@ -31,7 +31,7 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'NETbilling'
       self.homepage_url = 'http://www.netbilling.com'
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express discover jcb diners_club]
 
       def initialize(options = {})
         requires!(options, :login)

data/lib/active_merchant/billing/gateways/netpay.rb

@@ -42,7 +42,7 @@ module ActiveMerchant #:nodoc:
       self.default_currency = 'MXN'
 
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express diners_club]
 
       # The homepage URL of the gateway
       self.homepage_url = 'http://www.netpay.com.mx'
@@ -55,7 +55,7 @@ module ActiveMerchant #:nodoc:
       }
 
       # The header keys that we will provide in the response params hash
-      RESPONSE_KEYS = ['ResponseMsg', 'ResponseText', 'ResponseCode', 'TimeIn', 'TimeOut', 'AuthCode', 'OrderId', 'CardTypeName', 'MerchantId', 'IssuerAuthDate']
+      RESPONSE_KEYS = %w[ResponseMsg ResponseText ResponseCode TimeIn TimeOut AuthCode OrderId CardTypeName MerchantId IssuerAuthDate]
 
       def initialize(options = {})
         requires!(options, :store_id, :login, :password)

data/lib/active_merchant/billing/gateways/network_merchants.rb

@@ -4,7 +4,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = self.test_url = 'https://secure.networkmerchants.com/api/transact.php'
 
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'http://www.nmi.com/'
       self.display_name = 'Network Merchants (NMI)'

data/lib/active_merchant/billing/gateways/nmi.rb

@@ -9,7 +9,7 @@ module ActiveMerchant #:nodoc:
       self.default_currency = 'USD'
       self.money_format = :dollars
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.homepage_url = 'http://nmi.com/'
       self.display_name = 'NMI'
 
@@ -138,7 +138,7 @@ module ActiveMerchant #:nodoc:
       private
 
       def add_level3_fields(post, options)
-        add_fields_to_post_if_present(post, options, [:tax, :shipping, :ponumber])
+        add_fields_to_post_if_present(post, options, %i[tax shipping ponumber])
       end
 
       def add_invoice(post, money, options)
@@ -154,7 +154,7 @@ module ActiveMerchant #:nodoc:
 
       def add_payment_method(post, payment_method, options)
         if payment_method.is_a?(String)
-          customer_vault_id, _ = split_authorization(payment_method)
+          customer_vault_id, = split_authorization(payment_method)
           post[:customer_vault_id] = customer_vault_id
         elsif payment_method.is_a?(NetworkTokenizationCreditCard)
           post[:ccnumber] = payment_method.number
@@ -249,7 +249,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_reference(post, authorization)
-        transaction_id, _ = split_authorization(authorization)
+        transaction_id, = split_authorization(authorization)
         post[:transactionid] = transaction_id
       end
 

data/lib/active_merchant/billing/gateways/ogone.rb

@@ -133,9 +133,9 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://secure.ogone.com/ncol/test/'
       self.live_url = 'https://secure.ogone.com/ncol/prod/'
 
-      self.supported_countries = ['BE', 'DE', 'FR', 'NL', 'AT', 'CH']
+      self.supported_countries = %w[BE DE FR NL AT CH]
       # also supports Airplus and UATP
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover, :jcb, :maestro]
+      self.supported_cardtypes = %i[visa master american_express diners_club discover jcb maestro]
       self.homepage_url = 'http://www.ogone.com/'
       self.display_name = 'Ogone'
       self.default_currency = 'EUR'

data/lib/active_merchant/billing/gateways/omise.rb

@@ -27,7 +27,7 @@ module ActiveMerchant #:nodoc:
       # * VISA
       # * MasterCard
       # * JCB
-      self.supported_cardtypes = [:visa, :master, :jcb]
+      self.supported_cardtypes = %i[visa master jcb]
 
       # Omise main page
       self.homepage_url = 'https://www.omise.co/'

data/lib/active_merchant/billing/gateways/openpay.rb

@@ -5,7 +5,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = 'https://sandbox-api.openpay.mx/v1/'
 
       self.supported_countries = ['MX']
-      self.supported_cardtypes = [:visa, :master, :american_express, :carnet]
+      self.supported_cardtypes = %i[visa master american_express carnet]
       self.homepage_url = 'http://www.openpay.mx/'
       self.display_name = 'Openpay'
       self.default_currency = 'MXN'

data/lib/active_merchant/billing/gateways/opp.rb

@@ -112,7 +112,7 @@ module ActiveMerchant #:nodoc:
 
       self.supported_countries = %w(AD AI AG AR AU AT BS BB BE BZ BM BR BN BG CA HR CY CZ DK DM EE FI FR DE GR GD GY HK HU IS IN IL IT JP LV LI LT LU MY MT MX MC MS NL PA PL PT KN LC MF VC SM SG SK SI ZA ES SR SE CH TR GB US UY)
       self.default_currency = 'EUR'
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :discover, :jcb, :maestro, :dankort]
+      self.supported_cardtypes = %i[visa master american_express diners_club discover jcb maestro dankort]
 
       self.homepage_url = 'https://docs.oppwa.com'
       self.display_name = 'Open Payment Platform'

data/lib/active_merchant/billing/gateways/optimal_payment.rb

@@ -5,12 +5,12 @@ module ActiveMerchant #:nodoc:
       self.live_url = 'https://webservices.optimalpayments.com/creditcardWS/CreditCardServlet/v1'
 
       # The countries the gateway supports merchants from as 2 digit ISO country codes
-      self.supported_countries = ['CA', 'US', 'GB', 'AU', 'AT', 'BE', 'BG', 'HR', 'CY', 'CZ', 'DK',
-                                  'EE', 'FI', 'DE', 'GR', 'HU', 'IE', 'IT', 'LV', 'LT', 'LU', 'MT',
-                                  'NL', 'NO', 'PL', 'PT', 'RO', 'SK', 'SI', 'ES', 'SE', 'CH']
+      self.supported_countries = %w[CA US GB AU AT BE BG HR CY CZ DK
+                                    EE FI DE GR HU IE IT LV LT LU MT
+                                    NL NO PL PT RO SK SI ES SE CH]
 
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express discover diners_club]
 
       # The homepage URL of the gateway
       self.homepage_url = 'http://www.optimalpayments.com/'

data/lib/active_merchant/billing/gateways/orbital.rb

@@ -71,16 +71,16 @@ module ActiveMerchant #:nodoc:
       self.live_url = 'https://orbital1.chasepaymentech.com/authorize'
       self.secondary_live_url = 'https://orbital2.chasepaymentech.com/authorize'
 
-      self.supported_countries = ['US', 'CA']
+      self.supported_countries = %w[US CA]
       self.default_currency = 'CAD'
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
+      self.supported_cardtypes = %i[visa master american_express discover diners_club jcb]
 
       self.display_name = 'Orbital Paymentech'
       self.homepage_url = 'http://chasepaymentech.com/'
 
       self.money_format = :cents
 
-      AVS_SUPPORTED_COUNTRIES = ['US', 'CA', 'UK', 'GB']
+      AVS_SUPPORTED_COUNTRIES = %w[US CA UK GB]
 
       CURRENCY_CODES = {
         'AUD' => '036',
@@ -181,7 +181,7 @@ module ActiveMerchant #:nodoc:
       USE_ORDER_ID         = 'O' #  Use OrderID field
       USE_COMMENTS         = 'D' #  Use Comments field
 
-      SENSITIVE_FIELDS = [:account_num, :cc_account_num]
+      SENSITIVE_FIELDS = %i[account_num cc_account_num]
 
       def initialize(options = {})
         requires!(options, :merchant_id)
@@ -678,7 +678,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def success?(response, message_type)
-        if [:refund, :void].include?(message_type)
+        if %i[refund void].include?(message_type)
           response[:proc_status] == SUCCESS
         elsif response[:customer_profile_action]
           response[:profile_proc_status] == SUCCESS
@@ -749,7 +749,7 @@ module ActiveMerchant #:nodoc:
 
             # Append Transaction Reference Number at the end for Refund transactions
             if action == REFUND
-              tx_ref_num, _ = split_authorization(parameters[:authorization])
+              tx_ref_num, = split_authorization(parameters[:authorization])
               xml.tag! :TxRefNum, tx_ref_num
             end
 

data/lib/active_merchant/billing/gateways/orbital/orbital_soft_descriptors.rb

@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
 
         errors << [:merchant_phone, 'is required to follow "NNN-NNN-NNNN" or "NNN-AAAAAAA" format'] if !empty?(self.merchant_phone) && !self.merchant_phone.match(PHONE_FORMAT_1) && !self.merchant_phone.match(PHONE_FORMAT_2)
 
-        [:merchant_email, :merchant_url].each do |attr|
+        %i[merchant_email merchant_url].each do |attr|
           unless self.send(attr).blank?
             errors << [attr, 'is required to be 13 bytes or less'] if self.send(attr).bytesize > 13
           end

data/lib/active_merchant/billing/gateways/pac_net_raven.rb

@@ -28,7 +28,7 @@ module ActiveMerchant #:nodoc:
       self.test_url = self.live_url
 
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master]
+      self.supported_cardtypes = %i[visa master]
       self.money_format = :cents
       self.default_currency = 'USD'
       self.homepage_url = 'https://www.deepcovelabs.com/raven'

data/lib/active_merchant/billing/gateways/pagarme.rb

@@ -6,7 +6,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['BR']
       self.default_currency = 'BRL'
       self.money_format = :cents
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express discover diners_club]
 
       self.homepage_url = 'https://pagar.me/'
       self.display_name = 'Pagar.me'
@@ -207,7 +207,7 @@ module ActiveMerchant #:nodoc:
           when 'refunded'
             'Transação estornada'
           else
-            "Transação com status '#{response["status"]}'"
+            "Transação com status '#{response['status']}'"
           end
         elsif failure_from(response)
           'Transação recusada'

data/lib/active_merchant/billing/gateways/pago_facil.rb

@@ -6,7 +6,7 @@ module ActiveMerchant #:nodoc:
 
       self.supported_countries = ['MX']
       self.default_currency = 'MXN'
-      self.supported_cardtypes = [:visa, :master, :american_express, :jcb]
+      self.supported_cardtypes = %i[visa master american_express jcb]
 
       self.homepage_url = 'http://www.pagofacil.net/'
       self.display_name = 'PagoFacil'

data/lib/active_merchant/billing/gateways/pay_conex.rb

@@ -8,7 +8,7 @@ module ActiveMerchant #:nodoc:
 
       self.supported_countries = %w(US CA)
       self.default_currency = 'USD'
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express discover jcb diners_club]
 
       self.homepage_url = 'http://www.bluefincommerce.com/'
       self.display_name = 'PayConex'

data/lib/active_merchant/billing/gateways/pay_gate_xml.rb

@@ -76,10 +76,10 @@ module ActiveMerchant #:nodoc:
       self.live_url = 'https://www.paygate.co.za/payxml/process.trans'
 
       # The countries the gateway supports merchants from as 2 digit ISO country codes
-      self.supported_countries = ['US', 'ZA']
+      self.supported_countries = %w[US ZA]
 
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express diners_club]
 
       # The homepage URL of the gateway
       self.homepage_url = 'http://paygate.co.za/'

data/lib/active_merchant/billing/gateways/pay_hub.rb

@@ -5,7 +5,7 @@ module ActiveMerchant #:nodoc:
 
       self.supported_countries = ['US']
       self.default_currency = 'USD'
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       self.homepage_url = 'http://www.payhub.com/'
       self.display_name = 'PayHub'

data/lib/active_merchant/billing/gateways/pay_junction.rb

@@ -107,7 +107,7 @@ module ActiveMerchant #:nodoc:
       TEST_LOGIN = 'pj-ql-01'
       TEST_PASSWORD = 'pj-ql-01p'
 
-      SUCCESS_CODES = ['00', '85']
+      SUCCESS_CODES = %w[00 85]
       SUCCESS_MESSAGE = 'The transaction was approved.'
 
       FAILURE_MESSAGE = 'The transaction was declined.'
@@ -150,7 +150,7 @@ module ActiveMerchant #:nodoc:
         'AB'  => 'Aborted because of an upstream system error, please try again later.'
       }
 
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.supported_countries = ['US']
       self.homepage_url = 'http://www.payjunction.com/'
       self.display_name = 'PayJunction'
@@ -241,7 +241,7 @@ module ActiveMerchant #:nodoc:
       def recurring(money, payment_source, options = {})
         ActiveMerchant.deprecated RECURRING_DEPRECATION_MESSAGE
 
-        requires!(options, [:periodicity, :monthly, :weekly, :daily], :payments)
+        requires!(options, %i[periodicity monthly weekly daily], :payments)
 
         periodic_type =
           case options[:periodicity]

data/lib/active_merchant/billing/gateways/pay_junction_v2.rb

@@ -10,7 +10,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['US']
       self.default_currency = 'USD'
       self.money_format = :dollars
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       def initialize(options={})
         requires!(options, :api_login, :api_password, :api_key)
@@ -146,7 +146,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def ssl_invoke(action, params)
-        if ['purchase', 'authorize', 'refund', 'credit'].include?(action)
+        if %w[purchase authorize refund credit].include?(action)
           ssl_post(url(), post_data(params), headers)
         else
           ssl_request(:put, url(params), post_data(params), headers)

data/lib/active_merchant/billing/gateways/pay_secure.rb

@@ -20,7 +20,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['AU']
       self.homepage_url = 'http://www.commsecure.com.au/paysecure.shtml'
       self.display_name = 'PaySecure'
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express diners_club]
 
       def initialize(options = {})
         requires!(options, :login, :password)

data/lib/active_merchant/billing/gateways/paybox_direct.rb

@@ -39,7 +39,7 @@ module ActiveMerchant #:nodoc:
       }
 
       SUCCESS_CODES = ['00000']
-      UNAVAILABILITY_CODES = ['00001', '00097', '00098']
+      UNAVAILABILITY_CODES = %w[00001 00097 00098]
       SUCCESS_MESSAGE = 'The transaction was approved'
       FAILURE_MESSAGE = 'The transaction failed'
 
@@ -51,7 +51,7 @@ module ActiveMerchant #:nodoc:
       self.supported_countries = ['FR']
 
       # The card types supported by the payment gateway
-      self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb]
+      self.supported_cardtypes = %i[visa master american_express diners_club jcb]
 
       # The homepage URL of the gateway
       self.homepage_url = 'http://www.paybox.com/'
@@ -160,7 +160,7 @@ module ActiveMerchant #:nodoc:
           test: test?,
           authorization: response[:numappel].to_s + response[:numtrans].to_s,
           fraud_review: false,
-          sent_params: parameters.delete_if { |key, value| ['porteur', 'dateval', 'cvv'].include?(key.to_s) }
+          sent_params: parameters.delete_if { |key, value| %w[porteur dateval cvv].include?(key.to_s) }
         )
       end
 

data/lib/active_merchant/billing/gateways/payeezy.rb

@@ -11,7 +11,7 @@ module ActiveMerchant
       self.money_format = :cents
       self.supported_countries = %w(US CA)
 
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :diners_club]
+      self.supported_cardtypes = %i[visa master american_express discover jcb diners_club]
 
       self.homepage_url = 'https://developer.payeezy.com/'
       self.display_name = 'Payeezy'
@@ -136,7 +136,7 @@ module ActiveMerchant
       end
 
       def add_authorization_info(params, authorization, options = {})
-        transaction_id, transaction_tag, method, _ = authorization.split('|')
+        transaction_id, transaction_tag, method, = authorization.split('|')
         params[:method] = method == 'token' ? 'credit_card' : method
 
         if options[:reversal_id]

data/lib/active_merchant/billing/gateways/payex.rb

@@ -12,8 +12,8 @@ module ActiveMerchant #:nodoc:
       self.test_confined_url = 'https://test-confined.payex.com/'
 
       self.money_format = :cents
-      self.supported_countries = ['DK', 'FI', 'NO', 'SE']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_countries = %w[DK FI NO SE]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.homepage_url = 'http://payex.com/'
       self.display_name = 'Payex'
       self.default_currency = 'EUR'
@@ -193,9 +193,9 @@ module ActiveMerchant #:nodoc:
           cancelUrl: nil,
           clientLanguage: nil
         }
-        hash_fields = [:accountNumber, :purchaseOperation, :price, :priceArgList, :currency, :vat, :orderID,
-                       :productNumber, :description, :clientIPAddress, :clientIdentifier, :additionalValues,
-                       :externalID, :returnUrl, :view, :agreementRef, :cancelUrl, :clientLanguage]
+        hash_fields = %i[accountNumber purchaseOperation price priceArgList currency vat orderID
+                         productNumber description clientIPAddress clientIdentifier additionalValues
+                         externalID returnUrl view agreementRef cancelUrl clientLanguage]
         add_request_hash(properties, hash_fields)
         soap_action = SOAP_ACTIONS[:initialize]
         request = build_xml_request(soap_action, properties)
@@ -213,8 +213,8 @@ module ActiveMerchant #:nodoc:
           cardHolderName: payment_method.name,
           cardNumberCVC: payment_method.verification_value
         }
-        hash_fields = [:accountNumber, :orderRef, :transactionType, :cardNumber, :cardNumberExpireMonth,
-                       :cardNumberExpireYear, :cardNumberCVC, :cardHolderName]
+        hash_fields = %i[accountNumber orderRef transactionType cardNumber cardNumberExpireMonth
+                         cardNumberExpireYear cardNumberCVC cardHolderName]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:purchasecc]
@@ -233,7 +233,7 @@ module ActiveMerchant #:nodoc:
           purchaseOperation: is_auth ? 'AUTHORIZATION' : 'SALE',
           currency: (options[:currency] || default_currency),
         }
-        hash_fields = [:accountNumber, :agreementRef, :price, :productNumber, :description, :orderId, :purchaseOperation, :currency]
+        hash_fields = %i[accountNumber agreementRef price productNumber description orderId purchaseOperation currency]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:autopay]
@@ -250,7 +250,7 @@ module ActiveMerchant #:nodoc:
           vatAmount: options[:vat_amount] || 0,
           additionalValues: ''
         }
-        hash_fields = [:accountNumber, :transactionNumber, :amount, :orderId, :vatAmount, :additionalValues]
+        hash_fields = %i[accountNumber transactionNumber amount orderId vatAmount additionalValues]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:capture]
@@ -267,7 +267,7 @@ module ActiveMerchant #:nodoc:
           vatAmount: options[:vat_amount] || 0,
           additionalValues: ''
         }
-        hash_fields = [:accountNumber, :transactionNumber, :amount, :orderId, :vatAmount, :additionalValues]
+        hash_fields = %i[accountNumber transactionNumber amount orderId vatAmount additionalValues]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:credit]
@@ -280,7 +280,7 @@ module ActiveMerchant #:nodoc:
           accountNumber: @options[:account],
           transactionNumber: transaction_number,
         }
-        hash_fields = [:accountNumber, :transactionNumber]
+        hash_fields = %i[accountNumber transactionNumber]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:cancel]
@@ -299,7 +299,7 @@ module ActiveMerchant #:nodoc:
           startDate: options[:startDate] || '',
           stopDate: options[:stopDate] || ''
         }
-        hash_fields = [:accountNumber, :merchantRef, :description, :purchaseOperation, :maxAmount, :notifyUrl, :startDate, :stopDate]
+        hash_fields = %i[accountNumber merchantRef description purchaseOperation maxAmount notifyUrl startDate stopDate]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:create_agreement]
@@ -312,7 +312,7 @@ module ActiveMerchant #:nodoc:
           accountNumber: @options[:account],
           agreementRef: authorization,
         }
-        hash_fields = [:accountNumber, :agreementRef]
+        hash_fields = %i[accountNumber agreementRef]
         add_request_hash(properties, hash_fields)
 
         soap_action = SOAP_ACTIONS[:delete_agreement]