activemerchant 1.105.0 → 1.107.4

data/lib/active_merchant/billing/gateways/element.rb

@@ -111,10 +111,18 @@ module ActiveMerchant #:nodoc:
       end
 
       def verify(credit_card, options={})
-        MultiResponse.run(:use_first_response) do |r|
-          r.process { authorize(100, credit_card, options) }
-          r.process(:ignore_result) { void(r.authorization, options) }
+        request = build_soap_request do |xml|
+          xml.CreditCardAVSOnly(xmlns: 'https://transaction.elementexpress.com') do
+            add_credentials(xml)
+            add_payment_method(xml, credit_card)
+            add_transaction(xml, 0, options)
+            add_terminal(xml, options)
+            add_address(xml, options)
+          end
         end
+
+        # send request with the transaction amount set to 0
+        commit('CreditCardAVSOnly', request, 0)
       end
 
       def supports_scrubbing?
@@ -186,7 +194,7 @@ module ActiveMerchant #:nodoc:
       def add_terminal(xml, options)
         xml.terminal do
           xml.TerminalID '01'
-          xml.CardPresentCode 'UseDefault'
+          xml.CardPresentCode options[:card_present_code] || 'UseDefault'
           xml.CardholderPresentCode 'UseDefault'
           xml.CardInputCode 'UseDefault'
           xml.CVVPresenceCode 'UseDefault'

data/lib/active_merchant/billing/gateways/epay.rb

@@ -12,41 +12,41 @@ module ActiveMerchant #:nodoc:
       self.display_name = 'ePay'
 
       CURRENCY_CODES = {
-        :ADP => '020', :AED => '784', :AFA => '004', :ALL => '008', :AMD => '051',
-        :ANG => '532', :AOA => '973', :ARS => '032', :AUD => '036', :AWG => '533',
-        :AZM => '031', :BAM => '977', :BBD => '052', :BDT => '050', :BGL => '100',
-        :BGN => '975', :BHD => '048', :BIF => '108', :BMD => '060', :BND => '096',
-        :BOB => '068', :BOV => '984', :BRL => '986', :BSD => '044', :BTN => '064',
-        :BWP => '072', :BYR => '974', :BZD => '084', :CAD => '124', :CDF => '976',
-        :CHF => '756', :CLF => '990', :CLP => '152', :CNY => '156', :COP => '170',
-        :CRC => '188', :CUP => '192', :CVE => '132', :CYP => '196', :CZK => '203',
-        :DJF => '262', :DKK => '208', :DOP => '214', :DZD => '012', :ECS => '218',
-        :ECV => '983', :EEK => '233', :EGP => '818', :ERN => '232', :ETB => '230',
-        :EUR => '978', :FJD => '242', :FKP => '238', :GBP => '826', :GEL => '981',
-        :GHC => '288', :GIP => '292', :GMD => '270', :GNF => '324', :GTQ => '320',
-        :GWP => '624', :GYD => '328', :HKD => '344', :HNL => '340', :HRK => '191',
-        :HTG => '332', :HUF => '348', :IDR => '360', :ILS => '376', :INR => '356',
-        :IQD => '368', :IRR => '364', :ISK => '352', :JMD => '388', :JOD => '400',
-        :JPY => '392', :KES => '404', :KGS => '417', :KHR => '116', :KMF => '174',
-        :KPW => '408', :KRW => '410', :KWD => '414', :KYD => '136', :KZT => '398',
-        :LAK => '418', :LBP => '422', :LKR => '144', :LRD => '430', :LSL => '426',
-        :LTL => '440', :LVL => '428', :LYD => '434', :MAD => '504', :MDL => '498',
-        :MGF => '450', :MKD => '807', :MMK => '104', :MNT => '496', :MOP => '446',
-        :MRO => '478', :MTL => '470', :MUR => '480', :MVR => '462', :MWK => '454',
-        :MXN => '484', :MXV => '979', :MYR => '458', :MZM => '508', :NAD => '516',
-        :NGN => '566', :NIO => '558', :NOK => '578', :NPR => '524', :NZD => '554',
-        :OMR => '512', :PAB => '590', :PEN => '604', :PGK => '598', :PHP => '608',
-        :PKR => '586', :PLN => '985', :PYG => '600', :QAR => '634', :ROL => '642',
-        :RUB => '643', :RUR => '810', :RWF => '646', :SAR => '682', :SBD => '090',
-        :SCR => '690', :SDD => '736', :SEK => '752', :SGD => '702', :SHP => '654',
-        :SIT => '705', :SKK => '703', :SLL => '694', :SOS => '706', :SRG => '740',
-        :STD => '678', :SVC => '222', :SYP => '760', :SZL => '748', :THB => '764',
-        :TJS => '972', :TMM => '795', :TND => '788', :TOP => '776', :TPE => '626',
-        :TRL => '792', :TRY => '949', :TTD => '780', :TWD => '901', :TZS => '834',
-        :UAH => '980', :UGX => '800', :USD => '840', :UYU => '858', :UZS => '860',
-        :VEB => '862', :VND => '704', :VUV => '548', :XAF => '950', :XCD => '951',
-        :XOF => '952', :XPF => '953', :YER => '886', :YUM => '891', :ZAR => '710',
-        :ZMK => '894', :ZWD => '716'
+        ADP: '020', AED: '784', AFA: '004', ALL: '008', AMD: '051',
+        ANG: '532', AOA: '973', ARS: '032', AUD: '036', AWG: '533',
+        AZM: '031', BAM: '977', BBD: '052', BDT: '050', BGL: '100',
+        BGN: '975', BHD: '048', BIF: '108', BMD: '060', BND: '096',
+        BOB: '068', BOV: '984', BRL: '986', BSD: '044', BTN: '064',
+        BWP: '072', BYR: '974', BZD: '084', CAD: '124', CDF: '976',
+        CHF: '756', CLF: '990', CLP: '152', CNY: '156', COP: '170',
+        CRC: '188', CUP: '192', CVE: '132', CYP: '196', CZK: '203',
+        DJF: '262', DKK: '208', DOP: '214', DZD: '012', ECS: '218',
+        ECV: '983', EEK: '233', EGP: '818', ERN: '232', ETB: '230',
+        EUR: '978', FJD: '242', FKP: '238', GBP: '826', GEL: '981',
+        GHC: '288', GIP: '292', GMD: '270', GNF: '324', GTQ: '320',
+        GWP: '624', GYD: '328', HKD: '344', HNL: '340', HRK: '191',
+        HTG: '332', HUF: '348', IDR: '360', ILS: '376', INR: '356',
+        IQD: '368', IRR: '364', ISK: '352', JMD: '388', JOD: '400',
+        JPY: '392', KES: '404', KGS: '417', KHR: '116', KMF: '174',
+        KPW: '408', KRW: '410', KWD: '414', KYD: '136', KZT: '398',
+        LAK: '418', LBP: '422', LKR: '144', LRD: '430', LSL: '426',
+        LTL: '440', LVL: '428', LYD: '434', MAD: '504', MDL: '498',
+        MGF: '450', MKD: '807', MMK: '104', MNT: '496', MOP: '446',
+        MRO: '478', MTL: '470', MUR: '480', MVR: '462', MWK: '454',
+        MXN: '484', MXV: '979', MYR: '458', MZM: '508', NAD: '516',
+        NGN: '566', NIO: '558', NOK: '578', NPR: '524', NZD: '554',
+        OMR: '512', PAB: '590', PEN: '604', PGK: '598', PHP: '608',
+        PKR: '586', PLN: '985', PYG: '600', QAR: '634', ROL: '642',
+        RUB: '643', RUR: '810', RWF: '646', SAR: '682', SBD: '090',
+        SCR: '690', SDD: '736', SEK: '752', SGD: '702', SHP: '654',
+        SIT: '705', SKK: '703', SLL: '694', SOS: '706', SRG: '740',
+        STD: '678', SVC: '222', SYP: '760', SZL: '748', THB: '764',
+        TJS: '972', TMM: '795', TND: '788', TOP: '776', TPE: '626',
+        TRL: '792', TRY: '949', TTD: '780', TWD: '901', TZS: '834',
+        UAH: '980', UGX: '800', USD: '840', UYU: '858', UZS: '860',
+        VEB: '862', VND: '704', VUV: '548', XAF: '950', XCD: '951',
+        XOF: '952', XPF: '953', YER: '886', YUM: '891', ZAR: '710',
+        ZMK: '894', ZWD: '716'
       }
 
       # login: merchant number
@@ -177,14 +177,14 @@ module ActiveMerchant #:nodoc:
           Response.new response['accept'].to_i == 1,
             response['errortext'],
             response,
-            :test => test?,
-            :authorization => response['tid']
+            test: test?,
+            authorization: response['tid']
         else
           Response.new response['result'] == 'true',
             messages(response['epay'], response['pbs']),
             response,
-            :test => test?,
-            :authorization => params[:transaction]
+            test: test?,
+            authorization: params[:transaction]
         end
       end
 
@@ -261,7 +261,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def xml_builder(params, soap_call)
-        xml = Builder::XmlMarkup.new(:indent => 2)
+        xml = Builder::XmlMarkup.new(indent: 2)
         xml.instruct!
         xml.tag! 'soap:Envelope', { 'xmlns:xsi' => 'http://schemas.xmlsoap.org/soap/envelope/',
                                     'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',

data/lib/active_merchant/billing/gateways/evo_ca.rb

@@ -139,8 +139,8 @@ module ActiveMerchant #:nodoc:
       # <tt>options</tt>.
       def capture(money, authorization, options = {})
         post = {
-          :amount         => amount(money),
-          :transactionid  => authorization
+          amount: amount(money),
+          transactionid: authorization
         }
         add_order(post, options)
         commit('capture', money, post)
@@ -153,7 +153,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def refund(money, identification)
-        post = {:transactionid => identification}
+        post = {transactionid: identification}
         commit('refund', money, post)
       end
 
@@ -181,7 +181,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def void(identification)
-        post = {:transactionid => identification}
+        post = {transactionid: identification}
         commit('void', nil, post)
       end
 
@@ -192,7 +192,7 @@ module ActiveMerchant #:nodoc:
       # The <tt>identification</tt> parameter is the transaction ID, retrieved
       # from {Response#authorization}.
       def update(identification, options)
-        post = {:transactionid => identification}
+        post = {transactionid: identification}
         add_order(post, options)
         commit('update', nil, post)
       end
@@ -245,7 +245,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_paymentmethod(post, payment)
-        if card_brand(payment)=='check'
+        if card_brand(payment) == 'check'
           post[:payment]              = 'check'
           post[:checkname]            = payment.name
           post[:checkaba]             = payment.routing_number
@@ -280,10 +280,10 @@ module ActiveMerchant #:nodoc:
         message = message_from(response)
 
         Response.new(success?(response), message, response,
-          :test          => test?,
-          :authorization => response['transactionid'],
-          :avs_result    => { :code => response['avsresponse'] },
-          :cvv_result    => response['cvvresponse']
+          test: test?,
+          authorization: response['transactionid'],
+          avs_result: { code: response['avsresponse'] },
+          cvv_result: response['cvvresponse']
         )
       end
 
@@ -292,7 +292,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def post_data(action, parameters = {})
-        post = {:type => action}
+        post = {type: action}
 
         if test?
           post[:username] = 'demo'

data/lib/active_merchant/billing/gateways/eway.rb

@@ -71,7 +71,7 @@ module ActiveMerchant #:nodoc:
 
       def add_creditcard(post, creditcard)
         post[:CardNumber] = creditcard.number
-        post[:CardExpiryMonth]  = sprintf('%.2i', creditcard.month)
+        post[:CardExpiryMonth] = sprintf('%.2i', creditcard.month)
         post[:CardExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CustomerFirstName] = creditcard.first_name
         post[:CustomerLastName]  = creditcard.last_name
@@ -114,8 +114,8 @@ module ActiveMerchant #:nodoc:
         Response.new(success?(response),
           message_from(response[:ewaytrxnerror]),
           response,
-          :authorization => response[:ewaytrxnnumber],
-          :test => test?
+          authorization: response[:ewaytrxnnumber],
+          test: test?
         )
       end
 

data/lib/active_merchant/billing/gateways/eway_managed.rb

@@ -59,7 +59,7 @@ module ActiveMerchant #:nodoc:
         billing_address = options[:billing_address]
         eway_requires!(billing_address)
 
-        post[:managedCustomerID]=billing_id
+        post[:managedCustomerID] = billing_id
         add_creditcard(post, creditcard)
         add_address(post, billing_address)
         add_misc_fields(post, options)
@@ -83,7 +83,7 @@ module ActiveMerchant #:nodoc:
       def purchase(money, billing_id, options={})
         post = {}
         post[:managedCustomerID] = billing_id.to_s
-        post[:amount]=money
+        post[:amount] = money
         add_invoice(post, options)
 
         commit('ProcessPayment', post)
@@ -122,13 +122,13 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_misc_fields(post, options)
-        post[:CustomerRef]=options[:billing_address][:customer_ref] || options[:customer]
-        post[:Title]=options[:billing_address][:title]
-        post[:Company]=options[:billing_address][:company]
-        post[:JobDesc]=options[:billing_address][:job_desc]
-        post[:Email]=options[:billing_address][:email] || options[:email]
-        post[:URL]=options[:billing_address][:url]
-        post[:Comments]=options[:description]
+        post[:CustomerRef] = options[:billing_address][:customer_ref] || options[:customer]
+        post[:Title] = options[:billing_address][:title]
+        post[:Company] = options[:billing_address][:company]
+        post[:JobDesc] = options[:billing_address][:job_desc]
+        post[:Email] = options[:billing_address][:email] || options[:email]
+        post[:URL] = options[:billing_address][:url]
+        post[:Comments] = options[:description]
       end
 
       def add_invoice(post, options)
@@ -139,7 +139,7 @@ module ActiveMerchant #:nodoc:
       # add credit card details to be stored by eway. NOTE eway requires "title" field
       def add_creditcard(post, creditcard)
         post[:CCNumber] = creditcard.number
-        post[:CCExpiryMonth]  = sprintf('%.2i', creditcard.month)
+        post[:CCExpiryMonth] = sprintf('%.2i', creditcard.month)
         post[:CCExpiryYear] = sprintf('%.4i', creditcard.year)[-2..-1]
         post[:CCNameOnCard] = creditcard.name
         post[:FirstName] = creditcard.first_name
@@ -150,24 +150,24 @@ module ActiveMerchant #:nodoc:
         reply = {}
         xml = REXML::Document.new(body)
         if root = REXML::XPath.first(xml, '//soap:Fault') then
-          reply=parse_fault(root)
+          reply = parse_fault(root)
         else
           if root = REXML::XPath.first(xml, '//ProcessPaymentResponse/ewayResponse') then
             # Successful payment
-            reply=parse_purchase(root)
+            reply = parse_purchase(root)
           else
             if root = REXML::XPath.first(xml, '//QueryCustomerResult') then
-              reply=parse_query_customer(root)
+              reply = parse_query_customer(root)
             else
               if root = REXML::XPath.first(xml, '//CreateCustomerResult') then
-                reply[:message]='OK'
-                reply[:CreateCustomerResult]=root.text
-                reply[:success]=true
+                reply[:message] = 'OK'
+                reply[:CreateCustomerResult] = root.text
+                reply[:success] = true
               else
                 if root = REXML::XPath.first(xml, '//UpdateCustomerResult') then
                   if root.text.casecmp('true').zero? then
-                    reply[:message]='OK'
-                    reply[:success]=true
+                    reply[:message] = 'OK'
+                    reply[:success] = true
                   else
                     # ERROR: This state should never occur. If there is a problem,
                     #        a soap:Fault will be returned. The presence of this
@@ -187,29 +187,29 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse_fault(node)
-        reply={}
-        reply[:message]=REXML::XPath.first(node, '//soap:Reason/soap:Text').text
-        reply[:success]=false
+        reply = {}
+        reply[:message] = REXML::XPath.first(node, '//soap:Reason/soap:Text').text
+        reply[:success] = false
         reply
       end
 
       def parse_purchase(node)
-        reply={}
-        reply[:message]=REXML::XPath.first(node, '//ewayTrxnError').text
-        reply[:success]=(REXML::XPath.first(node, '//ewayTrxnStatus').text == 'True')
-        reply[:auth_code]=REXML::XPath.first(node, '//ewayAuthCode').text
-        reply[:transaction_number]=REXML::XPath.first(node, '//ewayTrxnNumber').text
+        reply = {}
+        reply[:message] = REXML::XPath.first(node, '//ewayTrxnError').text
+        reply[:success] = (REXML::XPath.first(node, '//ewayTrxnStatus').text == 'True')
+        reply[:auth_code] = REXML::XPath.first(node, '//ewayAuthCode').text
+        reply[:transaction_number] = REXML::XPath.first(node, '//ewayTrxnNumber').text
         reply
       end
 
       def parse_query_customer(node)
-        reply={}
-        reply[:message]='OK'
-        reply[:success]=true
-        reply[:CCNumber]=REXML::XPath.first(node, '//CCNumber').text
-        reply[:CCName]=REXML::XPath.first(node, '//CCName').text
-        reply[:CCExpiryMonth]=REXML::XPath.first(node, '//CCExpiryMonth').text
-        reply[:CCExpiryYear]=REXML::XPath.first(node, '//CCExpiryYear').text
+        reply = {}
+        reply[:message] = 'OK'
+        reply[:success] = true
+        reply[:CCNumber] = REXML::XPath.first(node, '//CCNumber').text
+        reply[:CCName] = REXML::XPath.first(node, '//CCName').text
+        reply[:CCExpiryMonth] = REXML::XPath.first(node, '//CCExpiryMonth').text
+        reply[:CCExpiryYear] = REXML::XPath.first(node, '//CCExpiryYear').text
         reply
       end
 
@@ -223,8 +223,8 @@ module ActiveMerchant #:nodoc:
         response = parse(raw)
 
         EwayResponse.new(response[:success], response[:message], response,
-          :test => test?,
-          :authorization => response[:auth_code]
+          test: test?,
+          authorization: response[:auth_code]
         )
       end
 
@@ -242,7 +242,7 @@ module ActiveMerchant #:nodoc:
                  default_customer_fields.merge(arguments)
                end
 
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
         xml.instruct!
         xml.tag! 'soap12:Envelope', {'xmlns:xsi' => 'http://www.w3.org/2001/XMLSchema-instance', 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema', 'xmlns:soap12' => 'http://www.w3.org/2003/05/soap-envelope'} do
           xml.tag! 'soap12:Header' do
@@ -264,17 +264,17 @@ module ActiveMerchant #:nodoc:
       end
 
       def default_customer_fields
-        hash={}
+        hash = {}
         %w(CustomerRef Title FirstName LastName Company JobDesc Email Address Suburb State PostCode Country Phone Mobile Fax URL Comments CCNumber CCNameOnCard CCExpiryMonth CCExpiryYear).each do |field|
-          hash[field.to_sym]=''
+          hash[field.to_sym] = ''
         end
         return hash
       end
 
       def default_payment_fields
-        hash={}
+        hash = {}
         %w(managedCustomerID amount invoiceReference invoiceDescription).each do |field|
-          hash[field.to_sym]=''
+          hash[field.to_sym] = ''
         end
         return hash
       end

data/lib/active_merchant/billing/gateways/eway_rapid.rb

@@ -232,7 +232,7 @@ module ActiveMerchant #:nodoc:
         params[key] = {}
 
         add_name_and_email(params[key], options[:shipping_address], options[:email])
-        add_address(params[key], options[:shipping_address], {:skip_company => true})
+        add_address(params[key], options[:shipping_address], {skip_company: true})
       end
 
       def add_name_and_email(params, address, email, payment_method = nil)
@@ -304,13 +304,13 @@ module ActiveMerchant #:nodoc:
           succeeded,
           message_from(succeeded, raw),
           raw,
-          :authorization => authorization_from(raw),
-          :test => test?,
-          :avs_result => avs_result_from(raw),
-          :cvv_result => cvv_result_from(raw)
+          authorization: authorization_from(raw),
+          test: test?,
+          avs_result: avs_result_from(raw),
+          cvv_result: cvv_result_from(raw)
         )
       rescue ActiveMerchant::ResponseError => e
-        return ActiveMerchant::Billing::Response.new(false, e.response.message, {:status_code => e.response.code}, :test => test?)
+        return ActiveMerchant::Billing::Response.new(false, e.response.message, {status_code: e.response.code}, test: test?)
       end
 
       def parse(data)
@@ -365,7 +365,7 @@ module ActiveMerchant #:nodoc:
           else
             'I'
           end
-        {:code => code}
+        {code: code}
       end
 
       def cvv_result_from(response)

data/lib/active_merchant/billing/gateways/exact.rb

@@ -5,13 +5,13 @@ module ActiveMerchant #:nodoc:
 
       API_VERSION = '8.5'
 
-      TEST_LOGINS = [{:login => 'A00049-01', :password => 'test1'},
-                     {:login => 'A00427-01', :password => 'testus'}]
+      TEST_LOGINS = [{login: 'A00049-01', password: 'test1'},
+                     {login: 'A00427-01', password: 'testus'}]
 
-      TRANSACTIONS = { :sale          => '00',
-                       :authorization => '01',
-                       :capture       => '32',
-                       :credit        => '34' }
+      TRANSACTIONS = { sale: '00',
+                       authorization: '01',
+                       capture: '32',
+                       credit: '34' }
 
       ENVELOPE_NAMESPACES = { 'xmlns:xsd' => 'http://www.w3.org/2001/XMLSchema',
                               'xmlns:env' => 'http://schemas.xmlsoap.org/soap/envelope/',
@@ -159,15 +159,15 @@ module ActiveMerchant #:nodoc:
         response = parse(ssl_post(self.live_url, build_request(action, request), POST_HEADERS))
 
         Response.new(successful?(response), message_from(response), response,
-          :test => test?,
-          :authorization => authorization_from(response),
-          :avs_result => { :code => response[:avs] },
-          :cvv_result => response[:cvv2]
+          test: test?,
+          authorization: authorization_from(response),
+          avs_result: { code: response[:avs] },
+          cvv_result: response[:cvv2]
         )
       rescue ResponseError => e
         case e.response.code
         when '401'
-          return Response.new(false, "Invalid Login: #{e.response.body}", {}, :test => test?)
+          return Response.new(false, "Invalid Login: #{e.response.body}", {}, test: test?)
         else
           raise
         end