activemerchant 1.102.0 → 1.103.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 676020bb24cc6d3a8b17a3d2ed035398803a436371c3c6a368ab3b49104d618e
-  data.tar.gz: 5a46ff06616a3b914c599d7da7455f0a4dc1b7579907a03a2c51463d6c81a8ef
+  metadata.gz: a51e307707d9ffa9cd0d32779623b7095ea9af27f16078de9736be65fc8c0090
+  data.tar.gz: 27b16b69f6bb974795ddc1fae4d924257bee5c0620d0ab009b771b107d59be24
 SHA512:
-  metadata.gz: b06c1bd98e25faed372c68877041f127a64b21021f88ec102dd0910d976eeaba2f19a4414a5b9d122fb5a92f64489d34e961652ad1a7aac6f85e802ada89d1cf
-  data.tar.gz: 7cb0c86d44cbc7d23ea441aba7dc90ec58d7d5be2d972dd63c0b3545c4372c752d7fc068a173f0d26532f4cede6a97dcecae8fd86c40f17551c6017a9c07db1c
+  metadata.gz: 6d0e03c0a615dabf2ef0299baaac647eabe906f08bfbb3343e545d3a7ee1390678a963a4a1433b24cb478264b7ad260a30c947d827e91e835f6892ca31644399
+  data.tar.gz: db9a355a166614c1ebe4b018ba1a5634448bd5be14aa34e9db55837d529b1aad4f10994cf476793e38619fb7d8c7785ab014b5dac4d2a33bcea3720da8a98689

data/CHANGELOG

@@ -2,6 +2,18 @@
 
 == HEAD
 
+== Version 1.103.0 (Dec 2, 2019)
+* Quickbooks: Mark transactions that returned `AuthorizationFailed` as failures [britth] #3447
+* Credorax: Add referral CFT transactions [leila-alderman] #3432
+* DLocal: Updates for version 2.1 [molbrown] #3449
+* CyberSource: Send MDD on capture [leila-alderman] #3453
+* Ixopay: Include extra_data gateway specific field [therufs] #3450
+* CyberSource: Fix XML error on capture [leila-alderman] #3454
+* Adyen: Add gateway specific field for splits [leila-alderman] #3448
+* Adyen: Add `unstore` and `storeToken` actions with '/Recurring' endpoint [deedeelavinder][davidsantoso] #3438
+* Barclaycard Smartpay: Add functionality to set 3DS exemptions via API [britth] #3457
+* Use null@cybersource.com when option[:email] is an empty string [pi3r] #3462
+
 == Version 1.102.0 (Nov 14, 2019)
 * Quickbooks: Make token refresh optional with allow_refresh flag [britth] #3419
 * Paymentez: Update supported countries [curiousepic] #3425

data/lib/active_merchant/billing/gateways/adyen.rb

@@ -4,10 +4,10 @@ module ActiveMerchant #:nodoc:
 
       # we recommend setting up merchant-specific endpoints.
       # https://docs.adyen.com/developers/api-manual#apiendpoints
-      self.test_url = 'https://pal-test.adyen.com/pal/servlet/Payment/'
-      self.live_url = 'https://pal-live.adyen.com/pal/servlet/Payment/'
+      self.test_url = 'https://pal-test.adyen.com/pal/servlet/'
+      self.live_url = 'https://pal-live.adyen.com/pal/servlet/'
 
-      self.supported_countries = ['AT', 'AU', 'BE', 'BG', 'BR', 'CH', 'CY', 'CZ', 'DE', 'DK', 'EE', 'ES', 'FI', 'FR', 'GB', 'GI', 'GR', 'HK', 'HU', 'IE', 'IS', 'IT', 'LI', 'LT', 'LU', 'LV', 'MC', 'MT', 'MX', 'NL', 'NO', 'PL', 'PT', 'RO', 'SE', 'SG', 'SK', 'SI', 'US']
+      self.supported_countries = %w(AT AU BE BG BR CH CY CZ DE DK EE ES FI FR GB GI GR HK HU IE IS IT LI LT LU LV MC MT MX NL NO PL PT RO SE SG SK SI US)
       self.default_currency = 'USD'
       self.currencies_without_fractions = %w(CVE DJF GNF IDR JPY KMF KRW PYG RWF UGX VND VUV XAF XOF XPF)
       self.supported_cardtypes = [:visa, :master, :american_express, :diners_club, :jcb, :dankort, :maestro, :discover, :elo, :naranja, :cabal]
@@ -17,7 +17,8 @@ module ActiveMerchant #:nodoc:
       self.homepage_url = 'https://www.adyen.com/'
       self.display_name = 'Adyen'
 
-      API_VERSION = 'v40'
+      PAYMENT_API_VERSION = 'v40'
+      RECURRING_API_VERSION = 'v30'
 
       STANDARD_ERROR_CODE_MAPPING = {
         '101' => STANDARD_ERROR_CODE[:incorrect_number],
@@ -57,6 +58,7 @@ module ActiveMerchant #:nodoc:
         add_installments(post, options) if options[:installments]
         add_3ds(post, options)
         add_3ds_authenticated_data(post, options)
+        add_splits(post, options)
         commit('authorise', post, options)
       end
 
@@ -64,6 +66,7 @@ module ActiveMerchant #:nodoc:
         post = init_post(options)
         add_invoice_for_modification(post, money, options)
         add_reference(post, authorization, options)
+        add_splits(post, options)
         commit('capture', post, options)
       end
 
@@ -71,6 +74,7 @@ module ActiveMerchant #:nodoc:
         post = init_post(options)
         add_invoice_for_modification(post, money, options)
         add_original_reference(post, authorization, options)
+        add_splits(post, options)
         commit('refund', post, options)
       end
 
@@ -98,7 +102,9 @@ module ActiveMerchant #:nodoc:
         add_recurring_contract(post, options)
         add_address(post, options)
 
-        initial_response = commit('authorise', post, options)
+        action = options[:tokenize_only] ? 'storeToken' : 'authorise'
+
+        initial_response = commit(action, post, options)
 
         if initial_response.success? && card_not_stored?(initial_response)
           unsupported_failure_response(initial_response)
@@ -107,6 +113,17 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def unstore(options={})
+        requires!(options, :shopper_reference, :recurring_detail_reference)
+        post = {}
+
+        add_shopper_reference(post, options)
+        add_merchant_account(post, options)
+        post[:recurringDetailReference] = options[:recurring_detail_reference]
+
+        commit('disable', post, options)
+      end
+
       def verify(credit_card, options={})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(0, credit_card, options) }
@@ -179,7 +196,6 @@ module ActiveMerchant #:nodoc:
         post[:telephoneNumber] = options[:billing_address][:phone] if options.dig(:billing_address, :phone)
         post[:shopperEmail] = options[:shopper_email] if options[:shopper_email]
         post[:shopperIP] = options[:shopper_ip] if options[:shopper_ip]
-        post[:shopperReference] = options[:shopper_reference] if options[:shopper_reference]
         post[:shopperStatement] = options[:shopper_statement] if options[:shopper_statement]
         post[:fraudOffset] = options[:fraud_offset] if options[:fraud_offset]
         post[:selectedBrand] = options[:selected_brand] if options[:selected_brand]
@@ -198,6 +214,7 @@ module ActiveMerchant #:nodoc:
         post[:additionalData][:RequestedTestAcquirerResponseCode] = options[:requested_test_acquirer_response_code] if options[:requested_test_acquirer_response_code] && test?
         post[:deviceFingerprint] = options[:device_fingerprint] if options[:device_fingerprint]
         add_risk_data(post, options)
+        add_shopper_reference(post, options)
       end
 
       def add_risk_data(post, options)
@@ -207,11 +224,39 @@ module ActiveMerchant #:nodoc:
         end
       end
 
+      def add_splits(post, options)
+        return unless split_data = options[:splits]
+        splits = []
+        split_data.each do |split|
+          amount = {
+            value: split['amount']['value'],
+          }
+          amount[:currency] = split['amount']['currency'] if split['amount']['currency']
+
+          split_hash = {
+            amount: amount,
+            type: split['type'],
+            reference: split['reference']
+          }
+          split_hash['account'] = split['account'] if split['account']
+          splits.push(split_hash)
+        end
+        post[:splits] = splits
+      end
+
       def add_stored_credentials(post, payment, options)
         add_shopper_interaction(post, payment, options)
         add_recurring_processing_model(post, options)
       end
 
+      def add_merchant_account(post, options)
+        post[:merchantAccount] = options[:merchant_account] || @merchant_account
+      end
+
+      def add_shopper_reference(post, options)
+        post[:shopperReference] = options[:shopper_reference] if options[:shopper_reference]
+      end
+
       def add_shopper_interaction(post, payment, options={})
         if options.dig(:stored_credential, :initial_transaction) || (payment.respond_to?(:verification_value) && payment.verification_value) || payment.is_a?(NetworkTokenizationCreditCard)
           shopper_interaction = 'Ecommerce'
@@ -401,7 +446,7 @@ module ActiveMerchant #:nodoc:
 
       def commit(action, parameters, options)
         begin
-          raw_response = ssl_post("#{url}/#{action}", post_data(action, parameters), request_headers(options))
+          raw_response = ssl_post(url(action), post_data(action, parameters), request_headers(options))
           response = parse(raw_response)
         rescue ResponseError => e
           raw_response = e.response.body
@@ -428,13 +473,18 @@ module ActiveMerchant #:nodoc:
         CVC_MAPPING[response['additionalData']['cvcResult'][0]] if response.dig('additionalData', 'cvcResult')
       end
 
-      def url
+      def endpoint(action)
+        recurring = %w(disable storeToken).include?(action)
+        recurring ? "Recurring/#{RECURRING_API_VERSION}/#{action}" : "Payment/#{PAYMENT_API_VERSION}/#{action}"
+      end
+
+      def url(action)
         if test?
-          "#{test_url}#{API_VERSION}"
+          "#{test_url}#{endpoint(action)}"
         elsif @options[:subdomain]
-          "https://#{@options[:subdomain]}-pal-live.adyenpayments.com/pal/servlet/Payment/#{API_VERSION}"
+          "https://#{@options[:subdomain]}-pal-live.adyenpayments.com/pal/servlet/#{endpoint(action)}"
         else
-          "#{live_url}#{API_VERSION}"
+          "#{live_url}#{endpoint(action)}"
         end
       end
 
@@ -459,6 +509,8 @@ module ActiveMerchant #:nodoc:
           response['response'] == "[#{action}-received]"
         when 'adjustAuthorisation'
           response['response'] == 'Authorised' || response['response'] == '[adjustAuthorisation-received]'
+        when 'storeToken'
+          response['result'] == 'Success'
         else
           false
         end
@@ -466,26 +518,29 @@ module ActiveMerchant #:nodoc:
 
       def message_from(action, response)
         return authorize_message_from(response) if action.to_s == 'authorise' || action.to_s == 'authorise3d'
-        response['response'] || response['message']
+        response['response'] || response['message'] || response['result']
       end
 
       def authorize_message_from(response)
         if response['refusalReason'] && response['additionalData'] && response['additionalData']['refusalReasonRaw']
           "#{response['refusalReason']} | #{response['additionalData']['refusalReasonRaw']}"
         else
-          response['refusalReason'] || response['resultCode'] || response['message']
+          response['refusalReason'] || response['resultCode'] || response['message'] || response['result']
         end
       end
 
       def authorization_from(action, parameters, response)
         return nil if response['pspReference'].nil?
+
         recurring = response['additionalData']['recurring.recurringDetailReference'] if response['additionalData']
+        recurring = response['recurringDetailReference'] if action == 'storeToken'
+
         "#{parameters[:originalReference]}##{response['pspReference']}##{recurring}"
       end
 
       def init_post(options = {})
         post = {}
-        post[:merchantAccount] = options[:merchant_account] || @merchant_account
+        add_merchant_account(post, options)
         post[:reference] = options[:order_id] if options[:order_id]
         post
       end

data/lib/active_merchant/billing/gateways/barclaycard_smartpay.rb

@@ -359,6 +359,12 @@ module ActiveMerchant #:nodoc:
             add_browser_info(three_ds_2_options[:browser_info], post)
             post[:threeDS2RequestData] = { deviceChannel: device_channel, notificationURL: three_ds_2_options[:notification_url] }
           end
+
+          if options.has_key?(:execute_threed)
+            post[:additionalData] ||= {}
+            post[:additionalData][:executeThreeD] = options[:execute_threed]
+            post[:additionalData][:scaExemption] = options[:sca_exemption] if options[:sca_exemption]
+          end
         else
           return unless options[:execute_threed] || options[:threed_dynamic]
           post[:browserInfo] = { userAgent: options[:user_agent], acceptHeader: options[:accept_header] }

data/lib/active_merchant/billing/gateways/credorax.rb

@@ -187,8 +187,13 @@ module ActiveMerchant #:nodoc:
         add_echo(post, options)
         add_submerchant_id(post, options)
         add_processor(post, options)
+        add_email(post, options)
 
-        commit(:refund, post)
+        if options[:referral_cft]
+          commit(:referral_cft, post)
+        else
+          commit(:refund, post)
+        end
       end
 
       def credit(amount, payment_method, options={})
@@ -372,7 +377,8 @@ module ActiveMerchant #:nodoc:
         purchase_void: '7',
         refund_void: '8',
         capture_void: '9',
-        threeds_completion: '92'
+        threeds_completion: '92',
+        referral_cft: '34'
       }
 
       def commit(action, params, reference_action = nil)

data/lib/active_merchant/billing/gateways/cyber_source.rb

@@ -288,6 +288,7 @@ module ActiveMerchant #:nodoc:
 
         xml = Builder::XmlMarkup.new :indent => 2
         add_purchase_data(xml, money, true, options)
+        add_mdd_fields(xml, options)
         add_capture_service(xml, request_id, request_token)
         add_business_rules_data(xml, authorization, options)
         add_issuer_additional_data(xml, options)
@@ -468,7 +469,7 @@ module ActiveMerchant #:nodoc:
           xml.tag! 'company',               address[:company]                 unless address[:company].blank?
           xml.tag! 'companyTaxID',          address[:companyTaxID]            unless address[:company_tax_id].blank?
           xml.tag! 'phoneNumber',           address[:phone]                   unless address[:phone].blank?
-          xml.tag! 'email',                 options[:email] || 'null@cybersource.com'
+          xml.tag! 'email',                 options[:email].presence || 'null@cybersource.com'
           xml.tag! 'ipAddress',             options[:ip]                      unless options[:ip].blank? || shipTo
           xml.tag! 'driversLicenseNumber',  options[:drivers_license_number]  unless options[:drivers_license_number].blank?
           xml.tag! 'driversLicenseState',   options[:drivers_license_state]   unless options[:drivers_license_state].blank?

data/lib/active_merchant/billing/gateways/d_local.rb

@@ -32,7 +32,7 @@ module ActiveMerchant #:nodoc:
 
       def capture(money, authorization, options={})
         post = {}
-        post[:payment_id] = authorization
+        post[:authorization_id] = authorization
         add_invoice(post, money, options) if money
         commit('capture', post, options)
       end
@@ -47,7 +47,7 @@ module ActiveMerchant #:nodoc:
 
       def void(authorization, options={})
         post = {}
-        post[:payment_id] = authorization
+        post[:authorization_id] = authorization
         commit('void', post, options)
       end
 
@@ -193,9 +193,9 @@ module ActiveMerchant #:nodoc:
         when 'refund'
           'refunds'
         when 'capture'
-          "payments/#{parameters[:payment_id]}/capture"
+          'payments'
         when 'void'
-          "payments/#{parameters[:payment_id]}/cancel"
+          "payments/#{parameters[:authorization_id]}/cancel"
         end
       end
 

data/lib/active_merchant/billing/gateways/ixopay.rb

@@ -145,6 +145,7 @@ module ActiveMerchant #:nodoc:
           xml.transactionId new_transaction_id
 
           add_customer_data(xml, options)
+          add_extra_data(xml, options[:extra_data]) if options[:extra_data]
 
           xml.amount      localized_amount(money, currency)
           xml.currency    currency
@@ -162,6 +163,7 @@ module ActiveMerchant #:nodoc:
           xml.transactionId new_transaction_id
 
           add_customer_data(xml, options)
+          add_extra_data(xml, options[:extra_data]) if options[:extra_data]
 
           xml.amount      localized_amount(money, currency)
           xml.currency    currency
@@ -174,17 +176,19 @@ module ActiveMerchant #:nodoc:
         currency = options[:currency] || currency(money)
 
         xml.refund do
-          xml.transactionId           new_transaction_id
-          xml.referenceTransactionId  authorization&.split('|')&.first
-          xml.amount                  localized_amount(money, currency)
-          xml.currency                currency
+          xml.transactionId new_transaction_id
+          add_extra_data(xml, options[:extra_data]) if options[:extra_data]
+          xml.referenceTransactionId authorization&.split('|')&.first
+          xml.amount                 localized_amount(money, currency)
+          xml.currency               currency
         end
       end
 
       def add_void(xml, authorization)
         xml.void do
-          xml.transactionId           new_transaction_id
-          xml.referenceTransactionId  authorization&.split('|')&.first
+          xml.transactionId new_transaction_id
+          add_extra_data(xml, options[:extra_data]) if options[:extra_data]
+          xml.referenceTransactionId authorization&.split('|')&.first
         end
       end
 
@@ -192,10 +196,11 @@ module ActiveMerchant #:nodoc:
         currency = options[:currency] || currency(money)
 
         xml.capture_ do
-          xml.transactionId             new_transaction_id
-          xml.referenceTransactionId    authorization&.split('|')&.first
-          xml.amount                    localized_amount(money, currency)
-          xml.currency                  currency
+          xml.transactionId new_transaction_id
+          add_extra_data(xml, options[:extra_data]) if options[:extra_data]
+          xml.referenceTransactionId authorization&.split('|')&.first
+          xml.amount                 localized_amount(money, currency)
+          xml.currency               currency
         end
       end
 
@@ -246,6 +251,12 @@ module ActiveMerchant #:nodoc:
         SecureRandom.uuid
       end
 
+      def add_extra_data(xml, extra_data)
+        extra_data.each do |k, v|
+          xml.extraData(v, key: k)
+        end
+      end
+
       def commit(request)
         url = (test? ? test_url : live_url)
 

data/lib/active_merchant/billing/gateways/quickbooks.rb

@@ -321,7 +321,7 @@ module ActiveMerchant #:nodoc:
       def success?(response)
         return FRAUD_WARNING_CODES.concat(['0']).include?(response['errors'].first['code']) if response['errors']
 
-        !['DECLINED', 'CANCELLED'].include?(response['status']) && !['AuthenticationFailed'].include?(response['code'])
+        !['DECLINED', 'CANCELLED'].include?(response['status']) && !['AuthenticationFailed', 'AuthorizationFailed'].include?(response['code'])
       end
 
       def message_from(response)
@@ -329,7 +329,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def errors_from(response)
-        response['errors'].present? ? STANDARD_ERROR_CODE_MAPPING[response['errors'].first['code']] : ''
+        if ['AuthenticationFailed', 'AuthorizationFailed'].include?(response['code'])
+          response['code']
+        else
+          response['errors'].present? ? STANDARD_ERROR_CODE_MAPPING[response['errors'].first['code']] : ''
+        end
       end
 
       def authorization_from(response, headers = {})

data/lib/active_merchant/version.rb

@@ -1,3 +1,3 @@
 module ActiveMerchant
-  VERSION = '1.102.0'
+  VERSION = '1.103.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activemerchant
 version: !ruby/object:Gem::Version
-  version: 1.102.0
+  version: 1.103.0
 platform: ruby
 authors:
 - Tobias Luetke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-14 00:00:00.000000000 Z
+date: 2019-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport