activemerchant 1.100.0 → 1.133.0

data/lib/active_merchant/billing/gateways/authorize_net_arb.rb

@@ -31,18 +31,18 @@ module ActiveMerchant #:nodoc:
 
       self.default_currency = 'USD'
 
-      self.supported_countries = ['US', 'CA', 'GB']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :diners_club, :jcb]
+      self.supported_countries = %w[US CA GB]
+      self.supported_cardtypes = %i[visa master american_express discover diners_club jcb]
       self.homepage_url = 'http://www.authorize.net/'
       self.display_name = 'Authorize.Net'
 
       AUTHORIZE_NET_ARB_NAMESPACE = 'AnetApi/xml/v1/schema/AnetApiSchema.xsd'
 
       RECURRING_ACTIONS = {
-        :create => 'ARBCreateSubscription',
-        :update => 'ARBUpdateSubscription',
-        :cancel => 'ARBCancelSubscription',
-        :status => 'ARBGetSubscriptionStatus'
+        create: 'ARBCreateSubscription',
+        update: 'ARBUpdateSubscription',
+        cancel: 'ARBCancelSubscription',
+        status: 'ARBGetSubscriptionStatus'
       }
 
       # Creates a new AuthorizeNetArbGateway
@@ -82,9 +82,9 @@ module ActiveMerchant #:nodoc:
       #   +:interval => { :unit => :months, :length => 3 }+ (REQUIRED)
       # * <tt>:duration</tt> -- A hash containing keys for the <tt>:start_date</tt> the subscription begins (also the date the
       #   initial billing occurs) and the total number of billing <tt>:occurrences</tt> or payments for the subscription. (REQUIRED)
-      def recurring(money, creditcard, options={})
+      def recurring(money, creditcard, options = {})
         requires!(options, :interval, :duration, :billing_address)
-        requires!(options[:interval], :length, [:unit, :days, :months])
+        requires!(options[:interval], :length, %i[unit days months])
         requires!(options[:duration], :start_date, :occurrences)
         requires!(options[:billing_address], :first_name, :last_name)
 
@@ -110,7 +110,7 @@ module ActiveMerchant #:nodoc:
       #
       # * <tt>:subscription_id</tt> -- A string containing the <tt>:subscription_id</tt> of the recurring payment already in place
       #   for a given credit card. (REQUIRED)
-      def update_recurring(options={})
+      def update_recurring(options = {})
         requires!(options, :subscription_id)
         request = build_recurring_request(:update, options)
         recurring_commit(:update, request)
@@ -126,7 +126,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>subscription_id</tt> -- A string containing the +subscription_id+ of the recurring payment already in place
       #   for a given credit card. (REQUIRED)
       def cancel_recurring(subscription_id)
-        request = build_recurring_request(:cancel, :subscription_id => subscription_id)
+        request = build_recurring_request(:cancel, subscription_id: subscription_id)
         recurring_commit(:cancel, request)
       end
 
@@ -139,7 +139,7 @@ module ActiveMerchant #:nodoc:
       # * <tt>subscription_id</tt> -- A string containing the +subscription_id+ of the recurring payment already in place
       #   for a given credit card. (REQUIRED)
       def status_recurring(subscription_id)
-        request = build_recurring_request(:status, :subscription_id => subscription_id)
+        request = build_recurring_request(:status, subscription_id: subscription_id)
         recurring_commit(:status, request)
       end
 
@@ -147,13 +147,11 @@ module ActiveMerchant #:nodoc:
 
       # Builds recurring billing request
       def build_recurring_request(action, options = {})
-        unless RECURRING_ACTIONS.include?(action)
-          raise StandardError, "Invalid Automated Recurring Billing Action: #{action}"
-        end
+        raise StandardError, "Invalid Automated Recurring Billing Action: #{action}" unless RECURRING_ACTIONS.include?(action)
 
-        xml = Builder::XmlMarkup.new(:indent => 2)
-        xml.instruct!(:xml, :version => '1.0', :encoding => 'utf-8')
-        xml.tag!("#{RECURRING_ACTIONS[action]}Request", :xmlns => AUTHORIZE_NET_ARB_NAMESPACE) do
+        xml = Builder::XmlMarkup.new(indent: 2)
+        xml.instruct!(:xml, version: '1.0', encoding: 'utf-8')
+        xml.tag!("#{RECURRING_ACTIONS[action]}Request", xmlns: AUTHORIZE_NET_ARB_NAMESPACE) do
           add_merchant_authentication(xml)
           # Merchant-assigned reference ID for the request
           xml.tag!('refId', options[:ref_id]) if options[:ref_id]
@@ -232,6 +230,7 @@ module ActiveMerchant #:nodoc:
       def add_interval(xml, options)
         interval = options[:interval]
         return unless interval
+
         xml.tag!('interval') do
           # The measurement of time, in association with the Interval Unit,
           # that is used to define the frequency of the billing occurrences
@@ -246,6 +245,7 @@ module ActiveMerchant #:nodoc:
       def add_duration(xml, options)
         duration = options[:duration]
         return unless duration
+
         # The date the subscription begins
         # (also the date the initial billing occurs)
         xml.tag!('startDate', duration[:start_date]) if duration[:start_date]
@@ -255,6 +255,7 @@ module ActiveMerchant #:nodoc:
 
       def add_payment_schedule(xml, options)
         return unless options[:interval] || options[:duration]
+
         xml.tag!('paymentSchedule') do
           # Contains information about the interval of time between payments
           add_interval(xml, options)
@@ -269,6 +270,7 @@ module ActiveMerchant #:nodoc:
       # Adds customer's credit card or bank account payment information
       def add_payment(xml, options)
         return unless options[:credit_card] || options[:bank_account]
+
         xml.tag!('payment') do
           # Contains the customer’s credit card information
           add_credit_card(xml, options)
@@ -283,6 +285,7 @@ module ActiveMerchant #:nodoc:
       def add_credit_card(xml, options)
         credit_card = options[:credit_card]
         return unless credit_card
+
         xml.tag!('creditCard') do
           # The credit card number used for payment of the subscription
           xml.tag!('cardNumber', credit_card.number)
@@ -297,6 +300,7 @@ module ActiveMerchant #:nodoc:
       def add_bank_account(xml, options)
         bank_account = options[:bank_account]
         return unless bank_account
+
         xml.tag!('bankAccount') do
           # The type of bank account used for payment of the subscription
           xml.tag!('accountType', bank_account[:account_type])
@@ -319,6 +323,7 @@ module ActiveMerchant #:nodoc:
       def add_order(xml, options)
         order = options[:order]
         return unless order
+
         xml.tag!('order') do
           # Merchant-assigned invoice number for the subscription (optional)
           xml.tag!('invoiceNumber', order[:invoice_number])
@@ -331,6 +336,7 @@ module ActiveMerchant #:nodoc:
       def add_customer(xml, options)
         customer = options[:customer]
         return unless customer
+
         xml.tag!('customer') do
           xml.tag!('type', customer[:type]) if customer[:type]
           xml.tag!('id', customer[:id]) if customer[:id]
@@ -346,6 +352,7 @@ module ActiveMerchant #:nodoc:
       def add_drivers_license(xml, options)
         return unless customer = options[:customer]
         return unless drivers_license = customer[:drivers_license]
+
         xml.tag!('driversLicense') do
           # The customer's driver's license number
           xml.tag!('number', drivers_license[:number])
@@ -359,6 +366,7 @@ module ActiveMerchant #:nodoc:
       # Adds address information
       def add_address(xml, container_name, address)
         return if address.blank?
+
         xml.tag!(container_name) do
           xml.tag!('firstName', address[:first_name])
           xml.tag!('lastName', address[:last_name])
@@ -386,9 +394,8 @@ module ActiveMerchant #:nodoc:
         success = response[:result_code] == 'Ok'
 
         Response.new(success, message, response,
-          :test => test_mode,
-          :authorization => response[:subscription_id]
-        )
+          test: test_mode,
+          authorization: response[:subscription_id])
       end
 
       def recurring_parse(action, xml)

data/lib/active_merchant/billing/gateways/authorize_net_cim.rb

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+
 module ActiveMerchant #:nodoc:
   module Billing #:nodoc:
     # ==== Customer Information Manager (CIM)
@@ -33,55 +34,55 @@ module ActiveMerchant #:nodoc:
       AUTHORIZE_NET_CIM_NAMESPACE = 'AnetApi/xml/v1/schema/AnetApiSchema.xsd'
 
       CIM_ACTIONS = {
-        :create_customer_profile => 'createCustomerProfile',
-        :create_customer_payment_profile => 'createCustomerPaymentProfile',
-        :create_customer_shipping_address => 'createCustomerShippingAddress',
-        :get_customer_profile => 'getCustomerProfile',
-        :get_customer_profile_ids => 'getCustomerProfileIds',
-        :get_customer_payment_profile => 'getCustomerPaymentProfile',
-        :get_customer_shipping_address => 'getCustomerShippingAddress',
-        :delete_customer_profile => 'deleteCustomerProfile',
-        :delete_customer_payment_profile => 'deleteCustomerPaymentProfile',
-        :delete_customer_shipping_address => 'deleteCustomerShippingAddress',
-        :update_customer_profile => 'updateCustomerProfile',
-        :update_customer_payment_profile => 'updateCustomerPaymentProfile',
-        :update_customer_shipping_address => 'updateCustomerShippingAddress',
-        :create_customer_profile_transaction => 'createCustomerProfileTransaction',
-        :validate_customer_payment_profile => 'validateCustomerPaymentProfile'
+        create_customer_profile: 'createCustomerProfile',
+        create_customer_payment_profile: 'createCustomerPaymentProfile',
+        create_customer_shipping_address: 'createCustomerShippingAddress',
+        get_customer_profile: 'getCustomerProfile',
+        get_customer_profile_ids: 'getCustomerProfileIds',
+        get_customer_payment_profile: 'getCustomerPaymentProfile',
+        get_customer_shipping_address: 'getCustomerShippingAddress',
+        delete_customer_profile: 'deleteCustomerProfile',
+        delete_customer_payment_profile: 'deleteCustomerPaymentProfile',
+        delete_customer_shipping_address: 'deleteCustomerShippingAddress',
+        update_customer_profile: 'updateCustomerProfile',
+        update_customer_payment_profile: 'updateCustomerPaymentProfile',
+        update_customer_shipping_address: 'updateCustomerShippingAddress',
+        create_customer_profile_transaction: 'createCustomerProfileTransaction',
+        validate_customer_payment_profile: 'validateCustomerPaymentProfile'
       }
 
       CIM_TRANSACTION_TYPES = {
-        :auth_capture => 'profileTransAuthCapture',
-        :auth_only => 'profileTransAuthOnly',
-        :capture_only => 'profileTransCaptureOnly',
-        :prior_auth_capture => 'profileTransPriorAuthCapture',
-        :refund => 'profileTransRefund',
-        :void => 'profileTransVoid'
+        auth_capture: 'profileTransAuthCapture',
+        auth_only: 'profileTransAuthOnly',
+        capture_only: 'profileTransCaptureOnly',
+        prior_auth_capture: 'profileTransPriorAuthCapture',
+        refund: 'profileTransRefund',
+        void: 'profileTransVoid'
       }
 
       CIM_VALIDATION_MODES = {
-        :none => 'none',
-        :test => 'testMode',
-        :live => 'liveMode',
-        :old => 'oldLiveMode'
+        none: 'none',
+        test: 'testMode',
+        live: 'liveMode',
+        old: 'oldLiveMode'
       }
 
       BANK_ACCOUNT_TYPES = {
-        :checking => 'checking',
-        :savings => 'savings',
-        :business_checking => 'businessChecking'
+        checking: 'checking',
+        savings: 'savings',
+        business_checking: 'businessChecking'
       }
 
       ECHECK_TYPES = {
-        :ccd => 'CCD',
-        :ppd => 'PPD',
-        :web => 'WEB'
+        ccd: 'CCD',
+        ppd: 'PPD',
+        web: 'WEB'
       }
 
       self.homepage_url = 'http://www.authorize.net/'
       self.display_name = 'Authorize.Net CIM'
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
 
       # Creates a new AuthorizeNetCimGateway
       #
@@ -485,13 +486,11 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_request(action, options = {})
-        unless CIM_ACTIONS.include?(action)
-          raise StandardError, "Invalid Customer Information Manager Action: #{action}"
-        end
+        raise StandardError, "Invalid Customer Information Manager Action: #{action}" unless CIM_ACTIONS.include?(action)
 
-        xml = Builder::XmlMarkup.new(:indent => 2)
-        xml.instruct!(:xml, :version => '1.0', :encoding => 'utf-8')
-        xml.tag!("#{CIM_ACTIONS[action]}Request", :xmlns => AUTHORIZE_NET_CIM_NAMESPACE) do
+        xml = Builder::XmlMarkup.new(indent: 2)
+        xml.instruct!(:xml, version: '1.0', encoding: 'utf-8')
+        xml.tag!("#{CIM_ACTIONS[action]}Request", xmlns: AUTHORIZE_NET_CIM_NAMESPACE) do
           add_merchant_authentication(xml)
           # Merchant-assigned reference ID for the request
           xml.tag!('refId', options[:ref_id]) if options[:ref_id]
@@ -564,6 +563,8 @@ module ActiveMerchant #:nodoc:
 
       def build_get_customer_profile_request(xml, options)
         xml.tag!('customerProfileId', options[:customer_profile_id])
+        xml.tag!('unmaskExpirationDate', options[:unmask_expiration_date]) if options[:unmask_expiration_date]
+        xml.tag!('includeIssuerInfo', options[:include_issuer_info]) if options[:include_issuer_info]
         xml.target!
       end
 
@@ -575,6 +576,7 @@ module ActiveMerchant #:nodoc:
         xml.tag!('customerProfileId', options[:customer_profile_id])
         xml.tag!('customerPaymentProfileId', options[:customer_payment_profile_id])
         xml.tag!('unmaskExpirationDate', options[:unmask_expiration_date]) if options[:unmask_expiration_date]
+        xml.tag!('includeIssuerInfo', options[:include_issuer_info]) if options[:include_issuer_info]
         xml.target!
       end
 
@@ -657,9 +659,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def add_transaction(xml, transaction)
-        unless CIM_TRANSACTION_TYPES.include?(transaction[:type])
-          raise StandardError, "Invalid Customer Information Manager Transaction Type: #{transaction[:type]}"
-        end
+        raise StandardError, "Invalid Customer Information Manager Transaction Type: #{transaction[:type]}" unless CIM_TRANSACTION_TYPES.include?(transaction[:type])
 
         xml.tag!('transaction') do
           xml.tag!(CIM_TRANSACTION_TYPES[transaction[:type]]) do
@@ -695,12 +695,10 @@ module ActiveMerchant #:nodoc:
               add_order(xml, transaction[:order]) if transaction[:order].present?
 
             end
-            if [:auth_capture, :auth_only, :capture_only].include?(transaction[:type])
+            if %i[auth_capture auth_only capture_only].include?(transaction[:type])
               xml.tag!('recurringBilling', transaction[:recurring_billing]) if transaction.has_key?(:recurring_billing)
             end
-            unless [:void, :refund, :prior_auth_capture].include?(transaction[:type])
-              tag_unless_blank(xml, 'cardCode', transaction[:card_code])
-            end
+            tag_unless_blank(xml, 'cardCode', transaction[:card_code]) unless %i[void refund prior_auth_capture].include?(transaction[:type])
           end
         end
       end
@@ -797,6 +795,7 @@ module ActiveMerchant #:nodoc:
       # when the payment method is credit card.
       def add_credit_card(xml, credit_card)
         return unless credit_card
+
         xml.tag!('creditCard') do
           # The credit card number used for payment of the subscription
           xml.tag!('cardNumber', full_or_masked_card_number(credit_card.number))
@@ -857,7 +856,7 @@ module ActiveMerchant #:nodoc:
 
         response_params = parse(action, xml)
 
-        message_element= response_params['messages']['message']
+        message_element = response_params['messages']['message']
         first_error = message_element.is_a?(Array) ? message_element.first : message_element
         message = first_error['text']
         test_mode = @options[:test_requests] || message =~ /Test Mode/
@@ -883,7 +882,7 @@ module ActiveMerchant #:nodoc:
 
       def parse_direct_response(params)
         delimiter = @options[:delimiter] || ','
-        direct_response = {'raw' => params}
+        direct_response = { 'raw' => params }
         direct_response_fields = params.split(delimiter)
         direct_response.merge(
           {
@@ -933,7 +932,7 @@ module ActiveMerchant #:nodoc:
             'card_type' => direct_response_fields[51] || '',
             'split_tender_id' => direct_response_fields[52] || '',
             'requested_amount' => direct_response_fields[53] || '',
-            'balance_on_card' => direct_response_fields[54] || '',
+            'balance_on_card' => direct_response_fields[54] || ''
           }
         )
       end
@@ -942,9 +941,7 @@ module ActiveMerchant #:nodoc:
         xml = REXML::Document.new(xml)
         root = REXML::XPath.first(xml, "//#{CIM_ACTIONS[action]}Response") ||
                REXML::XPath.first(xml, '//ErrorResponse')
-        if root
-          response = parse_element(root)
-        end
+        response = parse_element(root) if root
 
         response
       end

data/lib/active_merchant/billing/gateways/axcessms.rb

@@ -8,7 +8,7 @@ module ActiveMerchant #:nodoc:
                                     GI GR HR HU IE IL IM IS IT LI LT LU LV MC MT MX NL
                                     NO PL PT RO RU SE SI SK TR US VA)
 
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover, :jcb, :maestro]
+      self.supported_cardtypes = %i[visa master american_express discover jcb maestro]
 
       self.homepage_url = 'http://www.axcessms.com/'
       self.display_name = 'Axcess MS'
@@ -23,33 +23,33 @@ module ActiveMerchant #:nodoc:
       PAYMENT_CODE_REFUND = 'CC.RF'
       PAYMENT_CODE_REBILL = 'CC.RB'
 
-      def initialize(options={})
+      def initialize(options = {})
         requires!(options, :sender, :login, :password, :channel)
         super
       end
 
-      def purchase(money, payment, options={})
+      def purchase(money, payment, options = {})
         payment_code = payment.respond_to?(:number) ? PAYMENT_CODE_DEBIT : PAYMENT_CODE_REBILL
         commit(payment_code, money, payment, options)
       end
 
-      def authorize(money, authorization, options={})
+      def authorize(money, authorization, options = {})
         commit(PAYMENT_CODE_PREAUTHORIZATION, money, authorization, options)
       end
 
-      def capture(money, authorization, options={})
+      def capture(money, authorization, options = {})
         commit(PAYMENT_CODE_CAPTURE, money, authorization, options)
       end
 
-      def refund(money, authorization, options={})
+      def refund(money, authorization, options = {})
         commit(PAYMENT_CODE_REFUND, money, authorization, options)
       end
 
-      def void(authorization, options={})
+      def void(authorization, options = {})
         commit(PAYMENT_CODE_REVERSAL, nil, authorization, options)
       end
 
-      def verify(credit_card, options={})
+      def verify(credit_card, options = {})
         MultiResponse.run(:use_first_response) do |r|
           r.process { authorize(100, credit_card, options) }
           r.process(:ignore_result) { void(r.authorization, options) }
@@ -72,9 +72,8 @@ module ActiveMerchant #:nodoc:
         authorization = response[:unique_id]
 
         Response.new(success, message, response,
-          :authorization => authorization,
-          :test => (response[:mode] != 'LIVE')
-        )
+          authorization: authorization,
+          test: (response[:mode] != 'LIVE'))
       end
 
       def parse(body)
@@ -93,9 +92,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def parse_element(response, node)
-        if node.has_attributes?
-          node.attributes.each { |name, value| response["#{node.name}_#{name}".underscore.to_sym] = value }
-        end
+        node.attributes.each { |name, value| response["#{node.name}_#{name}".underscore.to_sym] = value } if node.has_attributes?
 
         if node.has_elements?
           node.elements.each { |element| parse_element(response, element) }
@@ -105,7 +102,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def build_request(payment_code, money, payment, options)
-        xml = Builder::XmlMarkup.new :indent => 2
+        xml = Builder::XmlMarkup.new indent: 2
         xml.instruct!
         xml.tag! 'Request', 'version' => API_VERSION do
           xml.tag! 'Header' do
@@ -168,6 +165,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(xml, address)
         raise ArgumentError.new('Address is required') unless address
+
         xml.tag! 'Address' do
           xml.tag! 'Street', "#{address[:address1]} #{address[:address2]}".strip
           xml.tag! 'City', address[:city]

data/lib/active_merchant/billing/gateways/balanced.rb

@@ -22,7 +22,7 @@ module ActiveMerchant #:nodoc:
       self.live_url = 'https://api.balancedpayments.com'
 
       self.supported_countries = ['US']
-      self.supported_cardtypes = [:visa, :master, :american_express, :discover]
+      self.supported_cardtypes = %i[visa master american_express discover]
       self.homepage_url = 'https://www.balancedpayments.com/'
       self.display_name = 'Balanced'
       self.money_format = :cents
@@ -44,12 +44,13 @@ module ActiveMerchant #:nodoc:
         add_common_params(post, options)
 
         MultiResponse.run do |r|
-          identifier = if(payment_method.respond_to?(:number))
-                         r.process { store(payment_method, options) }
-                         r.authorization
-                       else
-                         payment_method
-          end
+          identifier =
+            if payment_method.respond_to?(:number)
+              r.process { store(payment_method, options) }
+              r.authorization
+            else
+              payment_method
+            end
           r.process { commit('debits', "cards/#{card_identifier_from(identifier)}/debits", post) }
         end
       end
@@ -61,12 +62,13 @@ module ActiveMerchant #:nodoc:
         add_common_params(post, options)
 
         MultiResponse.run do |r|
-          identifier = if(payment_method.respond_to?(:number))
-                         r.process { store(payment_method, options) }
-                         r.authorization
-                       else
-                         payment_method
-          end
+          identifier =
+            if payment_method.respond_to?(:number)
+              r.process { store(payment_method, options) }
+              r.authorization
+            else
+              payment_method
+            end
           r.process { commit('card_holds', "cards/#{card_identifier_from(identifier)}/card_holds", post) }
         end
       end
@@ -97,7 +99,7 @@ module ActiveMerchant #:nodoc:
         commit('refunds', "debits/#{reference_identifier_from(identifier)}/refunds", post)
       end
 
-      def store(credit_card, options={})
+      def store(credit_card, options = {})
         post = {}
 
         post[:number] = credit_card.number
@@ -137,7 +139,7 @@ module ActiveMerchant #:nodoc:
 
       def add_address(post, options)
         address = (options[:billing_address] || options[:address])
-        if(address && address[:zip].present?)
+        if address && address[:zip].present?
           post[:address] = {}
           post[:address][:line1] = address[:address1] if address[:address1]
           post[:address][:line2] = address[:address2] if address[:address2]
@@ -154,18 +156,22 @@ module ActiveMerchant #:nodoc:
         post[:meta] = options[:meta]
       end
 
-      def commit(entity_name, path, post, method=:post)
-        raw_response = begin
-          parse(ssl_request(
-            method,
-            live_url + "/#{path}",
-            post_data(post),
-            headers
-          ))
-        rescue ResponseError => e
-          raise unless(e.response.code.to_s =~ /4\d\d/)
-          parse(e.response.body)
-        end
+      def commit(entity_name, path, post, method = :post)
+        raw_response =
+          begin
+            parse(
+              ssl_request(
+                method,
+                live_url + "/#{path}",
+                post_data(post),
+                headers
+              )
+            )
+          rescue ResponseError => e
+            raise unless e.response.code.to_s =~ /4\d\d/
+
+            parse(e.response.body)
+          end
 
         Response.new(
           success_from(entity_name, raw_response),
@@ -178,13 +184,13 @@ module ActiveMerchant #:nodoc:
 
       def success_from(entity_name, raw_response)
         entity = (raw_response[entity_name] || []).first
-        if(!entity)
+        if !entity
           false
-        elsif((entity_name == 'refunds') && entity.include?('status'))
+        elsif (entity_name == 'refunds') && entity.include?('status')
           %w(succeeded pending).include?(entity['status'])
-        elsif(entity.include?('status'))
+        elsif entity.include?('status')
           (entity['status'] == 'succeeded')
-        elsif(entity_name == 'cards')
+        elsif entity_name == 'cards'
           !!entity['id']
         else
           false
@@ -192,7 +198,7 @@ module ActiveMerchant #:nodoc:
       end
 
       def message_from(raw_response)
-        if(raw_response['errors'])
+        if raw_response['errors']
           error = raw_response['errors'].first
           (error['additional'] || error['message'] || error['description'])
         else
@@ -222,6 +228,7 @@ module ActiveMerchant #:nodoc:
 
         params.map do |key, value|
           next if value.blank?
+
           if value.is_a?(Hash)
             h = {}
             value.each do |k, v|
@@ -245,10 +252,10 @@ module ActiveMerchant #:nodoc:
         )
 
         {
-            'Authorization' => 'Basic ' + Base64.encode64(@options[:login].to_s + ':').strip,
-            'User-Agent' => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
-            'Accept' => 'application/vnd.api+json;revision=1.1',
-            'X-Balanced-User-Agent' => @@ua,
+          'Authorization' => 'Basic ' + Base64.encode64(@options[:login].to_s + ':').strip,
+          'User-Agent' => "Balanced/v1.1 ActiveMerchantBindings/#{ActiveMerchant::VERSION}",
+          'Accept' => 'application/vnd.api+json;revision=1.1',
+          'X-Balanced-User-Agent' => @@ua
         }
       end
     end