activematrix 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1f24e67640b140aef30d970e2ca17366a860914fa34dedb4f6879b84259fb43
-  data.tar.gz: ab62b7257d5bbb8c29738005ffd2443e96f5837a7a07f0b7263a1c9942bad6ff
+  metadata.gz: 5f0db6dac569a30cc870826d01a99877b7f565c70c91807d3e6060dc07af8a9b
+  data.tar.gz: db8b7398c33b5218e53e46110279854ea8e919315d2c40f70641075765a7f3fd
 SHA512:
-  metadata.gz: 01c30a4813a0ba61fc39ce2dd920dce535ca0de65154f48e635598268ad9480857376363b63441203c7e0d6abe62af7b2580ea74dff8b5853a3a5afc4712381c
-  data.tar.gz: 96f2c51f3f6b70df680ca90a8f120abe15675f341c706e99286e728d910c9db8fd4c84a53880cfe178cc794d0472ab3bfca856e2a8caa6c1d3112767dd63b1d4
+  metadata.gz: 21bd2769dcce98268e832a2ba4479f38e48e567598c41ab1fc0c18aac73ca448e3805cdc266a4db1b126f3b146e8e2fba70dcf159d635d671f3a39b8e8c73c14
+  data.tar.gz: edd3589aa53ded85318976e2cedddcba921c187cf831373a764aebc3b190cb65d84a4dcd27e659ec21daecda2b63a4485d87d6975151cc4944aba88771a770f3

data/lib/active_matrix/{util/account_data_cache.rb → account_data_cache.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-module ActiveMatrix::Util
+module ActiveMatrix
   class AccountDataCache
     extend ActiveMatrix::Extensions
     include Enumerable
@@ -26,8 +26,6 @@ module ActiveMatrix::Util
 
     def reload!
       # Clear all cache entries for this account data
-      return unless cache_available?
-
       if room
         cache.delete_matched("activematrix:account_data:#{client.mxid}:room:#{room.id}:*")
       else
@@ -48,7 +46,7 @@ module ActiveMatrix::Util
     end
 
     def key?(key)
-      cache_available? && cache.exist?(cache_key(key))
+      cache.exist?(cache_key(key))
     end
 
     def each(live: false)
@@ -63,7 +61,7 @@ module ActiveMatrix::Util
       else
         client.api.set_account_data(client.mxid, key, {})
       end
-      cache.delete(cache_key(key)) if cache_available?
+      cache.delete(cache_key(key))
     end
 
     def [](key)
@@ -72,8 +70,6 @@ module ActiveMatrix::Util
       # Track the key whenever it's accessed
       @tracked_keys.add(key)
 
-      return fetch_account_data(key) unless cache_available?
-
       cache.fetch(cache_key(key), expires_in: @cache_time) do
         fetch_account_data(key)
       end
@@ -98,14 +94,14 @@ module ActiveMatrix::Util
       end
 
       @tracked_keys.add(key)
-      cache.write(cache_key(key), value, expires_in: @cache_time) if cache_available?
+      cache.write(cache_key(key), value, expires_in: @cache_time)
     end
 
     # Write data without making API call (for sync responses)
     def write(key, value)
       key = key.to_s unless key.is_a? String
       @tracked_keys.add(key)
-      cache.write(cache_key(key), value, expires_in: @cache_time) if cache_available?
+      cache.write(cache_key(key), value, expires_in: @cache_time)
     end
 
     private
@@ -118,10 +114,6 @@ module ActiveMatrix::Util
       end
     end
 
-    def cache_available?
-      defined?(::Rails) && ::Rails.respond_to?(:cache) && ::Rails.cache
-    end
-
     def cache
       ::Rails.cache
     end

data/lib/active_matrix/agent_manager.rb

@@ -233,7 +233,7 @@ module ActiveMatrix
     end
 
     def check_agent_health
-      @registry.all.each do |entry|
+      @registry.find_each do |entry|
         agent = entry[:record]
         thread = entry[:thread]
 
@@ -267,7 +267,7 @@ module ActiveMatrix
       %w[INT TERM].each do |signal|
         Signal.trap(signal) do
           Thread.new { stop_all }.join
-          exit
+          exit # rubocop:disable Rails/Exit
         end
       end
     end

data/lib/active_matrix/agent_registry.rb

@@ -56,12 +56,12 @@ module ActiveMatrix
 
     # Get all agent records
     def all_records
-      @agents.values.map { |entry| entry[:record] }
+      @agents.values.pluck(:record)
     end
 
     # Get all bot instances
     def all_instances
-      @agents.values.map { |entry| entry[:instance] }
+      @agents.values.pluck(:instance)
     end
 
     # Check if an agent is running

data/lib/active_matrix/api.rb

@@ -46,7 +46,7 @@ module ActiveMatrix
       raise ArgumentError, 'Homeserver URL must be String or URI' unless @homeserver.is_a?(String) || @homeserver.is_a?(URI)
 
       @homeserver = URI.parse("#{'https://' unless @homeserver.start_with? 'http'}#{@homeserver}") unless @homeserver.is_a? URI
-      @homeserver.path.gsub!(/\/?_matrix\/?/, '') if @homeserver.path =~ /_matrix\/?$/
+      @homeserver.path.gsub!(/\/?_matrix\/?/, '') if /_matrix\/?$/.match?(@homeserver.path)
       raise ArgumentError, 'Please use the base URL for your HS (without /_matrix/)' if @homeserver.path.include? '/_matrix/'
 
       @proxy_uri = params.fetch(:proxy_uri, nil)
@@ -101,7 +101,7 @@ module ActiveMatrix
       logger = ActiveMatrix.logger
       logger.debug "Resolving #{domain}"
 
-      if !port.nil? && !port.empty?
+      if port.present?
         # If the domain is fully qualified according to Matrix (FQDN and port) then skip discovery
         target_uri = URI("https://#{domain}:#{port}")
       elsif target == :server
@@ -283,7 +283,7 @@ module ActiveMatrix
       url = homeserver.dup.tap do |u|
         u.path = api_to_path(api) + path
         u.query = [u.query, URI.encode_www_form(options.fetch(:query))].flatten.compact.join('&') if options[:query]
-        u.query = nil if u.query.nil? || u.query.empty?
+        u.query = nil if u.query.blank?
       end
 
       failures = 0
@@ -299,9 +299,9 @@ module ActiveMatrix
         loc_http = http
         perform_request = proc do
           @inflight << loc_http
-          dur_start = Time.now
+          dur_start = Time.zone.now
           response = loc_http.request req_obj
-          dur_end = Time.now
+          dur_end = Time.zone.now
           duration = dur_end - dur_start
         rescue EOFError
           logger.error 'Socket closed unexpectedly'

data/lib/active_matrix/bot/base.rb

@@ -130,9 +130,7 @@ module ActiveMatrix::Bot
     end
 
     # Access settings defined with Base.set
-    def settings
-      self.class.settings
-    end
+    delegate :settings, to: :class
 
     # Access settings defined with Base.set
     def self.settings
@@ -255,7 +253,7 @@ module ActiveMatrix::Bot
       #   Can use :DM, :Admin, :Mod
       # @option params
       def command(command, desc: nil, notes: nil, only: nil, **params, &)
-        args = params[:args] || convert_to_lambda(&).parameters.map do |type, name|
+        args = params[:args] || convert_to_lambda(&).parameters.filter_map do |type, name|
           case type
           when :req
             name.to_s.upcase
@@ -264,7 +262,7 @@ module ActiveMatrix::Bot
           when :rest
             "[#{name.to_s.upcase}...]"
           end
-        end.compact.join(' ')
+        end.join(' ')
 
         logger.debug "Registering command #{command} with args #{args}"
 
@@ -435,7 +433,7 @@ module ActiveMatrix::Bot
       end
 
       def start_bot(bot_settings, &block)
-        cl = if homeserver =~ %r{^https?://}
+        cl = if %r{^https?://}.match?(homeserver)
                ActiveMatrix::Client.new homeserver
              else
                ActiveMatrix::Client.new_for_domain homeserver
@@ -652,7 +650,7 @@ module ActiveMatrix::Bot
       logger.error "#{e.class} when handling #{event[:type]}: #{e}\n#{e.backtrace[0, 10].join("\n")}"
       room.send_notice("Failed to handle event of type #{event[:type]} - #{e}.")
     rescue StandardError => e
-      puts e, e.backtrace if settings.respond_to?(:testing?) && settings.testing?
+      Rails.logger.debug e, e.backtrace if settings.respond_to?(:testing?) && settings.testing?
       logger.error "#{e.class} when handling #{event[:type]}: #{e}\n#{e.backtrace[0, 10].join("\n")}"
       room.send_notice("Failed to handle event of type #{event[:type]} - #{e}.\nMore information is available in the bot logs")
     ensure
@@ -718,7 +716,7 @@ module ActiveMatrix::Bot
       logger.error "#{e.class} when handling #{settings.command_prefix}#{command}: #{e}\n#{e.backtrace[0, 10].join("\n")}"
       room.send_notice("Failed to handle #{command} - #{e}.")
     rescue StandardError => e
-      puts e, e.backtrace if settings.respond_to?(:testing?) && settings.testing?
+      Rails.logger.debug e, e.backtrace if settings.respond_to?(:testing?) && settings.testing?
       logger.error "#{e.class} when handling #{settings.command_prefix}#{command}: #{e}\n#{e.backtrace[0, 10].join("\n")}"
       room.send_notice("Failed to handle #{command} - #{e}.\nMore information is available in the bot logs")
     ensure

data/lib/active_matrix/bot.rb

@@ -1,7 +1,48 @@
 # frozen_string_literal: true
 
+require 'optparse'
+
 module ActiveMatrix
-  # Namespace module for Bot framework
   module Bot
+    PARAMS_CONFIG = {} # rubocop:disable Style/MutableConstant Intended
+
+    class << self
+      def parse_arguments!
+        parser = OptionParser.new do |op|
+          op.on('-s homeserver', 'Specify homeserver') { |val| PARAMS_CONFIG[:homeserver] = val }
+
+          op.on('-T token', 'Token') { |val| PARAMS_CONFIG[:access_token] = val }
+          op.on('-U username', 'Username') { |val| PARAMS_CONFIG[:username] = val }
+          op.on('-P password', 'Password') { |val| PARAMS_CONFIG[:password] = val }
+
+          op.on('-q', 'Disable logging') { PARAMS_CONFIG[:logging] = false }
+          op.on('-v', 'Enable verbose output') { PARAMS_CONFIG[:logging] = !(PARAMS_CONFIG[:log_level] = :debug).nil? }
+        end
+
+        begin
+          parser.parse!(ARGV.dup)
+        rescue StandardError => e
+          PARAMS_CONFIG[:optparse_error] = e
+        end
+
+        ActiveMatrix.debug! if ENV['MATRIX_DEBUG'] == '1'
+      end
+    end
+
+    class Instance < Base
+      set :logging, true
+      set :log_level, :info
+
+      set :app_file, caller_files.first || $PROGRAM_NAME
+      set(:run) { File.expand_path($PROGRAM_NAME) == File.expand_path(app_file) }
+
+      if run? && ARGV.any?
+        Bot.parse_arguments!
+        error = PARAMS_CONFIG.delete(:optparse_error)
+        raise error if error
+
+        PARAMS_CONFIG.each { |k, v| set k, v }
+      end
+    end
   end
 end

data/lib/active_matrix/cacheable.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module ActiveMatrix
+  # Provides caching functionality for Matrix objects
+  # Handles serialization/deserialization to work with Rails.cache
+  module Cacheable
+    extend ActiveSupport::Concern
+
+    included do
+      attr_accessor :cached_at
+    end
+
+    class_methods do
+      # Reconstruct object from cached data
+      def from_cache(client, data)
+        return nil unless data.is_a?(Hash) && data[:_cache_class] == name
+
+        # Remove cache metadata
+        attrs = data.except(:_cache_class, :_cached_at)
+
+        # Reconstruct based on class type
+        case name
+        when 'ActiveMatrix::User'
+          new(client, attrs[:id], attrs.except(:id))
+        when 'ActiveMatrix::Room'
+          new(client, attrs[:id], attrs.except(:id))
+        else
+          new(client, attrs)
+        end
+      end
+    end
+
+    # Convert object to cacheable hash
+    def to_cache
+      data = cache_attributes.merge(
+        _cache_class: self.class.name,
+        _cached_at: Time.current
+      )
+
+      # Ensure we only cache serializable data
+      data.deep_stringify_keys
+    end
+
+    # Override in each class to specify what to cache
+    def cache_attributes
+      if respond_to?(:attributes)
+        attributes
+      elsif respond_to?(:to_h)
+        to_h
+      else
+        {}
+      end
+    end
+
+    # Generate a cache key for this object
+    def cache_key(*suffixes)
+      base_key = "#{self.class.name.underscore}:#{cache_id}"
+      suffixes.any? ? "#{base_key}:#{suffixes.join(':')}" : base_key
+    end
+
+    # Override in each class if ID method is different
+    def cache_id
+      respond_to?(:id) ? id : object_id
+    end
+
+    # Check if this object was loaded from cache
+    def from_cache?
+      @cached_at.present?
+    end
+  end
+end

data/lib/active_matrix/client.rb

@@ -165,9 +165,9 @@ module ActiveMatrix
 
     # Retrieve an account data helper
     def account_data
-      return ActiveMatrix::Util::AccountDataCache.new self if cache == :none
+      return ActiveMatrix::AccountDataCache.new self if cache == :none
 
-      @account_data ||= ActiveMatrix::Util::AccountDataCache.new self
+      @account_data ||= ActiveMatrix::AccountDataCache.new self
     end
 
     # Gets a direct message room for the given user if one exists
@@ -252,7 +252,7 @@ module ActiveMatrix
       username = username.to_s unless username.is_a?(String)
       password = password.to_s unless password.is_a?(String)
 
-      raise ArgumentError, "Username can't be nil or empty" if username.nil? || username.empty?
+      raise ArgumentError, "Username can't be nil or empty" if username.blank?
       raise ArgumentError, "Password can't be nil or empty" if password.nil? || username.empty?
 
       data = api.register(auth: { type: 'm.login.dummy' }, username: username, password: password)
@@ -279,8 +279,8 @@ module ActiveMatrix
       username = username.to_s unless username.is_a?(String)
       password = password.to_s unless password.is_a?(String)
 
-      raise ArgumentError, "Username can't be nil or empty" if username.nil? || username.empty?
-      raise ArgumentError, "Password can't be nil or empty" if password.nil? || password.empty?
+      raise ArgumentError, "Username can't be nil or empty" if username.blank?
+      raise ArgumentError, "Password can't be nil or empty" if password.blank?
 
       data = api.login(user: username, password: password)
       post_authentication(data)
@@ -307,8 +307,8 @@ module ActiveMatrix
       username = username.to_s unless username.is_a?(String)
       token = token.to_s unless token.is_a?(String)
 
-      raise ArgumentError, "Username can't be nil or empty" if username.nil? || username.empty?
-      raise ArgumentError, "Token can't be nil or empty" if token.nil? || token.empty?
+      raise ArgumentError, "Username can't be nil or empty" if username.blank?
+      raise ArgumentError, "Token can't be nil or empty" if token.blank?
 
       data = api.login(user: username, token: token, type: 'm.login.token')
       post_authentication(data)
@@ -344,13 +344,13 @@ module ActiveMatrix
       data.threepids.each do |obj|
         obj.instance_eval do
           def added_at
-            Time.at(self[:added_at] / 1000)
+            Time.zone.at(self[:added_at] / 1000)
           end
 
           def validated_at
             return unless validated?
 
-            Time.at(self[:validated_at] / 1000)
+            Time.zone.at(self[:validated_at] / 1000)
           end
 
           def validated?
@@ -639,7 +639,7 @@ module ActiveMatrix
 
       data.dig(:rooms, :join)&.each do |room_id, join|
         room = ensure_room(room_id)
-        room.instance_variable_set '@prev_batch', join.dig(:timeline, :prev_batch)
+        room.instance_variable_set :@prev_batch, join.dig(:timeline, :prev_batch)
         room.instance_variable_set :@members_loaded, true unless sync_filter.fetch(:room, {}).fetch(:state, {}).fetch(:lazy_load_members, false)
 
         join.dig(:account_data, :events)&.each do |account_data|

data/lib/active_matrix/errors.rb

@@ -1,68 +1,82 @@
 # frozen_string_literal: true
 
 module ActiveMatrix
-  # A generic error raised for issues in the ActiveMatrix
-  class MatrixError < StandardError
-  end
+  module Errors
+    # A generic error raised for issues in the ActiveMatrix
+    class MatrixError < StandardError
+    end
 
-  # An error specialized and raised for failed requests
-  class MatrixRequestError < MatrixError
-    attr_reader :code, :data, :httpstatus, :message
-    alias error message
+    # An error specialized and raised for failed requests
+    class MatrixRequestError < MatrixError
+      attr_reader :code, :data, :httpstatus, :message
+      alias error message
 
-    def self.class_by_code(code)
-      code = code.to_i
+      def self.class_by_code(code)
+        code = code.to_i
 
-      return MatrixNotAuthorizedError if code == 401
-      return MatrixForbiddenError if code == 403
-      return MatrixNotFoundError if code == 404
-      return MatrixConflictError if code == 409
-      return MatrixTooManyRequestsError if code == 429
+        return MatrixNotAuthorizedError if code == 401
+        return MatrixForbiddenError if code == 403
+        return MatrixNotFoundError if code == 404
+        return MatrixConflictError if code == 409
+        return MatrixTooManyRequestsError if code == 429
 
-      MatrixRequestError
-    end
+        MatrixRequestError
+      end
 
-    def self.new_by_code(data, code)
-      class_by_code(code).new(data, code)
-    end
+      def self.new_by_code(data, code)
+        class_by_code(code).new(data, code)
+      end
 
-    def initialize(error, status)
-      @code = error[:errcode]
-      @httpstatus = status
-      @message = error[:error]
-      @data = error.except(:errcode, :error)
+      def initialize(error, status)
+        @code = error[:errcode]
+        @httpstatus = status
+        @message = error[:error]
+        @data = error.except(:errcode, :error)
 
-      super(error[:error])
-    end
+        super(error[:error])
+      end
 
-    def to_s
-      "HTTP #{httpstatus} (#{code}): #{message}"
+      def to_s
+        "HTTP #{httpstatus} (#{code}): #{message}"
+      end
     end
-  end
 
-  class MatrixNotAuthorizedError < MatrixRequestError; end
+    class MatrixNotAuthorizedError < MatrixRequestError; end
 
-  class MatrixForbiddenError < MatrixRequestError; end
+    class MatrixForbiddenError < MatrixRequestError; end
 
-  class MatrixNotFoundError < MatrixRequestError; end
+    class MatrixNotFoundError < MatrixRequestError; end
 
-  class MatrixConflictError < MatrixRequestError; end
+    class MatrixConflictError < MatrixRequestError; end
 
-  class MatrixTooManyRequestsError < MatrixRequestError; end
+    class MatrixTooManyRequestsError < MatrixRequestError; end
 
-  # An error raised when errors occur in the connection layer
-  class MatrixConnectionError < MatrixError
-    def self.class_by_code(code)
-      return MatrixTimeoutError if code == 504
+    # An error raised when errors occur in the connection layer
+    class MatrixConnectionError < MatrixError
+      def self.class_by_code(code)
+        return MatrixTimeoutError if code == 504
 
-      MatrixConnectionError
+        MatrixConnectionError
+      end
     end
-  end
 
-  class MatrixTimeoutError < MatrixConnectionError
-  end
+    class MatrixTimeoutError < MatrixConnectionError
+    end
 
-  # An error raised when the homeserver returns an unexpected response to the client
-  class MatrixUnexpectedResponseError < MatrixError
+    # An error raised when the homeserver returns an unexpected response to the client
+    class MatrixUnexpectedResponseError < MatrixError
+    end
   end
+
+  # Make error classes available at the top level for backward compatibility
+  MatrixError = Errors::MatrixError
+  MatrixRequestError = Errors::MatrixRequestError
+  MatrixNotAuthorizedError = Errors::MatrixNotAuthorizedError
+  MatrixForbiddenError = Errors::MatrixForbiddenError
+  MatrixNotFoundError = Errors::MatrixNotFoundError
+  MatrixConflictError = Errors::MatrixConflictError
+  MatrixTooManyRequestsError = Errors::MatrixTooManyRequestsError
+  MatrixConnectionError = Errors::MatrixConnectionError
+  MatrixTimeoutError = Errors::MatrixTimeoutError
+  MatrixUnexpectedResponseError = Errors::MatrixUnexpectedResponseError
 end

data/lib/active_matrix/{util/events.rb → events.rb}

@@ -88,9 +88,7 @@ module ActiveMatrix
       end
     end
 
-    def [](key)
-      event[key]
-    end
+    delegate :[], to: :event
 
     def to_s
       "#{event[:type]}: #{event.except(:type).to_json}"

data/lib/active_matrix/{util/extensions.rb → extensions.rb}

@@ -1,17 +1,5 @@
 # frozen_string_literal: true
 
-unless Object.respond_to? :yield_self
-  class Object
-    def yield_self
-      yield(self)
-    end
-  end
-end
-
-# Time.current is provided by ActiveSupport
-
-# Time duration helpers are provided by ActiveSupport
-
 module ActiveMatrix
   module Extensions
     def events(*symbols)
@@ -25,7 +13,7 @@ module ActiveMatrix
         name = sym.to_s
 
         initializers << "
-          @on_#{name} = ActiveMatrix::EventHandlerArray.new
+          @on_#{name} = ::ActiveMatrix::EventHandlerArray.new
         "
         readers << ":on_#{name}"
         methods << "

data/lib/active_matrix/logging.rb

@@ -24,33 +24,4 @@ module ActiveMatrix
       @logger = logger
     end
   end
-
-  class << self
-    def logger
-      @logger ||= if defined?(::Rails) && ::Rails.respond_to?(:logger)
-                    ::Rails.logger
-                  else
-                    # Fallback for testing
-                    require 'logger'
-                    ::Logger.new($stdout)
-                  end
-    end
-
-    def logger=(logger)
-      @logger = logger
-      @global_logger = !logger.nil?
-    end
-
-    def debug!
-      logger.level = if defined?(::Rails)
-                       :debug
-                     else
-                       ::Logger::DEBUG
-                     end
-    end
-
-    def global_logger?
-      @global_logger ||= false
-    end
-  end
 end

data/lib/active_matrix/memory/base.rb

@@ -32,7 +32,7 @@ module ActiveMatrix
 
       # Get multiple keys at once
       def get_multi(*keys)
-        keys.to_h { |key| [key, get(key)] }
+        keys.index_with { |key| get(key) }
       end
 
       # Set multiple keys at once

data/lib/active_matrix/mxid.rb

@@ -8,7 +8,7 @@ module ActiveMatrix
     def initialize(identifier)
       raise ArgumentError, 'Identifier must be a String' unless identifier.is_a? String
       raise ArgumentError, 'Identifier is too long' if identifier.size > 255
-      raise ArgumentError, 'Identifier lacks required data' unless identifier =~ %r{^([@!$+#][^:]+:[^:]+(?::\d+)?)|(\$[A-Za-z0-9+/]+)$}
+      raise ArgumentError, 'Identifier lacks required data' unless %r{^([@!$+#][^:]+:[^:]+(?::\d+)?)|(\$[A-Za-z0-9+/]+)$}.match?(identifier)
 
       # TODO: Community-as-a-Room / Profile-as-a-Room, in case they're going for room aliases
       @sigil = identifier[0]

data/lib/active_matrix/protocols/msc.rb

@@ -35,7 +35,6 @@ module ActiveMatrix::Protocols::MSC
   #
   # @see Protocols::CS#sync
   # @see https://github.com/matrix-org/matrix-doc/pull/2108/
-  # rubocop:disable Metrics/MethodLength
   def msc2108_sync_sse(since: nil, **params, &on_data)
     raise ArgumentError, 'Must be given a block accepting two args - data and { event:, id: }' \
       unless on_data.is_a?(Proc) && on_data.arity == 2

data/lib/active_matrix/railtie.rb

@@ -8,11 +8,5 @@ module ActiveMatrix
       # Configure Rails.logger as the default logger
       ActiveMatrix.logger = Rails.logger
     end
-
-    initializer 'activematrix.configure_cache' do
-      # Rails cache adapter is automatically used when Rails is detected
-      require 'active_matrix/util/rails_cache_adapter'
-      ActiveMatrix::Util::Tinycache.adapter = ActiveMatrix::Util::RailsCacheAdapter
-    end
   end
 end

data/lib/active_matrix/response.rb

@@ -23,7 +23,7 @@ module ActiveMatrix
   module Response
     def self.new(api, data)
       if data.is_a? Array
-        raise ArgumentError, 'Input data was not an array of hashes' unless data.all? { |v| v.is_a? Hash }
+        raise ArgumentError, 'Input data was not an array of hashes' unless data.all?(Hash)
 
         data.each do |value|
           Response.new api, value