activejob 7.2.1.1 → 8.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3a60bf6940ca6270c614cf3618f9537ee9a082da84e176c00735b040199798e
-  data.tar.gz: 1c1807cc840a89fe4414a39fc48582d18ed2e46ad89080ca63c508165080d8a0
+  metadata.gz: 0fbfb304817561be2dc9669fc234d56cfc38bc25f02134e41299642807b0c997
+  data.tar.gz: 791c6aa25026dab8c5c42ce200e843d9e898e8e67fcf8feda11cda9a98c2ad72
 SHA512:
-  metadata.gz: ff2f5e989fb6da50b5c504a97d7bbd62caa4a627476702e7bdbc4ae4fc28f664fce0589cf6e317125b9ccf2dc60812de8b076e513dd7131d1a94927eb1ac437d
-  data.tar.gz: 15c61d32050aac39e081ef4200b798d89abfbb465bcc6fcae5a8dfd0788b8c686ebeec7a486fead2cdafbf96f613d8ec997873fb044d53252b5577a1c5ae6e66
+  metadata.gz: 996122b64c9ae05031fea17c63835e42e2b9b97c7918be29676d148c276c9459701d65654111a1d3921b6bc17a2afbe167e87f5cfe6a51eaf3e278bbd94e707f
+  data.tar.gz: 499c6a3257207aa90f824edbe5631767c5252d13b063860c00d06bd2440161960c692aeb596df83a3d29609be3a9e1c7c61ebcc881b94fc5983733884d2feb23

data/CHANGELOG.md

@@ -1,77 +1,13 @@
-## Rails 7.2.1.1 (October 15, 2024) ##
+## Rails 8.0.0.beta1 (September 26, 2024) ##
 
-*   No changes.
+*   Deprecate `sucker_punch` as an adapter option.
 
+    If you're using this adapter, change to `adapter: async` for the same functionality.
 
-## Rails 7.2.1 (August 22, 2024) ##
+    *Dino Maric, zzak*
 
-*   No changes.
+*   Use `RAILS_MAX_THREADS` in `ActiveJob::AsyncAdapter`. If it is not set, use 5 as default.
 
+    *heka1024*
 
-## Rails 7.2.0 (August 09, 2024) ##
-
-*   All tests now respect the `active_job.queue_adapter` config.
-
-    Previously if you had set `config.active_job.queue_adapter` in your `config/application.rb`
-    or `config/environments/test.rb` file, the adapter you selected was previously not used consistently
-    across all tests. In some tests your adapter would be used, but other tests would use the `TestAdapter`.
-
-    In Rails 7.2, all tests will respect the `queue_adapter` config if provided. If no config is provided,
-    the `TestAdapter` will continue to be used.
-
-    See [#48585](https://github.com/rails/rails/pull/48585) for more details.
-
-    *Alex Ghiculescu*
-
-*   Make Active Job transaction aware when used conjointly with Active Record.
-
-    A common mistake with Active Job is to enqueue jobs from inside a transaction,
-    causing them to potentially be picked and ran by another process, before the
-    transaction is committed, which may result in various errors.
-
-    ```ruby
-    Topic.transaction do
-      topic = Topic.create(...)
-      NewTopicNotificationJob.perform_later(topic)
-    end
-    ```
-
-    Now Active Job will automatically defer the enqueuing to after the transaction is committed,
-    and drop the job if the transaction is rolled back.
-
-    Various queue implementations can choose to disable this behavior, and users can disable it,
-    or force it on a per job basis:
-
-    ```ruby
-    class NewTopicNotificationJob < ApplicationJob
-      self.enqueue_after_transaction_commit = :never # or `:always` or `:default`
-    end
-    ```
-
-    *Jean Boussier*, *Cristian Bica*
-
-*   Do not trigger immediate loading of `ActiveJob::Base` when loading `ActiveJob::TestHelper`.
-
-    *Maxime Réty*
-
-*   Preserve the serialized timezone when deserializing `ActiveSupport::TimeWithZone` arguments.
-
-    *Joshua Young*
-
-*   Remove deprecated `:exponentially_longer` value for the `:wait` in `retry_on`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated support to set numeric values to `scheduled_at` attribute.
-
-    *Rafael Mendonça França*
-
-*   Deprecate `Rails.application.config.active_job.use_big_decimal_serialize`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated primitive serializer for `BigDecimal` arguments.
-
-    *Rafael Mendonça França*
-
-Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/activejob/CHANGELOG.md) for previous changes.
+Please check [7-2-stable](https://github.com/rails/rails/blob/7-2-stable/activejob/CHANGELOG.md) for previous changes.

data/lib/active_job/gem_version.rb

@@ -7,10 +7,10 @@ module ActiveJob
   end
 
   module VERSION
-    MAJOR = 7
-    MINOR = 2
-    TINY  = 1
-    PRE   = "1"
+    MAJOR = 8
+    MINOR = 0
+    TINY  = 0
+    PRE   = "beta1"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_job/log_subscriber.rb

@@ -189,15 +189,29 @@ module ActiveJob
       end
 
       def log_enqueue_source
-        source = extract_enqueue_source_location(caller)
+        source = enqueue_source_location
 
         if source
           logger.info("↳ #{source}")
         end
       end
 
-      def extract_enqueue_source_location(locations)
-        backtrace_cleaner.clean(locations.lazy).first
+      if Thread.respond_to?(:each_caller_location)
+        def enqueue_source_location
+          Thread.each_caller_location do |location|
+            frame = backtrace_cleaner.clean_frame(location)
+            return frame if frame
+          end
+          nil
+        end
+      else
+        def enqueue_source_location
+          caller_locations(2).each do |location|
+            frame = backtrace_cleaner.clean_frame(location)
+            return frame if frame
+          end
+          nil
+        end
       end
 
       def enqueued_jobs_message(adapter, enqueued_jobs)

data/lib/active_job/queue_adapter.rb

@@ -50,6 +50,7 @@ module ActiveJob
         case name_or_adapter
         when Symbol, String
           queue_adapter = ActiveJob::QueueAdapters.lookup(name_or_adapter).new
+          queue_adapter.try(:check_adapter)
           assign_adapter(name_or_adapter.to_s, queue_adapter)
         else
           if queue_adapter?(name_or_adapter)

data/lib/active_job/queue_adapters/async_adapter.rb

@@ -74,7 +74,7 @@ module ActiveJob
       class Scheduler # :nodoc:
         DEFAULT_EXECUTOR_OPTIONS = {
           min_threads:     0,
-          max_threads:     Concurrent.processor_count,
+          max_threads:     ENV.fetch("RAILS_MAX_THREADS", 5).to_i,
           auto_terminate:  true,
           idletime:        60, # 1 minute
           max_queue:       0, # unlimited

data/lib/active_job/queue_adapters/sucker_punch_adapter.rb

@@ -18,6 +18,13 @@ module ActiveJob
     #
     #   Rails.application.config.active_job.queue_adapter = :sucker_punch
     class SuckerPunchAdapter < AbstractAdapter
+      def check_adapter
+        ActiveJob.deprecator.warn <<~MSG.squish
+          The `sucker_punch` adapter is deprecated and will be removed in Rails 8.1.
+          Please use the `async` adapter instead.
+        MSG
+      end
+
       def enqueue(job) # :nodoc:
         if JobWrapper.respond_to?(:perform_async)
           # sucker_punch 2.0 API

data/lib/active_job/queue_adapters.rb

@@ -12,7 +12,6 @@ module ActiveJob
   # * {Resque}[https://github.com/resque/resque]
   # * {Sidekiq}[https://sidekiq.org]
   # * {Sneakers}[https://github.com/jondot/sneakers]
-  # * {Sucker Punch}[https://github.com/brandonhilkert/sucker_punch]
   # * Please Note: We are not accepting pull requests for new adapters. See the {README}[link:files/activejob/README_md.html] for more details.
   #
   # For testing and development Active Job has three built-in adapters:
@@ -32,7 +31,6 @@ module ActiveJob
   #   | Resque            | Yes   | Yes    | Yes (Gem)  | Queue      | Global  | Yes     |
   #   | Sidekiq           | Yes   | Yes    | Yes        | Queue      | No      | Job     |
   #   | Sneakers          | Yes   | Yes    | No         | Queue      | Queue   | No      |
-  #   | Sucker Punch      | Yes   | Yes    | Yes        | No         | No      | No      |
   #   | Active Job Async  | Yes   | Yes    | Yes        | No         | No      | No      |
   #   | Active Job Inline | No    | Yes    | N/A        | N/A        | N/A     | N/A     |
   #   | Active Job Test   | No    | Yes    | N/A        | N/A        | N/A     | N/A     |
@@ -119,7 +117,6 @@ module ActiveJob
     autoload :InlineAdapter
     autoload :BackburnerAdapter
     autoload :DelayedJobAdapter
-    autoload :QueAdapter
     autoload :QueueClassicAdapter
     autoload :ResqueAdapter
     autoload :SidekiqAdapter

data/lib/active_job/railtie.rb

@@ -91,7 +91,9 @@ module ActiveJob
         app.config.active_record.query_log_tags |= [:job]
 
         ActiveSupport.on_load(:active_record) do
-          ActiveRecord::QueryLogs.taggings[:job] = ->(context) { context[:job].class.name if context[:job] }
+          ActiveRecord::QueryLogs.taggings = ActiveRecord::QueryLogs.taggings.merge(
+            job: ->(context) { context[:job].class.name if context[:job] }
+          )
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activejob
 version: !ruby/object:Gem::Version
-  version: 7.2.1.1
+  version: 8.0.0.beta1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-10-15 00:00:00.000000000 Z
+date: 2024-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.1.1
+        version: 8.0.0.beta1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.2.1.1
+        version: 8.0.0.beta1
 - !ruby/object:Gem::Dependency
   name: globalid
   requirement: !ruby/object:Gem::Requirement
@@ -104,10 +104,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.2.1.1/activejob/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.2.1.1/
+  changelog_uri: https://github.com/rails/rails/blob/v8.0.0.beta1/activejob/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.0.0.beta1/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.2.1.1/activejob
+  source_code_uri: https://github.com/rails/rails/tree/v8.0.0.beta1/activejob
   rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
@@ -117,7 +117,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.1.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="