activejob 5.0.0.beta3 → 5.0.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 526b7c0ad7e2e92215cbb0bf362ef9113e248cd2
-  data.tar.gz: 3f66e41cd86278974127b13e08a28b81a9c68c0e
+  metadata.gz: 2222c833aa10b4408013759ed7bd4f5a55f3f4c3
+  data.tar.gz: c659efca7e60db7b59168fd94b73d21402cb619c
 SHA512:
-  metadata.gz: eb8349f3129814464cfe53b3c9ec2f4d9a1a900482ca510093ba66b23ee8f8246356772070e0f6baf62a9afc297fb8f6b5cc03284ad81c6946782187243cf05e
-  data.tar.gz: 01908295426a77f5dfedad73c7e10afe59c5066eb8687800c28e5f4411bc93206cbbcf3ca8dd6db34ee7def299c56e04f46dae88c8724cdae47eb83b82b610b0
+  metadata.gz: be60b1de999875823e05c7b8b02145511d629370a100e2d5daf0a32d1bbe226b3f1eb270b41230b8fd901efa48e43061bf849ca474b1a7c7bf798cc631795ddd
+  data.tar.gz: 82449401bccd1b3ff8dda0004404f477e1953639849081613ce4fa4d39ca89a9bcd3899a04d2e04dcd0a36b23276cb18515c4774a2371ec61ec5714abc45761f

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## Rails 5.0.0.beta4 (April 27, 2016) ##
+
+*   Enable class reloading prior to job dispatch, and ensure Active Record
+    connections are returned to the pool when jobs are run in separate threads.
+
+    *Matthew Draper*
+
+*   Tune the async adapter for low-footprint dev/test usage. Use a single
+    thread pool for all queues and limit to 0 to #CPU total threads, down from
+    2 to 10*#CPU per queue.
+
+    *Jeremy Daer*
+
+
 ## Rails 5.0.0.beta3 (February 24, 2016) ##
 
 *   Change the default adapter from inline to async. It's a better default as tests will then not mistakenly

data/lib/active_job.rb

@@ -32,7 +32,6 @@ module ActiveJob
   autoload :Base
   autoload :QueueAdapters
   autoload :ConfiguredJob
-  autoload :AsyncJob
   autoload :TestCase
   autoload :TestHelper
 end

data/lib/active_job/callbacks.rb

@@ -17,6 +17,11 @@ module ActiveJob
     extend  ActiveSupport::Concern
     include ActiveSupport::Callbacks
 
+    class << self
+      include ActiveSupport::Callbacks
+      define_callbacks :execute
+    end
+
     included do
       define_callbacks :perform
       define_callbacks :enqueue

data/lib/active_job/core.rb

@@ -79,7 +79,7 @@ module ActiveJob
         'queue_name' => queue_name,
         'priority'   => priority,
         'arguments'  => serialize_arguments(arguments),
-        'locale'     => I18n.locale
+        'locale'     => I18n.locale.to_s
       }
     end
 
@@ -108,7 +108,7 @@ module ActiveJob
       self.queue_name           = job_data['queue_name']
       self.priority             = job_data['priority']
       self.serialized_arguments = job_data['arguments']
-      self.locale               = job_data['locale'] || I18n.locale
+      self.locale               = job_data['locale'] || I18n.locale.to_s
     end
 
     private

data/lib/active_job/enqueuing.rb

@@ -36,7 +36,7 @@ module ActiveJob
     #
     # ==== Examples
     #
-    #  class SiteScrapperJob < ActiveJob::Base
+    #  class SiteScraperJob < ActiveJob::Base
     #    rescue_from(ErrorLoadingSite) do
     #      retry_job queue: :low_priority
     #    end

data/lib/active_job/execution.rb

@@ -17,8 +17,10 @@ module ActiveJob
       end
 
       def execute(job_data) #:nodoc:
-        job = deserialize(job_data)
-        job.perform_now
+        ActiveJob::Callbacks.run_callbacks(:execute) do
+          job = deserialize(job_data)
+          job.perform_now
+        end
       end
     end
 

data/lib/active_job/gem_version.rb

@@ -8,7 +8,7 @@ module ActiveJob
     MAJOR = 5
     MINOR = 0
     TINY  = 0
-    PRE   = "beta3"
+    PRE   = "beta4"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/active_job/queue_adapters.rb

@@ -33,7 +33,8 @@ module ActiveJob
   #
   # ==== Async
   #
-  # Yes: The Queue Adapter runs the jobs in a separate or forked process.
+  # Yes: The Queue Adapter has the ability to run the job in a non-blocking manner.
+  # It either runs on a separate or forked process, or on a different thread.
   #
   # No: The job is run in the same process.
   #

data/lib/active_job/queue_adapters/async_adapter.rb

@@ -1,22 +1,113 @@
-require 'active_job/async_job'
+require 'securerandom'
+require 'concurrent/scheduled_task'
+require 'concurrent/executor/thread_pool_executor'
+require 'concurrent/utility/processor_counter'
 
 module ActiveJob
   module QueueAdapters
     # == Active Job Async adapter
     #
-    # When enqueuing jobs with the Async adapter the job will be executed
-    # asynchronously using {AsyncJob}[http://api.rubyonrails.org/classes/ActiveJob/AsyncJob.html].
+    # The Async adapter runs jobs with an in-process thread pool.
     #
-    # To use +AsyncJob+ set the queue_adapter config to +:async+.
+    # This is the default queue adapter. It's well-suited for dev/test since
+    # it doesn't need an external infrastructure, but it's a poor fit for
+    # production since it drops pending jobs on restart.
     #
-    #   Rails.application.config.active_job.queue_adapter = :async
+    # To use this adapter, set queue adapter to +:async+:
+    #
+    #   config.active_job.queue_adapter = :async
+    #
+    # To configure the adapter's thread pool, instantiate the adapter and
+    # pass your own config:
+    #
+    #   config.active_job.queue_adapter = ActiveJob::QueueAdapters::AsyncAdapter.new \
+    #     min_threads: 1,
+    #     max_threads: 2 * Concurrent.processor_count,
+    #     idletime: 600.seconds
+    #
+    # The adapter uses a {Concurrent Ruby}[https://github.com/ruby-concurrency/concurrent-ruby] thread pool to schedule and execute
+    # jobs. Since jobs share a single thread pool, long-running jobs will block
+    # short-lived jobs. Fine for dev/test; bad for production.
     class AsyncAdapter
+      # See {Concurrent::ThreadPoolExecutor}[http://ruby-concurrency.github.io/concurrent-ruby/Concurrent/ThreadPoolExecutor.html] for executor options.
+      def initialize(**executor_options)
+        @scheduler = Scheduler.new(**executor_options)
+      end
+
       def enqueue(job) #:nodoc:
-        ActiveJob::AsyncJob.enqueue(job.serialize, queue: job.queue_name)
+        @scheduler.enqueue JobWrapper.new(job), queue_name: job.queue_name
       end
 
       def enqueue_at(job, timestamp) #:nodoc:
-        ActiveJob::AsyncJob.enqueue_at(job.serialize, timestamp, queue: job.queue_name)
+        @scheduler.enqueue_at JobWrapper.new(job), timestamp, queue_name: job.queue_name
+      end
+
+      # Gracefully stop processing jobs. Finishes in-progress work and handles
+      # any new jobs following the executor's fallback policy (`caller_runs`).
+      # Waits for termination by default. Pass `wait: false` to continue.
+      def shutdown(wait: true) #:nodoc:
+        @scheduler.shutdown wait: wait
+      end
+
+      # Used for our test suite.
+      def immediate=(immediate) #:nodoc:
+        @scheduler.immediate = immediate
+      end
+
+      # Note that we don't actually need to serialize the jobs since we're
+      # performing them in-process, but we do so anyway for parity with other
+      # adapters and deployment environments. Otherwise, serialization bugs
+      # may creep in undetected.
+      class JobWrapper #:nodoc:
+        def initialize(job)
+          job.provider_job_id = SecureRandom.uuid
+          @job_data = job.serialize
+        end
+
+        def perform
+          Base.execute @job_data
+        end
+      end
+
+      class Scheduler #:nodoc:
+        DEFAULT_EXECUTOR_OPTIONS = {
+          min_threads:     0,
+          max_threads:     Concurrent.processor_count,
+          auto_terminate:  true,
+          idletime:        60, # 1 minute
+          max_queue:       0, # unlimited
+          fallback_policy: :caller_runs # shouldn't matter -- 0 max queue
+        }.freeze
+
+        attr_accessor :immediate
+
+        def initialize(**options)
+          self.immediate = false
+          @immediate_executor = Concurrent::ImmediateExecutor.new
+          @async_executor = Concurrent::ThreadPoolExecutor.new(DEFAULT_EXECUTOR_OPTIONS.merge(options))
+        end
+
+        def enqueue(job, queue_name:)
+          executor.post(job, &:perform)
+        end
+
+        def enqueue_at(job, timestamp, queue_name:)
+          delay = timestamp - Time.current.to_f
+          if delay > 0
+            Concurrent::ScheduledTask.execute(delay, args: [job], executor: executor, &:perform)
+          else
+            enqueue(job, queue_name: queue_name)
+          end
+        end
+
+        def shutdown(wait: true)
+          @async_executor.shutdown
+          @async_executor.wait_for_termination if wait
+        end
+
+        def executor
+          immediate ? @immediate_executor : @async_executor
+        end
       end
     end
   end

data/lib/active_job/railtie.rb

@@ -19,5 +19,14 @@ module ActiveJob
       end
     end
 
+    initializer "active_job.set_reloader_hook" do |app|
+      ActiveSupport.on_load(:active_job) do
+        ActiveJob::Callbacks.singleton_class.set_callback(:execute, :around, prepend: true) do |_, inner|
+          app.reloader.wrap do
+            inner.call
+          end
+        end
+      end
+    end
   end
 end

data/lib/active_job/test_helper.rb

@@ -4,325 +4,308 @@ require 'active_support/core_ext/hash/keys'
 module ActiveJob
   # Provides helper methods for testing Active Job
   module TestHelper
-    extend ActiveSupport::Concern
+    delegate :enqueued_jobs, :enqueued_jobs=,
+      :performed_jobs, :performed_jobs=,
+      to: :queue_adapter
 
-    included do
-      def before_setup # :nodoc:
-        test_adapter = ActiveJob::QueueAdapters::TestAdapter.new
+    def before_setup # :nodoc:
+      test_adapter = ActiveJob::QueueAdapters::TestAdapter.new
 
-        @old_queue_adapters = (ActiveJob::Base.subclasses << ActiveJob::Base).select do |klass|
-          # only override explicitly set adapters, a quirk of `class_attribute`
-          klass.singleton_class.public_instance_methods(false).include?(:_queue_adapter)
-        end.map do |klass|
-          [klass, klass.queue_adapter].tap do
-            klass.queue_adapter = test_adapter
-          end
+      @old_queue_adapters = (ActiveJob::Base.subclasses << ActiveJob::Base).select do |klass|
+        # only override explicitly set adapters, a quirk of `class_attribute`
+        klass.singleton_class.public_instance_methods(false).include?(:_queue_adapter)
+      end.map do |klass|
+        [klass, klass.queue_adapter].tap do
+          klass.queue_adapter = test_adapter
         end
-
-        clear_enqueued_jobs
-        clear_performed_jobs
-        super
       end
 
-      def after_teardown # :nodoc:
-        super
-        @old_queue_adapters.each do |(klass, adapter)|
-          klass.queue_adapter = adapter
-        end
-      end
+      clear_enqueued_jobs
+      clear_performed_jobs
+      super
+    end
 
-      # Asserts that the number of enqueued jobs matches the given number.
-      #
-      #   def test_jobs
-      #     assert_enqueued_jobs 0
-      #     HelloJob.perform_later('david')
-      #     assert_enqueued_jobs 1
-      #     HelloJob.perform_later('abdelkader')
-      #     assert_enqueued_jobs 2
-      #   end
-      #
-      # If a block is passed, that block should cause the specified number of
-      # jobs to be enqueued.
-      #
-      #   def test_jobs_again
-      #     assert_enqueued_jobs 1 do
-      #       HelloJob.perform_later('cristian')
-      #     end
-      #
-      #     assert_enqueued_jobs 2 do
-      #       HelloJob.perform_later('aaron')
-      #       HelloJob.perform_later('rafael')
-      #     end
-      #   end
-      #
-      # The number of times a specific job is enqueued can be asserted.
-      #
-      #   def test_logging_job
-      #     assert_enqueued_jobs 1, only: LoggingJob do
-      #       LoggingJob.perform_later
-      #       HelloJob.perform_later('jeremy')
-      #     end
-      #   end
-      def assert_enqueued_jobs(number, only: nil)
-        if block_given?
-          original_count = enqueued_jobs_size(only: only)
-          yield
-          new_count = enqueued_jobs_size(only: only)
-          assert_equal number, new_count - original_count, "#{number} jobs expected, but #{new_count - original_count} were enqueued"
-        else
-          actual_count = enqueued_jobs_size(only: only)
-          assert_equal number, actual_count, "#{number} jobs expected, but #{actual_count} were enqueued"
-        end
+    def after_teardown # :nodoc:
+      super
+      @old_queue_adapters.each do |(klass, adapter)|
+        klass.queue_adapter = adapter
       end
+    end
 
-      # Asserts that no jobs have been enqueued.
-      #
-      #   def test_jobs
-      #     assert_no_enqueued_jobs
-      #     HelloJob.perform_later('jeremy')
-      #     assert_enqueued_jobs 1
-      #   end
-      #
-      # If a block is passed, that block should not cause any job to be enqueued.
-      #
-      #   def test_jobs_again
-      #     assert_no_enqueued_jobs do
-      #       # No job should be enqueued from this block
-      #     end
-      #   end
-      #
-      # It can be asserted that no jobs of a specific kind are enqueued:
-      #
-      #   def test_no_logging
-      #     assert_no_enqueued_jobs only: LoggingJob do
-      #       HelloJob.perform_later('jeremy')
-      #     end
-      #   end
-      #
-      # Note: This assertion is simply a shortcut for:
-      #
-      #   assert_enqueued_jobs 0, &block
-      def assert_no_enqueued_jobs(only: nil, &block)
-        assert_enqueued_jobs 0, only: only, &block
+    # Asserts that the number of enqueued jobs matches the given number.
+    #
+    #   def test_jobs
+    #     assert_enqueued_jobs 0
+    #     HelloJob.perform_later('david')
+    #     assert_enqueued_jobs 1
+    #     HelloJob.perform_later('abdelkader')
+    #     assert_enqueued_jobs 2
+    #   end
+    #
+    # If a block is passed, that block should cause the specified number of
+    # jobs to be enqueued.
+    #
+    #   def test_jobs_again
+    #     assert_enqueued_jobs 1 do
+    #       HelloJob.perform_later('cristian')
+    #     end
+    #
+    #     assert_enqueued_jobs 2 do
+    #       HelloJob.perform_later('aaron')
+    #       HelloJob.perform_later('rafael')
+    #     end
+    #   end
+    #
+    # The number of times a specific job is enqueued can be asserted.
+    #
+    #   def test_logging_job
+    #     assert_enqueued_jobs 1, only: LoggingJob do
+    #       LoggingJob.perform_later
+    #       HelloJob.perform_later('jeremy')
+    #     end
+    #   end
+    def assert_enqueued_jobs(number, only: nil)
+      if block_given?
+        original_count = enqueued_jobs_size(only: only)
+        yield
+        new_count = enqueued_jobs_size(only: only)
+        assert_equal number, new_count - original_count, "#{number} jobs expected, but #{new_count - original_count} were enqueued"
+      else
+        actual_count = enqueued_jobs_size(only: only)
+        assert_equal number, actual_count, "#{number} jobs expected, but #{actual_count} were enqueued"
       end
+    end
 
-      # Asserts that the number of performed jobs matches the given number.
-      # If no block is passed, <tt>perform_enqueued_jobs</tt>
-      # must be called around the job call.
-      #
-      #   def test_jobs
-      #     assert_performed_jobs 0
-      #
-      #     perform_enqueued_jobs do
-      #       HelloJob.perform_later('xavier')
-      #     end
-      #     assert_performed_jobs 1
-      #
-      #     perform_enqueued_jobs do
-      #       HelloJob.perform_later('yves')
-      #       assert_performed_jobs 2
-      #     end
-      #   end
-      #
-      # If a block is passed, that block should cause the specified number of
-      # jobs to be performed.
-      #
-      #   def test_jobs_again
-      #     assert_performed_jobs 1 do
-      #       HelloJob.perform_later('robin')
-      #     end
-      #
-      #     assert_performed_jobs 2 do
-      #       HelloJob.perform_later('carlos')
-      #       HelloJob.perform_later('sean')
-      #     end
-      #   end
-      #
-      # The block form supports filtering. If the :only option is specified,
-      # then only the listed job(s) will be performed.
-      #
-      #     def test_hello_job
-      #       assert_performed_jobs 1, only: HelloJob do
-      #         HelloJob.perform_later('jeremy')
-      #         LoggingJob.perform_later
-      #       end
-      #     end
-      #
-      # An array may also be specified, to support testing multiple jobs.
-      #
-      #     def test_hello_and_logging_jobs
-      #       assert_nothing_raised do
-      #         assert_performed_jobs 2, only: [HelloJob, LoggingJob] do
-      #           HelloJob.perform_later('jeremy')
-      #           LoggingJob.perform_later('stewie')
-      #           RescueJob.perform_later('david')
-      #         end
-      #       end
-      #     end
-      def assert_performed_jobs(number, only: nil)
-        if block_given?
-          original_count = performed_jobs.size
-          perform_enqueued_jobs(only: only) { yield }
-          new_count = performed_jobs.size
-          assert_equal number, new_count - original_count,
-                       "#{number} jobs expected, but #{new_count - original_count} were performed"
-        else
-          performed_jobs_size = performed_jobs.size
-          assert_equal number, performed_jobs_size, "#{number} jobs expected, but #{performed_jobs_size} were performed"
-        end
-      end
+    # Asserts that no jobs have been enqueued.
+    #
+    #   def test_jobs
+    #     assert_no_enqueued_jobs
+    #     HelloJob.perform_later('jeremy')
+    #     assert_enqueued_jobs 1
+    #   end
+    #
+    # If a block is passed, that block should not cause any job to be enqueued.
+    #
+    #   def test_jobs_again
+    #     assert_no_enqueued_jobs do
+    #       # No job should be enqueued from this block
+    #     end
+    #   end
+    #
+    # It can be asserted that no jobs of a specific kind are enqueued:
+    #
+    #   def test_no_logging
+    #     assert_no_enqueued_jobs only: LoggingJob do
+    #       HelloJob.perform_later('jeremy')
+    #     end
+    #   end
+    #
+    # Note: This assertion is simply a shortcut for:
+    #
+    #   assert_enqueued_jobs 0, &block
+    def assert_no_enqueued_jobs(only: nil, &block)
+      assert_enqueued_jobs 0, only: only, &block
+    end
 
-      # Asserts that no jobs have been performed.
-      #
-      #   def test_jobs
-      #     assert_no_performed_jobs
-      #
-      #     perform_enqueued_jobs do
-      #       HelloJob.perform_later('matthew')
-      #       assert_performed_jobs 1
-      #     end
-      #   end
-      #
-      # If a block is passed, that block should not cause any job to be performed.
-      #
-      #   def test_jobs_again
-      #     assert_no_performed_jobs do
-      #       # No job should be performed from this block
-      #     end
-      #   end
-      #
-      # The block form supports filtering. If the :only option is specified,
-      # then only the listed job(s) will be performed.
-      #
-      #     def test_hello_job
-      #       assert_performed_jobs 1, only: HelloJob do
-      #         HelloJob.perform_later('jeremy')
-      #         LoggingJob.perform_later
-      #       end
-      #     end
-      #
-      # An array may also be specified, to support testing multiple jobs.
-      #
-      #     def test_hello_and_logging_jobs
-      #       assert_nothing_raised do
-      #         assert_performed_jobs 2, only: [HelloJob, LoggingJob] do
-      #           HelloJob.perform_later('jeremy')
-      #           LoggingJob.perform_later('stewie')
-      #           RescueJob.perform_later('david')
-      #         end
-      #       end
-      #     end
-      #
-      # Note: This assertion is simply a shortcut for:
-      #
-      #   assert_performed_jobs 0, &block
-      def assert_no_performed_jobs(only: nil, &block)
-        assert_performed_jobs 0, only: only, &block
+    # Asserts that the number of performed jobs matches the given number.
+    # If no block is passed, <tt>perform_enqueued_jobs</tt>
+    # must be called around the job call.
+    #
+    #   def test_jobs
+    #     assert_performed_jobs 0
+    #
+    #     perform_enqueued_jobs do
+    #       HelloJob.perform_later('xavier')
+    #     end
+    #     assert_performed_jobs 1
+    #
+    #     perform_enqueued_jobs do
+    #       HelloJob.perform_later('yves')
+    #       assert_performed_jobs 2
+    #     end
+    #   end
+    #
+    # If a block is passed, that block should cause the specified number of
+    # jobs to be performed.
+    #
+    #   def test_jobs_again
+    #     assert_performed_jobs 1 do
+    #       HelloJob.perform_later('robin')
+    #     end
+    #
+    #     assert_performed_jobs 2 do
+    #       HelloJob.perform_later('carlos')
+    #       HelloJob.perform_later('sean')
+    #     end
+    #   end
+    #
+    # The block form supports filtering. If the :only option is specified,
+    # then only the listed job(s) will be performed.
+    #
+    #     def test_hello_job
+    #       assert_performed_jobs 1, only: HelloJob do
+    #         HelloJob.perform_later('jeremy')
+    #         LoggingJob.perform_later
+    #       end
+    #     end
+    #
+    # An array may also be specified, to support testing multiple jobs.
+    #
+    #     def test_hello_and_logging_jobs
+    #       assert_nothing_raised do
+    #         assert_performed_jobs 2, only: [HelloJob, LoggingJob] do
+    #           HelloJob.perform_later('jeremy')
+    #           LoggingJob.perform_later('stewie')
+    #           RescueJob.perform_later('david')
+    #         end
+    #       end
+    #     end
+    def assert_performed_jobs(number, only: nil)
+      if block_given?
+        original_count = performed_jobs.size
+        perform_enqueued_jobs(only: only) { yield }
+        new_count = performed_jobs.size
+        assert_equal number, new_count - original_count,
+          "#{number} jobs expected, but #{new_count - original_count} were performed"
+      else
+        performed_jobs_size = performed_jobs.size
+        assert_equal number, performed_jobs_size, "#{number} jobs expected, but #{performed_jobs_size} were performed"
       end
+    end
 
-      # Asserts that the job passed in the block has been enqueued with the given arguments.
-      #
-      #   def test_assert_enqueued_with
-      #     assert_enqueued_with(job: MyJob, args: [1,2,3], queue: 'low') do
-      #       MyJob.perform_later(1,2,3)
-      #     end
-      #
-      #     assert_enqueued_with(job: MyJob, at: Date.tomorrow.noon) do
-      #       MyJob.set(wait_until: Date.tomorrow.noon).perform_later
-      #     end
-      #   end
-      def assert_enqueued_with(args = {})
-        original_enqueued_jobs_count = enqueued_jobs.count
-        args.assert_valid_keys(:job, :args, :at, :queue)
-        serialized_args = serialize_args_for_assertion(args)
-        yield
-        in_block_jobs = enqueued_jobs.drop(original_enqueued_jobs_count)
-        matching_job = in_block_jobs.find do |job|
-          serialized_args.all? { |key, value| value == job[key] }
-        end
-        assert matching_job, "No enqueued job found with #{args}"
-        instantiate_job(matching_job)
-      end
+    # Asserts that no jobs have been performed.
+    #
+    #   def test_jobs
+    #     assert_no_performed_jobs
+    #
+    #     perform_enqueued_jobs do
+    #       HelloJob.perform_later('matthew')
+    #       assert_performed_jobs 1
+    #     end
+    #   end
+    #
+    # If a block is passed, that block should not cause any job to be performed.
+    #
+    #   def test_jobs_again
+    #     assert_no_performed_jobs do
+    #       # No job should be performed from this block
+    #     end
+    #   end
+    #
+    # The block form supports filtering. If the :only option is specified,
+    # then only the listed job(s) will not be performed.
+    #
+    #   def test_no_logging
+    #     assert_no_performed_jobs only: LoggingJob do
+    #       HelloJob.perform_later('jeremy')
+    #     end
+    #   end
+    #
+    # Note: This assertion is simply a shortcut for:
+    #
+    #   assert_performed_jobs 0, &block
+    def assert_no_performed_jobs(only: nil, &block)
+      assert_performed_jobs 0, only: only, &block
+    end
 
-      # Asserts that the job passed in the block has been performed with the given arguments.
-      #
-      #   def test_assert_performed_with
-      #     assert_performed_with(job: MyJob, args: [1,2,3], queue: 'high') do
-      #       MyJob.perform_later(1,2,3)
-      #     end
-      #
-      #     assert_performed_with(job: MyJob, at: Date.tomorrow.noon) do
-      #       MyJob.set(wait_until: Date.tomorrow.noon).perform_later
-      #     end
-      #   end
-      def assert_performed_with(args = {})
-        original_performed_jobs_count = performed_jobs.count
-        args.assert_valid_keys(:job, :args, :at, :queue)
-        serialized_args = serialize_args_for_assertion(args)
-        perform_enqueued_jobs { yield }
-        in_block_jobs = performed_jobs.drop(original_performed_jobs_count)
-        matching_job = in_block_jobs.find do |job|
-          serialized_args.all? { |key, value| value == job[key] }
-        end
-        assert matching_job, "No performed job found with #{args}"
-        instantiate_job(matching_job)
+    # Asserts that the job passed in the block has been enqueued with the given arguments.
+    #
+    #   def test_assert_enqueued_with
+    #     assert_enqueued_with(job: MyJob, args: [1,2,3], queue: 'low') do
+    #       MyJob.perform_later(1,2,3)
+    #     end
+    #
+    #     assert_enqueued_with(job: MyJob, at: Date.tomorrow.noon) do
+    #       MyJob.set(wait_until: Date.tomorrow.noon).perform_later
+    #     end
+    #   end
+    def assert_enqueued_with(args = {})
+      original_enqueued_jobs_count = enqueued_jobs.count
+      args.assert_valid_keys(:job, :args, :at, :queue)
+      serialized_args = serialize_args_for_assertion(args)
+      yield
+      in_block_jobs = enqueued_jobs.drop(original_enqueued_jobs_count)
+      matching_job = in_block_jobs.find do |job|
+        serialized_args.all? { |key, value| value == job[key] }
       end
+      assert matching_job, "No enqueued job found with #{args}"
+      instantiate_job(matching_job)
+    end
 
-      def perform_enqueued_jobs(only: nil)
-        old_perform_enqueued_jobs = queue_adapter.perform_enqueued_jobs
-        old_perform_enqueued_at_jobs = queue_adapter.perform_enqueued_at_jobs
-        old_filter = queue_adapter.filter
-
-        begin
-          queue_adapter.perform_enqueued_jobs = true
-          queue_adapter.perform_enqueued_at_jobs = true
-          queue_adapter.filter = only
-          yield
-        ensure
-          queue_adapter.perform_enqueued_jobs = old_perform_enqueued_jobs
-          queue_adapter.perform_enqueued_at_jobs = old_perform_enqueued_at_jobs
-          queue_adapter.filter = old_filter
-        end
+    # Asserts that the job passed in the block has been performed with the given arguments.
+    #
+    #   def test_assert_performed_with
+    #     assert_performed_with(job: MyJob, args: [1,2,3], queue: 'high') do
+    #       MyJob.perform_later(1,2,3)
+    #     end
+    #
+    #     assert_performed_with(job: MyJob, at: Date.tomorrow.noon) do
+    #       MyJob.set(wait_until: Date.tomorrow.noon).perform_later
+    #     end
+    #   end
+    def assert_performed_with(args = {})
+      original_performed_jobs_count = performed_jobs.count
+      args.assert_valid_keys(:job, :args, :at, :queue)
+      serialized_args = serialize_args_for_assertion(args)
+      perform_enqueued_jobs { yield }
+      in_block_jobs = performed_jobs.drop(original_performed_jobs_count)
+      matching_job = in_block_jobs.find do |job|
+        serialized_args.all? { |key, value| value == job[key] }
       end
+      assert matching_job, "No performed job found with #{args}"
+      instantiate_job(matching_job)
+    end
+
+    def perform_enqueued_jobs(only: nil)
+      old_perform_enqueued_jobs = queue_adapter.perform_enqueued_jobs
+      old_perform_enqueued_at_jobs = queue_adapter.perform_enqueued_at_jobs
+      old_filter = queue_adapter.filter
 
-      def queue_adapter
-        ActiveJob::Base.queue_adapter
+      begin
+        queue_adapter.perform_enqueued_jobs = true
+        queue_adapter.perform_enqueued_at_jobs = true
+        queue_adapter.filter = only
+        yield
+      ensure
+        queue_adapter.perform_enqueued_jobs = old_perform_enqueued_jobs
+        queue_adapter.perform_enqueued_at_jobs = old_perform_enqueued_at_jobs
+        queue_adapter.filter = old_filter
       end
+    end
 
-      delegate :enqueued_jobs, :enqueued_jobs=,
-               :performed_jobs, :performed_jobs=,
-               to: :queue_adapter
+    def queue_adapter
+      ActiveJob::Base.queue_adapter
+    end
 
-      private
-        def clear_enqueued_jobs # :nodoc:
-          enqueued_jobs.clear
-        end
+    private
+      def clear_enqueued_jobs # :nodoc:
+        enqueued_jobs.clear
+      end
 
-        def clear_performed_jobs # :nodoc:
-          performed_jobs.clear
-        end
+      def clear_performed_jobs # :nodoc:
+        performed_jobs.clear
+      end
 
-        def enqueued_jobs_size(only: nil) # :nodoc:
-          if only
-            enqueued_jobs.count { |job| Array(only).include?(job.fetch(:job)) }
-          else
-            enqueued_jobs.count
-          end
+      def enqueued_jobs_size(only: nil) # :nodoc:
+        if only
+          enqueued_jobs.count { |job| Array(only).include?(job.fetch(:job)) }
+        else
+          enqueued_jobs.count
         end
+      end
 
-        def serialize_args_for_assertion(args) # :nodoc:
-          args.dup.tap do |serialized_args|
-            serialized_args[:args] = ActiveJob::Arguments.serialize(serialized_args[:args]) if serialized_args[:args]
-            serialized_args[:at]   = serialized_args[:at].to_f if serialized_args[:at]
-          end
+      def serialize_args_for_assertion(args) # :nodoc:
+        args.dup.tap do |serialized_args|
+          serialized_args[:args] = ActiveJob::Arguments.serialize(serialized_args[:args]) if serialized_args[:args]
+          serialized_args[:at]   = serialized_args[:at].to_f if serialized_args[:at]
         end
+      end
 
-        def instantiate_job(payload) # :nodoc:
-          job = payload[:job].new(*payload[:args])
-          job.scheduled_at = Time.at(payload[:at]) if payload.key?(:at)
-          job.queue_name = payload[:queue]
-          job
-        end
-    end
+      def instantiate_job(payload) # :nodoc:
+        job = payload[:job].new(*payload[:args])
+        job.scheduled_at = Time.at(payload[:at]) if payload.key?(:at)
+        job.queue_name = payload[:queue]
+        job
+      end
   end
 end

data/lib/rails/generators/job/job_generator.rb

@@ -17,7 +17,22 @@ module Rails # :nodoc:
 
       def create_job_file
         template 'job.rb', File.join('app/jobs', class_path, "#{file_name}_job.rb")
+
+        in_root do
+          if self.behavior == :invoke && !File.exist?(application_job_file_name)
+            template 'application_job.rb', application_job_file_name
+          end
+        end
       end
+
+      private
+        def application_job_file_name
+           @application_job_file_name ||= if mountable_engine?
+             "app/jobs/#{namespaced_path}/application_job.rb"
+           else
+             'app/jobs/application_job.rb'
+           end
+        end
     end
   end
 end

data/lib/rails/generators/job/templates/application_job.rb

@@ -0,0 +1,4 @@
+<% module_namespacing do -%>
+class ApplicationJob < ActiveJob::Base
+end
+<% end -%>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activejob
 version: !ruby/object:Gem::Version
-  version: 5.0.0.beta3
+  version: 5.0.0.beta4
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-24 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.beta3
+        version: 5.0.0.beta4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.0.0.beta3
+        version: 5.0.0.beta4
 - !ruby/object:Gem::Dependency
   name: globalid
   requirement: !ruby/object:Gem::Requirement
@@ -49,7 +49,6 @@ files:
 - README.md
 - lib/active_job.rb
 - lib/active_job/arguments.rb
-- lib/active_job/async_job.rb
 - lib/active_job/base.rb
 - lib/active_job/callbacks.rb
 - lib/active_job/configured_job.rb
@@ -80,8 +79,9 @@ files:
 - lib/active_job/translation.rb
 - lib/active_job/version.rb
 - lib/rails/generators/job/job_generator.rb
+- lib/rails/generators/job/templates/application_job.rb
 - lib/rails/generators/job/templates/job.rb
-homepage: http://www.rubyonrails.org
+homepage: http://rubyonrails.org
 licenses:
 - MIT
 metadata: {}
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Job framework with pluggable queues.

data/lib/active_job/async_job.rb

@@ -1,77 +0,0 @@
-require 'concurrent/map'
-require 'concurrent/scheduled_task'
-require 'concurrent/executor/thread_pool_executor'
-require 'concurrent/utility/processor_counter'
-
-module ActiveJob
-  # == Active Job Async Job
-  #
-  # When enqueuing jobs with Async Job each job will be executed asynchronously
-  # on a +concurrent-ruby+ thread pool. All job data is retained in memory.
-  # Because job data is not saved to a persistent datastore there is no
-  # additional infrastructure needed and jobs process quickly. The lack of
-  # persistence, however, means that all unprocessed jobs will be lost on
-  # application restart. Therefore in-memory queue adapters are unsuitable for
-  # most production environments but are excellent for development and testing.
-  #
-  # Read more about Concurrent Ruby {here}[https://github.com/ruby-concurrency/concurrent-ruby].
-  #
-  # To use Async Job set the queue_adapter config to +:async+.
-  #
-  #   Rails.application.config.active_job.queue_adapter = :async
-  #
-  # Async Job supports job queues specified with +queue_as+. Queues are created
-  # automatically as needed and each has its own thread pool.
-  class AsyncJob
-
-    DEFAULT_EXECUTOR_OPTIONS = {
-      min_threads:     [2, Concurrent.processor_count].max,
-      max_threads:     Concurrent.processor_count * 10,
-      auto_terminate:  true,
-      idletime:        60, # 1 minute
-      max_queue:       0, # unlimited
-      fallback_policy: :caller_runs # shouldn't matter -- 0 max queue
-    }.freeze
-
-    QUEUES = Concurrent::Map.new do |hash, queue_name| #:nodoc:
-      hash.compute_if_absent(queue_name) { ActiveJob::AsyncJob.create_thread_pool }
-    end
-
-    class << self
-      # Forces jobs to process immediately when testing the Active Job gem.
-      # This should only be called from within unit tests.
-      def perform_immediately! #:nodoc:
-        @perform_immediately = true
-      end
-
-      # Allows jobs to run asynchronously when testing the Active Job gem.
-      # This should only be called from within unit tests.
-      def perform_asynchronously! #:nodoc:
-        @perform_immediately = false
-      end
-
-      def create_thread_pool #:nodoc:
-        if @perform_immediately
-          Concurrent::ImmediateExecutor.new
-        else
-          Concurrent::ThreadPoolExecutor.new(DEFAULT_EXECUTOR_OPTIONS)
-        end
-      end
-
-      def enqueue(job_data, queue: 'default') #:nodoc:
-        QUEUES[queue].post(job_data) { |job| ActiveJob::Base.execute(job) }
-      end
-
-      def enqueue_at(job_data, timestamp, queue: 'default') #:nodoc:
-        delay = timestamp - Time.current.to_f
-        if delay > 0
-          Concurrent::ScheduledTask.execute(delay, args: [job_data], executor: QUEUES[queue]) do |job|
-            ActiveJob::Base.execute(job)
-          end
-        else
-          enqueue(job_data, queue: queue)
-        end
-      end
-    end
-  end
-end